@codelaw/rules-js 0.1.0 → 0.2.0

package/rules/ts/no-duplicate-enum-values.md

@@ -1,65 +0,0 @@
----
-id: ts/no-duplicate-enum-values
-title: "No two enum members share a value"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "which value is right needs the author"
-stability: preview
-ported_from: [typescript-eslint/no-duplicate-enum-values]
-since: 0.1.0
----
-
-Each member of an enum given a literal value has a different value.
-
-**Why:** Two members with one value are indistinguishable at run time, which is usually a copy-paste
-slip.
-
-```codelaw
-native: ts/no-duplicate-enum-values
-```
-
-## How to fix
-
-1. Give each member its own value.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-enum Color {
-  Red = 1,
-  Green = 1,
-}
-```
-
-#### Do
-
-```ts
-enum Color {
-  Red = 1,
-  Green = 2,
-}
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-enum Color {
-  Red = 1,
-  Green = 1,
-}
-```
-
-#### Do
-
-```tsx
-enum Color {
-  Red = 1,
-  Green = 2,
-}
-```

package/rules/ts/no-empty-object-type.md

@@ -1,65 +0,0 @@
----
-id: ts/no-empty-object-type
-title: "No empty interfaces or {} types"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "the right replacement — `object`, `unknown` or `Record<string, never>` — depends on intent"
-stability: preview
-ported_from: [typescript-eslint/no-empty-object-type]
-since: 0.1.0
----
-
-Code doesn't declare an empty interface or use the type `{}`.
-
-**Why:** `{}` accepts every value except `null` and `undefined`, which is almost never what an
-empty-looking type was meant to say.
-
-```codelaw
-match:
-  any:
-    - kind: interface_declaration
-      has: { field: body, regex: '^\{\s*\}$' }
-    - kind: object_type
-      regex: '^\{\s*\}$'
-message: "`{}` means any non-null value, not an empty object; say what you mean"
-```
-
-## How to fix
-
-1. For any object, use `object`.
-2. For any value, use `unknown`.
-3. For an object with no keys, use `Record<string, never>`.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-interface Options {}
-type Empty = {};
-```
-
-#### Do
-
-```ts
-type Options = Record<string, never>;
-type Anything = unknown;
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-interface Options {}
-type Empty = {};
-```
-
-#### Do
-
-```tsx
-type Options = Record<string, never>;
-type Anything = unknown;
-```

package/rules/ts/no-explicit-any.md

@@ -1,61 +0,0 @@
----
-id: ts/no-explicit-any
-title: "No explicit any"
-languages: [typescript, tsx]
-fix: suggest
-fix_reason: "`unknown` may need narrowing code where the value is used"
-stability: preview
-ported_from: [typescript-eslint/no-explicit-any]
-since: 0.1.0
----
-
-Types are not written as `any`.
-
-**Why:** `any` silently disables checking for everything it touches; `unknown` keeps the checks and
-forces a narrowing.
-
-```codelaw
-match:
-  kind: predefined_type
-  regex: ^any$
-message: "`any` turns off type-checking here; use `unknown` and narrow it"
-fix: "unknown"
-```
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-function parse(input: any) {
-  return input;
-}
-```
-
-#### Do
-
-```ts
-function parse(input: unknown) {
-  return input;
-}
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-function parse(input: any) {
-  return input;
-}
-```
-
-#### Do
-
-```tsx
-function parse(input: unknown) {
-  return input;
-}
-```

package/rules/ts/no-extra-non-null-assertion.md

@@ -1,50 +0,0 @@
----
-id: ts/no-extra-non-null-assertion
-title: "No repeated non-null assertions"
-languages: [typescript, tsx]
-fix: auto
-stability: preview
-ported_from: [typescript-eslint/no-extra-non-null-assertion]
-since: 0.1.0
----
-
-A non-null assertion `!` is not repeated.
-
-**Why:** `x!!` means the same as `x!`; the second `!` is a typo.
-
-```codelaw
-match:
-  pattern: $X!!
-message: "One `!` is enough"
-fix: "$X!"
-```
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-const n = value!!;
-```
-
-#### Do
-
-```ts
-const n = value!;
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-const n = value!!;
-```
-
-#### Do
-
-```tsx
-const n = value!;
-```

package/rules/ts/no-misused-new.md

@@ -1,70 +0,0 @@
----
-id: ts/no-misused-new
-title: "No constructors declared in interfaces, and no `new` methods in classes"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "the intended constructor signature needs the author"
-stability: preview
-ported_from: [typescript-eslint/no-misused-new]
-since: 0.1.0
----
-
-An interface doesn't declare a method named `constructor`, and a class doesn't declare a method
-named `new`.
-
-**Why:** Both look like constructors but are ordinary methods; constructors in types are written
-`new (): T`.
-
-```codelaw
-match:
-  any:
-    - kind: method_signature
-      has: { field: name, regex: ^constructor$ }
-      inside: { kind: interface_body, stopBy: neighbor }
-    - kind: method_definition
-      has: { field: name, regex: ^new$ }
-message: "This declares a constructor where TypeScript reads a plain method"
-```
-
-## How to fix
-
-1. In an interface, describe a constructor with `new (…): T`.
-2. In a class, use `constructor(…)`.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-interface Point {
-  constructor(): void;
-}
-```
-
-#### Do
-
-```ts
-interface PointConstructor {
-  new (): object;
-}
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-interface Point {
-  constructor(): void;
-}
-```
-
-#### Do
-
-```tsx
-interface PointConstructor {
-  new (): object;
-}
-```

package/rules/ts/no-namespace.md

@@ -1,65 +0,0 @@
----
-id: ts/no-namespace
-title: "No TypeScript namespaces"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "moving a namespace's members into a module changes every import"
-stability: preview
-ported_from: [typescript-eslint/no-namespace]
-since: 0.1.0
----
-
-Code is organised with ES modules, not `namespace` or `module` blocks; `declare module "x"` and
-`declare global` are allowed.
-
-**Why:** Namespaces predate ES modules and don't work with modern bundlers and tooling as well.
-
-```codelaw
-match:
-  any:
-    - kind: internal_module
-    - kind: module
-      has: { field: name, kind: identifier }
-  not:
-    inside: { kind: ambient_declaration, stopBy: end }
-message: "Use ES modules instead of a namespace"
-```
-
-## How to fix
-
-1. Move the namespace's members to a module of their own.
-2. Export them, and import them where the namespace was used.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-namespace Geometry {
-  export const pi = 3.14;
-}
-```
-
-#### Do
-
-```ts
-export const pi = 3.14;
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-namespace Geometry {
-  export const pi = 3.14;
-}
-```
-
-#### Do
-
-```tsx
-export const pi = 3.14;
-```

package/rules/ts/no-non-null-asserted-optional-chain.md

@@ -1,55 +0,0 @@
----
-id: ts/no-non-null-asserted-optional-chain
-title: "No non-null assertion after an optional chain"
-languages: [typescript, tsx]
-fix: suggest
-fix_reason: "removing `!` widens the type to include `undefined`, which later code may not handle"
-stability: preview
-ported_from: [typescript-eslint/no-non-null-asserted-optional-chain]
-since: 0.1.0
----
-
-An optional chain (`a?.b`) is not followed by a non-null assertion (`!`).
-
-**Why:** The two contradict each other: `?.` allows `undefined`, and `!` asserts it never happens.
-
-```codelaw
-match:
-  pattern: $X!
-  has:
-    stopBy: neighbor
-    any: [{ kind: member_expression }, { kind: call_expression }, { kind: subscript_expression }]
-    has: { kind: optional_chain, stopBy: neighbor }
-message: "`?.` says this can be undefined; `!` says it can't"
-fix: "$X"
-```
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-const name = user?.name!;
-```
-
-#### Do
-
-```ts
-const name = user?.name;
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-const name = user?.name!;
-```
-
-#### Do
-
-```tsx
-const name = user?.name;
-```

package/rules/ts/no-require-imports.md

@@ -1,54 +0,0 @@
----
-id: ts/no-require-imports
-title: "No require() calls"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "an import may need the module's default or named exports chosen by hand"
-stability: preview
-ported_from: [typescript-eslint/no-require-imports]
-since: 0.1.0
----
-
-Modules are loaded with `import`, not `require()`.
-
-**Why:** `require()` is untyped and invisible to TypeScript's module checks.
-
-```codelaw
-match:
-  pattern: require($$$ARGS)
-message: "Use `import` instead of `require()`"
-```
-
-## How to fix
-
-1. Replace the call with an `import` of the names the code uses.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-const fs = require("node:fs");
-```
-
-#### Do
-
-```ts
-import fs from "node:fs";
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-const fs = require("node:fs");
-```
-
-#### Do
-
-```tsx
-import fs from "node:fs";
-```

package/rules/ts/no-this-alias.md

@@ -1,68 +0,0 @@
----
-id: ts/no-this-alias
-title: "No aliasing this to a variable"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "the callbacks that use the alias must become arrow functions by hand"
-stability: preview
-ported_from: [typescript-eslint/no-this-alias]
-since: 0.1.0
----
-
-`this` is not stored in a variable such as `self` or `that`; destructuring it is fine.
-
-**Why:** Arrow functions keep the outer `this`, so an alias only adds a name to keep track of.
-
-```codelaw
-match:
-  kind: variable_declarator
-  all:
-    - has: { field: name, kind: identifier }
-    - has: { field: value, kind: this }
-message: "Use an arrow function instead of aliasing `this`"
-```
-
-## How to fix
-
-1. Turn the callbacks that use the alias into arrow functions.
-2. Use `this` directly and remove the alias.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-const self = this;
-button.onclick = function () {
-  self.save();
-};
-```
-
-#### Do
-
-```ts
-button.onclick = () => {
-  this.save();
-};
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-const self = this;
-button.onclick = function () {
-  self.save();
-};
-```
-
-#### Do
-
-```tsx
-button.onclick = () => {
-  this.save();
-};
-```

package/rules/ts/no-unnecessary-type-constraint.md

@@ -1,64 +0,0 @@
----
-id: ts/no-unnecessary-type-constraint
-title: "No extends any or extends unknown on a type parameter"
-languages: [typescript, tsx]
-fix: suggest
-fix_reason: "in a .tsx arrow function `<T>` alone parses as JSX and needs `<T,>`"
-stability: preview
-ported_from: [typescript-eslint/no-unnecessary-type-constraint]
-since: 0.1.0
----
-
-A type parameter isn't constrained to `any` or `unknown`.
-
-**Why:** Every type extends both, so the constraint says nothing.
-
-```codelaw
-match:
-  kind: type_parameter
-  all:
-    - has: { field: name, pattern: $NAME }
-    - has:
-        field: constraint
-        has: { kind: predefined_type, regex: ^(any|unknown)$ }
-message: "Every type already extends `any` and `unknown`; drop the constraint"
-fix: "$NAME"
-```
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-function id<T extends unknown>(x: T) {
-  return x;
-}
-```
-
-#### Do
-
-```ts
-function id<T>(x: T) {
-  return x;
-}
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-function id<T extends unknown>(x: T) {
-  return x;
-}
-```
-
-#### Do
-
-```tsx
-function id<T>(x: T) {
-  return x;
-}
-```

package/rules/ts/no-unsafe-declaration-merging.md

@@ -1,73 +0,0 @@
----
-id: ts/no-unsafe-declaration-merging
-title: "No interface that merges with a class of the same name"
-languages: [typescript, tsx]
-fix: manual
-fix_reason: "whether to rename or to move the members into the class needs the author"
-stability: preview
-ported_from: [typescript-eslint/no-unsafe-declaration-merging]
-since: 0.1.0
----
-
-An interface doesn't share its name with a class in the same scope.
-
-**Why:** The merged interface adds members to the class's type that the class never initialises, and
-the compiler can't tell.
-
-```codelaw
-native: ts/no-unsafe-declaration-merging
-```
-
-## How to fix
-
-1. Move the interface's members into the class, or rename the interface.
-
-## Examples
-
-### TypeScript
-
-#### Don't
-
-```ts
-interface Point {
-  z: number;
-}
-class Point {
-  x = 0;
-}
-```
-
-#### Do
-
-```ts
-interface PointLike {
-  z: number;
-}
-class Point {
-  x = 0;
-}
-```
-
-### TSX
-
-#### Don't
-
-```tsx
-interface Point {
-  z: number;
-}
-class Point {
-  x = 0;
-}
-```
-
-#### Do
-
-```tsx
-interface PointLike {
-  z: number;
-}
-class Point {
-  x = 0;
-}
-```