@codehz/ecs 0.7.2 → 0.7.4

package/src/__tests__/relations/dont-fragment/basic.test.ts

@@ -0,0 +1,496 @@
+import { describe, expect, it } from "bun:test";
+import { component, relation, type EntityId } from "../../../entity";
+import { World } from "../../../world/world";
+
+describe("DontFragment Relations", () => {
+  it("should prevent archetype fragmentation for dontFragment relations", () => {
+    const world = new World();
+
+    // Create component types
+    type Position = { x: number; y: number };
+    const PositionId = component<Position>();
+    const VelocityId = component();
+
+    // Create ChildOf with dontFragment option
+    const ChildOf = component({ dontFragment: true });
+
+    // Create parent entities
+    const parent1 = world.new();
+    const parent2 = world.new();
+    const parent3 = world.new();
+
+    // Create child entities with different parents
+    const child1 = world.new();
+    world.set(child1, PositionId, { x: 1, y: 1 });
+    world.set(child1, VelocityId);
+    world.set(child1, relation(ChildOf, parent1));
+
+    const child2 = world.new();
+    world.set(child2, PositionId, { x: 2, y: 2 });
+    world.set(child2, VelocityId);
+    world.set(child2, relation(ChildOf, parent2));
+
+    const child3 = world.new();
+    world.set(child3, PositionId, { x: 3, y: 3 });
+    world.set(child3, VelocityId);
+    world.set(child3, relation(ChildOf, parent3));
+
+    world.sync();
+
+    // Verify all children are in the same archetype
+    // This is the key benefit: despite having different parent relations,
+    // they share the same archetype because ChildOf is marked as dontFragment
+    const archetypes = (world as any).archetypes;
+
+    // Count archetypes with Position and Velocity
+    const matchingArchetypes = archetypes.filter((arch: any) => {
+      const types = arch.componentTypes;
+      return types.includes(PositionId) && types.includes(VelocityId);
+    });
+
+    // All three children should be in the SAME archetype
+    expect(matchingArchetypes.length).toBe(1);
+    expect(matchingArchetypes[0].size).toBe(3);
+
+    // Verify we can still access the relations
+    expect(world.has(child1, relation(ChildOf, parent1))).toBe(true);
+    expect(world.has(child2, relation(ChildOf, parent2))).toBe(true);
+    expect(world.has(child3, relation(ChildOf, parent3))).toBe(true);
+
+    // Verify queries still work
+    const entities = world.query([PositionId, VelocityId]);
+    expect(entities.length).toBe(3);
+  });
+
+  it("should handle dontFragment relations with wildcard queries", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    const child1 = world.new();
+    world.set(child1, PositionId);
+    world.set(child1, relation(ChildOf, parent1));
+
+    const child2 = world.new();
+    world.set(child2, PositionId);
+    world.set(child2, relation(ChildOf, parent2));
+
+    world.sync();
+
+    // Wildcard query should work with dontFragment relations
+    const wildcardChildOf = relation(ChildOf, "*");
+    const child1Relations = world.get(child1, wildcardChildOf);
+    const child2Relations = world.get(child2, wildcardChildOf);
+
+    expect(child1Relations.length).toBe(1);
+    expect(child1Relations[0]![0]).toBe(parent1);
+
+    expect(child2Relations.length).toBe(1);
+    expect(child2Relations[0]![0]).toBe(parent2);
+  });
+
+  it("should allow updating dontFragment relations", () => {
+    const world = new World();
+
+    const ChildOf = component({ dontFragment: true, exclusive: true });
+    const PositionId = component();
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+    const child = world.new();
+
+    world.set(child, PositionId);
+    world.set(child, relation(ChildOf, parent1));
+    world.sync();
+
+    expect(world.has(child, relation(ChildOf, parent1))).toBe(true);
+
+    // Change parent (exclusive should replace)
+    world.set(child, relation(ChildOf, parent2));
+    world.sync();
+
+    expect(world.has(child, relation(ChildOf, parent1))).toBe(false);
+    expect(world.has(child, relation(ChildOf, parent2))).toBe(true);
+  });
+
+  it("should handle removing dontFragment relations", () => {
+    const world = new World();
+
+    const ChildOf = component({ dontFragment: true });
+    const PositionId = component();
+
+    const parent = world.new();
+    const child = world.new();
+
+    world.set(child, PositionId);
+    world.set(child, relation(ChildOf, parent));
+    world.sync();
+
+    expect(world.has(child, relation(ChildOf, parent))).toBe(true);
+
+    // Remove the relation
+    world.remove(child, relation(ChildOf, parent));
+    world.sync();
+
+    expect(world.has(child, relation(ChildOf, parent))).toBe(false);
+    expect(world.has(child, PositionId)).toBe(true);
+  });
+
+  it("should handle queries with dontFragment relations", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const VelocityId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    // Create entities with dontFragment relations
+    for (let i = 0; i < 10; i++) {
+      const entity = world.new();
+      world.set(entity, PositionId);
+      world.set(entity, VelocityId);
+      world.set(entity, relation(ChildOf, i % 2 === 0 ? parent1 : parent2));
+    }
+
+    world.sync();
+
+    // Query should find all entities despite different parent relations
+    const query = world.createQuery([PositionId, VelocityId]);
+    const entities = query.getEntities();
+    expect(entities.length).toBe(10);
+
+    // All should be in the same archetype
+    const archetypes = (world as any).archetypes;
+    const matchingArchetypes = archetypes.filter((arch: any) => {
+      return arch.componentTypes.includes(PositionId) && arch.componentTypes.includes(VelocityId);
+    });
+    expect(matchingArchetypes.length).toBe(1);
+  });
+
+  it("should compare fragmentation: with and without dontFragment", () => {
+    // Test WITHOUT dontFragment (causes fragmentation)
+    const world1 = new World();
+    const PositionId1 = component();
+    const ChildOf1 = component(); // No dontFragment
+
+    for (let i = 0; i < 5; i++) {
+      const parent = world1.new();
+      const child = world1.new();
+      world1.set(child, PositionId1);
+      world1.set(child, relation(ChildOf1, parent));
+    }
+    world1.sync();
+
+    const archetypes1 = (world1 as any).archetypes.filter((arch: any) => {
+      return arch.componentTypes.includes(PositionId1);
+    });
+
+    // Test WITH dontFragment (prevents fragmentation)
+    const world2 = new World();
+    const PositionId2 = component();
+    const ChildOf2 = component({ dontFragment: true }); // With dontFragment
+
+    for (let i = 0; i < 5; i++) {
+      const parent = world2.new();
+      const child = world2.new();
+      world2.set(child, PositionId2);
+      world2.set(child, relation(ChildOf2, parent));
+    }
+    world2.sync();
+
+    const archetypes2 = (world2 as any).archetypes.filter((arch: any) => {
+      return arch.componentTypes.includes(PositionId2);
+    });
+
+    // Without dontFragment: 5 archetypes (one per parent)
+    expect(archetypes1.length).toBe(5);
+
+    // With dontFragment: 1 archetype (all children share it)
+    expect(archetypes2.length).toBe(1);
+    expect(archetypes2[0].size).toBe(5);
+  });
+
+  it("should query entities with wildcard relation on dontFragment component using createQuery", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    const child1 = world.new();
+    world.set(child1, PositionId);
+    world.set(child1, relation(ChildOf, parent1));
+
+    const child2 = world.new();
+    world.set(child2, PositionId);
+    world.set(child2, relation(ChildOf, parent2));
+
+    world.sync();
+
+    // Try to query entities with wildcard ChildOf relation
+    const wildcardChildOf = relation(ChildOf, "*");
+    const query = world.createQuery([wildcardChildOf]);
+    const entities = query.getEntities();
+
+    // This should find both child1 and child2
+    expect(entities.length).toBe(2);
+    expect(entities).toContain(child1);
+    expect(entities).toContain(child2);
+  });
+
+  it("should query entities with wildcard relation + other components on dontFragment", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const VelocityId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    const child1 = world.new();
+    world.set(child1, PositionId);
+    world.set(child1, VelocityId);
+    world.set(child1, relation(ChildOf, parent1));
+
+    const child2 = world.new();
+    world.set(child2, PositionId);
+    world.set(child2, VelocityId);
+    world.set(child2, relation(ChildOf, parent2));
+
+    // Entity without ChildOf relation
+    const child3 = world.new();
+    world.set(child3, PositionId);
+    world.set(child3, VelocityId);
+
+    world.sync();
+
+    // Query for entities with wildcard ChildOf relation AND Position
+    const wildcardChildOf = relation(ChildOf, "*");
+    const query = world.createQuery([wildcardChildOf, PositionId]);
+    const entities = query.getEntities();
+
+    // Should find child1 and child2, but not child3 (no ChildOf relation)
+    expect(entities.length).toBe(2);
+    expect(entities).toContain(child1);
+    expect(entities).toContain(child2);
+    expect(entities).not.toContain(child3);
+  });
+
+  it("should correctly cleanup dontFragment relations when target entity is destroyed", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const VelocityId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    // Create children with dontFragment relations
+    const child1 = world.new();
+    world.set(child1, PositionId);
+    world.set(child1, VelocityId);
+    world.set(child1, relation(ChildOf, parent1));
+
+    const child2 = world.new();
+    world.set(child2, PositionId);
+    world.set(child2, VelocityId);
+    world.set(child2, relation(ChildOf, parent2));
+
+    const child3 = world.new();
+    world.set(child3, PositionId);
+    world.set(child3, VelocityId);
+    world.set(child3, relation(ChildOf, parent1)); // Same parent as child1
+
+    world.sync();
+
+    // All children should be in the same archetype (due to dontFragment)
+    const archetypes = (world as any).archetypes;
+    const matchingArchetypesBefore = archetypes.filter((arch: any) => {
+      return arch.componentTypes.includes(PositionId) && arch.componentTypes.includes(VelocityId);
+    });
+    expect(matchingArchetypesBefore.length).toBe(1);
+    expect(matchingArchetypesBefore[0].size).toBe(3);
+
+    // Verify relations exist
+    expect(world.has(child1, relation(ChildOf, parent1))).toBe(true);
+    expect(world.has(child2, relation(ChildOf, parent2))).toBe(true);
+    expect(world.has(child3, relation(ChildOf, parent1))).toBe(true);
+
+    // Delete parent1 - should remove relations from child1 and child3
+    world.delete(parent1);
+    world.sync();
+
+    // Relations to parent1 should be removed
+    expect(world.has(child1, relation(ChildOf, parent1))).toBe(false);
+    expect(world.has(child3, relation(ChildOf, parent1))).toBe(false);
+
+    // Relation to parent2 should still exist
+    expect(world.has(child2, relation(ChildOf, parent2))).toBe(true);
+
+    // Entities should still exist with their other components
+    expect(world.exists(child1)).toBe(true);
+    expect(world.exists(child2)).toBe(true);
+    expect(world.exists(child3)).toBe(true);
+    expect(world.has(child1, PositionId)).toBe(true);
+    expect(world.has(child2, PositionId)).toBe(true);
+    expect(world.has(child3, PositionId)).toBe(true);
+
+    // Archetype should not fragment - entities without relations should move to a different archetype
+    // (one without the wildcard marker)
+    const matchingArchetypesAfter = archetypes.filter((arch: any) => {
+      return arch.componentTypes.includes(PositionId) && arch.componentTypes.includes(VelocityId);
+    });
+
+    // child1 and child3 no longer have ChildOf relations, so they should be in an archetype
+    // without the wildcard marker, while child2 should be in the one with the marker
+    expect(matchingArchetypesAfter.length).toBe(2);
+  });
+
+  it("should not create new archetypes when removing dontFragment relation from entity", () => {
+    const world = new World();
+
+    const PositionId = component();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent1 = world.new();
+    const parent2 = world.new();
+
+    // Create multiple children with different parents
+    const children: EntityId[] = [];
+    for (let i = 0; i < 5; i++) {
+      const child = world.new();
+      world.set(child, PositionId);
+      world.set(child, relation(ChildOf, i % 2 === 0 ? parent1 : parent2));
+      children.push(child);
+    }
+
+    world.sync();
+
+    // Count archetypes before deletion
+    const archetypesBefore = (world as any).archetypes.length;
+
+    // Delete parent1 - this should remove relations but not fragment
+    world.delete(parent1);
+    world.sync();
+
+    // Some children (those with parent1) should have lost their ChildOf relation
+    // but the archetype structure should be minimal (not fragmented)
+    const archetypesAfter = (world as any).archetypes.length;
+
+    // We expect at most one new archetype (for entities without ChildOf)
+    // The key point is we don't create separate archetypes per entity
+    expect(archetypesAfter).toBeLessThanOrEqual(archetypesBefore + 1);
+
+    // Verify entities still exist and have Position
+    for (const child of children) {
+      expect(world.exists(child)).toBe(true);
+      expect(world.has(child, PositionId)).toBe(true);
+    }
+  });
+
+  it("should trigger lifecycle hooks when dontFragment relations are removed due to entity destruction", () => {
+    const world = new World();
+
+    const ChildOf = component({ dontFragment: true });
+    const PositionId = component();
+
+    const parent = world.new();
+    const child = world.new();
+    world.set(child, PositionId);
+    world.set(child, relation(ChildOf, parent));
+    world.sync();
+
+    // Set up hook to track removals
+    const removedRelations: Array<{ entity: number; relations: [number, void][] }> = [];
+    const wildcardChildOf = relation(ChildOf, "*");
+    world.hook([wildcardChildOf], {
+      on_remove: (entity, relations) => {
+        removedRelations.push({ entity, relations });
+      },
+    });
+
+    // Delete parent - should trigger hook for removed relation
+    world.delete(parent);
+    world.sync();
+
+    // Hook should have been called
+    expect(removedRelations.length).toBe(1);
+    expect(removedRelations[0]!.entity).toBe(child);
+    expect(removedRelations[0]!.relations).toEqual([[parent, undefined]]);
+  });
+
+  it("should handle cascade delete with dontFragment relations correctly", () => {
+    const world = new World();
+
+    const PositionId = component();
+    // Cascade delete AND dontFragment - when parent dies, children die too
+    const ChildOf = component({ dontFragment: true, cascadeDelete: true });
+
+    const grandparent = world.new();
+    const parent = world.new();
+    world.set(parent, PositionId);
+    world.set(parent, relation(ChildOf, grandparent));
+
+    const child = world.new();
+    world.set(child, PositionId);
+    world.set(child, relation(ChildOf, parent));
+
+    world.sync();
+
+    // Verify hierarchy
+    expect(world.exists(grandparent)).toBe(true);
+    expect(world.exists(parent)).toBe(true);
+    expect(world.exists(child)).toBe(true);
+
+    // Delete grandparent - should cascade to parent, then to child
+    world.delete(grandparent);
+    world.sync();
+
+    // All should be deleted due to cascade
+    expect(world.exists(grandparent)).toBe(false);
+    expect(world.exists(parent)).toBe(false);
+    expect(world.exists(child)).toBe(false);
+  });
+
+  it("should maintain entity archetype integrity when removing dontFragment relations", () => {
+    const world = new World();
+
+    const PositionId = component<{ x: number; y: number }>();
+    const VelocityId = component<{ vx: number; vy: number }>();
+    const ChildOf = component({ dontFragment: true });
+
+    const parent = world.new();
+
+    // Create entity with components and dontFragment relation
+    const entity = world.new();
+    world.set(entity, PositionId, { x: 10, y: 20 });
+    world.set(entity, VelocityId, { vx: 1, vy: 2 });
+    world.set(entity, relation(ChildOf, parent));
+    world.sync();
+
+    // Verify initial state
+    expect(world.get(entity, PositionId)).toEqual({ x: 10, y: 20 });
+    expect(world.get(entity, VelocityId)).toEqual({ vx: 1, vy: 2 });
+    expect(world.has(entity, relation(ChildOf, parent))).toBe(true);
+
+    // Delete parent - relation should be removed but other components preserved
+    world.delete(parent);
+    world.sync();
+
+    // Entity should still exist with all other components intact
+    expect(world.exists(entity)).toBe(true);
+    expect(world.has(entity, relation(ChildOf, parent))).toBe(false);
+    expect(world.get(entity, PositionId)).toEqual({ x: 10, y: 20 });
+    expect(world.get(entity, VelocityId)).toEqual({ vx: 1, vy: 2 });
+  });
+});

package/src/__tests__/relations/dont-fragment/query-notification.test.ts

@@ -0,0 +1,125 @@
+import { describe, expect, it } from "bun:test";
+import { component, relation } from "../../../entity";
+import { World } from "../../../world/world";
+
+describe("DontFragment Query Notification Issue", () => {
+  it("should handle dontFragment wildcard queries and archetype lifecycle", () => {
+    const world = new World();
+    const Position = component();
+    const ChildOf = component({ dontFragment: true });
+    const WildcardChildOf = relation(ChildOf, "*");
+
+    const query = world.createQuery([WildcardChildOf, Position]);
+    expect(query.getEntities().length).toBe(0);
+
+    const parent1 = world.new();
+    const child1 = world.new();
+    world.set(child1, Position);
+    world.set(child1, relation(ChildOf, parent1));
+    world.sync();
+
+    // Verify entity is found and archetype has wildcard marker
+    expect(query.getEntities()).toContain(child1);
+    const arch1 = (world as any).entityToArchetype.get(child1);
+    expect(arch1.componentTypes).toContain(WildcardChildOf);
+
+    // Verify archetype separation: entity without relation shouldn't match
+    const entityWithout = world.new();
+    world.set(entityWithout, Position);
+    world.sync();
+    expect(query.getEntities()).not.toContain(entityWithout);
+    expect((world as any).entityToArchetype.get(entityWithout)).not.toBe(arch1);
+
+    // Add relation to existing entity
+    const parent2 = world.new();
+    world.set(entityWithout, relation(ChildOf, parent2));
+    world.sync();
+    expect(query.getEntities()).toContain(entityWithout);
+
+    // Remove relation: marker should disappear when last one is gone
+    world.remove(child1, relation(ChildOf, parent1));
+    world.sync();
+    expect(query.getEntities()).not.toContain(child1);
+    expect((world as any).entityToArchetype.get(child1).componentTypes).not.toContain(WildcardChildOf);
+  });
+
+  it("should handle exclusive dontFragment relations and specific target queries", () => {
+    const world = new World();
+    const ChildOf = component({ dontFragment: true, exclusive: true });
+    const p1 = world.new();
+    const p2 = world.new();
+    const entity = world.new();
+
+    const queryP1 = world.createQuery([relation(ChildOf, p1)]);
+    const queryP2 = world.createQuery([relation(ChildOf, p2)]);
+
+    // Set p1
+    world.set(entity, relation(ChildOf, p1));
+    world.sync();
+    expect(queryP1.getEntities()).toContain(entity);
+    expect(queryP2.getEntities()).not.toContain(entity);
+
+    // Re-set p1 (no-op/stable)
+    world.set(entity, relation(ChildOf, p1));
+    world.sync();
+    expect(queryP1.getEntities().length).toBe(1);
+
+    // Switch to p2
+    world.set(entity, relation(ChildOf, p2));
+    world.sync();
+    expect(queryP1.getEntities()).not.toContain(entity);
+    expect(queryP2.getEntities()).toContain(entity);
+
+    // Wildcard query should still work
+    const wildcardQuery = world.createQuery([relation(ChildOf, "*")]);
+    expect(wildcardQuery.getEntities()).toContain(entity);
+  });
+
+  it("should handle multiple non-exclusive dontFragment relations", () => {
+    const world = new World();
+    const Tag = component({ dontFragment: true });
+    const t1 = world.new();
+    const t2 = world.new();
+    const entity = world.new();
+    const wildcardQuery = world.createQuery([relation(Tag, "*")]);
+
+    world.set(entity, relation(Tag, t1));
+    world.set(entity, relation(Tag, t2));
+    world.sync();
+
+    expect(wildcardQuery.getEntities().length).toBe(1);
+    expect(world.has(entity, relation(Tag, t1))).toBe(true);
+    expect(world.has(entity, relation(Tag, t2))).toBe(true);
+
+    world.remove(entity, relation(Tag, t1));
+    world.sync();
+    expect(wildcardQuery.getEntities().length).toBe(1);
+    expect(world.has(entity, relation(Tag, t1))).toBe(false);
+
+    world.remove(entity, relation(Tag, t2));
+    world.sync();
+    expect(wildcardQuery.getEntities().length).toBe(0);
+  });
+
+  it("should correctly filter false positives in wildcard queries", () => {
+    const world = new World();
+    const TagA = component({ dontFragment: true });
+    const TagB = component({ dontFragment: true });
+    const p = world.new();
+
+    const e1 = world.new();
+    world.set(e1, relation(TagA, p));
+    const e2 = world.new();
+    world.set(e2, relation(TagB, p));
+    world.sync();
+
+    // QueryA should only find e1, QueryB should only find e2
+    const queryA = world.createQuery([relation(TagA, "*")]);
+    const queryB = world.createQuery([relation(TagB, "*")]);
+
+    expect(queryA.getEntities()).toContain(e1);
+    expect(queryA.getEntities()).not.toContain(e2);
+    expect(queryB.getEntities()).toContain(e2);
+    expect(queryB.getEntities()).not.toContain(e1);
+  });
+});