@codedrifters/configulator 0.0.231 → 0.0.233

package/lib/index.js

@@ -7375,7 +7375,10 @@ var requirementsAnalystSubAgent = {
     "   meeting extract).",
     "3. **Respect the taxonomy.** Route every discovered requirement to the",
     "   correct BCM category (FR, BR, NFR, SEC, DR, INT, OPS, UX, MT, ADR, TR)",
-    "   using the disambiguation rules in the requirements-writer skill.",
+    "   using the shared disambiguation rules \u2014 the same taxonomy the",
+    "   `requirements-writer` and `requirements-reviewer` load. The",
+    "   canonical source lives in `requirements-taxonomy.ts` and is",
+    "   embedded verbatim in both downstream agents' prompts.",
     "4. **Deduplicate.** Before creating an issue, check whether a requirement",
     "   already exists or an issue is already open for it.",
     "",
@@ -7478,7 +7481,9 @@ var requirementsAnalystSubAgent = {
     "2. **Identify potential gaps.** For each potential missing requirement:",
     "   - Classify into the correct BCM category (FR, BR, NFR, SEC, DR, INT,",
     "     OPS, UX, MT, ADR, TR)",
-    "   - Apply the disambiguation rules from the requirements-writer skill",
+    "   - Apply the shared disambiguation rules (from `requirements-taxonomy.ts`,",
+    "     also embedded in the requirements-writer and requirements-reviewer",
+    "     prompts)",
     "   - Note the source that revealed the gap",
     "   - Estimate priority based on the source context",
     "",
@@ -7819,6 +7824,61 @@ var requirementsAnalystBundle = {
   ]
 };
 
+// src/agent/bundles/requirements-taxonomy.ts
+var REQUIREMENTS_TAXONOMY_TABLE_SECTION = [
+  "## The 11-Category Taxonomy",
+  "",
+  "All requirements follow the BIZBOK-aligned 11-category taxonomy",
+  "below. Getting requirements into the right category matters because",
+  "it determines which template applies, which standards inform it, and",
+  "how it traces to other requirements.",
+  "",
+  "| Category | Prefix | Directory (default) | Question it answers |",
+  "|----------|--------|---------------------|---------------------|",
+  "| Business Requirements | BR | `business/` | **Why** are we building this? What business value does it deliver? |",
+  "| Functional Requirements | FR | `functional/` | **What** does the system do? What is the user-visible behavior? |",
+  "| Non-Functional Requirements | NFR | `non-functional/` | **How well** must the system perform? What quality bar must it meet? |",
+  "| Technical Requirements | TR | `technical/` | **What technology** are we using, and why that one? |",
+  "| Architectural Decisions | ADR | `architectural-decisions/` | **What structural decision** are we making, and what are the trade-offs? |",
+  "| Security & Compliance | SEC | `security/` | **What must we protect**, and what rules govern that protection? |",
+  "| Data Requirements | DR | `data/` | **What data** do we store, how long, and how do we recover it? |",
+  "| Integration Requirements | INT | `integration/` | **What external systems** do we connect to, and how? |",
+  "| Operational Requirements | OPS | `operational/` | **How do we deploy, monitor, and respond** to incidents? |",
+  "| UX Requirements | UX | `ux/` | **How must the interface look, feel, and behave** for users? |",
+  "| Multi-Tenancy & Licensing | MT | `multi-tenancy/` | **How do we isolate tenants, gate features, and meter usage?** |",
+  "",
+  "All requirement documents live under `<REQUIREMENTS_ROOT>` in the",
+  "category directory shown above. Directory names are defaults \u2014",
+  "consuming projects may rename them, but the prefixes are universal."
+];
+var REQUIREMENTS_TAXONOMY_DISAMBIGUATION_SECTION = [
+  "- **SEC vs NFR:** Protecting data, enforcing access control, or",
+  "  meeting a regulation \u2192 SEC. System performance, uptime, or",
+  '  scalability \u2192 NFR. "99.9% uptime" is NFR; "audit logs for all',
+  '  admin actions" is SEC.',
+  '- **TR vs ADR:** A TR pins down a specific technology choice ("use',
+  '  PostgreSQL 16+"). An ADR records a structural decision with',
+  '  context, trade-offs, and alternatives ("why row-level isolation',
+  '  over schema-per-tenant"). TRs often follow from ADRs.',
+  "- **FR vs INT:** What the user experiences \u2192 FR. How two systems",
+  '  communicate \u2192 INT. "User can pay with a credit card" is FR;',
+  '  "Stripe Checkout API integration for payment processing" is INT.',
+  "- **DR vs SEC:** What data exists, how long we keep it, and how we",
+  "  recover it \u2192 DR. Who can access it and how it's protected \u2192 SEC.",
+  "  These often cross-reference each other.",
+  "- **NFR vs OPS:** A measurable target the system must meet \u2192 NFR.",
+  '  The tooling and processes to run the system \u2192 OPS. "p99 latency',
+  '  < 200ms" is NFR; "Datadog APM for latency monitoring" is OPS.'
+];
+var REQUIREMENTS_TIER_TABLE_SECTION = [
+  "| Tier | Slug | When to use |",
+  "|------|------|-------------|",
+  "| **Platform** | `platform` | Core platform services \u2014 APIs, tenant isolation, auth, event bus, shared infrastructure |",
+  "| **Industry** | `industry` | Vertical-specific capabilities not every tenant needs |",
+  "| **Customer Workflow** | `customer-workflow` | Business logic tenants configure within the platform \u2014 approval chains, notification rules, intake processes |",
+  "| **Consumer Application** | `consumer-app` | UI/UX and integrations in external front-ends/systems consuming the platform's APIs |"
+];
+
 // src/agent/bundles/requirements-writer.ts
 var TEMPLATE_BR = `---
 title: "BR-NNN: [Business Requirement Title]"
@@ -9750,52 +9810,13 @@ var requirementsWriterSubAgent = {
     "",
     "---",
     "",
-    "## The 11-Category Taxonomy",
-    "",
-    "All requirements follow the BIZBOK-aligned 11-category taxonomy",
-    "below. Getting requirements into the right category matters because",
-    "it determines which template applies, which standards inform it, and",
-    "how it traces to other requirements.",
-    "",
-    "| Category | Prefix | Directory (default) | Question it answers |",
-    "|----------|--------|---------------------|---------------------|",
-    "| Business Requirements | BR | `business/` | **Why** are we building this? What business value does it deliver? |",
-    "| Functional Requirements | FR | `functional/` | **What** does the system do? What is the user-visible behavior? |",
-    "| Non-Functional Requirements | NFR | `non-functional/` | **How well** must the system perform? What quality bar must it meet? |",
-    "| Technical Requirements | TR | `technical/` | **What technology** are we using, and why that one? |",
-    "| Architectural Decisions | ADR | `architectural-decisions/` | **What structural decision** are we making, and what are the trade-offs? |",
-    "| Security & Compliance | SEC | `security/` | **What must we protect**, and what rules govern that protection? |",
-    "| Data Requirements | DR | `data/` | **What data** do we store, how long, and how do we recover it? |",
-    "| Integration Requirements | INT | `integration/` | **What external systems** do we connect to, and how? |",
-    "| Operational Requirements | OPS | `operational/` | **How do we deploy, monitor, and respond** to incidents? |",
-    "| UX Requirements | UX | `ux/` | **How must the interface look, feel, and behave** for users? |",
-    "| Multi-Tenancy & Licensing | MT | `multi-tenancy/` | **How do we isolate tenants, gate features, and meter usage?** |",
-    "",
-    "All requirement documents live under `<REQUIREMENTS_ROOT>` in the",
-    "category directory shown above. Directory names are defaults \u2014",
-    "consuming projects may rename them, but the prefixes are universal.",
+    ...REQUIREMENTS_TAXONOMY_TABLE_SECTION,
     "",
     "### Disambiguation Rules",
     "",
     "Apply these rules when deciding where a requirement belongs:",
     "",
-    "- **SEC vs NFR:** Protecting data, enforcing access control, or",
-    "  meeting a regulation \u2192 SEC. System performance, uptime, or",
-    '  scalability \u2192 NFR. "99.9% uptime" is NFR; "audit logs for all',
-    '  admin actions" is SEC.',
-    '- **TR vs ADR:** A TR pins down a specific technology choice ("use',
-    '  PostgreSQL 16+"). An ADR records a structural decision with',
-    '  context, trade-offs, and alternatives ("why row-level isolation',
-    '  over schema-per-tenant"). TRs often follow from ADRs.',
-    "- **FR vs INT:** What the user experiences \u2192 FR. How two systems",
-    '  communicate \u2192 INT. "User can pay with a credit card" is FR;',
-    '  "Stripe Checkout API integration for payment processing" is INT.',
-    "- **DR vs SEC:** What data exists, how long we keep it, and how we",
-    "  recover it \u2192 DR. Who can access it and how it's protected \u2192 SEC.",
-    "  These often cross-reference each other.",
-    "- **NFR vs OPS:** A measurable target the system must meet \u2192 NFR.",
-    '  The tooling and processes to run the system \u2192 OPS. "p99 latency',
-    '  < 200ms" is NFR; "Datadog APM for latency monitoring" is OPS.',
+    ...REQUIREMENTS_TAXONOMY_DISAMBIGUATION_SECTION,
     "",
     "---",
     "",
@@ -9807,12 +9828,7 @@ var requirementsWriterSubAgent = {
     "are the bundle defaults; consuming projects may rename or reduce the",
     "tier set in their own `docs/project-context.md`.",
     "",
-    "| Tier | Slug | When to use |",
-    "|------|------|-------------|",
-    "| **Platform** | `platform` | Core platform services \u2014 APIs, tenant isolation, auth, event bus, shared infrastructure |",
-    "| **Industry** | `industry` | Vertical-specific capabilities not every tenant needs |",
-    "| **Customer Workflow** | `customer-workflow` | Business logic tenants configure within the platform \u2014 approval chains, notification rules, intake processes |",
-    "| **Consumer Application** | `consumer-app` | UI/UX and integrations in external front-ends/systems consuming the platform's APIs |",
+    ...REQUIREMENTS_TIER_TABLE_SECTION,
     "",
     "Tier is a **required metadata field**. Set it in the Metadata table",
     "of every requirement document and apply the matching `tier:*` issue",
@@ -10602,19 +10618,12 @@ var requirementsReviewerSubAgent = {
     "### 2. Categorization Accuracy",
     "",
     "Verify each document is in the right category by applying the",
-    "disambiguation rules from the `requirements-writer` taxonomy:",
-    "",
-    "- **SEC vs NFR:** Protecting data, enforcing access control, or",
-    "  meeting a regulation \u2192 SEC. System performance, uptime, or",
-    "  scalability \u2192 NFR.",
-    "- **TR vs ADR:** A specific technology choice \u2192 TR. A structural",
-    "  decision with trade-offs \u2192 ADR.",
-    "- **FR vs INT:** User-visible behavior \u2192 FR. System-to-system",
-    "  communication \u2192 INT.",
-    "- **DR vs SEC:** Data lifecycle / retention / recovery \u2192 DR. Data",
-    "  access / protection \u2192 SEC.",
-    "- **NFR vs OPS:** Measurable system quality target \u2192 NFR. Tooling",
-    "  and processes to operate the system \u2192 OPS.",
+    "shared taxonomy disambiguation rules. The reviewer and the",
+    "`requirements-writer` load the **same** rules from",
+    "`requirements-taxonomy.ts` so the reviewer never flags a",
+    "correctly-categorized document as wrong:",
+    "",
+    ...REQUIREMENTS_TAXONOMY_DISAMBIGUATION_SECTION,
     "",
     "Flag any documents that appear miscategorized. Explain where they",
     "should live and why.",
@@ -10659,6 +10668,16 @@ var requirementsReviewerSubAgent = {
     "- Bidirectional links exist where expected (if A references B in",
     "  Traceability, B should reference A)",
     "",
+    "Findings from this check describe edits inside an existing",
+    "requirement document (the broken link lives in the body of the",
+    "doc and must be rewritten or removed). Route follow-up issues to",
+    "`req:write` so the `requirements-writer` \u2014 the only agent scoped",
+    "to edit under `<REQUIREMENTS_ROOT>` \u2014 picks them up. Do **not**",
+    "route Check 4 findings to `req:trace`; the analyst bundle does",
+    "not edit requirement documents and the issue would sit",
+    "unresolved. See the Follow-Up Issues section below for the full",
+    "Check 3 vs. Check 4 routing split.",
+    "",
     "### 5. Sequence Number Integrity",
     "",
     "Within each category directory under `<REQUIREMENTS_ROOT>`:",
@@ -10984,12 +11003,23 @@ var requirementsReviewerSubAgent = {
     "- Carries `type:requirement` (the type owned by the upstream",
     "  `requirements-analyst` bundle)",
     "- Carries the appropriate phase label for the work needed:",
-    "  - Structural / content fixes that an existing document needs \u2192",
-    "    `req:write` (the `requirements-writer` agent picks it up to",
-    "    revise the document)",
-    "  - Missing or broken traceability links \u2192 `req:trace` (the",
-    "    `requirements-analyst` agent picks it up to backfill",
-    "    traceability)",
+    "  - Structural / content fixes that an existing requirement",
+    "    document needs (including broken internal cross-references",
+    "    from Check 4 \u2014 e.g., a `See: [FR-012](...)` link pointing at",
+    "    a renamed or deleted requirement) \u2192 `req:write` (the",
+    "    `requirements-writer` agent picks it up to revise the",
+    "    document). Only the writer is scoped to edit requirement",
+    "    documents, so anything that requires an in-place edit under",
+    "    `<REQUIREMENTS_ROOT>` routes here.",
+    "  - Missing traceability in **source documents** \u2014 BCM model",
+    "    docs, competitive-analysis notes, product-roadmap entries,",
+    "    meeting extracts \u2014 that should link forward to an existing",
+    "    requirement (Check 3: orphaned requirements whose fix lives",
+    "    in the source tree, not the requirement doc) \u2192 `req:trace`",
+    "    (the `requirements-analyst` agent picks it up to backfill",
+    "    source-doc traceability). **Do not** route Check 4 broken",
+    "    cross-references here \u2014 the analyst bundle never writes to",
+    "    `<REQUIREMENTS_ROOT>` and the issue would sit unresolved.",
     "  - A new requirement is needed (e.g., a `Proposed` ADR is missing",
     "    for a deferred technology choice) \u2192 `req:scan` (the analyst",
     "    runs a scoped scan to confirm the gap, then drafts the new",