@codedrifters/configulator 0.0.199 → 0.0.200

package/lib/index.mjs

@@ -440,55 +440,11 @@ var createRuleSkill = {
     "- Use `ruleExtensions` to add project-specific content to existing bundle rules instead of replacing them"
   ].join("\n")
 };
-var reviewPrSkill = {
-  name: "review-pr",
-  description: "Review a pull request for code quality, conventions, and correctness",
-  instructions: [
-    "# Review Pull Request",
-    "",
-    "Review the current pull request in **{{repository.owner}}/{{repository.name}}**.",
-    "",
-    "## Review Checklist",
-    "",
-    "1. **Read the PR description** \u2014 understand the intent and linked issue",
-    "2. **Review the diff** \u2014 check all changed files for:",
-    "   - Correctness and logic errors",
-    "   - Adherence to project conventions",
-    "   - Test coverage for new/changed behavior",
-    "   - No unintended side effects",
-    "3. **Check PR conventions:**",
-    "   - Title uses conventional commit prefix (`feat:`, `fix:`, `docs:`, etc.)",
-    "   - Body includes a closing keyword (`Closes #<issue>`)",
-    "   - Summary of changes is present",
-    "4. **Verify build and tests pass**",
-    "",
-    "## Commands",
-    "",
-    "```bash",
-    "# View the PR details",
-    "gh pr view",
-    "",
-    "# View the diff",
-    "gh pr diff",
-    "",
-    "# Check CI status",
-    "gh pr checks",
-    "```",
-    "",
-    "## Output Format",
-    "",
-    "Provide a structured review with:",
-    "- **Summary**: One-line verdict (approve, request changes, or comment)",
-    "- **Findings**: Bulleted list of issues or suggestions, grouped by severity",
-    "- **Positive notes**: What was done well"
-  ].join("\n"),
-  allowedTools: ["Read", "Glob", "Grep", "Bash(gh *)"]
-};
 var baseBundle = {
   name: "base",
   description: "Core rules: project overview, interaction style, and general coding conventions",
   appliesWhen: () => true,
-  skills: [createRuleSkill, reviewPrSkill],
+  skills: [createRuleSkill],
   rules: [
     {
       name: "project-overview",
@@ -980,21 +936,7 @@ var githubWorkflowBundle = {
         "6. **Create the PR** using `gh pr create`:",
         "   - **Title**: use a conventional commit style title (e.g., `feat(scope): short description`)",
         "   - **Body**: include `Closes #<issue-number>` (derived from the branch name) and a brief summary of changes",
-        "7. **Enable auto-merge with squash** \u2014 use `gh pr merge --auto --squash` with the merge commit message:",
-        "",
-        "```",
-        "gh pr merge --auto --squash --subject '<conventional-commit-title>' --body '<extended-description>'",
-        "```",
-        "",
-        "The merge commit message should follow this format:",
-        "",
-        "```",
-        "Subject: <conventional-commit-title>",
-        "",
-        "Body:",
-        "- Bullet points summarizing the changes",
-        "- Closes #<issue-number>",
-        "```",
+        "7. **Delegate review and merge to the `pr-reviewer` sub-agent.** After the PR is created, invoke the `/review-pr <pr-number>` skill (or otherwise hand the new PR number to the `pr-reviewer` sub-agent). The reviewer verifies the diff against the linked issue's acceptance criteria and enables squash auto-merge when all checks pass. Do **not** run `gh pr merge --auto` yourself \u2014 review/merge policy lives solely in the `pr-reviewer` agent.",
         "",
         "### PR Body Template",
         "",
@@ -1015,7 +957,7 @@ var githubWorkflowBundle = {
         "",
         "- Always derive the issue number from the branch name (e.g., `feat/42-add-login` \u2192 `#42`)",
         "- Use conventional commit format for the PR title",
-        "- Always enable auto-merge with squash \u2014 do not merge manually"
+        "- Delegate merge to the `pr-reviewer` sub-agent \u2014 do not merge manually and do not enable auto-merge directly"
       ].join("\n"),
       tags: ["workflow"]
     }
@@ -1797,8 +1739,7 @@ var orchestratorSubAgent = {
     "   - Verify PR conventions: conventional commit title, closing keyword, summary present",
     "   - Check CI status: `gh pr checks N`",
     "3. If the PR passes review:",
-    "   - Approve: `gh pr review N --approve --body '<summary>'`",
-    "   - Enable auto-merge: `gh pr merge N --auto --squash`",
+    "   - Enable squash auto-merge: `gh pr merge N --auto --squash --subject '<conventional-commit-title>' --body '<extended-description>'`",
     "4. If the PR fails review:",
     "   - Request changes: `gh pr review N --request-changes --body '<findings>'`",
     "5. After each PR (whether merged or not):",
@@ -2058,10 +1999,10 @@ var issueWorkerSubAgent = {
     'Closes #<issue-number>"',
     "```",
     "",
-    "Enable auto-merge:",
-    "```bash",
-    "gh pr merge --auto --squash",
-    "```",
+    "Do **not** enable auto-merge yourself. The `pr-reviewer` sub-agent owns",
+    "review and merge for every PR \u2014 it verifies the diff against the issue's",
+    "acceptance criteria and enables squash auto-merge only when all checks",
+    "pass. Record the new PR number so a reviewer can be invoked next.",
     "",
     "## Phase 8: Update Status",
     "",
@@ -2072,9 +2013,9 @@ var issueWorkerSubAgent = {
     "",
     "## Phase 9: Branch Cleanup",
     "",
-    "Auto-merge is enabled, so the PR may not be merged yet. Poll the PR state",
-    "up to 10 times, waiting 30 seconds between polls, until it either merges,",
-    "closes, or the timeout is reached:",
+    "The PR will not auto-merge until the `pr-reviewer` enables it. Poll the PR",
+    "state up to 10 times, waiting 30 seconds between polls, until it either",
+    "merges, closes, or the timeout is reached:",
     "",
     "```bash",
     "gh pr view <pr-number> --json state --jq '.state'",
@@ -2088,8 +2029,8 @@ var issueWorkerSubAgent = {
     "  ```",
     "- **If the state becomes `CLOSED` (not merged):** leave the branch in place",
     "  and report that the PR was closed without merging. Do not delete the branch.",
-    "- **If still `OPEN` after the polling window:** report that auto-merge is",
-    "  still pending and stop. Do not delete the branch.",
+    "- **If still `OPEN` after the polling window:** report that the PR is",
+    "  awaiting review/merge and stop. Do not delete the branch.",
     "",
     "---",
     "",
@@ -2270,6 +2211,392 @@ var pnpmBundle = {
   ]
 };
 
+// src/agent/bundles/pr-review.ts
+var prReviewerSubAgent = {
+  name: "pr-reviewer",
+  description: "Reviews a pull request against its linked issue's acceptance criteria, then enables squash auto-merge or comments with findings",
+  model: AGENT_MODEL.POWERFUL,
+  maxTurns: 40,
+  platforms: { cursor: { exclude: true } },
+  prompt: [
+    "# PR Reviewer Agent",
+    "",
+    "You review a single pull request in **{{repository.owner}}/{{repository.name}}**",
+    "against its linked issue's acceptance criteria, verify code quality and",
+    "convention compliance, and then either enable squash auto-merge or leave",
+    "a review comment with findings. You handle exactly **one PR per session**",
+    "unless invoked from the multi-PR loop skill (`/review-prs`), in which case",
+    "you process each eligible PR in turn.",
+    "",
+    "---",
+    "",
+    "## Phase 1: Identify the PR",
+    "",
+    "If a PR number was provided in your instructions, use that. Otherwise stop",
+    "and report that you need a PR number \u2014 do not pick one yourself.",
+    "",
+    "## Phase 1.5: Pre-flight Eligibility Filter",
+    "",
+    "Before spending turns on a full review, run a cheap eligibility check:",
+    "",
+    "```bash",
+    "gh pr view <pr-number> --json number,title,body,headRefName,mergeable,mergeStateStatus,statusCheckRollup",
+    "```",
+    "",
+    "The PR is **eligible** only when **all** of the following hold:",
+    "",
+    '1. `mergeable == "MERGEABLE"` (no merge conflicts).',
+    "2. No **failing** required checks in `statusCheckRollup` \u2014 CI must be",
+    "   green or still pending. Any `FAILURE`, `TIMED_OUT`, `CANCELLED`, or",
+    "   `ERROR` conclusion on a required check disqualifies the PR.",
+    "3. The PR body contains a linked issue via one of the closing keywords:",
+    "   `Closes #N`, `Fixes #N`, or `Resolves #N` (case-insensitive).",
+    "",
+    "If **any** check fails, post a short comment explaining the reason and",
+    "stop. Do not proceed to full review.",
+    "",
+    "```bash",
+    "gh pr comment <pr-number> --body '<reason>'",
+    "```",
+    "",
+    "Typical reasons:",
+    "",
+    "- `Not reviewable: merge conflicts \u2014 please rebase onto the default branch.`",
+    "- `Not reviewable: required CI check <name> is failing.`",
+    "- `Not reviewable: PR body is missing a linked issue (Closes #N / Fixes #N / Resolves #N).`",
+    "",
+    "## Phase 2: Gather Context",
+    "",
+    "```bash",
+    "gh pr view <pr-number> --json number,title,body,headRefName,baseRefName,isDraft,state,labels,reviews",
+    "gh pr diff <pr-number>",
+    "gh pr checks <pr-number>",
+    "```",
+    "",
+    "Extract the linked issue number from the PR body using the closing keywords",
+    "(`Closes #N`, `Fixes #N`, or `Resolves #N`) identified in Phase 1.5.",
+    "",
+    "Then fetch the linked issue:",
+    "",
+    "```bash",
+    "gh issue view <issue-number>",
+    "```",
+    "",
+    "## Phase 3: Compare Diff to Acceptance Criteria",
+    "",
+    "Read the issue body for an **Acceptance Criteria** (or equivalent) section.",
+    "Build a checklist from it. For each item:",
+    "",
+    "1. Locate the changes in the diff that satisfy it.",
+    "2. Mark it as `met`, `partial`, or `missing`.",
+    "3. Record the specific files / functions / tests that provide evidence.",
+    "",
+    "Also evaluate:",
+    "",
+    "- **Convention compliance** \u2014 PR title uses a conventional commit prefix,",
+    "  body includes a closing keyword, branch name follows project conventions",
+    "- **Test coverage** \u2014 new or changed behavior has tests",
+    "- **CI status** \u2014 `gh pr checks` reports all required checks passing",
+    "- **Scope creep** \u2014 diff stays within the issue's stated scope",
+    "",
+    "## Phase 4: Decide and Act",
+    "",
+    "### If all acceptance criteria are met and CI is green",
+    "",
+    "Enable squash auto-merge with branch deletion. This queues the merge to",
+    "happen once required checks pass; no separate approval review is needed.",
+    "",
+    "```bash",
+    "gh pr merge <pr-number> --auto --squash --delete-branch \\",
+    "  --subject '<conventional-commit-title>' \\",
+    "  --body '<extended-description>'",
+    "```",
+    "",
+    "The squash-merge subject should follow conventional commit format (e.g.",
+    "`feat(scope): description`). The body should bullet the changes and end",
+    "with `Closes #<issue-number>`.",
+    "",
+    "### If any criterion is missing, partial, or CI is failing",
+    "",
+    "Post a plain comment (not a formal review block) with grouped findings:",
+    "",
+    "```bash",
+    "gh pr comment <pr-number> --body '<grouped findings>'",
+    "```",
+    "",
+    "Group findings by severity (**Blocking** / **Suggested** / **Nitpick**).",
+    "For each blocking finding, cite the unmet acceptance criterion and the",
+    "file or function the gap lives in. Do **not** merge, and do **not** push",
+    "any commits to the PR's branch.",
+    "",
+    "Rationale for using a plain comment rather than `gh pr review",
+    "--request-changes`: it is lighter-weight, doesn't require the author to",
+    "dismiss a formal review, and composes cleanly with the multi-PR loop.",
+    "",
+    "## Phase 5: Branch Cleanup and Issue Closure Verification",
+    "",
+    "Auto-merge may not be immediate. Poll the PR state up to 10 times, waiting",
+    "30 seconds between polls:",
+    "",
+    "```bash",
+    "gh pr view <pr-number> --json state --jq '.state'",
+    "```",
+    "",
+    "- **`MERGED`** \u2014 clean up locally **and** verify the linked issue closed:",
+    "  ```bash",
+    "  git checkout {{repository.defaultBranch}}",
+    "  git pull origin {{repository.defaultBranch}}",
+    "  git fetch --prune origin",
+    "  git branch -d <branch-name> 2>/dev/null || git branch -D <branch-name> 2>/dev/null || true",
+    "  ```",
+    "  Then check the linked issue state:",
+    "  ```bash",
+    "  gh issue view <issue-number> --json state --jq '.state'",
+    "  ```",
+    "  If the issue is **not** `CLOSED`, close it explicitly (this covers",
+    "  malformed or missing closing keywords on the merge commit):",
+    "  ```bash",
+    "  gh issue close <issue-number> --reason completed",
+    "  gh issue comment <issue-number> --body 'PR #<pr-number> merged. Closing issue.'",
+    "  ```",
+    "- **`CLOSED` (not merged)** \u2014 leave the branch in place; report the closure.",
+    "- **Still `OPEN`** \u2014 auto-merge is pending; report and stop without deleting.",
+    "",
+    "---",
+    "",
+    "## Output Format",
+    "",
+    "Return a structured report:",
+    "",
+    "```",
+    "PR #<number> \u2014 <title>",
+    "Linked issue: #<issue-number>",
+    "Verdict: AUTO_MERGE_ENABLED | NEEDS_CHANGES | INELIGIBLE | BLOCKED",
+    "",
+    "Acceptance criteria:",
+    "  [x] <criterion> \u2014 <evidence>",
+    "  [~] <criterion> \u2014 partial: <gap>",
+    "  [ ] <criterion> \u2014 missing",
+    "",
+    "Findings:",
+    "  - Blocking: <items>",
+    "  - Suggested: <items>",
+    "  - Nitpick: <items>",
+    "",
+    "Action taken: <enable-auto-merge | commented-on-the-pr | none>",
+    "Branch state: <merged | open | closed>",
+    "Issue state: <closed | open>",
+    "```",
+    "",
+    "---",
+    "",
+    "## Rules",
+    "",
+    "1. **One PR per session** when invoked directly (`/review-pr`). When",
+    "   invoked from the multi-PR loop (`/review-prs`), process every eligible",
+    "   PR in turn.",
+    "2. **Never merge without a linked issue.** If the PR body has no",
+    "   `Closes #N` / `Fixes #N` / `Resolves #N`, comment and stop.",
+    "3. **Never merge with failing CI.** Even if every criterion is met,",
+    "   block on red checks.",
+    "4. **Never bypass review conventions.** Always use `--squash`, `--auto`,",
+    "   and `--delete-branch` for merges. Do not force-merge.",
+    "5. **Do not implement code.** You review, decide, and orchestrate. If",
+    "   the PR needs changes, comment and stop.",
+    "6. **Never push commits to the PR's branch.** If the PR needs changes,",
+    "   comment and stop \u2014 do not attempt to fix it yourself. The PR author",
+    "   owns the branch; pushing to someone else's branch is out of scope.",
+    "7. **In loop mode (`/review-prs`), never stop early.** If any review",
+    "   fails, comment and move to the next PR. Only abort the loop on a",
+    "   fatal error (e.g. `gh` auth failure, network outage).",
+    "8. **Follow CLAUDE.md conventions** for all `git` and `gh` operations."
+  ].join("\n")
+};
+var reviewPrSkill = {
+  name: "review-pr",
+  description: "Review a single pull request against its linked issue's acceptance criteria, then enable squash auto-merge or comment with findings",
+  disableModelInvocation: true,
+  userInvocable: true,
+  context: "fork",
+  agent: "pr-reviewer",
+  platforms: { cursor: { exclude: true } },
+  instructions: [
+    "# Review Pull Request",
+    "",
+    "Run a full PR review against the linked issue's acceptance criteria,",
+    "then either enable squash auto-merge or post a findings comment.",
+    "",
+    "## Usage",
+    "",
+    "/review-pr <pr-number>",
+    "",
+    "## What This Skill Does",
+    "",
+    "1. Runs a pre-flight eligibility filter (mergeable, CI not failing, has linked issue)",
+    "2. Fetches the PR, its diff, CI status, and the linked issue",
+    "3. Builds a checklist from the issue's acceptance criteria",
+    "4. Compares the diff against each criterion",
+    "5. Verifies PR conventions (title, closing keyword, branch name)",
+    "6. Verifies CI is green",
+    "7. **If all checks pass:** enables squash auto-merge (with `--delete-branch`)",
+    "8. **If any check fails:** posts a findings comment via `gh pr comment`",
+    "9. After merge, verifies the linked issue is closed and closes it if not",
+    "10. Cleans up the local branch after merge",
+    "",
+    "## Input",
+    "",
+    "Provide the PR number to review. The skill resolves the linked issue from",
+    "the PR body (`Closes #N` / `Fixes #N` / `Resolves #N`).",
+    "",
+    "## Output",
+    "",
+    "A structured report covering verdict, per-criterion status, findings",
+    "grouped by severity, the action taken, and the final branch / issue state.",
+    "",
+    "## Composability",
+    "",
+    "This skill is generic and can be composed with the `github-workflow`",
+    "bundle. The reviewer never implements code and never pushes to the PR",
+    "branch \u2014 it only reviews, decides, and orchestrates merge or comment."
+  ].join("\n")
+};
+var reviewPrsSkill = {
+  name: "review-prs",
+  description: "Loop over every eligible open pull request in the repository and review each one through the full pipeline",
+  disableModelInvocation: true,
+  userInvocable: true,
+  context: "fork",
+  agent: "pr-reviewer",
+  platforms: { cursor: { exclude: true } },
+  instructions: [
+    "# Review All Eligible Pull Requests",
+    "",
+    "Run the pr-reviewer pipeline over every eligible open PR in",
+    "**{{repository.owner}}/{{repository.name}}**, one after another, until",
+    "the eligible queue is empty.",
+    "",
+    "## Usage",
+    "",
+    "/review-prs",
+    "",
+    "## What This Skill Does",
+    "",
+    "### Step 1: Enumerate open PRs",
+    "",
+    "```bash",
+    "gh pr list --json number,title,body,headRefName,mergeable,mergeStateStatus,statusCheckRollup --limit 50",
+    "```",
+    "",
+    "### Step 2: Filter to eligible PRs",
+    "",
+    "A PR is **eligible** when all of the following hold:",
+    "",
+    '1. `state == "OPEN"` (implicit from `gh pr list`).',
+    '2. `mergeable == "MERGEABLE"` (no conflicts).',
+    "3. No required check in `statusCheckRollup` has a failing conclusion",
+    "   (`FAILURE`, `TIMED_OUT`, `CANCELLED`, `ERROR`). CI green or still",
+    "   pending is fine.",
+    "4. The PR body contains a linked issue (`Closes #N` / `Fixes #N` /",
+    "   `Resolves #N`, case-insensitive).",
+    "",
+    "Drop any PR that fails the filter from the queue. Do not comment on",
+    "them from this skill \u2014 the individual `/review-pr` invocation handles",
+    "the inline rejection comment when run on a specific PR.",
+    "",
+    "### Step 3: Process each eligible PR",
+    "",
+    "For every eligible PR, invoke the full pr-reviewer pipeline",
+    "(Phases 1 through 5) as if `/review-pr <number>` had been called",
+    "directly:",
+    "",
+    "- Gather context (diff, checks, linked issue)",
+    "- Compare diff to acceptance criteria",
+    "- Decide and act (enable auto-merge **or** post findings comment)",
+    "- Verify branch / issue cleanup after merge",
+    "",
+    "Continue to the next PR after each one completes. Never stop the loop",
+    "early because a single PR's review failed \u2014 comment and move on.",
+    "",
+    "### Step 4: Stop when the queue is empty",
+    "",
+    "When no eligible PRs remain, emit a final summary listing every PR",
+    "processed and the verdict for each, then stop.",
+    "",
+    "## Output",
+    "",
+    "Per-PR structured report (same shape as `/review-pr`), followed by a",
+    "one-line-per-PR summary at the end:",
+    "",
+    "```",
+    "Summary:",
+    "  PR #<n>: <verdict>",
+    "  PR #<n>: <verdict>",
+    "  ...",
+    "Total processed: <count>",
+    "```",
+    "",
+    "## Failure Handling",
+    "",
+    "Only abort the loop on a fatal error (e.g. `gh` authentication failure,",
+    "network outage). A failed review for an individual PR is not fatal \u2014",
+    "comment on that PR and continue with the next."
+  ].join("\n")
+};
+var prReviewBundle = {
+  name: "pr-review",
+  description: "Pull request review workflow: verifies PRs against their linked issues' acceptance criteria and orchestrates squash-merge, single or looped over all eligible PRs",
+  // Default-apply: the PR review workflow is safe to include everywhere,
+  // and keeping review/merge policy centralised in the pr-reviewer agent
+  // means consumers get consistent behaviour out of the box. Consumers can
+  // still exclude it explicitly via `excludeBundles` if desired.
+  appliesWhen: () => true,
+  rules: [
+    {
+      name: "pr-review-workflow",
+      description: "Describes the /review-pr and /review-prs skills and their delegation to the pr-reviewer sub-agent",
+      scope: AGENT_RULE_SCOPE.ALWAYS,
+      content: [
+        "# PR Review Workflow",
+        "",
+        "Two skills are available, both backed by the same `pr-reviewer`",
+        "sub-agent:",
+        "",
+        "- **`/review-pr <pr-number>`** \u2014 review a single targeted PR.",
+        "- **`/review-prs`** \u2014 loop over every eligible open PR in the",
+        "  repository and review each one in turn.",
+        "",
+        "The `pr-reviewer` sub-agent:",
+        "",
+        "1. Runs a pre-flight eligibility filter (mergeable, CI not failing,",
+        "   has a linked issue). Ineligible PRs get a short comment and are",
+        "   skipped.",
+        "2. Fetches the PR, its diff, CI status, and the linked issue",
+        "3. Builds a checklist from the issue's acceptance criteria",
+        "4. Verifies the diff satisfies each criterion and that CI is green",
+        "5. **Enables squash auto-merge** (with `--delete-branch`) when all",
+        "   checks pass \u2014 no explicit approval review",
+        "6. **Comments with grouped findings** when any check fails (plain",
+        "   `gh pr comment`, not a formal `--request-changes` review)",
+        "7. After a successful merge, verifies the linked issue is closed",
+        "   and closes it explicitly if the merge commit did not",
+        "8. Cleans up the local branch after merge",
+        "",
+        "The reviewer **never** implements code and **never** pushes commits",
+        "to a PR's branch \u2014 it only reviews, decides, and orchestrates merge",
+        "or comment. In loop mode, a failed review for one PR never stops",
+        "the loop; the reviewer comments and moves on. See the `pr-reviewer`",
+        "agent definition for the full phase-by-phase contract."
+      ].join("\n"),
+      platforms: {
+        cursor: { exclude: true }
+      },
+      tags: ["workflow"]
+    }
+  ],
+  skills: [reviewPrSkill, reviewPrsSkill],
+  subAgents: [prReviewerSubAgent]
+};
+
 // src/agent/bundles/projen.ts
 var projenBundle = {
   name: "projen",
@@ -3187,7 +3514,8 @@ var BUILT_IN_BUNDLES = [
   githubWorkflowBundle,
   slackBundle,
   meetingAnalysisBundle,
-  orchestratorBundle
+  orchestratorBundle,
+  prReviewBundle
 ];
 
 // src/agent/bundles/scope.ts
@@ -6725,6 +7053,7 @@ export {
   meetingAnalysisBundle,
   orchestratorBundle,
   pnpmBundle,
+  prReviewBundle,
   projenBundle,
   resolveModelAlias,
   resolveTemplateVariables,