@codebakers/cli 3.9.40 → 3.9.42

package/src/mcp/server.ts

@@ -71,6 +71,31 @@ class CodeBakersServer {
   private updateCheckInterval = 60 * 60 * 1000; // Check every hour
   private currentSessionToken: string | null = null; // v6.19: Server-side enforcement session
 
+  // Check for pre-commit violations
+  private checkForViolations(): { hasViolations: boolean; violations: any[] | null; message: string | null } {
+    const cwd = process.cwd();
+    const violationsPath = path.join(cwd, '.codebakers', 'violations.json');
+
+    if (!fs.existsSync(violationsPath)) {
+      return { hasViolations: false, violations: null, message: null };
+    }
+
+    try {
+      const data = JSON.parse(fs.readFileSync(violationsPath, 'utf-8'));
+      if (data.violations && data.violations.length > 0) {
+        return {
+          hasViolations: true,
+          violations: data.violations,
+          message: `⚠️ ${data.count} pre-commit violation(s) found! Call heal_violations() to auto-fix.`
+        };
+      }
+    } catch {
+      // Ignore parse errors
+    }
+
+    return { hasViolations: false, violations: null, message: null };
+  }
+
   constructor() {
     this.apiKey = getApiKey();
     this.apiUrl = getApiUrl();
@@ -1643,6 +1668,21 @@ class CodeBakersServer {
             },
           },
         },
+        // Pre-commit violation healing tool
+        {
+          name: 'heal_violations',
+          description:
+            'Auto-fix pre-commit hook violations. Call this when you see a violation warning in tool responses. Reads .codebakers/violations.json and provides fixes using CodeBakers patterns. After fixing, clears the violations file.',
+          inputSchema: {
+            type: 'object' as const,
+            properties: {
+              autoFix: {
+                type: 'boolean',
+                description: 'Automatically apply fixes (default: true). Set to false to just see the issues.',
+              },
+            },
+          },
+        },
         // Engineering workflow tools
         ...ENGINEERING_TOOLS,
       ],
@@ -1900,6 +1940,9 @@ class CodeBakersServer {
         case 'setup_services':
           return this.handleSetupServices(args as { services?: string[]; checkOnly?: boolean });
 
+        case 'heal_violations':
+          return this.handleHealViolations(args as { autoFix?: boolean });
+
         // Engineering workflow tools
         case 'engineering_start':
         case 'engineering_scope':
@@ -4394,6 +4437,115 @@ If you want AI features and prefer Claude over GPT (or want both as fallback).`,
     };
   }
 
+  private handleHealViolations(args: { autoFix?: boolean }) {
+    const { autoFix = true } = args;
+    const cwd = process.cwd();
+    const violationsPath = path.join(cwd, '.codebakers', 'violations.json');
+
+    // Check if violations file exists
+    if (!fs.existsSync(violationsPath)) {
+      return {
+        content: [{
+          type: 'text' as const,
+          text: `✅ **No violations found!**\n\nThe \`.codebakers/violations.json\` file doesn't exist, which means:\n- No pre-commit violations have been detected\n- Or they were already fixed\n\nYou're good to commit!`,
+        }],
+      };
+    }
+
+    // Read violations
+    let data: { timestamp: string; count: number; violations: Array<{ file: string; check: string; category: string; message: string; line?: number; code?: string }> };
+    try {
+      data = JSON.parse(fs.readFileSync(violationsPath, 'utf-8'));
+    } catch {
+      return {
+        content: [{
+          type: 'text' as const,
+          text: `⚠️ **Could not parse violations file**\n\nThe violations.json file exists but couldn't be read. Try running \`git commit\` again to regenerate it.`,
+        }],
+      };
+    }
+
+    if (!data.violations || data.violations.length === 0) {
+      // Clean up empty violations file
+      fs.unlinkSync(violationsPath);
+      return {
+        content: [{
+          type: 'text' as const,
+          text: `✅ **No violations to fix!**\n\nThe violations file was empty. Cleaned it up for you.`,
+        }],
+      };
+    }
+
+    // Group violations by file
+    const byFile: Record<string, typeof data.violations> = {};
+    for (const v of data.violations) {
+      if (!byFile[v.file]) byFile[v.file] = [];
+      byFile[v.file].push(v);
+    }
+
+    // Build response with fix instructions
+    let response = `# 🔧 Pre-Commit Violations Found\n\n`;
+    response += `**${data.count} violation(s)** detected at ${data.timestamp}\n\n`;
+
+    // Category fixes mapping
+    const categoryFixes: Record<string, string> = {
+      security: 'Use parameterized queries, escape user input, avoid eval()',
+      errors: 'Add try/catch blocks, handle Promise rejections, use Result types',
+      validation: 'Add Zod schemas at API boundaries, validate inputs before use',
+      quality: 'Remove console.log, add explicit types, avoid any',
+      typescript: 'Add proper type annotations, avoid type assertions',
+      react: 'Add key props, wrap handlers in useCallback, handle loading states',
+      accessibility: 'Add alt text, aria-labels, ensure keyboard navigation',
+      performance: 'Use proper React hooks dependencies, memoize expensive operations',
+      api: 'Use NextResponse for API routes, add rate limiting',
+      imports: 'Fix import order, remove unused imports',
+    };
+
+    for (const [file, violations] of Object.entries(byFile)) {
+      response += `## 📄 ${file}\n\n`;
+
+      for (const v of violations) {
+        response += `### ❌ ${v.check}\n`;
+        response += `- **Category:** ${v.category}\n`;
+        response += `- **Issue:** ${v.message}\n`;
+        if (v.line) response += `- **Line:** ${v.line}\n`;
+        if (v.code) response += `- **Code:** \`${v.code.substring(0, 100)}${v.code.length > 100 ? '...' : ''}\`\n`;
+
+        // Add fix suggestion
+        const fix = categoryFixes[v.category] || 'Review the code and apply best practices';
+        response += `- **Fix:** ${fix}\n\n`;
+      }
+    }
+
+    if (autoFix) {
+      response += `---\n\n`;
+      response += `## 🛠️ Auto-Fix Instructions\n\n`;
+      response += `I'll now fix these violations. For each file:\n\n`;
+
+      for (const [file, violations] of Object.entries(byFile)) {
+        response += `**${file}:**\n`;
+        for (const v of violations) {
+          response += `- Fix: ${v.check} (${v.category})\n`;
+        }
+        response += `\n`;
+      }
+
+      response += `After fixing, run \`git add .\` and \`git commit\` again.\n\n`;
+      response += `---\n\n`;
+      response += `**⚠️ IMPORTANT:** Read each file and apply the fixes according to CodeBakers patterns. Load the relevant pattern module for each category (e.g., \`00-core.md\` for types, \`02-auth.md\` for security, \`03-api.md\` for API routes).\n`;
+    } else {
+      response += `---\n\n`;
+      response += `Run \`heal_violations({ autoFix: true })\` to get fix instructions, or fix manually and commit again.\n`;
+    }
+
+    return {
+      content: [{
+        type: 'text' as const,
+        text: response,
+      }],
+    };
+  }
+
   private handleRunTests(args: { filter?: string; watch?: boolean }) {
     const { filter, watch = false } = args;
     const cwd = process.cwd();
@@ -5080,6 +5232,15 @@ If you want AI features and prefer Claude over GPT (or want both as fallback).`,
           responseText += `**${result.nextSteps || 'Fix the issues above and try again.'}**\n`;
         }
 
+        // Check for pre-commit violations
+        const violations = this.checkForViolations();
+        if (violations.hasViolations) {
+          responseText += `\n---\n\n`;
+          responseText += `## 🚨 PRE-COMMIT VIOLATIONS DETECTED\n\n`;
+          responseText += violations.message + `\n\n`;
+          responseText += `**IMPORTANT:** These violations will block your commit. Call \`heal_violations()\` to fix them.\n`;
+        }
+
         return {
           content: [{
             type: 'text' as const,
@@ -5417,6 +5578,15 @@ If you want AI features and prefer Claude over GPT (or want both as fallback).`,
       responseText += `5. Pre-commit hook blocks commits without passed validation\n\n`;
       responseText += `**Server is tracking this session. Compliance is enforced.**`;
 
+      // Check for pre-commit violations
+      const violations = this.checkForViolations();
+      if (violations.hasViolations) {
+        responseText += `\n\n---\n\n`;
+        responseText += `## 🚨 PRE-COMMIT VIOLATIONS DETECTED\n\n`;
+        responseText += violations.message + `\n\n`;
+        responseText += `**Fix these violations BEFORE writing new code.** Call \`heal_violations()\` to see details and fixes.\n`;
+      }
+
       return {
         content: [{
           type: 'text' as const,