@code-pushup/lighthouse-plugin 0.45.0 → 0.46.0

package/index.js

@@ -110,6 +110,7 @@ var fileNameSchema = z.string().trim().regex(filenameRegex, {
 }).min(1, { message: "file name is invalid" });
 var positiveIntSchema = z.number().int().positive();
 var nonnegativeIntSchema = z.number().int().nonnegative();
+var nonnegativeNumberSchema = z.number().nonnegative();
 function packageVersionSchema(options) {
   const { versionDescription = "NPM version of the package", required } = options ?? {};
   const packageSchema = z.string({ description: "NPM package name" });
@@ -122,7 +123,7 @@ function packageVersionSchema(options) {
     { description: "NPM package name and version of a published package" }
   );
 }
-var weightSchema = nonnegativeIntSchema.describe(
+var weightSchema = nonnegativeNumberSchema.describe(
   "Coefficient for the given score (use weight 0 if only for display)"
 );
 function weightedRefSchema(description, slugDescription) {
@@ -264,7 +265,7 @@ var tableObjectSchema = tableSharedSchema.merge(
 var tableSchema = (description = "Table information") => z4.union([tablePrimitiveSchema, tableObjectSchema], { description });
 
 // packages/models/src/lib/audit-output.ts
-var auditValueSchema = nonnegativeIntSchema.describe("Raw numeric value");
+var auditValueSchema = nonnegativeNumberSchema.describe("Raw numeric value");
 var auditDisplayValueSchema = z5.string({ description: "Formatted value (e.g. '0.9 s', '2.1 MB')" }).optional();
 var auditDetailsSchema = z5.object(
   {
@@ -708,6 +709,79 @@ var LIGHTHOUSE_OUTPUT_PATH = join(
 // packages/plugin-lighthouse/src/lib/normalize-flags.ts
 import chalk6 from "chalk";
 
+// packages/utils/src/lib/file-system.ts
+import { bundleRequire } from "bundle-require";
+import chalk2 from "chalk";
+import { mkdir, readFile, readdir, rm, stat } from "node:fs/promises";
+
+// packages/utils/src/lib/logging.ts
+import isaacs_cliui from "@isaacs/cliui";
+import { cliui } from "@poppinss/cliui";
+import chalk from "chalk";
+
+// packages/utils/src/lib/reports/constants.ts
+var TERMINAL_WIDTH = 80;
+
+// packages/utils/src/lib/logging.ts
+var singletonUiInstance;
+function ui() {
+  if (singletonUiInstance === void 0) {
+    singletonUiInstance = cliui();
+  }
+  return {
+    ...singletonUiInstance,
+    row: (args) => {
+      logListItem(args);
+    }
+  };
+}
+var singletonisaacUi;
+function logListItem(args) {
+  if (singletonisaacUi === void 0) {
+    singletonisaacUi = isaacs_cliui({ width: TERMINAL_WIDTH });
+  }
+  singletonisaacUi.div(...args);
+  const content = singletonisaacUi.toString();
+  singletonisaacUi.rows = [];
+  singletonUiInstance?.logger.log(content);
+}
+
+// packages/utils/src/lib/file-system.ts
+async function readTextFile(path) {
+  const buffer = await readFile(path);
+  return buffer.toString();
+}
+async function readJsonFile(path) {
+  const text = await readTextFile(path);
+  return JSON.parse(text);
+}
+async function ensureDirectoryExists(baseDir) {
+  try {
+    await mkdir(baseDir, { recursive: true });
+    return;
+  } catch (error) {
+    ui().logger.info(error.message);
+    if (error.code !== "EEXIST") {
+      throw error;
+    }
+  }
+}
+var NoExportError = class extends Error {
+  constructor(filepath) {
+    super(`No default export found in ${filepath}`);
+  }
+};
+async function importEsmModule(options) {
+  const { mod } = await bundleRequire({
+    format: "esm",
+    ...options
+  });
+  if (!("default" in mod)) {
+    throw new NoExportError(options.filepath);
+  }
+  return mod.default;
+}
+
 // packages/utils/src/lib/text-formats/constants.ts
 var NEW_LINE = "\n";
 var TAB = "  ";
@@ -983,79 +1057,6 @@ var html = {
   table
 };
 
-// packages/utils/src/lib/file-system.ts
-import { bundleRequire } from "bundle-require";
-import chalk2 from "chalk";
-import { mkdir, readFile, readdir, rm, stat } from "node:fs/promises";
-
-// packages/utils/src/lib/logging.ts
-import isaacs_cliui from "@isaacs/cliui";
-import { cliui } from "@poppinss/cliui";
-import chalk from "chalk";
-
-// packages/utils/src/lib/reports/constants.ts
-var TERMINAL_WIDTH = 80;
-
-// packages/utils/src/lib/logging.ts
-var singletonUiInstance;
-function ui() {
-  if (singletonUiInstance === void 0) {
-    singletonUiInstance = cliui();
-  }
-  return {
-    ...singletonUiInstance,
-    row: (args) => {
-      logListItem(args);
-    }
-  };
-}
-var singletonisaacUi;
-function logListItem(args) {
-  if (singletonisaacUi === void 0) {
-    singletonisaacUi = isaacs_cliui({ width: TERMINAL_WIDTH });
-  }
-  singletonisaacUi.div(...args);
-  const content = singletonisaacUi.toString();
-  singletonisaacUi.rows = [];
-  singletonUiInstance?.logger.log(content);
-}
-
-// packages/utils/src/lib/file-system.ts
-async function readTextFile(path2) {
-  const buffer = await readFile(path2);
-  return buffer.toString();
-}
-async function readJsonFile(path2) {
-  const text = await readTextFile(path2);
-  return JSON.parse(text);
-}
-async function ensureDirectoryExists(baseDir) {
-  try {
-    await mkdir(baseDir, { recursive: true });
-    return;
-  } catch (error) {
-    ui().logger.info(error.message);
-    if (error.code !== "EEXIST") {
-      throw error;
-    }
-  }
-}
-var NoExportError = class extends Error {
-  constructor(filepath) {
-    super(`No default export found in ${filepath}`);
-  }
-};
-async function importEsmModule(options) {
-  const { mod } = await bundleRequire({
-    format: "esm",
-    ...options
-  });
-  if (!("default" in mod)) {
-    throw new NoExportError(options.filepath);
-  }
-  return mod.default;
-}
-
 // packages/utils/src/lib/reports/utils.ts
 var { image: image2, bold: boldMd } = md;
 
@@ -1156,8 +1157,8 @@ async function loadLighthouseAudit(value) {
   if (typeof value === "function") {
     return value;
   }
-  const path2 = typeof value === "string" ? value : value.path;
-  const module = await import(`lighthouse/core/audits/${path2}.js`);
+  const path = typeof value === "string" ? value : value.path;
+  const module = await import(`lighthouse/core/audits/${path}.js`);
   return module.default;
 }
 var LIGHTHOUSE_REPORT_NAME = "lighthouse-report.json";
@@ -1165,7 +1166,6 @@ var DEFAULT_CLI_FLAGS = {
   // default values extracted from
   // https://github.com/GoogleChrome/lighthouse/blob/7d80178c37a1b600ea8f092fc0b098029799a659/cli/cli-flags.js#L80
   verbose: false,
-  quiet: false,
   saveAssets: false,
   // needed to pass CI on linux and windows (locally it works without headless too)
   chromeFlags: ["--headless=shell"],
@@ -1174,10 +1174,11 @@ var DEFAULT_CLI_FLAGS = {
   view: false,
   channel: "cli",
   // custom overwrites in favour of the plugin
+  // hide logs by default
+  quiet: true,
   onlyAudits: [],
   skipAudits: [],
   onlyCategories: [],
-  budgets: [],
   output: ["json"],
   outputPath: join2(LIGHTHOUSE_OUTPUT_PATH, LIGHTHOUSE_REPORT_NAME)
 };
@@ -1188,7 +1189,6 @@ import log from "lighthouse-logger";
 import desktopConfig from "lighthouse/core/config/desktop-config.js";
 import experimentalConfig from "lighthouse/core/config/experimental-config.js";
 import perfConfig from "lighthouse/core/config/perf-config.js";
-import path from "node:path";
 function normalizeAuditOutputs(auditOutputs, flags = { skipAudits: [] }) {
   const toSkip = new Set(flags.skipAudits ?? []);
   return auditOutputs.filter(({ slug }) => {
@@ -1260,17 +1260,18 @@ function logUnsupportedDetails(lhrAudits, { displayCount = 3 } = {}) {
     );
   }
 }
-function setLogLevel({
+function determineAndSetLogLevel({
   verbose,
   quiet
 } = {}) {
+  let logLevel = "info";
   if (verbose) {
-    log.setLevel("verbose");
+    logLevel = "verbose";
   } else if (quiet) {
-    log.setLevel("silent");
-  } else {
-    log.setLevel("info");
+    logLevel = "silent";
   }
+  log.setLevel(logLevel);
+  return logLevel;
 }
 async function getConfig(options = {}) {
   const { configPath: filepath, preset } = options;
@@ -1296,14 +1297,6 @@ async function getConfig(options = {}) {
   }
   return void 0;
 }
-async function getBudgets(budgetPath) {
-  if (budgetPath) {
-    return await readJsonFile(
-      path.resolve(process.cwd(), budgetPath)
-    );
-  }
-  return [];
-}
 
 // packages/plugin-lighthouse/src/lib/runner/runner.ts
 function createRunnerFunction(urlUnderTest, flags = DEFAULT_CLI_FLAGS) {
@@ -1311,21 +1304,18 @@ function createRunnerFunction(urlUnderTest, flags = DEFAULT_CLI_FLAGS) {
     const {
       configPath,
       preset,
-      budgetPath,
-      budgets,
       outputPath,
       ...parsedFlags
     } = flags;
-    setLogLevel(parsedFlags);
+    const logLevel = determineAndSetLogLevel(parsedFlags);
     const config = await getConfig({ configPath, preset });
-    const budgetsJson = budgetPath ? await getBudgets(budgetPath) : budgets;
-    if (typeof outputPath === "string") {
+    if (outputPath) {
       await ensureDirectoryExists(dirname(outputPath));
     }
     const enrichedFlags = {
       ...parsedFlags,
-      outputPath,
-      budgets: budgetsJson
+      logLevel,
+      outputPath
     };
     const runnerResult = await runLighthouse(
       urlUnderTest,

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@code-pushup/lighthouse-plugin",
-  "version": "0.45.0",
+  "version": "0.46.0",
   "license": "MIT",
   "dependencies": {
-    "@code-pushup/models": "0.45.0",
-    "lighthouse": "^11.0.0",
-    "@code-pushup/utils": "0.45.0",
+    "@code-pushup/models": "0.46.0",
+    "lighthouse": "^12.0.0",
+    "@code-pushup/utils": "0.46.0",
     "lighthouse-logger": "2.0.1",
     "chalk": "^5.3.0"
   },

package/src/lib/normalize-flags.d.ts

@@ -3,16 +3,15 @@ import type { LighthouseOptions } from './types';
 export declare const DEFAULT_LIGHTHOUSE_OPTIONS: {
     onlyGroups: never[];
     verbose: false;
-    quiet: false;
     saveAssets: false;
     chromeFlags: string[];
     port: number;
     hostname: string;
     view: false;
     channel: string;
+    quiet: true;
     onlyAudits: never[];
     skipAudits: never[];
-    budgets: never[];
     output: "json"[];
     outputPath: string;
 };

package/src/lib/runner/constants.d.ts

@@ -5,17 +5,16 @@ export declare const LIGHTHOUSE_GROUPS: Group[];
 export declare const LIGHTHOUSE_REPORT_NAME = "lighthouse-report.json";
 export declare const DEFAULT_CLI_FLAGS: {
     verbose: false;
-    quiet: false;
     saveAssets: false;
     chromeFlags: string[];
     port: number;
     hostname: string;
     view: false;
     channel: string;
+    quiet: true;
     onlyAudits: never[];
     skipAudits: never[];
     onlyCategories: never[];
-    budgets: never[];
     output: "json"[];
     outputPath: string;
 };

package/src/lib/runner/types.d.ts

@@ -1,10 +1,8 @@
-import type { Budget } from 'lighthouse';
 import type { LighthouseOptions } from '../types';
 export type NormalizedFlags = {
     chromeFlags: string[];
     onlyAudits: string[];
     onlyCategories: string[];
     skipAudits: string[];
-    budgets: Budget[];
 };
 export type LighthouseCliFlags = Omit<LighthouseOptions, keyof NormalizedFlags> & NormalizedFlags;

package/src/lib/runner/utils.d.ts

@@ -1,4 +1,4 @@
-import type { Budget, Config } from 'lighthouse';
+import type { Config } from 'lighthouse';
 import { Result } from 'lighthouse/types/lhr/audit-result';
 import { AuditOutputs } from '@code-pushup/models';
 import type { LighthouseOptions } from '../types';
@@ -11,10 +11,10 @@ export declare const unsupportedDetailTypes: Set<string>;
 export declare function logUnsupportedDetails(lhrAudits: Result[], { displayCount }?: {
     displayCount?: number;
 }): void;
-export declare function setLogLevel({ verbose, quiet, }?: {
+export type LighthouseLogLevel = 'verbose' | 'error' | 'info' | 'silent' | 'warn' | undefined;
+export declare function determineAndSetLogLevel({ verbose, quiet, }?: {
     verbose?: boolean;
     quiet?: boolean;
-}): void;
+}): LighthouseLogLevel;
 export type ConfigOptions = Partial<Pick<LighthouseCliFlags, 'configPath' | 'preset'>>;
 export declare function getConfig(options?: ConfigOptions): Promise<Config | undefined>;
-export declare function getBudgets(budgetPath?: string): Promise<Budget[]>;