@code-pushup/eslint-plugin 0.4.5 → 0.5.1

package/bin.js

@@ -122,12 +122,14 @@ function scorableSchema(description, refSchema, duplicateCheckFn, duplicateMessa
   return z.object(
     {
       slug: slugSchema('Human-readable unique ID, e.g. "performance"'),
-      refs: z.array(refSchema).refine(
+      refs: z.array(refSchema).min(1).refine(
         (refs) => !duplicateCheckFn(refs),
         (refs) => ({
           message: duplicateMessageFn(refs)
         })
-      )
+      ).refine(hasWeightedRefsInCategories, () => ({
+        message: `In a category there has to be at least one ref with weight > 0`
+      }))
     },
     { description }
   );
@@ -136,6 +138,9 @@ var materialIconSchema = z.enum(
   MATERIAL_ICONS,
   { description: "Icon from VSCode Material Icons extension" }
 );
+function hasWeightedRefsInCategories(categoryRefs) {
+  return categoryRefs.reduce((acc, { weight }) => weight + acc, 0) !== 0;
+}
 
 // packages/models/src/lib/category-config.ts
 var categoryRefSchema = weightedRefSchema(
@@ -181,6 +186,23 @@ function getDuplicateRefsInCategoryMetrics(metrics) {
     metrics.map(({ slug, type, plugin }) => `${type} :: ${plugin} / ${slug}`)
   );
 }
+var categoriesSchema = z2.array(categoryConfigSchema, {
+  description: "Categorization of individual audits"
+}).min(1).refine(
+  (categoryCfg) => !getDuplicateSlugCategories(categoryCfg),
+  (categoryCfg) => ({
+    message: duplicateSlugCategoriesErrorMsg(categoryCfg)
+  })
+);
+function duplicateSlugCategoriesErrorMsg(categories) {
+  const duplicateStringSlugs = getDuplicateSlugCategories(categories);
+  return `In the categories, the following slugs are duplicated: ${errorItems(
+    duplicateStringSlugs
+  )}`;
+}
+function getDuplicateSlugCategories(categories) {
+  return hasDuplicateStrings(categories.map(({ slug }) => slug));
+}
 
 // packages/models/src/lib/core-config.ts
 import { z as z11 } from "zod";
@@ -189,10 +211,10 @@ import { z as z11 } from "zod";
 import { z as z3 } from "zod";
 var formatSchema = z3.enum(["json", "md"]);
 var persistConfigSchema = z3.object({
-  outputDir: filePathSchema("Artifacts folder"),
-  filename: fileNameSchema("Artifacts file name (without extension)").default(
-    "report"
-  ),
+  outputDir: filePathSchema("Artifacts folder").optional(),
+  filename: fileNameSchema(
+    "Artifacts file name (without extension)"
+  ).optional(),
   format: z3.array(formatSchema).default(["json"]).optional()
   // @TODO remove default or optional value and otherwise it will not set defaults.
 });
@@ -428,17 +450,10 @@ var unrefinedCoreConfigSchema = z11.object({
     description: "List of plugins to be used (official, community-provided, or custom)"
   }),
   /** portal configuration for persisting results */
-  persist: persistConfigSchema,
+  persist: persistConfigSchema.optional(),
   /** portal configuration for uploading results */
   upload: uploadConfigSchema.optional(),
-  categories: z11.array(categoryConfigSchema, {
-    description: "Categorization of individual audits"
-  }).refine(
-    (categoryCfg) => !getDuplicateSlugCategories(categoryCfg),
-    (categoryCfg) => ({
-      message: duplicateSlugCategoriesErrorMsg(categoryCfg)
-    })
-  )
+  categories: categoriesSchema
 });
 var coreConfigSchema = refineCoreConfig(unrefinedCoreConfigSchema);
 function refineCoreConfig(schema) {
@@ -489,15 +504,6 @@ function getMissingRefsForCategories(coreCfg) {
   }
   return missingRefs.length ? missingRefs : false;
 }
-function duplicateSlugCategoriesErrorMsg(categories) {
-  const duplicateStringSlugs = getDuplicateSlugCategories(categories);
-  return `In the categories, the following slugs are duplicated: ${errorItems(
-    duplicateStringSlugs
-  )}`;
-}
-function getDuplicateSlugCategories(categories) {
-  return hasDuplicateStrings(categories.map(({ slug }) => slug));
-}
 
 // packages/models/src/lib/report.ts
 import { z as z12 } from "zod";

package/index.js

@@ -5,7 +5,7 @@ import { fileURLToPath } from "url";
 
 // packages/plugin-eslint/package.json
 var name = "@code-pushup/eslint-plugin";
-var version = "0.4.5";
+var version = "0.5.1";
 
 // packages/plugin-eslint/src/lib/config.ts
 import { z } from "zod";
@@ -144,12 +144,14 @@ function scorableSchema(description, refSchema, duplicateCheckFn, duplicateMessa
   return z2.object(
     {
       slug: slugSchema('Human-readable unique ID, e.g. "performance"'),
-      refs: z2.array(refSchema).refine(
+      refs: z2.array(refSchema).min(1).refine(
         (refs) => !duplicateCheckFn(refs),
         (refs) => ({
           message: duplicateMessageFn(refs)
         })
-      )
+      ).refine(hasWeightedRefsInCategories, () => ({
+        message: `In a category there has to be at least one ref with weight > 0`
+      }))
     },
     { description }
   );
@@ -158,6 +160,9 @@ var materialIconSchema = z2.enum(
   MATERIAL_ICONS,
   { description: "Icon from VSCode Material Icons extension" }
 );
+function hasWeightedRefsInCategories(categoryRefs) {
+  return categoryRefs.reduce((acc, { weight }) => weight + acc, 0) !== 0;
+}
 
 // packages/models/src/lib/category-config.ts
 var categoryRefSchema = weightedRefSchema(
@@ -203,6 +208,23 @@ function getDuplicateRefsInCategoryMetrics(metrics) {
     metrics.map(({ slug, type, plugin }) => `${type} :: ${plugin} / ${slug}`)
   );
 }
+var categoriesSchema = z3.array(categoryConfigSchema, {
+  description: "Categorization of individual audits"
+}).min(1).refine(
+  (categoryCfg) => !getDuplicateSlugCategories(categoryCfg),
+  (categoryCfg) => ({
+    message: duplicateSlugCategoriesErrorMsg(categoryCfg)
+  })
+);
+function duplicateSlugCategoriesErrorMsg(categories) {
+  const duplicateStringSlugs = getDuplicateSlugCategories(categories);
+  return `In the categories, the following slugs are duplicated: ${errorItems(
+    duplicateStringSlugs
+  )}`;
+}
+function getDuplicateSlugCategories(categories) {
+  return hasDuplicateStrings(categories.map(({ slug }) => slug));
+}
 
 // packages/models/src/lib/core-config.ts
 import { z as z12 } from "zod";
@@ -211,10 +233,10 @@ import { z as z12 } from "zod";
 import { z as z4 } from "zod";
 var formatSchema = z4.enum(["json", "md"]);
 var persistConfigSchema = z4.object({
-  outputDir: filePathSchema("Artifacts folder"),
-  filename: fileNameSchema("Artifacts file name (without extension)").default(
-    "report"
-  ),
+  outputDir: filePathSchema("Artifacts folder").optional(),
+  filename: fileNameSchema(
+    "Artifacts file name (without extension)"
+  ).optional(),
   format: z4.array(formatSchema).default(["json"]).optional()
   // @TODO remove default or optional value and otherwise it will not set defaults.
 });
@@ -450,17 +472,10 @@ var unrefinedCoreConfigSchema = z12.object({
     description: "List of plugins to be used (official, community-provided, or custom)"
   }),
   /** portal configuration for persisting results */
-  persist: persistConfigSchema,
+  persist: persistConfigSchema.optional(),
   /** portal configuration for uploading results */
   upload: uploadConfigSchema.optional(),
-  categories: z12.array(categoryConfigSchema, {
-    description: "Categorization of individual audits"
-  }).refine(
-    (categoryCfg) => !getDuplicateSlugCategories(categoryCfg),
-    (categoryCfg) => ({
-      message: duplicateSlugCategoriesErrorMsg(categoryCfg)
-    })
-  )
+  categories: categoriesSchema
 });
 var coreConfigSchema = refineCoreConfig(unrefinedCoreConfigSchema);
 function refineCoreConfig(schema) {
@@ -511,15 +526,6 @@ function getMissingRefsForCategories(coreCfg) {
   }
   return missingRefs.length ? missingRefs : false;
 }
-function duplicateSlugCategoriesErrorMsg(categories) {
-  const duplicateStringSlugs = getDuplicateSlugCategories(categories);
-  return `In the categories, the following slugs are duplicated: ${errorItems(
-    duplicateStringSlugs
-  )}`;
-}
-function getDuplicateSlugCategories(categories) {
-  return hasDuplicateStrings(categories.map(({ slug }) => slug));
-}
 
 // packages/models/src/lib/report.ts
 import { z as z13 } from "zod";
@@ -760,7 +766,7 @@ function groupsFromRuleTypes(rules) {
     refs: auditSlugsMap[type]?.map(
       (slug) => ({ slug, weight: 1 })
     ) ?? []
-  }));
+  })).filter((group) => group.refs.length);
 }
 function groupsFromRuleCategories(rules) {
   const categoriesMap = rules.reduce(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@code-pushup/eslint-plugin",
-  "version": "0.4.5",
+  "version": "0.5.1",
   "dependencies": {
     "@code-pushup/utils": "*",
     "@code-pushup/models": "*",