@code-pushup/eslint-plugin 0.23.1 → 0.25.6

package/bin.js

@@ -1,5 +1,5 @@
 // packages/plugin-eslint/src/lib/runner/index.ts
-import { mkdir as mkdir2, writeFile } from "node:fs/promises";
+import { writeFile } from "node:fs/promises";
 import { dirname, join as join2 } from "node:path";
 
 // packages/models/src/lib/audit.ts
@@ -577,6 +577,17 @@ async function readJsonFile(path) {
   const text = await readTextFile(path);
   return JSON.parse(text);
 }
+async function ensureDirectoryExists(baseDir) {
+  try {
+    await mkdir(baseDir, { recursive: true });
+    return;
+  } catch (error) {
+    console.error(error.message);
+    if (error.code !== "EEXIST") {
+      throw error;
+    }
+  }
+}
 function pluginWorkDir(slug) {
   return join("node_modules", ".code-pushup", slug);
 }
@@ -591,6 +602,9 @@ function compareIssueSeverity(severity1, severity2) {
   return levels[severity1] - levels[severity2];
 }
 
+// packages/utils/src/lib/git.ts
+import { simpleGit } from "simple-git";
+
 // packages/utils/src/lib/transform.ts
 function toArray(val) {
   return Array.isArray(val) ? val : [val];
@@ -608,9 +622,6 @@ function distinct(array) {
   return [...new Set(array)];
 }
 
-// packages/utils/src/lib/git.ts
-import { simpleGit } from "simple-git";
-
 // packages/utils/src/lib/logging.ts
 import chalk2 from "chalk";
 
@@ -749,25 +760,20 @@ function convertSeverity(severity) {
 var WORKDIR = pluginWorkDir("eslint");
 var RUNNER_OUTPUT_PATH = join2(WORKDIR, "runner-output.json");
 var ESLINTRC_PATH = join2(process.cwd(), WORKDIR, ".eslintrc.json");
-var AUDIT_SLUGS_SEP = ",";
-async function executeRunner(argv = process.argv) {
-  const [slugs, eslintrc, ...patterns] = argv.slice(2);
-  if (!slugs) {
-    throw new Error("Invalid runner args - missing slugs argument");
-  }
-  if (!eslintrc) {
-    throw new Error("Invalid runner args - missing eslintrc argument");
-  }
-  if (patterns.length === 0) {
-    throw new Error("Invalid runner args - missing patterns argument");
-  }
+var PLUGIN_CONFIG_PATH = join2(
+  process.cwd(),
+  WORKDIR,
+  "plugin-config.json"
+);
+async function executeRunner() {
+  const { slugs, eslintrc, patterns } = await readJsonFile(PLUGIN_CONFIG_PATH);
   const lintResults = await lint({
     // if file created from inline object, provide inline to preserve relative links
     eslintrc: eslintrc === ESLINTRC_PATH ? await readJsonFile(eslintrc) : eslintrc,
     patterns
   });
   const failedAudits = lintResultsToAudits(lintResults);
-  const audits = slugs.split(AUDIT_SLUGS_SEP).map(
+  const audits = slugs.map(
     (slug) => failedAudits.find((audit) => audit.slug === slug) ?? {
       slug,
       score: 1,
@@ -776,9 +782,9 @@ async function executeRunner(argv = process.argv) {
       details: { issues: [] }
     }
   );
-  await mkdir2(dirname(RUNNER_OUTPUT_PATH), { recursive: true });
+  await ensureDirectoryExists(dirname(RUNNER_OUTPUT_PATH));
   await writeFile(RUNNER_OUTPUT_PATH, JSON.stringify(audits));
 }
 
 // packages/plugin-eslint/src/bin.ts
-await executeRunner().catch(console.error);
+await executeRunner();

package/index.js

@@ -1,11 +1,11 @@
 // packages/plugin-eslint/src/lib/eslint-plugin.ts
-import { mkdir as mkdir2, writeFile } from "node:fs/promises";
+import { mkdir as mkdir2, writeFile as writeFile2 } from "node:fs/promises";
 import { dirname as dirname2, join as join3 } from "node:path";
 import { fileURLToPath } from "node:url";
 
 // packages/plugin-eslint/package.json
 var name = "@code-pushup/eslint-plugin";
-var version = "0.23.1";
+var version = "0.25.6";
 
 // packages/plugin-eslint/src/lib/config.ts
 import { z } from "zod";
@@ -590,10 +590,24 @@ async function fileExists(path) {
     return false;
   }
 }
+async function ensureDirectoryExists(baseDir) {
+  try {
+    await mkdir(baseDir, { recursive: true });
+    return;
+  } catch (error) {
+    console.error(error.message);
+    if (error.code !== "EEXIST") {
+      throw error;
+    }
+  }
+}
 function pluginWorkDir(slug) {
   return join("node_modules", ".code-pushup", slug);
 }
 
+// packages/utils/src/lib/git.ts
+import { simpleGit } from "simple-git";
+
 // packages/utils/src/lib/transform.ts
 function toArray(val) {
   return Array.isArray(val) ? val : [val];
@@ -605,9 +619,6 @@ function distinct(array) {
   return [...new Set(array)];
 }
 
-// packages/utils/src/lib/git.ts
-import { simpleGit } from "simple-git";
-
 // packages/utils/src/lib/logging.ts
 import chalk2 from "chalk";
 
@@ -801,7 +812,7 @@ async function listAuditsAndGroups(eslint, patterns) {
 }
 
 // packages/plugin-eslint/src/lib/runner/index.ts
-import { platform } from "node:os";
+import { writeFile } from "node:fs/promises";
 import { dirname, join as join2 } from "node:path";
 
 // packages/plugin-eslint/src/lib/setup.ts
@@ -818,18 +829,22 @@ function setupESLint(eslintrc) {
 var WORKDIR = pluginWorkDir("eslint");
 var RUNNER_OUTPUT_PATH = join2(WORKDIR, "runner-output.json");
 var ESLINTRC_PATH = join2(process.cwd(), WORKDIR, ".eslintrc.json");
-var AUDIT_SLUGS_SEP = ",";
-function createRunnerConfig(scriptPath, audits, eslintrc, patterns) {
+var PLUGIN_CONFIG_PATH = join2(
+  process.cwd(),
+  WORKDIR,
+  "plugin-config.json"
+);
+async function createRunnerConfig(scriptPath, audits, eslintrc, patterns) {
+  const config = {
+    eslintrc,
+    slugs: audits.map((audit) => audit.slug),
+    patterns: toArray(patterns)
+  };
+  await ensureDirectoryExists(dirname(PLUGIN_CONFIG_PATH));
+  await writeFile(PLUGIN_CONFIG_PATH, JSON.stringify(config));
   return {
     command: "node",
-    args: [
-      scriptPath,
-      audits.map((audit) => audit.slug).join(AUDIT_SLUGS_SEP),
-      eslintrc,
-      ...toArray(patterns).map(
-        (pattern) => platform() === "win32" ? pattern : `'${pattern}'`
-      )
-    ],
+    args: [scriptPath],
     outputFile: RUNNER_OUTPUT_PATH
   };
 }
@@ -841,7 +856,7 @@ async function eslintPlugin(config) {
   const { audits, groups } = await listAuditsAndGroups(eslint, patterns);
   if (typeof eslintrc !== "string") {
     await mkdir2(dirname2(ESLINTRC_PATH), { recursive: true });
-    await writeFile(ESLINTRC_PATH, JSON.stringify(eslintrc));
+    await writeFile2(ESLINTRC_PATH, JSON.stringify(eslintrc));
   }
   const eslintrcPath = typeof eslintrc === "string" ? eslintrc : ESLINTRC_PATH;
   const runnerScriptPath = join3(
@@ -858,7 +873,7 @@ async function eslintPlugin(config) {
     version,
     audits,
     groups,
-    runner: createRunnerConfig(
+    runner: await createRunnerConfig(
       runnerScriptPath,
       audits,
       eslintrcPath,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@code-pushup/eslint-plugin",
-  "version": "0.23.1",
+  "version": "0.25.6",
   "license": "MIT",
   "dependencies": {
     "@code-pushup/utils": "*",

package/src/lib/config.d.ts

@@ -11,3 +11,8 @@ export declare const eslintPluginConfigSchema: z.ZodObject<{
     patterns: (string | string[]) & (string | string[] | undefined);
 }>;
 export type ESLintPluginConfig = z.infer<typeof eslintPluginConfigSchema>;
+export type ESLintPluginRunnerConfig = {
+    eslintrc: string;
+    slugs: string[];
+    patterns: string[];
+};

package/src/lib/runner/index.d.ts

@@ -2,5 +2,6 @@ import type { Audit, RunnerConfig } from '@code-pushup/models';
 export declare const WORKDIR: string;
 export declare const RUNNER_OUTPUT_PATH: string;
 export declare const ESLINTRC_PATH: string;
-export declare function executeRunner(argv?: string[]): Promise<void>;
-export declare function createRunnerConfig(scriptPath: string, audits: Audit[], eslintrc: string, patterns: string | string[]): RunnerConfig;
+export declare const PLUGIN_CONFIG_PATH: string;
+export declare function executeRunner(): Promise<void>;
+export declare function createRunnerConfig(scriptPath: string, audits: Audit[], eslintrc: string, patterns: string | string[]): Promise<RunnerConfig>;