@code-pushup/core 0.4.4 → 0.5.0

package/index.js

@@ -129,12 +129,14 @@ function scorableSchema(description, refSchema, duplicateCheckFn, duplicateMessa
   return z.object(
     {
       slug: slugSchema('Human-readable unique ID, e.g. "performance"'),
-      refs: z.array(refSchema).refine(
+      refs: z.array(refSchema).min(1).refine(
         (refs) => !duplicateCheckFn(refs),
         (refs) => ({
           message: duplicateMessageFn(refs)
         })
-      )
+      ).refine(hasWeightedRefsInCategories, () => ({
+        message: `In a category there has to be at least one ref with weight > 0`
+      }))
     },
     { description }
   );
@@ -143,6 +145,9 @@ var materialIconSchema = z.enum(
   MATERIAL_ICONS,
   { description: "Icon from VSCode Material Icons extension" }
 );
+function hasWeightedRefsInCategories(categoryRefs) {
+  return categoryRefs.reduce((acc, { weight }) => weight + acc, 0) !== 0;
+}
 
 // packages/models/src/lib/category-config.ts
 var categoryRefSchema = weightedRefSchema(
@@ -440,10 +445,10 @@ var unrefinedCoreConfigSchema = z11.object({
   upload: uploadConfigSchema.optional(),
   categories: z11.array(categoryConfigSchema, {
     description: "Categorization of individual audits"
-  }).refine(
-    (categoryCfg) => !getDuplicateSlugCategories(categoryCfg),
-    (categoryCfg) => ({
-      message: duplicateSlugCategoriesErrorMsg(categoryCfg)
+  }).min(1).refine(
+    (categories) => !getDuplicateSlugCategories(categories),
+    (categories) => ({
+      message: duplicateSlugCategoriesErrorMsg(categories)
     })
   )
 });
@@ -1391,6 +1396,11 @@ function calculateScore(refs, scoreFn) {
     },
     { numerator: 0, denominator: 0 }
   );
+  if (!numerator && !denominator) {
+    throw new Error(
+      "0 division for score. This can be caused by refs only weighted with 0 or empty refs"
+    );
+  }
   return numerator / denominator;
 }
 function scoreReport(report) {
@@ -1632,7 +1642,7 @@ function auditOutputsCorrelateWithPluginOutput(auditOutputs, pluginConfigAudits)
 
 // packages/core/package.json
 var name = "@code-pushup/core";
-var version = "0.4.4";
+var version = "0.5.0";
 
 // packages/core/src/lib/implementation/collect.ts
 async function collect(options) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@code-pushup/core",
-  "version": "0.4.4",
+  "version": "0.5.0",
   "dependencies": {
     "@code-pushup/models": "*",
     "@code-pushup/utils": "*",