@codacy/verity-cli 0.29.4-experimental.5fcba03 → 0.29.4-experimental.7126d67

package/bin/verity.js

@@ -10390,11 +10390,11 @@ var MAX_DELTA_BYTES = 194560;
 var MAX_FILES = 40;
 var MAX_FILE_BYTES = 51200;
 var DEBOUNCE_SECONDS = 30;
-var MAX_SPEC_FILES = 10;
-var MAX_SPEC_FILE_BYTES = 10240;
-var MAX_TOTAL_SPEC_BYTES = 30720;
+var MAX_SPEC_FILES = 6;
+var MAX_SPEC_FILE_BYTES = 512e3;
+var MAX_TOTAL_SPEC_BYTES = 512e3;
 var MAX_PLAN_FILES = 3;
-var MAX_PLAN_FILE_BYTES = 10240;
+var MAX_PLAN_FILE_BYTES = 512e3;
 var MAX_INTENT_CHARS = 2e3;
 var SNAPSHOT_DIR = `${VERITY_DIR}/.snapshot`;
 var BASELINE_DIR = `${VERITY_DIR}/.baseline`;
@@ -15060,8 +15060,10 @@ function recordVerdict(d, v) {
     if (summary) appendEvent(d, { k: "goal_delivered", summary });
   }
   const lines = /* @__PURE__ */ new Map();
+  const sent = new Set(v.sentPaths);
   for (const f of v.findings) {
     if (!f.file || typeof f.line !== "number" || !f.pattern_id) continue;
+    if (!sent.has(f.file)) continue;
     if (!lines.has(f.file)) {
       try {
         const abs = (0, import_node_path12.join)(root, f.file);
@@ -16717,7 +16719,7 @@ function formatRunEvidence(run, startedAt) {
   const md = run.modeDecision;
   if (md) {
     const how = md.forced ? "forced by --mode" : `predicted=${md.predicted ?? "none"} \u2192 ${md.resolved}`;
-    out += row("mode", `${md.resolved} \xB7 ${how} \xB7 authored=${md.authored ? "yes" : "no"} \xB7 investigated=${md.investigated ? "yes" : "no"}`);
+    out += row("mode", `${md.resolved} \xB7 ${how}` + (md.flip ? ` (flipped to plan: no delta at ${md.flip})` : "") + ` \xB7 authored=${md.authored ? "yes" : "no"} \xB7 investigated=${md.investigated ? "yes" : "no"}`);
   } else {
     out += row("mode", `? (this run stopped in ${run.phaseReached || "no phase"}, before the mode was decided)`);
   }
@@ -16765,6 +16767,30 @@ function formatRunEvidence(run, startedAt) {
       out += row("", `${cov.outsideRepo} authored path(s) refused as outside the repo`);
     }
   }
+  if (run.foldResult?.tools?.length) {
+    const shown = run.foldResult.tools.slice(0, 6).map((t) => {
+      const outcome = t.failed > 0 ? `${t.failed} failed` : t.last_status === 0 ? "ok" : "?";
+      const where = t.targets.length > 0 ? ` \u2192 ${t.targets.slice(0, 2).join(", ")}` : "";
+      return `${t.runs}\xD7 ${t.name} (${outcome})${where}`;
+    });
+    const more = run.foldResult.tools.length > 6 ? ` \u2026 +${run.foldResult.tools.length - 6} more` : "";
+    out += row("tools", shown.join(" \xB7 ") + more);
+    if (run.foldResult.coverage.toolNamesDropped > 0) {
+      out += row("", `\u26A0 ${run.foldResult.coverage.toolNamesDropped} tool name(s) refused by the cap`);
+    }
+  }
+  if (run.foldResult?.tasks?.length) {
+    const t = run.foldResult.tasks;
+    const done2 = t.filter((x) => x.status === "completed").length;
+    out += row("tasks", `${t.length} \xB7 ${done2} completed \xB7 ` + list(t.slice(0, 4).map((x) => `#${x.id} ${x.name} [${x.status}]`), 4));
+  }
+  if (run.specs?.length) {
+    const readThisSession = new Set(run.actionSummary?.files_read ?? []);
+    const labelled = run.specs.map(
+      (s) => `${s.path}${readThisSession.has(s.path) ? " (read)" : " (positional)"}`
+    );
+    out += row("specs", `${run.specs.length} \xB7 ${list(labelled, 5)}`);
+  }
   if (run.staticResults.findings.length > 0) {
     out += row("static", `${run.staticResults.findings.length} finding(s) from ${run.staticResults.summary.tools_run.join(", ") || "no tools"}`);
   }
@@ -17216,7 +17242,7 @@ function channelSilence(input) {
 // src/lib/cli-version.ts
 function cliVersion() {
   try {
-    return true ? "0.29.4-experimental.5fcba03" : "dev";
+    return true ? "0.29.4-experimental.7126d67" : "dev";
   } catch {
     return "dev";
   }
@@ -17567,18 +17593,26 @@ var SPEC_CANDIDATES = [
   "docs/API.md",
   "spec/ARCHITECTURE.md"
 ];
-function discoverSpecs() {
+var DOC_EXT = /\.(md|mdx|ya?ml|txt|rst|adoc)$/i;
+var UNCONSULTED_FILE_BYTES = 10240;
+var UNCONSULTED_TOTAL_BYTES = 30720;
+function discoverSpecs(consulted = []) {
   const result = [];
   const seen = /* @__PURE__ */ new Set();
   let totalBytes = 0;
-  const addSpec = (specPath) => {
+  const consultedDocs = new Set(
+    consulted.filter((p) => DOC_EXT.test(p) && !p.startsWith("/") && !p.includes(".."))
+  );
+  const addSpec = (specPath, relevant = false) => {
     if (result.length >= MAX_SPEC_FILES) return false;
-    if (totalBytes >= MAX_TOTAL_SPEC_BYTES) return false;
+    const totalCap = relevant ? MAX_TOTAL_SPEC_BYTES : UNCONSULTED_TOTAL_BYTES;
+    if (totalBytes >= totalCap) return false;
     if (seen.has(specPath)) return true;
     if (!(0, import_node_fs21.existsSync)(specPath)) return true;
     seen.add(specPath);
-    const remaining = MAX_TOTAL_SPEC_BYTES - totalBytes;
-    const readBytes = Math.min(MAX_SPEC_FILE_BYTES, remaining);
+    const remaining = totalCap - totalBytes;
+    const fileCap = relevant ? MAX_SPEC_FILE_BYTES : UNCONSULTED_FILE_BYTES;
+    const readBytes = Math.min(fileCap, remaining);
     try {
       const buf = Buffer.alloc(readBytes);
       const fd = (0, import_node_fs21.openSync)(specPath, "r");
@@ -17592,6 +17626,9 @@ function discoverSpecs() {
     }
     return true;
   };
+  for (const doc of consultedDocs) {
+    if (!addSpec(doc, true)) break;
+  }
   for (const candidate of SPEC_CANDIDATES) {
     if (!addSpec(candidate)) break;
   }
@@ -17662,7 +17699,7 @@ function discoverPlans() {
 async function intentInputs(run) {
   const { actionSummary, allForReview, assistantResponse, baseline, baselineSessionId } = run;
   const conversation = await readAndClearConversationBuffer(baselineSessionId);
-  const specs = discoverSpecs();
+  const specs = discoverSpecs(actionSummary?.files_read ?? []);
   const plans = discoverPlans();
   const agentAuthoredCodeThisTurn = !!(actionSummary && (actionSummary.files_edited.length > 0 || actionSummary.files_created.length > 0));
   const turnAuthoredCode = agentAuthoredCodeThisTurn || !!baseline && allForReview.some((f) => changedSinceBaseline(f, baseline));
@@ -18178,6 +18215,18 @@ function commandShape(cmd) {
   return out.join(" ").slice(0, COMMAND_HEAD_CHARS);
 }
 var COMMAND_HEAD_CHARS = 80;
+var MAX_TOOL_NAMES = 64;
+var MAX_TOOL_TARGETS = 3;
+var MAX_TASKS = 64;
+var TASK_NAME_CHARS = 120;
+function toolTarget(name, input) {
+  if (name === "Bash") return null;
+  for (const key of ["file_path", "notebook_path", "path", "filePath"]) {
+    const v = input[key];
+    if (typeof v === "string" && v) return v.slice(0, 120);
+  }
+  return null;
+}
 var rootCandidateCache = /* @__PURE__ */ new Map();
 function candidateRoots(repoRoot2) {
   const cached2 = rootCandidateCache.get(repoRoot2);
@@ -18208,15 +18257,20 @@ function toRepoRelative(path, repoRoot2) {
 }
 function isInsideRepo(path, repoRoot2) {
   const p = path.replace(/\\/g, "/");
-  if (!p.startsWith("/")) return true;
+  if (!isAbsolutePath(p)) return true;
   if (!repoRoot2) return true;
   return candidateRoots(repoRoot2).some((root) => p === root || p.startsWith(root + "/"));
 }
+function isAbsolutePath(p) {
+  return p.startsWith("/") || /^[A-Za-z]:\//.test(p);
+}
 function fold(transcriptPath, opts = {}) {
   const result = {
     authored: [],
     unobserved: [],
     commands: [],
+    tools: [],
+    tasks: [],
     unknownTypes: [],
     coverage: {
       recordCounts: {},
@@ -18224,16 +18278,23 @@ function fold(transcriptPath, opts = {}) {
       malformed: 0,
       subagentFiles: 0,
       outsideRepo: 0,
+      toolNamesDropped: 0,
       dispatched: 0,
       userMessages: 0,
       subagentSkipped: 0,
       compactions: 0,
       complete: false
-    }
+    },
+    planApproval: { approvals: 0, activeSinceLastPrompt: false }
   };
+  const flow = { seq: 0, lastPrompt: -1, lastApproval: -1, approvals: 0 };
   const byPath = /* @__PURE__ */ new Map();
   const commandStats = /* @__PURE__ */ new Map();
   const pendingByToolUse = /* @__PURE__ */ new Map();
+  const toolStats = /* @__PURE__ */ new Map();
+  const pendingToolName = /* @__PURE__ */ new Map();
+  const taskById = /* @__PURE__ */ new Map();
+  const pendingTaskName = /* @__PURE__ */ new Map();
   const unknown = /* @__PURE__ */ new Set();
   const ingest = (raw, owner) => {
     for (const line of raw.split("\n")) {
@@ -18252,8 +18313,12 @@ function fold(transcriptPath, opts = {}) {
       if (type === "system" && record.subtype === "compact_boundary") {
         result.coverage.compactions++;
       }
-      if (type === "user" && hasUserText(record)) result.coverage.userMessages++;
-      collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse, opts.repoRoot, result.coverage);
+      if (type === "user" && hasUserText(record)) {
+        result.coverage.userMessages++;
+        if (owner === "agent") flow.lastPrompt = flow.seq;
+      }
+      if (owner === "agent") flow.seq++;
+      collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse, toolStats, pendingToolName, taskById, pendingTaskName, opts.repoRoot, result.coverage, flow);
     }
   };
   try {
@@ -18311,12 +18376,24 @@ function fold(transcriptPath, opts = {}) {
   result.authored = [...byPath.values()].sort((a, b) => a.p.localeCompare(b.p));
   result.unknownTypes = [...unknown].sort();
   result.commands = [...commandStats.entries()].map(([cls, s]) => ({ class: cls, ...s })).sort((a, b) => a.class.localeCompare(b.class));
+  result.tools = [...toolStats.entries()].map(([name, s]) => ({
+    name,
+    runs: s.runs,
+    failed: s.failed,
+    last_status: s.last_status,
+    targets: [...s.targets].map((t) => toRepoRelative(t, opts.repoRoot)).sort()
+  })).sort((a, b) => b.runs - a.runs || a.name.localeCompare(b.name));
+  result.tasks = [...taskById.entries()].map(([id, t]) => ({ id, name: t.name, status: t.status })).sort((a, b) => (Number(a.id) || 0) - (Number(b.id) || 0));
   const authoredPaths = new Set(result.authored.map((a) => a.p));
   for (const raw of opts.changedFiles ?? []) {
     const p = toRepoRelative(raw, opts.repoRoot);
     if (!p || authoredPaths.has(p)) continue;
     result.unobserved.push({ p, cause: classifyUnobserved(raw) });
   }
+  result.planApproval = {
+    approvals: flow.approvals,
+    activeSinceLastPrompt: flow.lastApproval >= 0 && flow.lastApproval > flow.lastPrompt
+  };
   return result;
 }
 function classifyUnobserved(path) {
@@ -18329,7 +18406,7 @@ function classifyUnobserved(path) {
   if (/\.(png|jpg|jpeg|gif|pdf|zip|woff2?|ico|mp4)$/i.test(path)) return "binary";
   return "no_edit_record";
 }
-function collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse, repoRoot2, tally) {
+function collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse, toolStats, pendingToolName, taskById, pendingTaskName, repoRoot2, tally, flow) {
   const message = record.message;
   const content = message?.content ?? record.content;
   const blocks = Array.isArray(content) ? content : content && typeof content === "object" ? [content] : [];
@@ -18338,6 +18415,32 @@ function collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse
     if (blockType === "tool_use") {
       const name = String(block.name ?? "");
       const input = block.input ?? {};
+      if (name && toolStats.size < MAX_TOOL_NAMES) {
+        const prev = toolStats.get(name) ?? { runs: 0, failed: 0, last_status: null, targets: /* @__PURE__ */ new Set() };
+        prev.targets = prev.targets ?? /* @__PURE__ */ new Set();
+        if (prev.targets.size < MAX_TOOL_TARGETS) {
+          const target = toolTarget(name, input);
+          if (target) prev.targets.add(target);
+        }
+        toolStats.set(name, { runs: prev.runs + 1, failed: prev.failed, last_status: null, targets: prev.targets });
+        const toolId = typeof block.id === "string" ? block.id : null;
+        if (toolId) pendingToolName.set(toolId, name);
+      } else if (name && tally) {
+        tally.toolNamesDropped += 1;
+      }
+      if (name === "TaskCreate") {
+        const subject = typeof input.subject === "string" ? input.subject : "";
+        const taskId = typeof block.id === "string" ? block.id : null;
+        if (subject && taskId) pendingTaskName.set(taskId, subject.slice(0, TASK_NAME_CHARS));
+      }
+      if (name === "TaskUpdate") {
+        const id = typeof input.taskId === "string" ? input.taskId : "";
+        const status = typeof input.status === "string" ? input.status : "";
+        if (id && status) {
+          const entry = taskById.get(id);
+          taskById.set(id, { name: entry?.name ?? `#${id}`, status });
+        }
+      }
       if (EDIT_TOOLS.has(name)) {
         const rawPath = typeof input.notebook_path === "string" ? input.notebook_path : typeof input.file_path === "string" ? input.file_path : null;
         if (rawPath && !isInsideRepo(rawPath, repoRoot2)) {
@@ -18377,6 +18480,38 @@ function collectFromRecord(record, owner, byPath, commandStats, pendingByToolUse
     }
     if (blockType === "tool_result") {
       const id = typeof block.tool_use_id === "string" ? block.tool_use_id : null;
+      const taskName = id ? pendingTaskName.get(id) : void 0;
+      if (taskName) {
+        pendingTaskName.delete(id);
+        const body = typeof block.content === "string" ? block.content : "";
+        const created = /Task #(\d+)/.exec(body);
+        if (created && taskById.size < MAX_TASKS) {
+          taskById.set(created[1], { name: taskName, status: taskById.get(created[1])?.status ?? "created" });
+        }
+      }
+      const toolName = id ? pendingToolName.get(id) : void 0;
+      if (toolName === "ExitPlanMode" && flow && block.is_error !== true) {
+        const body = typeof block.content === "string" ? block.content : Array.isArray(block.content) ? block.content.map((c) => typeof c.text === "string" ? c.text : "").join(" ") : "";
+        if (/approved your plan/i.test(body)) {
+          flow.lastApproval = flow.seq;
+          flow.approvals += 1;
+        }
+      }
+      if (toolName) {
+        pendingToolName.delete(id);
+        const prevTool = toolStats.get(toolName);
+        if (prevTool) {
+          const failed = block.is_error === true;
+          toolStats.set(toolName, {
+            runs: prevTool.runs,
+            failed: prevTool.failed + (failed ? 1 : 0),
+            last_status: block.is_error === true ? 1 : block.is_error === false ? 0 : null,
+            // Carried, not rebuilt: the targets were collected on the `tool_use`
+            // side and dropping them here would empty the ledger on every result.
+            targets: prevTool.targets
+          });
+        }
+      }
       const cls = id ? pendingByToolUse.get(id) : void 0;
       if (!cls) continue;
       pendingByToolUse.delete(id);
@@ -18419,8 +18554,13 @@ function checkConservation(changedFiles, result, repoRoot2) {
 // src/commands/analyze/phases/06-evidence.ts
 async function evidence(run) {
   const { opts } = run;
-  const { actionSummary, allForReview, analyzable, assistantResponse, authorshipIsObservable, baseline, baselineSessionId, hasRecentCommitFiles, reviewable, securityFiles, sessionAuthoredCode, transcriptPath } = run;
+  const { actionSummary, allForReview, analyzable, assistantResponse, authorshipIsObservable, baseline, baselineSessionId, hasRecentCommitFiles, reviewable, securityFiles, sessionAuthoredCode, transcriptPath, turnAuthoredCode } = run;
   let { analysisMode, earlyFold } = run;
+  const recordFlip = (stage) => {
+    if (run.modeDecision) run.modeDecision = { ...run.modeDecision, resolved: "plan", flip: stage };
+    logEvent("mode_flipped", { stage, to: "plan" });
+  };
+  const planWorthy = !!assistantResponse && !turnAuthoredCode;
   let staticResults = {
     tool: "@codacy/analysis-cli",
     findings: [],
@@ -18440,8 +18580,9 @@ async function evidence(run) {
     const debounceSeconds = parseInt(opts.debounce, 10);
     const debounceSkip = checkDebounce(debounceSeconds, baselineSessionId);
     if (debounceSkip) {
-      if (assistantResponse) {
+      if (planWorthy) {
         analysisMode = "plan";
+        recordFlip("debounce");
       } else {
         await passAndExit(run, debounceSkip, "debounce");
       }
@@ -18450,8 +18591,9 @@ async function evidence(run) {
       const allCheckable = Array.from(/* @__PURE__ */ new Set([...analyzable, ...reviewable, ...securityFiles]));
       const mtimeSkip = checkMtime(allCheckable, hasRecentCommitFiles, baselineSessionId);
       if (mtimeSkip) {
-        if (assistantResponse) {
+        if (planWorthy) {
           analysisMode = "plan";
+          recordFlip("mtime");
         } else {
           await passAndExit(run, mtimeSkip, "no-delta-since-last-review");
         }
@@ -18462,8 +18604,9 @@ async function evidence(run) {
       const allCheckable = Array.from(/* @__PURE__ */ new Set([...analyzable, ...reviewable, ...securityFiles]));
       const hashResult = checkContentHash(allCheckable, baselineSessionId);
       if (hashResult.skip) {
-        if (assistantResponse) {
+        if (planWorthy) {
           analysisMode = "plan";
+          recordFlip("content-hash");
         } else {
           await passAndExit(run, hashResult.skip, "no-delta-since-last-review");
         }
@@ -18525,8 +18668,9 @@ async function evidence(run) {
           maxTotalBytes: parseInt(opts.maxTotalSize, 10)
         });
         if (codeDelta.files.length === 0 && staticResults.findings.length === 0) {
-          if (assistantResponse) {
+          if (planWorthy) {
             analysisMode = "plan";
+            recordFlip("empty-after-scoping");
           } else {
             await passAndExit(
               run,
@@ -19370,6 +19514,8 @@ async function buildRequest(run) {
         authored_since_verdict: memorySession ? foldDossier(memorySession.d).authored_all.filter((a) => a.hash_now !== a.hash_at_last_verdict).map((a) => a.path) : [],
         unobserved: foldResult?.unobserved ?? [],
         commands: foldResult?.commands ?? [],
+        tools: foldResult?.tools ?? [],
+        tasks: foldResult?.tasks ?? [],
         unknown_types: foldResult?.unknownTypes ?? [],
         coverage: foldResult?.coverage ?? { recordCounts: {}, totalRecords: 0, malformed: 0, subagentFiles: 0, subagentSkipped: 0, complete: false },
         // INV-19, computed client-side and sent so a conservation failure is
@@ -19480,6 +19626,10 @@ async function buildRequest(run) {
       intentContext.user_prompt = w4Task.goal;
       logEvent("w4_issue_anchor", { issue: w4Task.number, via: w4Task.via });
     }
+    if (foldResult?.planApproval?.activeSinceLastPrompt && intentContext.user_prompt) {
+      intentContext.plan_approved = true;
+      logEvent("plan_approval_carried", { approvals: foldResult.planApproval.approvals });
+    }
     if (assistantResponse) {
       const cap = analysisMode === "plan" ? MAX_ASSISTANT_RESPONSE_CHARS_PLAN : MAX_ASSISTANT_RESPONSE_CHARS_DEFAULT;
       intentContext.assistant_response = assistantResponse.length > cap ? assistantResponse.slice(0, cap) : assistantResponse;
@@ -19743,6 +19893,11 @@ async function reconcile(run) {
         decision,
         branch: getCurrentBranch(),
         watermarkSha: watermarkIsPartial ? null : watermarkHash,
+        // The byte witness — the same "only honest definition of reviewed" the
+        // coverage column uses. A finding on a path outside this set records no
+        // statement (plan-mode prose anchored to unsent files must not become
+        // "STILL OPEN … the tree is not clean").
+        sentPaths,
         findings: response.findings?.map((f) => ({
           file: f.file,
           line: f.line,
@@ -21996,8 +22151,8 @@ function registerTelemetryCommands(program2) {
 }
 
 // src/cli.ts
-program.name("verity").description("CLI for Verity quality gate service").version("0.29.4-experimental.5fcba03").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async (_thisCommand, actionCommand) => {
-  installStderrLog(actionCommand.name(), process.argv.slice(2), "0.29.4-experimental.5fcba03");
+program.name("verity").description("CLI for Verity quality gate service").version("0.29.4-experimental.7126d67").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async (_thisCommand, actionCommand) => {
+  installStderrLog(actionCommand.name(), process.argv.slice(2), "0.29.4-experimental.7126d67");
   setUserNamedServiceUrl(program.opts().serviceUrl);
   try {
     await foldLegacyLocalCredential();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codacy/verity-cli",
-  "version": "0.29.4-experimental.5fcba03",
+  "version": "0.29.4-experimental.7126d67",
   "description": "CLI for Verity quality gate service",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://verity.md",