@codacy/verity-cli 0.28.1-experimental.99781f8 → 0.28.1-experimental.a72d2d9

package/bin/verity.js

@@ -13591,6 +13591,70 @@ var import_node_fs10 = require("node:fs");
 var import_node_crypto5 = require("node:crypto");
 var import_node_path11 = require("node:path");
 
+// src/lib/skip-detection.ts
+function isBareAckPrompt(prompt) {
+  if (typeof prompt !== "string") return false;
+  const trimmed = prompt.trim();
+  if (trimmed.length === 0) return false;
+  if (trimmed.length > 20) return false;
+  const bareAckPattern = /^(\d{1,2}|y|n|yes|no|yep|nope|ok(ay)?|sure|skip|cancel|stop|done|noted|got\s+it|sounds\s+good|thanks|thank\s+you|thx)[.!?]*$/i;
+  return bareAckPattern.test(trimmed);
+}
+function isContinuationPrompt(prompt) {
+  if (typeof prompt !== "string") return false;
+  const trimmed = prompt.trim();
+  if (trimmed.length === 0) return false;
+  if (trimmed.length > 24) return false;
+  const continuation = /^(let['’]?s\s+(go|do\s+it|start|continue)|go|go\s+ahead|go\s+on|proceed|continue|carry\s+on|keep\s+going|do\s+it|make\s+it\s+so|next|start|begin|ship\s+it|yes\s+please|please\s+continue|perfect|great|nice|excellent|agreed)[.!]*$/i;
+  return continuation.test(trimmed) || isBareAckPrompt(trimmed);
+}
+function resolveGoalPrompt(prompts) {
+  if (prompts.length === 0) return null;
+  const latest = prompts[prompts.length - 1];
+  if (!isContinuationPrompt(latest.prompt)) return { entry: latest, turnsBack: 0 };
+  for (let i = prompts.length - 2; i >= 0; i--) {
+    if (!isContinuationPrompt(prompts[i].prompt)) {
+      return { entry: prompts[i], turnsBack: prompts.length - 1 - i };
+    }
+  }
+  return { entry: latest, turnsBack: 0 };
+}
+function isReflectionQuestion(response) {
+  if (!response || typeof response !== "string") return false;
+  const markers = [
+    /reflection\s+for\s+future\s+agents/i,
+    /what(?:'s|\s+is)\s+one\s+thing\s+you\s+learned/i,
+    /say\s+['"]?skip['"]?\s+to\s+skip/i,
+    /quick\s+reflection\s+question/i,
+    // Post-flip (VRT-21): the agent drafts the reflection itself and, when
+    // interactive, asks the user to confirm/correct before recording. That
+    // turn authors no code either, so it's still a reflection turn.
+    /reflection\s+draft/i,
+    /confirm,?\s+correct,?\s+or\s+add/i
+  ];
+  return markers.some((m) => m.test(response));
+}
+function isMetaTaskLabel(label2) {
+  if (label2 === null || label2 === void 0) return false;
+  if (typeof label2 !== "string") return false;
+  const trimmed = label2.trim();
+  if (trimmed.length === 0) return true;
+  const metaPatterns = [
+    /^verity\s+[\w-]+\s+response$/i,
+    // "Verity reflect response"
+    /^simple user response$/i,
+    /^verity\s+command$/i,
+    // "Verity command"
+    /^user\s+(question|reply|response|ack)$/i
+  ];
+  return metaPatterns.some((p) => p.test(trimmed));
+}
+function shouldSkipForBareAck(input) {
+  if (!isBareAckPrompt(input.prompt)) return false;
+  if (input.turnAuthoredCode) return false;
+  return input.canSeeTurnAuthorship;
+}
+
 // src/lib/dossier.ts
 var import_node_fs9 = require("node:fs");
 var import_node_crypto4 = require("node:crypto");
@@ -14695,7 +14759,19 @@ function sessionDossier(token, sessionId) {
   const d = openDossier(identity);
   return d ? { d, identity } : null;
 }
+function hasActiveGoal(d) {
+  try {
+    if (!(0, import_node_fs10.existsSync)(d.eventsPath)) return false;
+    return (0, import_node_fs10.readFileSync)(d.eventsPath, "utf8").includes('"k":"goal"');
+  } catch {
+    return false;
+  }
+}
 function recordGoal(d, prompt, source = "prompt") {
+  if (source === "prompt" && isContinuationPrompt(prompt) && hasActiveGoal(d)) {
+    appendEvent(d, { k: "goal_continue", text: prompt.slice(0, 64) });
+    return;
+  }
   const text = prompt.slice(0, MAX_GOAL_CHARS);
   appendEvent(d, {
     k: "goal",
@@ -16625,7 +16701,7 @@ function resolveTaskContext(opts) {
 // src/lib/cli-version.ts
 function cliVersion() {
   try {
-    return true ? "0.28.1-experimental.99781f8" : "dev";
+    return true ? "0.28.1-experimental.a72d2d9" : "dev";
   } catch {
     return "dev";
   }
@@ -17222,6 +17298,33 @@ function describeCoverage(coverage, maxPaths = 5) {
 ${lines.join("\n")}
 Treat those files as UNCHECKED, not as approved.`;
 }
+function openBlockingElsewhere(statements, reviewedNow, lineShaAt) {
+  const reviewed = new Set(reviewedNow);
+  const out = [];
+  const seen = /* @__PURE__ */ new Set();
+  for (const s of statements) {
+    if (s.outcome !== "open") continue;
+    if (s.register !== "BLOCK") continue;
+    if (s.carried) continue;
+    if (reviewed.has(s.file)) continue;
+    if (!s.line_sha) continue;
+    if (lineShaAt(s.file, s.line) !== s.line_sha) continue;
+    const key = `${s.file}::${s.pattern_id}`;
+    if (seen.has(key)) continue;
+    seen.add(key);
+    out.push({ file: s.file, line: s.line, pattern_id: s.pattern_id });
+  }
+  return out;
+}
+function describeOpenElsewhere(open) {
+  if (open.length === 0) return null;
+  const lines = open.slice(0, 5).map((o) => `  ${o.file}:${o.line} [${o.pattern_id}]`);
+  const more = open.length > 5 ? `
+  (+${open.length - 5} more)` : "";
+  return `STILL OPEN ELSEWHERE. ${open.length} blocking finding(s) Verity raised earlier are still present in files this run did not review:
+${lines.join("\n")}${more}
+This verdict covers the current change only. The tree is not clean.`;
+}
 
 // src/lib/channel.ts
 var MAX_AGENT_CONTEXT_CHARS = 1500;
@@ -17316,8 +17419,10 @@ var NC2 = "\x1B[0m";
 function emitVerdict(input) {
   const exit = input.exit ?? ((code) => process.exit(code));
   const { coverage, unaccounted } = reconcileCoverage(input.changed, input.coverage);
-  const verdict = resolveVerdict(input.proposed, coverage);
-  const note = describeCoverage(coverage);
+  let verdict = resolveVerdict(input.proposed, coverage);
+  const openElsewhere = input.openElsewhere ?? [];
+  if (verdict === "PASS" && openElsewhere.length > 0) verdict = "WARN";
+  const note = [describeCoverage(coverage), describeOpenElsewhere(openElsewhere)].filter(Boolean).join("\n\n") || null;
   if (unaccounted.length > 0) {
     process.stderr.write(
       `${YELLOW2}Verity: ${unaccounted.length} changed file(s) could not be attributed to any review stage \u2014 counted as unreviewed.${NC2}
@@ -17520,46 +17625,6 @@ function shouldWarmRetryAnalyze(result) {
   return false;
 }
 
-// src/lib/skip-detection.ts
-function isBareAckPrompt(prompt) {
-  if (typeof prompt !== "string") return false;
-  const trimmed = prompt.trim();
-  if (trimmed.length === 0) return false;
-  if (trimmed.length > 20) return false;
-  const bareAckPattern = /^(\d{1,2}|y|n|yes|no|yep|nope|ok(ay)?|sure|skip|cancel|stop|done|noted|got\s+it|sounds\s+good|thanks|thank\s+you|thx)[.!?]*$/i;
-  return bareAckPattern.test(trimmed);
-}
-function isReflectionQuestion(response) {
-  if (!response || typeof response !== "string") return false;
-  const markers = [
-    /reflection\s+for\s+future\s+agents/i,
-    /what(?:'s|\s+is)\s+one\s+thing\s+you\s+learned/i,
-    /say\s+['"]?skip['"]?\s+to\s+skip/i,
-    /quick\s+reflection\s+question/i,
-    // Post-flip (VRT-21): the agent drafts the reflection itself and, when
-    // interactive, asks the user to confirm/correct before recording. That
-    // turn authors no code either, so it's still a reflection turn.
-    /reflection\s+draft/i,
-    /confirm,?\s+correct,?\s+or\s+add/i
-  ];
-  return markers.some((m) => m.test(response));
-}
-function isMetaTaskLabel(label2) {
-  if (label2 === null || label2 === void 0) return false;
-  if (typeof label2 !== "string") return false;
-  const trimmed = label2.trim();
-  if (trimmed.length === 0) return true;
-  const metaPatterns = [
-    /^verity\s+[\w-]+\s+response$/i,
-    // "Verity reflect response"
-    /^simple user response$/i,
-    /^verity\s+command$/i,
-    // "Verity command"
-    /^user\s+(question|reply|response|ack)$/i
-  ];
-  return metaPatterns.some((p) => p.test(trimmed));
-}
-
 // src/lib/transcript.ts
 var import_node_fs22 = require("node:fs");
 var MAX_READ_BYTES = 256 * 1024;
@@ -18321,10 +18386,12 @@ async function runAnalyze(opts, globals) {
   if (/^\s*\/verity-/i.test(latestPrompt)) {
     await passAndExit("Verity command \u2014 skipping analysis", "verity-command");
   }
-  if (isBareAckPrompt(latestPrompt)) {
+  const agentAuthoredCodeThisTurn = !!(actionSummary && (actionSummary.files_edited.length > 0 || actionSummary.files_created.length > 0));
+  const turnAuthoredCode = agentAuthoredCodeThisTurn || !!baseline && allForReview.some((f) => changedSinceBaseline(f, baseline));
+  const canSeeTurnAuthorship = !!actionSummary || !!baseline;
+  if (shouldSkipForBareAck({ prompt: latestPrompt, turnAuthoredCode, canSeeTurnAuthorship })) {
     await passAndExit("Bare acknowledgment \u2014 skipping analysis", "bare-acknowledgment");
   }
-  const agentAuthoredCodeThisTurn = !!(actionSummary && (actionSummary.files_edited.length > 0 || actionSummary.files_created.length > 0));
   if (isReflectionQuestion(assistantResponse) && !agentAuthoredCodeThisTurn) {
     await passAndExit("Reflection-prompt turn \u2014 skipping analysis", "reflection-prompt");
   }
@@ -18767,7 +18834,20 @@ async function runAnalyze(opts, globals) {
     const intentContext = {};
     if (conversation && conversation.prompts.length > 0) {
       const latest = conversation.prompts[conversation.prompts.length - 1];
-      intentContext.user_prompt = latest.prompt;
+      const goalPrompt = resolveGoalPrompt(conversation.prompts) ?? { entry: latest, turnsBack: 0 };
+      intentContext.user_prompt = goalPrompt.entry.prompt;
+      if (isContinuationPrompt(intentContext.user_prompt)) {
+        const carried = memory?.projection.goal?.text;
+        if (carried && !isContinuationPrompt(carried)) {
+          intentContext.continuation_prompt = latest.prompt;
+          intentContext.user_prompt = carried;
+          logEvent("goal_from_dossier", { chars: carried.length });
+        }
+      }
+      if (goalPrompt.turnsBack > 0) {
+        intentContext.continuation_prompt = latest.prompt;
+        logEvent("goal_walked_back", { turns_back: goalPrompt.turnsBack });
+      }
       intentContext.session_id = latest.session_id || void 0;
       intentContext.prompt_captured_at = latest.captured_at || void 0;
       if (conversation.prompts.length > 1) {
@@ -18859,6 +18939,22 @@ async function runAnalyze(opts, globals) {
   const response = result.data;
   const decision = response.gate_decision ?? "(unrecognised)";
   const sentPaths = codeDelta.files.map((f) => f.path);
+  let openElsewhere = [];
+  if (memorySession) {
+    try {
+      const st = foldDossier(memorySession.d);
+      openElsewhere = openBlockingElsewhere(st.statements, sentPaths, (file, line) => {
+        try {
+          const src = (0, import_node_fs24.readFileSync)((0, import_node_path20.join)(repoRoot(), file), "utf8").split("\n");
+          const at = src[line - 1];
+          return at === void 0 ? null : lineSha(at);
+        } catch {
+          return null;
+        }
+      });
+    } catch {
+    }
+  }
   const reviewCoverage = {
     reviewed: sentPaths,
     // Declared drops from the stages that DO report themselves today. The other
@@ -19163,7 +19259,8 @@ ${YELLOW}${grantNudge.trim()}${NC}
         // so what the cut removes is the repeated commentary, never the defect.
         agentContext: silenced ? null : agentContextFor(response, intentRepeatCount),
         // The coverage note is silenced with it — half a channel is still a channel.
-        silenced: !!silenced
+        silenced: !!silenced,
+        openElsewhere
       });
       break;
     }
@@ -19183,7 +19280,8 @@ ${YELLOW}${grantNudge.trim()}${NC}
         userSummary,
         agentContext: silenced ? null : agentContextFor(response, intentRepeatCount),
         // The coverage note is silenced with it — half a channel is still a channel.
-        silenced: !!silenced
+        silenced: !!silenced,
+        openElsewhere
       });
       break;
     }
@@ -19202,7 +19300,8 @@ ${YELLOW}${grantNudge.trim()}${NC}
         userSummary,
         agentContext: silenced ? null : agentContextFor(response, intentRepeatCount),
         // The coverage note is silenced with it — half a channel is still a channel.
-        silenced: !!silenced
+        silenced: !!silenced,
+        openElsewhere
       });
       break;
     }
@@ -19316,8 +19415,8 @@ async function runReview(opts, globals) {
     for (const p of specPaths) {
       if (!(0, import_node_fs26.existsSync)(p)) continue;
       try {
-        const { readFileSync: readFileSync15 } = await import("node:fs");
-        const content = readFileSync15(p, "utf-8");
+        const { readFileSync: readFileSync16 } = await import("node:fs");
+        const content = readFileSync16(p, "utf-8");
         specs.push({ path: p, content: content.slice(0, 10240) });
       } catch {
       }
@@ -21003,7 +21102,7 @@ function registerTelemetryCommands(program2) {
 }
 
 // src/cli.ts
-program.name("verity").description("CLI for Verity quality gate service").version("0.28.1-experimental.99781f8").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async () => {
+program.name("verity").description("CLI for Verity quality gate service").version("0.28.1-experimental.a72d2d9").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async () => {
   try {
     await foldLegacyLocalCredential();
   } catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codacy/verity-cli",
-  "version": "0.28.1-experimental.99781f8",
+  "version": "0.28.1-experimental.a72d2d9",
   "description": "CLI for Verity quality gate service",
   "homepage": "https://verity.md",
   "bugs": {