@codacy/verity-cli 0.28.1-experimental.39013ce → 0.28.1-experimental.4410c26

package/bin/verity.js

@@ -10386,10 +10386,9 @@ function projectPath(relativePath) {
   return (0, import_node_path.join)(repoRoot(), relativePath);
 }
 var MAX_DELTA_BYTES = 194560;
-var MAX_FILES = 20;
+var MAX_FILES = 40;
 var MAX_FILE_BYTES = 51200;
 var DEBOUNCE_SECONDS = 30;
-var MAX_ITERATIONS = 2;
 var MAX_SPEC_FILES = 10;
 var MAX_SPEC_FILE_BYTES = 10240;
 var MAX_TOTAL_SPEC_BYTES = 30720;
@@ -15543,6 +15542,34 @@ ${addedLines}`,
   }
   return { diffs, has_baseline: true };
 }
+function absorbIntoBaseline(paths, sessionId) {
+  const baseline = readBaseline(sessionId);
+  if (!baseline || paths.length === 0) return 0;
+  const dir = sessionDir(sessionKey(baseline.session_id));
+  let adopted = 0;
+  const dirty = new Set(baseline.dirty_paths);
+  for (const p of paths) {
+    try {
+      const content = safeReadForMirror(projectPath(p));
+      if (content === null) continue;
+      const dest = mirrorPath(dir, p);
+      (0, import_node_fs13.mkdirSync)((0, import_node_path14.dirname)(dest), { recursive: true });
+      (0, import_node_fs13.writeFileSync)(dest, content);
+      dirty.add(p);
+      adopted++;
+    } catch {
+    }
+  }
+  if (adopted === 0) return 0;
+  try {
+    const updated = { ...baseline, dirty_paths: [...dirty] };
+    (0, import_node_fs13.writeFileSync)(manifestPath(dir), JSON.stringify(updated));
+    preImageCache.delete(baseline);
+  } catch {
+    return 0;
+  }
+  return adopted;
+}
 function changedSinceBaseline(repoRelPath, baseline) {
   const pre = preImage(repoRelPath, baseline);
   let current;
@@ -16419,40 +16446,40 @@ function narrowToRecent(files, sessionId) {
   });
   return recent.length > 0 ? recent : files;
 }
-function readIteration(currentCommit, _contentHash) {
-  if (!(0, import_node_fs15.existsSync)(ITERATION_FILE)) return 1;
+function readIterationState(currentCommit) {
+  if (!(0, import_node_fs15.existsSync)(ITERATION_FILE)) return { iteration: 1, fingerprint: null };
   try {
     const stored = (0, import_node_fs15.readFileSync)(ITERATION_FILE, "utf-8").trim();
     const parts = stored.split(":");
     const iter = parseInt(parts[0], 10);
     const storedCommit = parts[1] ?? "";
     const storedTimestamp = parseInt(parts[2] ?? "0", 10);
-    if (isNaN(iter)) return 1;
-    if (storedCommit !== currentCommit) return 1;
+    const fingerprint = parts.slice(3).join(":") || null;
+    if (isNaN(iter)) return { iteration: 1, fingerprint: null };
+    if (storedCommit !== currentCommit) return { iteration: 1, fingerprint: null };
     if (storedTimestamp > 0) {
       const elapsed = Math.floor(Date.now() / 1e3) - storedTimestamp;
-      if (elapsed > 600) return 1;
+      if (elapsed > 600) return { iteration: 1, fingerprint: null };
     }
-    return iter;
+    return { iteration: iter, fingerprint };
   } catch {
-    return 1;
+    return { iteration: 1, fingerprint: null };
   }
 }
-function checkMaxIterations(currentCommit, maxIterations = MAX_ITERATIONS, contentHash) {
-  const iteration = readIteration(currentCommit, contentHash);
-  if (iteration > maxIterations) {
-    writeIteration(1, currentCommit, contentHash);
-    return {
-      skip: `Max Verity iterations (${maxIterations}) reached \u2014 accepting to prevent infinite loop. Human review required before deploying.`,
-      iteration
-    };
-  }
-  return { skip: null, iteration };
+function findingsFingerprint(findings) {
+  const keys = findings.map((f) => `${String(f.pattern_id ?? "?")}|${String(f.file ?? "?")}`).filter((k) => k !== "?|?");
+  return [...new Set(keys)].sort().join(",");
+}
+function isSameProblem(previous, current) {
+  if (!previous || !current) return false;
+  const prev = new Set(previous.split(","));
+  return current.split(",").some((k) => prev.has(k));
 }
-function writeIteration(iteration, commit, _contentHash) {
+function writeIteration(iteration, commit, _contentHash, fingerprint) {
   (0, import_node_fs15.mkdirSync)(VERITY_DIR, { recursive: true });
   const ts = Math.floor(Date.now() / 1e3);
-  (0, import_node_fs15.writeFileSync)(ITERATION_FILE, `${iteration}:${commit}:${ts}`);
+  const fp = fingerprint ? `:${fingerprint}` : "";
+  (0, import_node_fs15.writeFileSync)(ITERATION_FILE, `${iteration}:${commit}:${ts}${fp}`);
 }
 
 // src/lib/static-analysis.ts
@@ -16701,7 +16728,7 @@ function resolveTaskContext(opts) {
 // src/lib/cli-version.ts
 function cliVersion() {
   try {
-    return true ? "0.28.1-experimental.39013ce" : "dev";
+    return true ? "0.28.1-experimental.4410c26" : "dev";
   } catch {
     return "dev";
   }
@@ -17375,6 +17402,7 @@ function buildAgentContext(input) {
   }
   for (const p of input.pendingItems ?? []) {
     if (lines.length >= MAX_AGENT_ITEMS) break;
+    if (p.pattern_id === "intent-misalignment") continue;
     const text = p.description ?? p.title ?? p.reason;
     if (!text) continue;
     lines.push(renderItem("", text, p.pattern_id, p.file, p.line));
@@ -17638,9 +17666,11 @@ var MAX_SUMMARY_BYTES = 4096;
 var HOME = process.env.HOME ?? "";
 async function extractActionSummary(transcriptPath) {
   try {
-    const lines = readTurnLines(transcriptPath);
-    if (!lines || lines.length === 0) return null;
-    return buildSummary(lines);
+    const read = readTurnLines(transcriptPath);
+    if (!read || read.lines.length === 0) return null;
+    const summary = buildSummary(read.lines);
+    if (summary) summary.transcript_windowed = read.window;
+    return summary;
   } catch {
     return null;
   }
@@ -17654,9 +17684,11 @@ function readTurnLines(transcriptPath) {
   }
   if (size === 0) return null;
   let raw;
+  let windowed = false;
   if (size <= SMALL_FILE_BYTES) {
     raw = (0, import_node_fs22.readFileSync)(transcriptPath, "utf-8");
   } else {
+    windowed = true;
     const buf = Buffer.alloc(Math.min(MAX_READ_BYTES, size));
     const fd = require("node:fs").openSync(transcriptPath, "r");
     try {
@@ -17674,17 +17706,22 @@ function readTurnLines(transcriptPath) {
   const allLines = raw.split("\n").filter((l) => l.trim().length > 0);
   if (allLines.length === 0) return null;
   let turnStart = 0;
+  let boundaryFound = false;
   for (let i = allLines.length - 1; i >= 0; i--) {
     try {
       const parsed = JSON.parse(allLines[i]);
       if (parsed.type === "user" && isRealUserMessage(parsed)) {
         turnStart = i;
+        boundaryFound = true;
         break;
       }
     } catch {
     }
   }
-  return allLines.slice(turnStart);
+  return {
+    lines: allLines.slice(turnStart),
+    window: !windowed ? "whole" : boundaryFound ? "windowed" : "orphaned"
+  };
 }
 function isRealUserMessage(parsed) {
   const message = parsed.message;
@@ -18281,7 +18318,7 @@ async function passAndExit(reason, skip, kindOverride) {
   if (unaccounted.length > 0) {
     logEvent("coverage_unaccounted", { where: "passAndExit", skip, count: unaccounted.length });
   }
-  const AGENT_SILENT_SKIPS = /* @__PURE__ */ new Set(["iteration-cap"]);
+  const AGENT_SILENT_SKIPS = /* @__PURE__ */ new Set([]);
   const agentNote = AGENT_SILENT_SKIPS.has(skip) ? null : note;
   printJsonCompact(
     buildHookOutput(
@@ -18382,13 +18419,21 @@ async function runAnalyze(opts, globals) {
   const conversation = await readAndClearConversationBuffer(baselineSessionId);
   const specs = discoverSpecs();
   const plans = discoverPlans();
+  const agentAuthoredCodeThisTurn = !!(actionSummary && (actionSummary.files_edited.length > 0 || actionSummary.files_created.length > 0));
+  const turnAuthoredCode = agentAuthoredCodeThisTurn || !!baseline && allForReview.some((f) => changedSinceBaseline(f, baseline));
+  const canSeeTurnAuthorship = !!actionSummary || !!baseline;
   const latestPrompt = conversation?.prompts?.[conversation.prompts.length - 1]?.prompt ?? "";
   if (/^\s*\/verity-/i.test(latestPrompt)) {
+    const setupAuthored = [
+      ...actionSummary?.files_edited ?? [],
+      ...actionSummary?.files_created ?? []
+    ];
+    if (setupAuthored.length > 0) {
+      const adopted = absorbIntoBaseline(setupAuthored, baselineSessionId);
+      logEvent("baseline_absorbed", { skip: "verity-command", offered: setupAuthored.length, adopted });
+    }
     await passAndExit("Verity command \u2014 skipping analysis", "verity-command");
   }
-  const agentAuthoredCodeThisTurn = !!(actionSummary && (actionSummary.files_edited.length > 0 || actionSummary.files_created.length > 0));
-  const turnAuthoredCode = agentAuthoredCodeThisTurn || !!baseline && allForReview.some((f) => changedSinceBaseline(f, baseline));
-  const canSeeTurnAuthorship = !!actionSummary || !!baseline;
   if (shouldSkipForBareAck({ prompt: latestPrompt, turnAuthoredCode, canSeeTurnAuthorship })) {
     await passAndExit("Bare acknowledgment \u2014 skipping analysis", "bare-acknowledgment");
   }
@@ -18438,7 +18483,11 @@ async function runAnalyze(opts, globals) {
     );
   }
   if (analysisMode === "skip") {
-    await passAndExit("Skip mode \u2014 no code work to analyze", "skip-mode");
+    await passAndExit(
+      "Skip mode \u2014 no code work to analyze",
+      "skip-mode",
+      turnAuthoredCode ? "capacity" : void 0
+    );
   }
   let staticResults = {
     tool: "@codacy/analysis-cli",
@@ -18531,19 +18580,13 @@ async function runAnalyze(opts, globals) {
         snapshotResult = generateSnapshotDiffs(codeDelta.files);
       }
       currentCommit = getCurrentCommit();
-      const maxIterations = parseInt(opts.maxIterations, 10);
-      const iterResult = checkMaxIterations(currentCommit, maxIterations, contentHash ?? void 0);
-      if (iterResult.skip) await passAndExit(iterResult.skip, "iteration-cap");
-      iteration = iterResult.iteration;
+      iteration = readIterationState(currentCommit).iteration;
     }
   }
   if (analysisMode === "plan") {
     recordAnalysisStart();
     currentCommit = getCurrentCommit();
-    const maxIterations = parseInt(opts.maxIterations, 10);
-    const iterResult = checkMaxIterations(currentCommit, maxIterations);
-    if (iterResult.skip) await passAndExit(iterResult.skip, "iteration-cap");
-    iteration = iterResult.iteration;
+    iteration = readIterationState(currentCommit).iteration;
   }
   const contextFiles = gatherContextFiles(contextFilePaths, codeDelta.files);
   for (const f of codeDelta.files) {
@@ -18716,7 +18759,30 @@ async function runAnalyze(opts, globals) {
     hasUserPrompt: (conversation?.prompts?.length ?? 0) > 0,
     isTTY: process.stdout.isTTY === true
   });
+  const excludedByReason = {};
+  for (const e of codeDelta.excluded ?? []) {
+    excludedByReason[e.reason] = (excludedByReason[e.reason] ?? 0) + 1;
+  }
+  const coverageTelemetry = {
+    // git's whole answer, before ANY narrowing. The number that has never been sent.
+    changed_all: allChanged.length,
+    analyzable: analyzable.length,
+    reviewable: reviewable.length,
+    security: securityFiles.length,
+    // after the allowlist, before authorship scoping and the caps
+    for_review: allForReview.length,
+    // what actually reaches the reviewer
+    sent: codeDelta.files.length,
+    // the two silent narrowings, counted separately so they can be told apart
+    capped_out: actionSummary?.capped_out?.length ?? 0,
+    excluded: (codeDelta.excluded ?? []).length,
+    excluded_by_reason: excludedByReason,
+    // was the transcript itself truncated? The 256 KB window means "this turn"
+    // can quietly mean "the last 256 KB of it".
+    transcript_windowed: actionSummary?.transcript_windowed ?? null
+  };
   const requestBody = {
+    coverage_telemetry: coverageTelemetry,
     static_results: staticResults,
     code_delta: codeDelta,
     changed_files: allForReview,
@@ -18802,6 +18868,54 @@ async function runAnalyze(opts, globals) {
         // replaced a population floor with ≈35% power that was sub-integer for
         // three-quarters of the fleet.
         conservation: foldConservation,
+        // ⚠ VRT-52 — RECORDED, NOT APPLIED. The number nobody has.
+        //
+        // The whole "task-scoped delta" design space rests on an assumption that
+        // has been observed exactly ONCE: that delta files routinely belong to
+        // earlier work. Three designs were built on it and all three were killed
+        // adversarially — two by measurement — so before another is attempted,
+        // measure the base rate.
+        //
+        // `authored_under_earlier_goal` counts delta paths whose LAST authorship
+        // event precedes the seq of the goal now in force. Both numbers come from
+        // the same append-only counter (`nextSeq`), so the comparison is exact.
+        //
+        // Keyed on the GOAL, deliberately, not on the task id. The task classifier
+        // reported `is_new_task` on two consecutive turns of one task 25 seconds
+        // apart, so a task-keyed number would measure its unreliability rather
+        // than the phenomenon. And this only became meaningful once `recordGoal`
+        // stopped letting a bare "ok" supersede the goal — before that the seq
+        // advanced every turn and this would have degenerated to "not edited this
+        // turn", which is the exact mistake that sank one of the three designs.
+        //
+        // Changes no payload the reviewer sees, no narrowing, no verdict.
+        vrt52: (() => {
+          const goalSeq = memory?.projection.goal?.seq;
+          if (goalSeq === void 0 || !memorySession) return { known: false };
+          const lastSeq2 = new Map(
+            foldDossier(memorySession.d).authored_all.map((a) => [a.path, a.last_seq])
+          );
+          let earlier = 0;
+          let unknown = 0;
+          for (const f of codeDelta.files) {
+            const seen = lastSeq2.get(f.path);
+            if (seen === void 0) unknown++;
+            else if (seen < goalSeq) earlier++;
+          }
+          return {
+            known: true,
+            goal_seq: goalSeq,
+            delta: codeDelta.files.length,
+            // Files this delta carries that were last written under an EARLIER
+            // instruction. If this stays near zero, VRT-52's code half is
+            // unnecessary and should be closed saying so.
+            authored_under_earlier_goal: earlier,
+            // Delta files the dossier has no authorship record for at all —
+            // pre-existing tree state, or an authorship channel the fold cannot
+            // see. Reported separately so a blind spot is never counted as a zero.
+            no_authorship_record: unknown
+          };
+        })(),
         // P2 — RECORDED, NOT APPLIED. What this run WOULD have reviewed if it
         // narrowed to the within-session increment: what changed since the last
         // VERDICT rather than since task start.
@@ -18836,6 +18950,14 @@ async function runAnalyze(opts, globals) {
       const latest = conversation.prompts[conversation.prompts.length - 1];
       const goalPrompt = resolveGoalPrompt(conversation.prompts) ?? { entry: latest, turnsBack: 0 };
       intentContext.user_prompt = goalPrompt.entry.prompt;
+      if (isContinuationPrompt(intentContext.user_prompt)) {
+        const carried = memory?.projection.goal?.text;
+        if (carried && !isContinuationPrompt(carried)) {
+          intentContext.continuation_prompt = latest.prompt;
+          intentContext.user_prompt = carried;
+          logEvent("goal_from_dossier", { chars: carried.length });
+        }
+      }
       if (goalPrompt.turnsBack > 0) {
         intentContext.continuation_prompt = latest.prompt;
         logEvent("goal_walked_back", { turns_back: goalPrompt.turnsBack });
@@ -19162,9 +19284,41 @@ async function runAnalyze(opts, globals) {
     reverify_by: response.reverify_by
   });
   const grantNudge = grantWarning ? ` \u26A0\uFE0F ${grantWarning}` : "";
-  switch (decision) {
+  let capReleased = false;
+  let effectiveDecision = decision;
+  if (decision === "FAIL") {
+    const blocking = (response.findings ?? []).filter((f) => {
+      const sev = String(f.severity ?? "").toLowerCase();
+      return sev === "critical" || sev === "high";
+    });
+    const fingerprint = findingsFingerprint(blocking);
+    const prior = readIterationState(currentCommit);
+    const sameProblem = isSameProblem(prior.fingerprint, fingerprint);
+    const nextIteration = sameProblem ? prior.iteration + 1 : 1;
+    const maxIterations = parseInt(opts.maxIterations, 10);
+    writeIteration(nextIteration, currentCommit, contentHash ?? void 0, fingerprint);
+    iteration = nextIteration;
+    if (nextIteration > maxIterations) {
+      capReleased = true;
+      effectiveDecision = "WARN";
+      logEvent("iteration_cap_released", { iteration: nextIteration, fingerprint });
+    }
+  }
+  if (capReleased) {
+    const findings = response.findings ?? [];
+    const lines = findings.slice(0, 5).map((f) => `  [${String(f.severity ?? "?").toUpperCase()}] ${String(f.title ?? f.message ?? "")} (${String(f.file ?? "?")}:${String(f.line ?? "?")})`);
+    emitVerdict({
+      proposed: "WARN",
+      changed: skipCoverageChanged,
+      coverage: reviewCoverage,
+      userSummary: `Verity: WARN \u2014 self-healing limit (${opts.maxIterations}) reached on the same finding. NO LONGER BLOCKING, but ${findings.length} finding(s) remain OPEN and were NOT fixed. Human review required before deploying.
+${lines.join("\n")}`,
+      agentContext: null,
+      silenced: true
+    });
+  }
+  switch (effectiveDecision) {
     case "FAIL": {
-      writeIteration(iteration + 1, currentCommit, contentHash ?? void 0);
       const assessment = response.assessment;
       const narrative = assessment?.narrative ?? "";
       const findings = response.findings ?? [];
@@ -21094,7 +21248,7 @@ function registerTelemetryCommands(program2) {
 }
 
 // src/cli.ts
-program.name("verity").description("CLI for Verity quality gate service").version("0.28.1-experimental.39013ce").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async () => {
+program.name("verity").description("CLI for Verity quality gate service").version("0.28.1-experimental.4410c26").option("--token <token>", "Override authentication token").option("--service-url <url>", "Override service URL").option("--verbose", "Log HTTP requests/responses to stderr").hook("preAction", async () => {
   try {
     await foldLegacyLocalCredential();
   } catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@codacy/verity-cli",
-  "version": "0.28.1-experimental.39013ce",
+  "version": "0.28.1-experimental.4410c26",
   "description": "CLI for Verity quality gate service",
   "homepage": "https://verity.md",
   "bugs": {