@coda-console/review 2.10.0 → 2.11.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -54,7 +54,7 @@
|
|
|
54
54
|
|
|
55
55
|
<!-- 检查:机器检查便宜,先过了它们再请 Agent 评审。项目在自己的仓库里声明哪些流程是检查(coda:kind="check"):这里在这个提交上调用它们,
|
|
56
56
|
一个没通过(运行失败)就交给开 PR 的会话;都通过了,再等这个提交在 GitHub 上的全部检查(项目检查写的状态、GitHub Actions 等)有结果,
|
|
57
|
-
|
|
57
|
+
它们的一句话结论交给评审方、写在批准卡上。会话推了新提交就答复「已推送新版本」,等新提交从头再来;重跑外部检查或处理好别的后答复,再跑一遍。 -->
|
|
58
58
|
<subProcess id="checking" name="检查">
|
|
59
59
|
<startEvent id="checking-in" />
|
|
60
60
|
<sequenceFlow id="c-in" sourceRef="checking-in" targetRef="run-checks" />
|
|
@@ -82,29 +82,44 @@
|
|
|
82
82
|
<conditionExpression xsi:type="tFormalExpression">=not(checks.passed)</conditionExpression>
|
|
83
83
|
</sequenceFlow>
|
|
84
84
|
<sequenceFlow id="checks-passed" sourceRef="checked" targetRef="checking-out" />
|
|
85
|
-
<userTask id="fix-checks" name="检查没通过:处理后答复" coda:status="检查没通过:开 PR 的会话处理中"
|
|
85
|
+
<userTask id="fix-checks" name="检查没通过:处理后答复" coda:status="检查没通过:开 PR 的会话处理中">
|
|
86
86
|
<documentation>PR #{{github.event.number}}({{github.event.pull_request.html_url}})的检查没通过。没通过的项目检查列在这次运行页的「调用的流程」里(运行 {{run.id}});
|
|
87
87
|
GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}` 查看。
|
|
88
88
|
|
|
89
|
-
|
|
89
|
+
请查明原因。是这次改动导致的就修改、验证并推送新版本,再答复 completed、choice pushed:这个版本不再重跑检查,新版本会重新检查、评审;检查本身出了问题(偶发、机器离线),处理好后答复 completed、choice again,项目的检查会再跑一遍,GitHub 上的其他检查要你自己重跑。做不了就答复 rejected,在 note 里写明原因,交给用户。</documentation>
|
|
90
|
+
<extensionElements>
|
|
91
|
+
<coda:choice id="again" name="已处理,再跑检查" primary="true" />
|
|
92
|
+
<coda:choice id="pushed" name="已推送新版本" />
|
|
93
|
+
</extensionElements>
|
|
90
94
|
</userTask>
|
|
91
|
-
<sequenceFlow id="
|
|
95
|
+
<sequenceFlow id="to-fixed-checks" sourceRef="fix-checks" targetRef="fixed-checks" />
|
|
96
|
+
<exclusiveGateway id="fixed-checks" name="推送了吗" default="run-again" />
|
|
97
|
+
<sequenceFlow id="checks-fix-pushed" sourceRef="fixed-checks" targetRef="checking-fixing">
|
|
98
|
+
<conditionExpression xsi:type="tFormalExpression">=fix-checks.chose.pushed</conditionExpression>
|
|
99
|
+
</sequenceFlow>
|
|
100
|
+
<sequenceFlow id="run-again" sourceRef="fixed-checks" targetRef="run-checks" />
|
|
92
101
|
<boundaryEvent id="checks-stuck" name="做不了" attachedToRef="fix-checks"><errorEventDefinition /></boundaryEvent>
|
|
93
102
|
<sequenceFlow id="to-checks-user" sourceRef="checks-stuck" targetRef="checks-user" />
|
|
94
|
-
<userTask id="checks-user" name="检查没通过:等你处理" coda:assignee="user" coda:
|
|
103
|
+
<userTask id="checks-user" name="检查没通过:等你处理" coda:assignee="user" coda:status="检查没通过:等你处理" coda:completeLabel="再跑检查" coda:rejectLabel="不再等">
|
|
95
104
|
<documentation>PR #{{github.event.number}}({{github.event.pull_request.html_url}})的检查没通过,开 PR 的会话处理不了,理由在这次运行的「检查没通过:处理后答复」任务里;
|
|
96
105
|
没通过的项目检查见运行页「调用的流程」,GitHub 上的检查见 PR 页面。
|
|
97
106
|
|
|
98
107
|
处理好后选「再跑检查」;推送新提交也会从头再来。</documentation>
|
|
99
108
|
</userTask>
|
|
100
109
|
<sequenceFlow id="run-again-by-user" sourceRef="checks-user" targetRef="run-checks" />
|
|
101
|
-
<endEvent id="checking-out"
|
|
110
|
+
<endEvent id="checking-out"><extensionElements><coda:output name="outcome" value="passed" /></extensionElements></endEvent>
|
|
111
|
+
<endEvent id="checking-fixing" name="等新提交"><extensionElements><coda:output name="outcome" value="fixing" /></extensionElements></endEvent>
|
|
102
112
|
</subProcess>
|
|
103
113
|
<boundaryEvent id="pushed-while-checking" name="新提交" attachedToRef="checking"><messageEventDefinition messageRef="synchronize" /></boundaryEvent>
|
|
104
114
|
<sequenceFlow id="checking-pushed" sourceRef="pushed-while-checking" targetRef="opening" />
|
|
105
115
|
<boundaryEvent id="closed-while-checking" name="PR 关闭" attachedToRef="checking"><messageEventDefinition messageRef="closed" /></boundaryEvent>
|
|
106
116
|
<sequenceFlow id="checking-closed" sourceRef="closed-while-checking" targetRef="ended" />
|
|
107
|
-
<sequenceFlow id="
|
|
117
|
+
<sequenceFlow id="checked-out" sourceRef="checking" targetRef="after-checking" />
|
|
118
|
+
<exclusiveGateway id="after-checking" name="接下来" default="to-reviewing" />
|
|
119
|
+
<sequenceFlow id="checked-fixing" sourceRef="after-checking" targetRef="waiting">
|
|
120
|
+
<conditionExpression xsi:type="tFormalExpression">=checking.outcome = "fixing"</conditionExpression>
|
|
121
|
+
</sequenceFlow>
|
|
122
|
+
<sequenceFlow id="to-reviewing" sourceRef="after-checking" targetRef="reviewing" />
|
|
108
123
|
|
|
109
124
|
<!-- 评审这个版本:同一个提交在同一个 base 上评审通过过就不再评;自动评审到了上限请你决定。结束时 head 是通过的那个提交,合并只合它。 -->
|
|
110
125
|
<subProcess id="reviewing" name="评审">
|
|
@@ -153,7 +168,7 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
153
168
|
</sequenceFlow>
|
|
154
169
|
<sequenceFlow id="approved" sourceRef="verdict" targetRef="passed" />
|
|
155
170
|
|
|
156
|
-
<userTask id="limit" name="评审次数已到上限" coda:assignee="user" coda:
|
|
171
|
+
<userTask id="limit" name="评审次数已到上限" coda:assignee="user" coda:status="评审次数已到上限:等你决定">
|
|
157
172
|
<documentation>PR #{{github.event.number}} 在这条运行里已自动评审 {{review.count}} 次,到了上限({{vars.review.maxReviews}} 次)。当前版本 {{github.event.pull_request.head.sha}} 还没评审过。
|
|
158
173
|
|
|
159
174
|
最近一次评审(提交 {{review.head}}):{{review.line}}
|
|
@@ -188,7 +203,7 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
188
203
|
<sequenceFlow id="fixed" sourceRef="fix" targetRef="fixing" />
|
|
189
204
|
<boundaryEvent id="disputed" name="不同意" attachedToRef="fix"><errorEventDefinition /></boundaryEvent>
|
|
190
205
|
<sequenceFlow id="to-arbitrate" sourceRef="disputed" targetRef="arbitrate" />
|
|
191
|
-
<userTask id="arbitrate" name="仲裁评审意见" coda:assignee="user" coda:
|
|
206
|
+
<userTask id="arbitrate" name="仲裁评审意见" coda:assignee="user" coda:status="评审意见有分歧:等你仲裁" coda:completeLabel="放行本次评审" coda:rejectLabel="按评审意见修改">
|
|
192
207
|
<documentation>交叉评审要求修改 PR {{review.pr}},开 PR 的会话不同意,理由在这次运行的「处理评审意见」任务里。阻塞级别及以上的问题:
|
|
193
208
|
|
|
194
209
|
{{review.findings}}
|
|
@@ -283,7 +298,7 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
283
298
|
<serviceTask id="kinds" name="看项目有哪些部署、发布" coda:action="workflow-kinds" />
|
|
284
299
|
<sequenceFlow id="kinds-known" sourceRef="kinds" targetRef="approve" />
|
|
285
300
|
|
|
286
|
-
<userTask id="approve" name="批准合并" coda:assignee="user" coda:
|
|
301
|
+
<userTask id="approve" name="批准合并" coda:assignee="user" coda:status="评审通过:等你批准合并">
|
|
287
302
|
<documentation>PR #{{github.event.number}} 可以合并。
|
|
288
303
|
|
|
289
304
|
- **评审**:{{review.line}}
|
|
@@ -348,7 +363,7 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
348
363
|
<sequenceFlow id="to-premerge" sourceRef="approval" targetRef="premerge" />
|
|
349
364
|
|
|
350
365
|
<!-- 合并前检查:每个版本都跑嫌贵的验证(如后端全套),项目声明为 coda:kind="premerge",批准后在要合并的提交上只跑一次。
|
|
351
|
-
没通过交给开 PR
|
|
366
|
+
没通过交给开 PR 的会话:推了新提交答复「已推送新版本」,等新提交从头再来,评审通过后按原批准合并;检查本身出了问题,处理好后答复,再跑一遍。 -->
|
|
352
367
|
<serviceTask id="premerge" name="合并前检查" coda:action="run-workflows" coda:status="合并前检查">
|
|
353
368
|
<extensionElements>
|
|
354
369
|
<coda:param name="kind" value="premerge" />
|
|
@@ -368,15 +383,24 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
368
383
|
<sequenceFlow id="handed-over" sourceRef="handing" targetRef="preparing-ready" />
|
|
369
384
|
<boundaryEvent id="premerge-broke" name="没通过" attachedToRef="premerge"><errorEventDefinition /></boundaryEvent>
|
|
370
385
|
<sequenceFlow id="premerge-to-fix" sourceRef="premerge-broke" targetRef="fix-premerge" />
|
|
371
|
-
<userTask id="fix-premerge" name="合并前检查没通过:处理后答复" coda:status="合并前检查没通过:开 PR 的会话处理中"
|
|
386
|
+
<userTask id="fix-premerge" name="合并前检查没通过:处理后答复" coda:status="合并前检查没通过:开 PR 的会话处理中">
|
|
372
387
|
<documentation>用户已批准合并 PR #{{github.event.number}}({{github.event.pull_request.html_url}}),但提交 {{reviewing.head}} 的合并前检查没通过,还没有合并。没通过的检查列在这次运行页的「调用的流程」里(运行 {{run.id}})。
|
|
373
388
|
|
|
374
|
-
|
|
389
|
+
请查明原因。是这次改动导致的就修改、验证并推送新版本,再答复 completed、choice pushed:这个版本不再跑合并前检查,新版本会重新检查、评审,通过后按用户的批准合并;检查本身出了问题(偶发、机器离线),处理好后答复 completed、choice again,合并前检查会再跑一遍。做不了就答复 rejected,在 note 里写明原因,交给用户。</documentation>
|
|
390
|
+
<extensionElements>
|
|
391
|
+
<coda:choice id="again" name="已处理,再跑检查" primary="true" />
|
|
392
|
+
<coda:choice id="pushed" name="已推送新版本" />
|
|
393
|
+
</extensionElements>
|
|
375
394
|
</userTask>
|
|
376
|
-
<sequenceFlow id="premerge
|
|
395
|
+
<sequenceFlow id="to-fixed-premerge" sourceRef="fix-premerge" targetRef="fixed-premerge" />
|
|
396
|
+
<exclusiveGateway id="fixed-premerge" name="推送了吗" default="premerge-again" />
|
|
397
|
+
<sequenceFlow id="premerge-fix-pushed" sourceRef="fixed-premerge" targetRef="preparing-fixing">
|
|
398
|
+
<conditionExpression xsi:type="tFormalExpression">=fix-premerge.chose.pushed</conditionExpression>
|
|
399
|
+
</sequenceFlow>
|
|
400
|
+
<sequenceFlow id="premerge-again" sourceRef="fixed-premerge" targetRef="premerge" />
|
|
377
401
|
<boundaryEvent id="premerge-stuck" name="做不了" attachedToRef="fix-premerge"><errorEventDefinition /></boundaryEvent>
|
|
378
402
|
<sequenceFlow id="to-premerge-user" sourceRef="premerge-stuck" targetRef="premerge-user" />
|
|
379
|
-
<userTask id="premerge-user" name="合并前检查没通过:等你处理" coda:assignee="user" coda:
|
|
403
|
+
<userTask id="premerge-user" name="合并前检查没通过:等你处理" coda:assignee="user" coda:status="合并前检查没通过:等你处理" coda:completeLabel="再跑检查" coda:rejectLabel="不再等">
|
|
380
404
|
<documentation>你已批准合并 PR #{{github.event.number}}({{github.event.pull_request.html_url}}),但合并前检查没通过,开 PR 的会话处理不了,理由在这次运行的「合并前检查没通过:处理后答复」任务里;
|
|
381
405
|
没通过的检查见运行页「调用的流程」。
|
|
382
406
|
|
|
@@ -428,20 +452,29 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
428
452
|
<subProcess id="resolving" name="处理合并阻碍">
|
|
429
453
|
<startEvent id="resolving-in" />
|
|
430
454
|
<sequenceFlow id="resolving-started" sourceRef="resolving-in" targetRef="unblock" />
|
|
431
|
-
<!-- 没有合并:开 PR
|
|
432
|
-
<userTask id="unblock" name="合并没成功:处理后答复" coda:status="没有合并:开 PR 的会话处理中"
|
|
455
|
+
<!-- 没有合并:开 PR 的会话推新提交后答复「已推送新版本」(经评审后按原批准合并),或处理好之后答复重试;它做不了交给你。 -->
|
|
456
|
+
<userTask id="unblock" name="合并没成功:处理后答复" coda:status="没有合并:开 PR 的会话处理中">
|
|
433
457
|
<documentation>用户已批准合并 PR #{{github.event.number}}({{github.event.pull_request.html_url}}),但没有合并:{{merge.reason}}
|
|
434
458
|
|
|
435
|
-
- 与目标分支 {{github.event.pull_request.base.ref}} 有冲突,或要求先合入:把它合入这个 PR
|
|
436
|
-
- PR 是草稿:确认可以评审后用 `gh pr ready` 标记,再答复 completed 重试合并。
|
|
437
|
-
- 必需的检查还没通过:等它通过后答复 completed
|
|
459
|
+
- 与目标分支 {{github.event.pull_request.base.ref}} 有冲突,或要求先合入:把它合入这个 PR 的分支,解决冲突、验证并推送,再答复 completed、choice pushed。新提交照常评审,通过后按用户的批准合并。
|
|
460
|
+
- PR 是草稿:确认可以评审后用 `gh pr ready` 标记,再答复 completed、choice again 重试合并。
|
|
461
|
+
- 必需的检查还没通过:等它通过后答复 completed、choice again 重试;检查失败就修复并推送,再答复 completed、choice pushed。
|
|
438
462
|
|
|
439
463
|
做不了就答复 rejected,在 note 里写明原因,交给用户。</documentation>
|
|
464
|
+
<extensionElements>
|
|
465
|
+
<coda:choice id="again" name="已处理,重试合并" primary="true" />
|
|
466
|
+
<coda:choice id="pushed" name="已推送新版本" />
|
|
467
|
+
</extensionElements>
|
|
440
468
|
</userTask>
|
|
441
|
-
<sequenceFlow id="
|
|
469
|
+
<sequenceFlow id="to-unblocked" sourceRef="unblock" targetRef="unblocked" />
|
|
470
|
+
<exclusiveGateway id="unblocked" name="推送了吗" default="retry" />
|
|
471
|
+
<sequenceFlow id="unblock-pushed" sourceRef="unblocked" targetRef="resolving-fixing">
|
|
472
|
+
<conditionExpression xsi:type="tFormalExpression">=unblock.chose.pushed</conditionExpression>
|
|
473
|
+
</sequenceFlow>
|
|
474
|
+
<sequenceFlow id="retry" sourceRef="unblocked" targetRef="resolving-retry" />
|
|
442
475
|
<boundaryEvent id="stuck" name="做不了" attachedToRef="unblock"><errorEventDefinition /></boundaryEvent>
|
|
443
476
|
<sequenceFlow id="to-unblock-user" sourceRef="stuck" targetRef="unblock-user" />
|
|
444
|
-
<userTask id="unblock-user" name="合并没成功:等你处理" coda:assignee="user" coda:
|
|
477
|
+
<userTask id="unblock-user" name="合并没成功:等你处理" coda:assignee="user" coda:status="没有合并:等你处理">
|
|
445
478
|
<documentation>你已批准合并 PR #{{github.event.number}}({{github.event.pull_request.html_url}}),但没有合并:{{merge.reason}}
|
|
446
479
|
|
|
447
480
|
开 PR 的会话处理不了,理由在这次运行的「合并没成功:处理后答复」任务里。在 GitHub 上处理好后选「重试合并」;推送新提交也会接着评审、按你的批准合并。</documentation>
|
|
@@ -459,6 +492,7 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
459
492
|
|
|
460
493
|
<endEvent id="resolving-retry"><extensionElements><coda:output name="outcome" value="retry" /></extensionElements></endEvent>
|
|
461
494
|
<endEvent id="resolving-close"><extensionElements><coda:output name="outcome" value="close" /></extensionElements></endEvent>
|
|
495
|
+
<endEvent id="resolving-fixing"><extensionElements><coda:output name="outcome" value="fixing" /></extensionElements></endEvent>
|
|
462
496
|
</subProcess>
|
|
463
497
|
<boundaryEvent id="closed-while-resolving" name="PR 关闭" attachedToRef="resolving"><messageEventDefinition messageRef="closed" /></boundaryEvent>
|
|
464
498
|
<sequenceFlow id="resolving-ended" sourceRef="closed-while-resolving" targetRef="merging-elsewhere" />
|
|
@@ -467,6 +501,9 @@ GitHub 上各项检查用 `gh pr checks {{github.event.pull_request.html_url}}`
|
|
|
467
501
|
<sequenceFlow id="resolved-close" sourceRef="after-resolving" targetRef="close">
|
|
468
502
|
<conditionExpression xsi:type="tFormalExpression">=resolving.outcome = "close"</conditionExpression>
|
|
469
503
|
</sequenceFlow>
|
|
504
|
+
<sequenceFlow id="resolved-fixing" sourceRef="after-resolving" targetRef="merging-fixing">
|
|
505
|
+
<conditionExpression xsi:type="tFormalExpression">=resolving.outcome = "fixing"</conditionExpression>
|
|
506
|
+
</sequenceFlow>
|
|
470
507
|
<sequenceFlow id="resolved-retry" sourceRef="after-resolving" targetRef="merge" />
|
|
471
508
|
<endEvent id="merging-elsewhere"><extensionElements><coda:output name="outcome" value="elsewhere" /></extensionElements></endEvent>
|
|
472
509
|
|