@cocreate/socket-server 1.4.19 → 1.4.20

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.4.20](https://github.com/CoCreate-app/CoCreate-socket-server/compare/v1.4.19...v1.4.20) (2022-12-07)
+
+
+### Bug Fixes
+
+* comment syncServer requires security improvements ([60f73de](https://github.com/CoCreate-app/CoCreate-socket-server/commit/60f73ded3927f7c6a5005b0f339e846ead920c2e))
+
 ## [1.4.19](https://github.com/CoCreate-app/CoCreate-socket-server/compare/v1.4.18...v1.4.19) (2022-12-07)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cocreate/socket-server",
-  "version": "1.4.19",
+  "version": "1.4.20",
   "description": "CoCreate-socket-server",
   "keywords": [
     "cocreate-socket",

package/src/index.js

@@ -132,9 +132,9 @@ class SocketServer extends EventEmitter{
 			// 	return;
 			// }
 			
-			const requestData = JSON.parse(message)
+			const {action, data} = JSON.parse(message)
 
-			if (requestData.action) {
+			if (action) {
 				this.recordTransfer('in', message, organization_id)
 
 				let user_id = null;
@@ -143,9 +143,13 @@ class SocketServer extends EventEmitter{
 				
 				//. check permission
 				if (this.permissionInstance) {
-					const passStatus = await this.permissionInstance.check(requestData.action, requestData.data, req, user_id)
+					const passStatus = await this.permissionInstance.check(action, data, req, user_id)
 					if (passStatus !== true) {
-						this.send(socket, 'Access Denied', passStatus)
+						// if (action == 'syncServer' && passStatus.database === true)
+						// if (action == 'syncServer')
+						// 	this.emit(action, socket, data);
+						// else
+							this.send(socket, 'Access Denied', passStatus)
 						return;
 					}
 				}
@@ -158,7 +162,7 @@ class SocketServer extends EventEmitter{
 				}
 
 				//. checking async status....				
-				if (requestData.data.async == true) {
+				if (data.async == true) {
 					console.log('async true')
 					const asyncMessage = this.asyncMessages.get(socket.config.key);
 					socket.config.asyncId = uid.generate();
@@ -167,7 +171,7 @@ class SocketServer extends EventEmitter{
 					}
 				}
 
-				this.emit(requestData.action, socket, requestData.data);
+				this.emit(action, socket, data);
 			}
 			
 		} catch(e) {