@cocreate/scroll 1.3.3 → 1.3.6

package/CHANGELOG.md

@@ -1,3 +1,24 @@
+## [1.3.6](https://github.com/CoCreate-app/CoCreate-scroll/compare/v1.3.5...v1.3.6) (2022-06-22)
+
+
+### Bug Fixes
+
+* compare datetime to break infinite loop on scroll up and scroll down ([c86b317](https://github.com/CoCreate-app/CoCreate-scroll/commit/c86b3170a9335acf895006de54d10b2cc3fc2ab0))
+
+## [1.3.5](https://github.com/CoCreate-app/CoCreate-scroll/compare/v1.3.4...v1.3.5) (2022-06-19)
+
+
+### Bug Fixes
+
+* removed scroll-element support as it was causing a loop. Moved to branch newScroll fordebugging ([f8d99c7](https://github.com/CoCreate-app/CoCreate-scroll/commit/f8d99c707b0e87032f7dd547b3342d308182c6d6))
+
+## [1.3.4](https://github.com/CoCreate-app/CoCreate-scroll/compare/v1.3.3...v1.3.4) (2022-06-18)
+
+
+### Bug Fixes
+
+* bump dependencies ([0bd768f](https://github.com/CoCreate-app/CoCreate-scroll/commit/0bd768fb982758e6daa62bfd3724a3dec1618f88))
+
 ## [1.3.3](https://github.com/CoCreate-app/CoCreate-scroll/compare/v1.3.2...v1.3.3) (2022-06-18)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cocreate/scroll",
-  "version": "1.3.3",
+  "version": "1.3.6",
   "description": "A simple scroll component in vanilla javascript. Easily configured using HTML5 attributes and/or JavaScript API.",
   "keywords": [
     "scroll",
@@ -61,7 +61,7 @@
     "webpack-log": "^3.0.1"
   },
   "dependencies": {
-    "@cocreate/docs": "^1.3.2",
-    "@cocreate/observer": "^1.5.2"
+    "@cocreate/docs": "^1.3.3",
+    "@cocreate/observer": "^1.5.3"
   }
 }

package/src/index.js

@@ -25,7 +25,7 @@ const CoCreateScroll = {
 		const targetSelector = element.getAttribute('scroll-target');
 		const scrollSelector = element.getAttribute('scroll-element');
 		const intersectValue = element.getAttribute('scroll-intersect');
-
+		
 		let values = element.getAttribute('scroll') || "";
 		values = values.split(",").map(x => x.trim());
 
@@ -88,7 +88,7 @@ const CoCreateScroll = {
 
 		elements.forEach((el) => {
 			self.__setScrolling(el, scrollInfo, false);
-			// self.__runScrollEvent(el, scrollInfo, scrollableEl);
+			self.__runScrollEvent(el, scrollInfo, scrollableEl);
 
 		});
 
@@ -97,18 +97,6 @@ const CoCreateScroll = {
 				self.__setScrolling(el, scrollInfo, true);
 			});
 		}, 500);
-
-		if (!self.firedEvents.has(element)) {
-			self.firedEvents.set(element, element)
-			elements.forEach((el) => {
-				self.__runScrollEvent(el, scrollInfo, scrollableEl);
-			});
-			setTimeout(function() {
-				self.firedEvents.delete(element)
-				// clearTimeout(eventTimer)
-			}, 300);
-		}
-
 	},
 
 	__initIntersectionObserver: function() {
@@ -159,15 +147,19 @@ const CoCreateScroll = {
 		}
 		const { upSize, downSize, attrName, values, scrollTop, scrollBottom, scrollLimbo } = info;
 
-		if (upSize < (currentPos - scrollY)) {
-			this.__addAttributeValue(element, attrName, values[0]);
-			this.__removeAttrbuteValue(element, attrName, values[1]);
-		}
-		else if (downSize < (scrollY - currentPos)) {
-			this.__removeAttrbuteValue(element, attrName, values[0]);
-			this.__addAttributeValue(element, attrName, values[1]);
-		}
+		let newTime = new Date().getTime()
+		if (!info.datetime || (newTime - info.datetime) > 200 ) {
+			info['datetime'] = newTime
 
+			if (upSize <= (currentPos - scrollY)) {
+				this.__addAttributeValue(element, attrName, values[0]);
+				this.__removeAttrbuteValue(element, attrName, values[1]);
+			}
+			else if (downSize <= (scrollY - currentPos)) {
+				this.__removeAttrbuteValue(element, attrName, values[0]);
+				this.__addAttributeValue(element, attrName, values[1]);
+			}
+		}
 		//. scroll top case
 		if (scrollY <= this.delta) {
 			this.__removeAttrbuteValue(element, attrName, values[0]);