@cocreate/render 1.28.4 → 1.28.5

package/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [1.28.5](https://github.com/CoCreate-app/CoCreate-render/compare/v1.28.4...v1.28.5) (2023-10-16)
+
+
+### Bug Fixes
+
+* render delete nodes ([1921e57](https://github.com/CoCreate-app/CoCreate-render/commit/1921e572051d62aa53513f5379538f3df3c76d93))
+* update and delete for loop data.type ([cc5e4b5](https://github.com/CoCreate-app/CoCreate-render/commit/cc5e4b5ef33814de59159204f6af8648b6fdfbca))
+
 ## [1.28.4](https://github.com/CoCreate-app/CoCreate-render/compare/v1.28.3...v1.28.4) (2023-10-14)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cocreate/render",
-  "version": "1.28.4",
+  "version": "1.28.5",
   "description": "A simple render component in vanilla javascript. Easily configured using HTML5 attributes and/or JavaScript API.",
   "keywords": [
     "render",

package/src/index.js

@@ -100,7 +100,7 @@ async function render({ source, element, data, key, index, currentIndex, update,
 
     for (let i = 0; i < element.length; i++) {
         if (!key)
-            key = element[i].getAttribute('render')
+            key = element[i].getAttribute('render') || type
 
         let renderedNode = renderedNodes.get(element[i])
         if (source) {
@@ -110,43 +110,37 @@ async function render({ source, element, data, key, index, currentIndex, update,
             }
         }
 
-        // TODO: for loop data[type]?
         if (remove) {
-            if (renderedNode.source) {
-                if (key)
-                    renderedNode.source.data[key].splice(index, 1)
-                else {
-
+            for (let j = 0; j < data[type].length; j++) {
+                let cloneKey
+                if (type === 'object') {
+                    cloneKey = data[type][j]._id;
+                } else {
+                    cloneKey = data[type][j].name;
                 }
-            }
 
-            let cloneKey
-            if (type === 'object') {
-                cloneKey = data[type][0]._id;
-            } else {
-                cloneKey = data[type][0].name;
-            }
-
-            let clone = renderedNode.clones.get(cloneKey)
-            if (!clone) return
+                let clone = renderedNode.clones.get(cloneKey)
+                if (!clone) return
 
-            renderedNode.clones.delete(cloneKey)
-            renderedNodes.delete(clone)
-            clone.remove()
+                renderedNode.clones.delete(cloneKey)
+                renderedNodes.delete(clone)
+                clone.remove()
+            }
         } else if (key || Array.isArray(data)) {
             if (update) {
-                let clone
-                if (type === 'object') {
-                    clone = renderedNode.clones.get(data[type][0]._id);
-                } else {
-                    clone = renderedNode.clones.get(data[type][0].name);
-                }
+                for (let j = 0; j < data[type].length; j++) {
+                    let clone
+                    if (type === 'object') {
+                        clone = renderedNode.clones.get(data[type][j]._id);
+                    } else {
+                        clone = renderedNode.clones.get(data[type][j].name);
+                    }
 
-                if (!currentIndex)
-                    currentIndex = data.$filter.currentIndex
+                    if (!currentIndex)
+                        currentIndex = data.$filter.currentIndex
+
+                    if (!clone) return
 
-                if (!clone) return
-                for (let j = 0; j < data[type].length; j++) {
                     await renderValues(clone, { object: data[type][j] });
                     if (currentIndex >= 0)
                         insertElement(renderedNode, clone, index, currentIndex)
@@ -170,8 +164,8 @@ async function render({ source, element, data, key, index, currentIndex, update,
 }
 
 async function renderTemplate(template, data, key, index, keyPath) {
-    if (!key)
-        key = template.getAttribute('render')
+    // if (!key)
+    //     key = template.getAttribute('render')
 
     let templateData = renderedNodes.get(template)
     if (!templateData) {