@cnrai/pave 0.3.35 → 0.3.51

package/test/agent-update.test.js

@@ -1,435 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for 'pave agent update' command (Issue #279)
- *
- * Verifies:
- * - args-parser recognizes 'update' as agent subcommand
- * - Flags --sleep, --reinject-interval, --soul are parsed correctly
- * - parseArgs integration for --reinject-interval validation
- * - soulPath guard logic (missing/present/provided)
- * - Existing soul file validation before restart
- * - Stop-before-write ordering (source + simulation)
- * - Dispatch routing from main to handleAgentUpdate
- * - Change summary generation
- *
- * Duration/soul validation details are covered in duration.test.js
- * and soul-reread.test.js respectively.
- *
- * Run with: node test/agent-update.test.js
- */
-
-let passed = 0;
-let failed = 0;
-
-function runTest(name, fn) {
-  try {
-    fn();
-    console.log('\u2705 ' + name);
-    passed++;
-  } catch (e) {
-    console.log('\u274C ' + name + ': ' + e.message);
-    failed++;
-  }
-}
-
-function assert(cond, msg) {
-  if (!cond) throw new Error(msg || 'Assertion failed');
-}
-
-function assertEqual(actual, expected, msg) {
-  if (actual !== expected) {
-    throw new Error((msg || 'assertEqual') + ': expected ' + JSON.stringify(expected) + ', got ' + JSON.stringify(actual));
-  }
-}
-
-// ─── Module Imports (fail fast if broken) ───
-
-const parseArgs = require('../lib/args-parser').parseArgs;
-const duration = require('../lib/duration');
-
-const formatDuration = duration.formatDuration;
-const validateSoulFile = require('../lib/soul').validateSoulFile;
-
-// ─── Args Parser Tests ───
-
-runTest('should recognize "update" as agent subcommand', () => {
-  const result = parseArgs(['agent', 'update', 'designer']);
-  assertEqual(result.command, 'agent', 'command');
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-});
-
-runTest('should parse update with --sleep flag', () => {
-  const result = parseArgs(['agent', 'update', '--sleep', '1h', 'designer']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.sleep, '1h', 'sleep');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-});
-
-runTest('should parse update with --reinject-interval flag', () => {
-  const result = parseArgs(['agent', 'update', '--reinject-interval', '5', 'designer']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.reinjectInterval, 5, 'reinjectInterval');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-});
-
-runTest('should parse update with --soul flag', () => {
-  const result = parseArgs(['agent', 'update', '--soul', './new-soul.md', 'designer']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.soul, './new-soul.md', 'soul');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-});
-
-runTest('should parse update with multiple flags', () => {
-  const result = parseArgs(['agent', 'update', '--sleep', '1h', '--reinject-interval', '5', 'designer']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.sleep, '1h', 'sleep');
-  assertEqual(result.reinjectInterval, 5, 'reinjectInterval');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-});
-
-runTest('should parse update with all three flags', () => {
-  const result = parseArgs(['agent', 'update', '--sleep', '30m', '--reinject-interval', '3', '--soul', './custom.md', 'myagent']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.sleep, '30m', 'sleep');
-  assertEqual(result.reinjectInterval, 3, 'reinjectInterval');
-  assertEqual(result.soul, './custom.md', 'soul');
-  assertEqual(result.commandArgs[0], 'myagent', 'commandArgs[0]');
-});
-
-runTest('should parse update with no flags (show config mode)', () => {
-  const result = parseArgs(['agent', 'update', 'designer']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-  assertEqual(result.reinjectInterval, null, 'reinjectInterval should be null');
-  assertEqual(result.soul, null, 'soul should be null');
-});
-
-runTest('should reject multiple positional args for update', () => {
-  let exitCode = null;
-  const errors = [];
-  const origExit = process.exit;
-  const origError = console.error;
-  process.exit = function (code) { exitCode = code; throw new Error('EXIT_' + code); };
-  console.error = function () { errors.push(Array.prototype.join.call(arguments, ' ')); };
-  try {
-    parseArgs(['agent', 'update', 'designer', 'extra-arg']);
-  } catch (e) {
-    if (!e.message.startsWith('EXIT_')) throw e;
-  } finally {
-    process.exit = origExit;
-    console.error = origError;
-  }
-  assertEqual(exitCode, 1, 'should exit with code 1');
-  assert(errors.length > 0, 'should print error message');
-  assert(errors[0].indexOf('at most one agent name') >= 0, 'error should mention "at most one agent name"');
-});
-
-runTest('should parse update with agent name before flags', () => {
-  const result = parseArgs(['agent', 'update', 'designer', '--sleep', '2h']);
-  assertEqual(result.agentSubcommand, 'update', 'agentSubcommand');
-  assertEqual(result.commandArgs[0], 'designer', 'commandArgs[0]');
-  assertEqual(result.sleep, '2h', 'sleep');
-});
-
-// ─── Reinject Interval Args-Parser Integration Tests ───
-
-runTest('parseArgs should parse valid --reinject-interval', () => {
-  const result = parseArgs(['agent', 'update', 'myagent', '--reinject-interval', '5']);
-  assertEqual(result.reinjectInterval, 5, 'should parse to number 5');
-});
-
-runTest('parseArgs should parse --reinject-interval 1 (minimum)', () => {
-  const result = parseArgs(['agent', 'update', 'myagent', '--reinject-interval', '1']);
-  assertEqual(result.reinjectInterval, 1, 'should parse to number 1');
-});
-
-runTest('parseArgs should reject --reinject-interval with non-integer', () => {
-  let exitCode = null;
-  const errors = [];
-  const origExit = process.exit;
-  const origError = console.error;
-  process.exit = function (code) { exitCode = code; throw new Error('EXIT_' + code); };
-  console.error = function () { errors.push(Array.prototype.join.call(arguments, ' ')); };
-  try {
-    parseArgs(['agent', 'update', 'myagent', '--reinject-interval', 'abc']);
-  } catch (e) {
-    if (!e.message.startsWith('EXIT_')) throw e;
-  } finally {
-    process.exit = origExit;
-    console.error = origError;
-  }
-  assertEqual(exitCode, 1, 'should exit with code 1 for non-integer');
-  assert(errors.length > 0, 'should print error');
-});
-
-runTest('parseArgs should reject --reinject-interval 0', () => {
-  let exitCode = null;
-  const errors = [];
-  const origExit = process.exit;
-  const origError = console.error;
-  process.exit = function (code) { exitCode = code; throw new Error('EXIT_' + code); };
-  console.error = function () { errors.push(Array.prototype.join.call(arguments, ' ')); };
-  try {
-    parseArgs(['agent', 'update', 'myagent', '--reinject-interval', '0']);
-  } catch (e) {
-    if (!e.message.startsWith('EXIT_')) throw e;
-  } finally {
-    process.exit = origExit;
-    console.error = origError;
-  }
-  assertEqual(exitCode, 1, 'should exit with code 1 for zero');
-});
-
-// ─── Change Summary Tests ───
-
-runTest('should build correct change summary for sleep change', () => {
-  const changes = [];
-  changes.push('sleep: ' + formatDuration(60000) + ' \u2192 ' + formatDuration(3600000));
-  assertEqual(changes.length, 1, 'one change');
-  assert(changes[0].indexOf('\u2192') >= 0, 'should contain arrow');
-});
-
-runTest('should build correct change summary for multiple changes', () => {
-  const changes = [];
-  changes.push('sleep: ' + formatDuration(60000) + ' \u2192 ' + formatDuration(3600000));
-  changes.push('reinject-interval: 10 \u2192 5');
-  changes.push('soul: /old.md \u2192 /new.md');
-  assertEqual(changes.length, 3, 'three changes');
-  assert(changes[1].indexOf('reinject-interval') >= 0, 'should mention reinject-interval');
-  assert(changes[2].indexOf('soul') >= 0, 'should mention soul');
-});
-
-// ─── hasAnyUpdate Detection Tests ───
-// Verify the production code checks all three flags before deciding to show config.
-
-runTest('source: hasAnyUpdate checks sleep, reinjectInterval, and soul', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  // Verify the handler checks all three flags
-  assert(handlerBody.indexOf('hasSleep') > -1, 'should check hasSleep');
-  assert(handlerBody.indexOf('hasReinject') > -1, 'should check hasReinject');
-  assert(handlerBody.indexOf('hasSoul') > -1, 'should check hasSoul');
-  assert(handlerBody.indexOf('hasAnyUpdate') > -1, 'should compute hasAnyUpdate');
-  // Verify it gates on hasAnyUpdate for show-config path
-  assert(handlerBody.indexOf('if (!hasAnyUpdate)') > -1, 'should gate on !hasAnyUpdate');
-});
-
-// ─── soulPath Guard Tests ───
-
-runTest('soulPath guard: should detect missing soulPath when status has none and --soul not provided', () => {
-  const status = { sleepMs: 60000, reinjectInterval: 10 };
-  let newSoulPath = status.soulPath;
-  const hasSoul = false;
-  if (hasSoul) { newSoulPath = '/some/path.md'; }
-  assert(!newSoulPath, 'newSoulPath should be falsy');
-});
-
-runTest('soulPath guard: should pass when status has soulPath', () => {
-  const status = { sleepMs: 60000, reinjectInterval: 10, soulPath: '/existing.md' };
-  const newSoulPath = status.soulPath;
-  assert(newSoulPath, 'newSoulPath should be truthy');
-  assertEqual(newSoulPath, '/existing.md', 'should use existing soulPath');
-});
-
-runTest('soulPath guard: should pass when --soul flag provides a new path', () => {
-  const status = { sleepMs: 60000, reinjectInterval: 10 };
-  let newSoulPath = status.soulPath;
-  const hasSoul = true;
-  if (hasSoul) { newSoulPath = '/new-soul.md'; }
-  assertEqual(newSoulPath, '/new-soul.md', 'should use --soul flag value');
-});
-
-// ─── Existing Soul Validation Tests ───
-
-runTest('existing soul validation: should reject missing soul file from status', () => {
-  const hasSoul = false;
-  // Use a guaranteed-nonexistent path under os.tmpdir() for cross-platform reliability
-  const newSoulPath = require('os').tmpdir() + '/nonexistent-soul-' + Date.now() + '-' + Math.random().toString(36).slice(2) + '.md';
-  if (!hasSoul) {
-    const result = validateSoulFile(newSoulPath);
-    assert(!result.valid, 'should reject non-existent soul file');
-  }
-});
-
-runTest('source: existing soul validation gated on !hasSoul', () => {
-  // Verify the production code only validates the existing soul file when
-  // --soul was NOT provided (hasSoul is false). When --soul is provided,
-  // validation already happened during flag parsing.
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  // There are two validateSoulFile calls: one for the --soul flag (hasSoul path),
-  // and one for the existing soul file (!hasSoul path). Find the !hasSoul-gated one
-  // by searching for the specific variable name 'existingSoulValidation'.
-  const existingIdx = handlerBody.indexOf('existingSoulValidation = validateSoulFile(');
-  assert(existingIdx > -1, 'should find existingSoulValidation = validateSoulFile(');
-  const preceding = handlerBody.substring(Math.max(0, existingIdx - 200), existingIdx);
-  assert(preceding.indexOf('if (!hasSoul)') > -1, 'existingSoulValidation should be gated on if (!hasSoul)');
-});
-
-// ─── Production Source Verification Tests ───
-
-runTest('production code updates status fields before writeStatus', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  const sleepAssign = handlerBody.indexOf('status.sleepMs = newSleepMs');
-  const riAssign = handlerBody.indexOf('status.reinjectInterval = newReinjectInterval');
-  const soulAssign = handlerBody.indexOf('status.soulPath = newSoulPath');
-  const writeCall = handlerBody.indexOf('registry.writeStatus(agentName');
-  assert(sleepAssign > -1, 'should assign status.sleepMs');
-  assert(riAssign > -1, 'should assign status.reinjectInterval');
-  assert(soulAssign > -1, 'should assign status.soulPath');
-  assert(writeCall > -1, 'should call writeStatus');
-  assert(sleepAssign < writeCall, 'sleepMs before writeStatus');
-  assert(riAssign < writeCall, 'reinjectInterval before writeStatus');
-  assert(soulAssign < writeCall, 'soulPath before writeStatus');
-});
-
-runTest('production code checks liveness before writing status', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  const aliveIdx = handlerBody.indexOf('registry.isAgentAlive(');
-  const writeIdx = handlerBody.indexOf('registry.writeStatus(agentName');
-  assert(aliveIdx > -1, 'should find isAgentAlive call');
-  assert(writeIdx > -1, 'should find writeStatus(agentName call');
-  assert(aliveIdx < writeIdx, 'isAgentAlive before writeStatus');
-});
-
-runTest('main dispatch routes agent update to handleAgentUpdate', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const dispatchIdx = indexSource.indexOf("args.agentSubcommand === 'update'");
-  assert(dispatchIdx > -1, 'should have dispatch check for update subcommand');
-  const dispatchBlock = indexSource.substring(dispatchIdx, dispatchIdx + 200);
-  assert(dispatchBlock.indexOf('handleAgentUpdate(args)') > -1,
-    'dispatch should call handleAgentUpdate(args)');
-});
-
-// ─── Stop-Before-Write Ordering Tests ───
-// Source-based: verify the production code calls stopAgent before writeStatus
-// when the agent is alive (the running-agent path).
-
-runTest('source: stopAgent called before writeStatus when agent is alive', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  const stopIdx = handlerBody.indexOf('registry.stopAgent(');
-  const writeIdx = handlerBody.indexOf('registry.writeStatus(agentName');
-  assert(stopIdx > -1, 'should find stopAgent call');
-  assert(writeIdx > -1, 'should find writeStatus call');
-  assert(stopIdx < writeIdx, 'stopAgent must come before writeStatus in source');
-});
-
-runTest('source: readStatus called after stopAgent (re-read fresh status)', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  const stopIdx = handlerBody.indexOf('registry.stopAgent(');
-  // Find the re-read after stop (second readStatus call)
-  const firstRead = handlerBody.indexOf('registry.readStatus(');
-  const secondRead = handlerBody.indexOf('registry.readStatus(', firstRead + 1);
-  assert(secondRead > -1, 'should find a second readStatus call (re-read after stop)');
-  assert(secondRead > stopIdx, 'second readStatus should come after stopAgent');
-});
-
-// ─── No-Op Detection Tests ───
-// Verify that handleAgentUpdate skips restart when values haven't changed.
-
-runTest('source: no-op detection returns early when all values unchanged', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  // Verify the handler computes unchanged flags
-  assert(handlerBody.indexOf('sleepUnchanged') > -1, 'should compute sleepUnchanged');
-  assert(handlerBody.indexOf('reinjectUnchanged') > -1, 'should compute reinjectUnchanged');
-  assert(handlerBody.indexOf('soulUnchanged') > -1, 'should compute soulUnchanged');
-  // Verify it returns early when all unchanged
-  assert(handlerBody.indexOf('No changes needed') > -1, 'should have no-changes-needed message');
-  // Verify no-op check comes before writeStatus
-  const noopIdx = handlerBody.indexOf('No changes needed');
-  const writeIdx = handlerBody.indexOf('registry.writeStatus(agentName');
-  assert(noopIdx < writeIdx, 'no-op check should come before writeStatus');
-});
-
-// ─── Restart Race Guard Tests ───
-// Verify that handleAgentUpdate re-checks liveness after stopAgent to detect
-// if another process restarted the agent during the stop window.
-
-runTest('source: re-checks liveness after stopAgent before writing', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate in source');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 11000);
-  const stopIdx = handlerBody.indexOf('registry.stopAgent(');
-  // Find the post-stop liveness re-check
-  const postStopAlive = handlerBody.indexOf('postStopAlive');
-  assert(postStopAlive > -1, 'should have postStopAlive variable');
-  assert(postStopAlive > stopIdx, 'postStopAlive check should come after stopAgent');
-  const writeIdx = handlerBody.indexOf('registry.writeStatus(agentName');
-  assert(postStopAlive < writeIdx, 'postStopAlive check should come before writeStatus');
-});
-
-// ─── Agent Name Inference Tests ───
-// Verify that handleAgentUpdate's inference matches handleAgentStop:
-// prefer alive agents, fall back to stale only when no alive match.
-
-runTest('source: agent name inference prefers alive agents over stale', () => {
-  const fs = require('fs');
-  const indexSource = fs.readFileSync(
-    require('path').join(__dirname, '..', 'index.js'), 'utf8',
-  );
-  const handleIdx = indexSource.indexOf('async function handleAgentUpdate(');
-  assert(handleIdx > -1, 'should find handleAgentUpdate');
-  const handlerBody = indexSource.substring(handleIdx, handleIdx + 3000);
-  // Verify the handler uses alive/stale split (not flat cwdMatches)
-  assert(handlerBody.indexOf('aliveMatches') > -1, 'should use aliveMatches array');
-  assert(handlerBody.indexOf('staleMatches') > -1, 'should use staleMatches array');
-  // Verify alive check uses same pattern as handleAgentStop
-  assert(handlerBody.indexOf("state === 'working'") > -1, 'should check working state');
-  assert(handlerBody.indexOf("state === 'sleeping'") > -1, 'should check sleeping state');
-  assert(handlerBody.indexOf("state === 'starting'") > -1, 'should check starting state');
-});
-
-// ─── Print Results ───
-
-console.log('\n' + passed + ' passed, ' + failed + ' failed, ' + (passed + failed) + ' total');
-if (failed > 0) {
-  process.exitCode = 1;
-}