@cnrai/pave 0.3.32 → 0.3.34

package/test/tool-states.test.js

@@ -0,0 +1,167 @@
+/**
+ * Tests for comprehensive tool state handling
+ * Addresses Copilot feedback on missing pending_confirmation state
+ */
+
+describe('Tool State Handling', () => {
+  let mockStdout;
+
+  beforeEach(() => {
+    mockStdout = jest.spyOn(process.stdout, 'write').mockImplementation();
+  });
+
+  afterEach(() => {
+    mockStdout.mockRestore();
+  });
+
+  const TOOL_COLORS = {
+    yellow: '\x1b[33m',
+    cyan: '\x1b[36m',
+    dim: '\x1b[2m',
+    reset: '\x1b[0m',
+  };
+
+  test('should handle completed tool state', () => {
+    const showTools = true;
+    const json = false;
+    const _noStream = false;
+    const status = 'completed';
+    const _toolName = 'bash';
+
+    if (showTools && !json) {
+      if (status === 'completed') {
+        process.stdout.write(' Tool completed');
+      }
+    }
+
+    expect(mockStdout).toHaveBeenCalledWith(' Tool completed');
+  });
+
+  test('should handle error tool state', () => {
+    const showTools = true;
+    const json = false;
+    const _noStream = false;
+    const status = 'error';
+    const _toolName = 'bash';
+
+    if (showTools && !json) {
+      if (status === 'error') {
+        process.stdout.write('L Tool error');
+      }
+    }
+
+    expect(mockStdout).toHaveBeenCalledWith('L Tool error');
+  });
+
+  test('should handle pending_confirmation tool state', () => {
+    const showTools = true;
+    const json = false;
+    const _noStream = false;
+    const status = 'pending_confirmation';
+    const toolName = 'bash';
+
+    if (showTools && !json) {
+      if (status === 'pending_confirmation') {
+        const confirmationMsg = `\n${TOOL_COLORS.yellow}S${TOOL_COLORS.reset} ${TOOL_COLORS.cyan}${toolName}${TOOL_COLORS.reset} ${TOOL_COLORS.dim}pending confirmation...${TOOL_COLORS.reset}\n`;
+        process.stdout.write(confirmationMsg);
+      }
+    }
+
+    expect(mockStdout).toHaveBeenCalledWith(expect.stringContaining('S'));
+    expect(mockStdout).toHaveBeenCalledWith(expect.stringContaining('pending confirmation'));
+  });
+
+  test('should handle running tool state only once per tool', () => {
+    const showTools = true;
+    const json = false;
+    const _noStream = false;
+    const status = 'running';
+    const toolName = 'bash';
+    const toolId = 'tool-123';
+    const activeTools = {};
+
+    if (showTools && !json) {
+      if (status === 'running' && !activeTools[toolId]) {
+        activeTools[toolId] = true;
+        const runningMsg = `\n${TOOL_COLORS.yellow}�${TOOL_COLORS.reset} ${TOOL_COLORS.cyan}${toolName}${TOOL_COLORS.reset} ${TOOL_COLORS.dim}running...${TOOL_COLORS.reset}\n`;
+        process.stdout.write(runningMsg);
+      }
+    }
+
+    expect(mockStdout).toHaveBeenCalledTimes(1);
+    expect(mockStdout).toHaveBeenCalledWith(expect.stringContaining('�'));
+    expect(mockStdout).toHaveBeenCalledWith(expect.stringContaining('running...'));
+
+    // Second call with same tool should not output again
+    mockStdout.mockClear();
+
+    if (showTools && !json) {
+      if (status === 'running' && !activeTools[toolId]) {
+        activeTools[toolId] = true;
+        process.stdout.write('Should not be called');
+      }
+    }
+
+    expect(mockStdout).not.toHaveBeenCalled();
+  });
+
+  test('should track tool states in JSON mode', () => {
+    const showTools = true;
+    const toolOutputs = [];
+    const toolEntry = {
+      id: 'tool-123',
+      name: 'bash',
+      status: 'pending_confirmation',
+      input: '{"command": "rm -rf /"}',
+      output: null,
+      duration: undefined,
+    };
+
+    if (showTools) {
+      toolOutputs.push(toolEntry);
+    }
+
+    expect(toolOutputs).toHaveLength(1);
+    expect(toolOutputs[0].status).toBe('pending_confirmation');
+  });
+});
+
+describe('Tool State Transitions', () => {
+  test('should handle tool state progression', () => {
+    const toolOutputs = [];
+    const toolId = 'tool-123';
+    const showTools = true;
+
+    // Running state
+    let toolEntry = {
+      id: toolId,
+      name: 'bash',
+      status: 'running',
+      input: '{"command": "sleep 5"}',
+      output: null,
+    };
+
+    if (showTools) {
+      toolOutputs.push(toolEntry);
+    }
+
+    expect(toolOutputs[0].status).toBe('running');
+
+    // Update to completed
+    toolEntry = {
+      ...toolEntry,
+      status: 'completed',
+      output: 'Command completed',
+      duration: 5000,
+    };
+
+    const existingIdx = toolOutputs.findIndex((t) => t.id === toolId);
+    if (existingIdx >= 0) {
+      toolOutputs[existingIdx] = toolEntry;
+    }
+
+    expect(toolOutputs[0].status).toBe('completed');
+    expect(toolOutputs[0].output).toBe('Command completed');
+    expect(toolOutputs[0].duration).toBe(5000);
+  });
+});

package/test/tools-flag.test.js

@@ -0,0 +1,65 @@
+/**
+ * Tests for --no-tools flag functionality
+ * Tool output is shown by default, use --no-tools to disable
+ */
+
+// Use mock parseArgs function from test runner
+const { parseArgs } = global.mockModules || { parseArgs(args) {
+  // Default: showTools is true
+  // --no-tools disables it
+  return {
+    command: args[0] || '',
+    commandArgs: args.slice(1).filter((arg) => !arg.startsWith('--') && !arg.startsWith('-')),
+    showTools: !args.includes('--no-tools'),
+    json: args.includes('--json'),
+    verbose: args.includes('--verbose') || args.includes('-v'),
+    noStream: args.includes('--no-stream'),
+  };
+} };
+
+describe('Tools Flag Parsing', () => {
+  test('should default showTools to true', () => {
+    const args = parseArgs(['chat', 'test', 'message']);
+    expect(args.showTools).toBe(true);
+  });
+
+  test('should parse --no-tools flag to disable', () => {
+    const args = parseArgs(['chat', '--no-tools', 'test', 'message']);
+    expect(args.showTools).toBe(false);
+    expect(args.command).toBe('chat');
+    expect(args.commandArgs).toEqual(['test', 'message']);
+  });
+
+  test('should work with other flags', () => {
+    const args = parseArgs(['chat', '--no-tools', '--json', '--verbose', 'test']);
+    expect(args.showTools).toBe(false);
+    expect(args.json).toBe(true);
+    expect(args.verbose).toBe(true);
+  });
+
+  test('should filter flags from command args', () => {
+    const args = parseArgs(['chat', '--no-tools', 'run', 'bash', 'command']);
+    expect(args.commandArgs).toEqual(['run', 'bash', 'command']);
+    expect(args.commandArgs).not.toContain('--no-tools');
+  });
+});
+
+describe('Tools Flag in Help Text', () => {
+  // Mock console.log to capture help output
+  let consoleSpy;
+  beforeEach(() => {
+    consoleSpy = jest.spyOn(console, 'log').mockImplementation();
+  });
+
+  afterEach(() => {
+    consoleSpy.mockRestore();
+  });
+
+  test('should include --no-tools in help text', () => {
+    const { showHelp } = require('../lib/args-parser');
+    showHelp();
+
+    const helpOutput = consoleSpy.mock.calls.map((call) => call[0]).join('\\n');
+    expect(helpOutput).toContain('--no-tools');
+  });
+});