@cluesmith/codev 2.0.0-rc.3 → 2.0.0-rc.4
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/agent-farm/commands/kickoff.d.ts.map +1 -1
- package/dist/agent-farm/commands/kickoff.js +10 -2
- package/dist/agent-farm/commands/kickoff.js.map +1 -1
- package/dist/commands/porch/index.d.ts +1 -1
- package/dist/commands/porch/index.d.ts.map +1 -1
- package/dist/commands/porch/index.js +194 -18
- package/dist/commands/porch/index.js.map +1 -1
- package/dist/commands/porch/state.d.ts.map +1 -1
- package/dist/commands/porch/state.js +14 -0
- package/dist/commands/porch/state.js.map +1 -1
- package/package.json +1 -1
- package/skeleton/protocols/spider/prompts/defend.md +215 -0
- package/skeleton/protocols/spider/prompts/evaluate.md +241 -0
- package/skeleton/protocols/spider/prompts/implement.md +149 -0
- package/skeleton/protocols/spider/prompts/plan.md +214 -0
- package/skeleton/protocols/spider/prompts/review.md +217 -0
- package/skeleton/protocols/spider/prompts/specify.md +167 -0
- package/skeleton/protocols/spider/protocol.json +6 -0
|
@@ -0,0 +1,149 @@
|
|
|
1
|
+
# IMPLEMENT Phase Prompt
|
|
2
|
+
|
|
3
|
+
You are executing the **IMPLEMENT** phase of the SPIDER protocol.
|
|
4
|
+
|
|
5
|
+
## Your Goal
|
|
6
|
+
|
|
7
|
+
Write clean, well-structured code that implements the current plan phase.
|
|
8
|
+
|
|
9
|
+
## Context
|
|
10
|
+
|
|
11
|
+
- **Project ID**: {{project_id}}
|
|
12
|
+
- **Project Title**: {{title}}
|
|
13
|
+
- **Current State**: {{current_state}}
|
|
14
|
+
- **Plan Phase**: {{plan_phase}} (if applicable)
|
|
15
|
+
- **Spec File**: `codev/specs/{{project_id}}-{{title}}.md`
|
|
16
|
+
- **Plan File**: `codev/plans/{{project_id}}-{{title}}.md`
|
|
17
|
+
|
|
18
|
+
## Consultation Context
|
|
19
|
+
|
|
20
|
+
**Implementation does NOT require consultation checkpoints** - that happens after Defend.
|
|
21
|
+
|
|
22
|
+
However, you should be aware:
|
|
23
|
+
- Spec and Plan have already been reviewed by GPT-5 Codex and Gemini Pro
|
|
24
|
+
- After you complete Implement + Defend, your work will be reviewed
|
|
25
|
+
- Implementation must strictly follow the approved spec and plan
|
|
26
|
+
|
|
27
|
+
## Prerequisites
|
|
28
|
+
|
|
29
|
+
Before implementing, verify:
|
|
30
|
+
1. Previous phase (if any) is committed to git
|
|
31
|
+
2. You've read the plan phase you're implementing
|
|
32
|
+
3. You understand the success criteria for this phase
|
|
33
|
+
4. Dependencies from earlier phases are available
|
|
34
|
+
|
|
35
|
+
## Process
|
|
36
|
+
|
|
37
|
+
### 1. Review the Plan Phase
|
|
38
|
+
|
|
39
|
+
Read the current phase in the plan:
|
|
40
|
+
- What is the objective?
|
|
41
|
+
- What files need to be created/modified?
|
|
42
|
+
- What are the success criteria?
|
|
43
|
+
- What dependencies exist?
|
|
44
|
+
|
|
45
|
+
### 2. Set Up
|
|
46
|
+
|
|
47
|
+
- Verify you're on the correct branch
|
|
48
|
+
- Check that previous phase is committed: `git log --oneline -5`
|
|
49
|
+
- Ensure build passes before starting: `npm run build` (or equivalent)
|
|
50
|
+
|
|
51
|
+
### 3. Implement
|
|
52
|
+
|
|
53
|
+
Write the code following these principles:
|
|
54
|
+
|
|
55
|
+
**Code Quality Standards**:
|
|
56
|
+
- Self-documenting code (clear names, obvious structure)
|
|
57
|
+
- No commented-out code
|
|
58
|
+
- No debug prints in final code
|
|
59
|
+
- Explicit error handling
|
|
60
|
+
- Follow project style guide
|
|
61
|
+
|
|
62
|
+
**Implementation Approach**:
|
|
63
|
+
- Work on one file at a time
|
|
64
|
+
- Make small, incremental changes
|
|
65
|
+
- Test as you go (manual verification is fine here)
|
|
66
|
+
- Document complex logic with comments
|
|
67
|
+
|
|
68
|
+
### 4. Self-Review
|
|
69
|
+
|
|
70
|
+
Before signaling completion:
|
|
71
|
+
- Read through all changes
|
|
72
|
+
- Check for obvious bugs
|
|
73
|
+
- Verify code matches the spec requirements
|
|
74
|
+
- Ensure no accidental debug code
|
|
75
|
+
|
|
76
|
+
### 5. Build Verification
|
|
77
|
+
|
|
78
|
+
Run build checks using **project-specific commands**:
|
|
79
|
+
|
|
80
|
+
```bash
|
|
81
|
+
# Check package.json scripts or Makefile for actual commands
|
|
82
|
+
# Common patterns:
|
|
83
|
+
npm run build # Node.js/TypeScript projects
|
|
84
|
+
npm run typecheck # TypeScript type checking
|
|
85
|
+
npm run lint # Linting (ESLint, etc.)
|
|
86
|
+
cargo build # Rust projects
|
|
87
|
+
go build ./... # Go projects
|
|
88
|
+
make build # Projects using Makefiles
|
|
89
|
+
```
|
|
90
|
+
|
|
91
|
+
**Important**: Don't assume `npm run build` exists. Check `package.json` or equivalent first.
|
|
92
|
+
|
|
93
|
+
Fix any errors before proceeding.
|
|
94
|
+
|
|
95
|
+
## Output
|
|
96
|
+
|
|
97
|
+
- Modified/created source files as specified in the plan phase
|
|
98
|
+
- All build checks passing
|
|
99
|
+
- Code ready for the Defend (testing) phase
|
|
100
|
+
|
|
101
|
+
## Signals
|
|
102
|
+
|
|
103
|
+
Emit appropriate signals based on your progress:
|
|
104
|
+
|
|
105
|
+
- After implementation is complete and builds pass:
|
|
106
|
+
```
|
|
107
|
+
<signal>PHASE_IMPLEMENTED</signal>
|
|
108
|
+
```
|
|
109
|
+
|
|
110
|
+
- If you encounter a blocker:
|
|
111
|
+
```
|
|
112
|
+
<signal>BLOCKED:reason goes here</signal>
|
|
113
|
+
```
|
|
114
|
+
|
|
115
|
+
- If you need spec/plan clarification:
|
|
116
|
+
```
|
|
117
|
+
<signal>NEEDS_CLARIFICATION:specific question</signal>
|
|
118
|
+
```
|
|
119
|
+
|
|
120
|
+
## Important Notes
|
|
121
|
+
|
|
122
|
+
1. **Follow the plan** - Implement what's specified, not more
|
|
123
|
+
2. **Don't over-engineer** - Simplest solution that works
|
|
124
|
+
3. **Don't skip error handling** - But don't go overboard either
|
|
125
|
+
4. **Keep changes focused** - Only touch files in this phase
|
|
126
|
+
5. **Build must pass** - Don't proceed if build fails
|
|
127
|
+
|
|
128
|
+
## What NOT to Do
|
|
129
|
+
|
|
130
|
+
- Don't write tests yet (that's Defend phase)
|
|
131
|
+
- Don't modify files outside this phase's scope
|
|
132
|
+
- Don't add features not in the spec
|
|
133
|
+
- Don't leave TODO comments for later (fix now or note as blocker)
|
|
134
|
+
- Don't commit yet (that happens after Defend + Evaluate)
|
|
135
|
+
- Don't use `git add .` or `git add -A` when you do commit (security risk)
|
|
136
|
+
|
|
137
|
+
## Handling Problems
|
|
138
|
+
|
|
139
|
+
**If the plan is unclear**:
|
|
140
|
+
Signal `NEEDS_CLARIFICATION` with your specific question.
|
|
141
|
+
|
|
142
|
+
**If you discover the spec is wrong**:
|
|
143
|
+
Signal `BLOCKED` and explain the issue. The Architect may need to update the spec.
|
|
144
|
+
|
|
145
|
+
**If a dependency is missing**:
|
|
146
|
+
Signal `BLOCKED` with details about what's missing.
|
|
147
|
+
|
|
148
|
+
**If build fails and you can't fix it**:
|
|
149
|
+
Signal `BLOCKED` with the error message.
|
|
@@ -0,0 +1,214 @@
|
|
|
1
|
+
# PLAN Phase Prompt
|
|
2
|
+
|
|
3
|
+
You are executing the **PLAN** phase of the SPIDER protocol.
|
|
4
|
+
|
|
5
|
+
## Your Goal
|
|
6
|
+
|
|
7
|
+
Transform the approved specification into an executable implementation plan with clear phases.
|
|
8
|
+
|
|
9
|
+
## Context
|
|
10
|
+
|
|
11
|
+
- **Project ID**: {{project_id}}
|
|
12
|
+
- **Project Title**: {{title}}
|
|
13
|
+
- **Current State**: {{current_state}}
|
|
14
|
+
- **Spec File**: `codev/specs/{{project_id}}-{{title}}.md`
|
|
15
|
+
- **Plan File**: `codev/plans/{{project_id}}-{{title}}.md`
|
|
16
|
+
|
|
17
|
+
## CRITICAL: Multi-Agent Consultation is MANDATORY
|
|
18
|
+
|
|
19
|
+
The SPIDER protocol **requires** consultation with GPT-5 Codex AND Gemini Pro at specific checkpoints. This is BLOCKING - you cannot proceed without completing consultations.
|
|
20
|
+
|
|
21
|
+
## Prerequisites
|
|
22
|
+
|
|
23
|
+
Before planning, verify:
|
|
24
|
+
1. The specification exists and has been approved
|
|
25
|
+
2. You've read and understood the entire spec
|
|
26
|
+
3. Success criteria are clear and measurable
|
|
27
|
+
|
|
28
|
+
## Process
|
|
29
|
+
|
|
30
|
+
### 1. Analyze the Specification
|
|
31
|
+
|
|
32
|
+
Read the spec thoroughly. Identify:
|
|
33
|
+
- All functional requirements
|
|
34
|
+
- Non-functional requirements
|
|
35
|
+
- Dependencies and constraints
|
|
36
|
+
- Success criteria to validate against
|
|
37
|
+
|
|
38
|
+
### 2. Identify Implementation Phases
|
|
39
|
+
|
|
40
|
+
Break the work into logical phases. Each phase should be:
|
|
41
|
+
- **Self-contained** - A complete unit of functionality
|
|
42
|
+
- **Independently testable** - Can be verified on its own
|
|
43
|
+
- **Valuable** - Delivers observable progress
|
|
44
|
+
- **Committable** - Can be a single atomic commit
|
|
45
|
+
|
|
46
|
+
Good phase examples:
|
|
47
|
+
- "Database Schema" - Creates all tables/migrations
|
|
48
|
+
- "Core API Endpoints" - Implements main REST routes
|
|
49
|
+
- "Authentication Flow" - Handles login/logout/session
|
|
50
|
+
|
|
51
|
+
Bad phase examples:
|
|
52
|
+
- "Setup" - Too vague
|
|
53
|
+
- "Part 1" - Not descriptive
|
|
54
|
+
- "Everything" - Not broken down
|
|
55
|
+
|
|
56
|
+
### 3. Define Each Phase
|
|
57
|
+
|
|
58
|
+
For each phase, document:
|
|
59
|
+
- **Objective** - Single clear goal
|
|
60
|
+
- **Files to modify/create** - Specific paths
|
|
61
|
+
- **Dependencies** - Which phases must complete first
|
|
62
|
+
- **Success criteria** - How to know it's done
|
|
63
|
+
- **Test approach** - What tests will verify it
|
|
64
|
+
|
|
65
|
+
### 4. Order Phases by Dependencies
|
|
66
|
+
|
|
67
|
+
Arrange phases so dependencies are satisfied:
|
|
68
|
+
```
|
|
69
|
+
Phase 1: Database Schema (no dependencies)
|
|
70
|
+
Phase 2: Data Models (depends on Phase 1)
|
|
71
|
+
Phase 3: API Endpoints (depends on Phase 2)
|
|
72
|
+
Phase 4: Frontend Integration (depends on Phase 3)
|
|
73
|
+
```
|
|
74
|
+
|
|
75
|
+
### 5. MANDATORY: First Consultation (After Draft)
|
|
76
|
+
|
|
77
|
+
After completing the initial plan draft:
|
|
78
|
+
|
|
79
|
+
```bash
|
|
80
|
+
# Run consultations in parallel (REQUIRED)
|
|
81
|
+
consult --model gemini plan {{project_id}} &
|
|
82
|
+
consult --model codex plan {{project_id}} &
|
|
83
|
+
wait
|
|
84
|
+
```
|
|
85
|
+
|
|
86
|
+
- Review ALL feedback from both models
|
|
87
|
+
- Update the plan with incorporated feedback
|
|
88
|
+
- Add a **Consultation Log** section documenting:
|
|
89
|
+
- Key feedback received
|
|
90
|
+
- Changes made in response
|
|
91
|
+
- Any feedback intentionally not incorporated (with reasoning)
|
|
92
|
+
|
|
93
|
+
### 6. Human Review
|
|
94
|
+
|
|
95
|
+
After consultation feedback is incorporated:
|
|
96
|
+
- Present the plan for human review
|
|
97
|
+
- Wait for approval or change requests
|
|
98
|
+
- If changes requested, make them and proceed to Step 7
|
|
99
|
+
|
|
100
|
+
### 7. MANDATORY: Second Consultation (After Human Feedback)
|
|
101
|
+
|
|
102
|
+
After incorporating human feedback:
|
|
103
|
+
|
|
104
|
+
```bash
|
|
105
|
+
# Run consultations again (REQUIRED)
|
|
106
|
+
consult --model gemini plan {{project_id}} &
|
|
107
|
+
consult --model codex plan {{project_id}} &
|
|
108
|
+
wait
|
|
109
|
+
```
|
|
110
|
+
|
|
111
|
+
- Update Consultation Log with new feedback
|
|
112
|
+
- Incorporate changes
|
|
113
|
+
- Prepare final plan for approval
|
|
114
|
+
|
|
115
|
+
## Output
|
|
116
|
+
|
|
117
|
+
Create the plan file at `codev/plans/{{project_id}}-{{title}}.md`.
|
|
118
|
+
|
|
119
|
+
Use the plan template from `codev/protocols/spider/templates/plan.md` if available.
|
|
120
|
+
|
|
121
|
+
### Plan Structure
|
|
122
|
+
|
|
123
|
+
```markdown
|
|
124
|
+
# Implementation Plan: {{title}}
|
|
125
|
+
|
|
126
|
+
## Overview
|
|
127
|
+
Brief summary of what will be implemented.
|
|
128
|
+
|
|
129
|
+
## Phases
|
|
130
|
+
|
|
131
|
+
### Phase 1: [Name]
|
|
132
|
+
- **Objective**: [Single clear goal]
|
|
133
|
+
- **Files**: [List of files to create/modify]
|
|
134
|
+
- **Dependencies**: None
|
|
135
|
+
- **Success Criteria**: [How to verify completion]
|
|
136
|
+
- **Tests**: [What tests will be written]
|
|
137
|
+
|
|
138
|
+
### Phase 2: [Name]
|
|
139
|
+
- **Objective**: [Single clear goal]
|
|
140
|
+
- **Files**: [List of files]
|
|
141
|
+
- **Dependencies**: Phase 1
|
|
142
|
+
- **Success Criteria**: [Verification method]
|
|
143
|
+
- **Tests**: [Test approach]
|
|
144
|
+
|
|
145
|
+
[Continue for all phases...]
|
|
146
|
+
|
|
147
|
+
## Risk Assessment
|
|
148
|
+
- [Risk 1]: [Mitigation]
|
|
149
|
+
- [Risk 2]: [Mitigation]
|
|
150
|
+
|
|
151
|
+
## Consultation Log
|
|
152
|
+
|
|
153
|
+
### First Consultation (After Draft)
|
|
154
|
+
- **Gemini Feedback**: [Summary]
|
|
155
|
+
- **Codex Feedback**: [Summary]
|
|
156
|
+
- **Changes Made**: [List]
|
|
157
|
+
- **Not Incorporated**: [List with reasons]
|
|
158
|
+
|
|
159
|
+
### Second Consultation (After Human Feedback)
|
|
160
|
+
- **Gemini Feedback**: [Summary]
|
|
161
|
+
- **Codex Feedback**: [Summary]
|
|
162
|
+
- **Changes Made**: [List]
|
|
163
|
+
```
|
|
164
|
+
|
|
165
|
+
## Signals
|
|
166
|
+
|
|
167
|
+
Emit appropriate signals based on your progress:
|
|
168
|
+
|
|
169
|
+
- After completing the plan draft:
|
|
170
|
+
```
|
|
171
|
+
<signal>PLAN_DRAFTED</signal>
|
|
172
|
+
```
|
|
173
|
+
|
|
174
|
+
- After incorporating consultation feedback:
|
|
175
|
+
```
|
|
176
|
+
<signal>CONSULTATION_INCORPORATED</signal>
|
|
177
|
+
```
|
|
178
|
+
|
|
179
|
+
- After final plan is ready for human approval:
|
|
180
|
+
```
|
|
181
|
+
<signal>PLAN_READY_FOR_APPROVAL</signal>
|
|
182
|
+
```
|
|
183
|
+
|
|
184
|
+
## Commit Cadence
|
|
185
|
+
|
|
186
|
+
Make commits at these milestones:
|
|
187
|
+
1. `[Spec {{project_id}}] Initial implementation plan`
|
|
188
|
+
2. `[Spec {{project_id}}] Plan with multi-agent review`
|
|
189
|
+
3. `[Spec {{project_id}}] Plan with user feedback`
|
|
190
|
+
4. `[Spec {{project_id}}] Final approved plan`
|
|
191
|
+
|
|
192
|
+
**CRITICAL**: Never use `git add .` or `git add -A`. Always stage specific files:
|
|
193
|
+
```bash
|
|
194
|
+
git add codev/plans/{{project_id}}-{{title}}.md
|
|
195
|
+
```
|
|
196
|
+
|
|
197
|
+
## Important Notes
|
|
198
|
+
|
|
199
|
+
1. **Consultation is MANDATORY** - Cannot skip GPT-5 + Gemini reviews
|
|
200
|
+
2. **No time estimates** - Don't include hours/days/weeks
|
|
201
|
+
3. **Be specific about files** - Exact paths, not "the config file"
|
|
202
|
+
4. **Keep phases small** - 1-3 files per phase is ideal
|
|
203
|
+
5. **Document dependencies clearly** - Prevents blocked work
|
|
204
|
+
6. **Document consultations** - Maintain the Consultation Log section
|
|
205
|
+
|
|
206
|
+
## What NOT to Do
|
|
207
|
+
|
|
208
|
+
- Don't skip consultations (they are BLOCKING)
|
|
209
|
+
- Don't write code (that's for Implement phase)
|
|
210
|
+
- Don't estimate time (meaningless in AI development)
|
|
211
|
+
- Don't create phases that can't be independently tested
|
|
212
|
+
- Don't skip dependency analysis
|
|
213
|
+
- Don't make phases too large (if >5 files, split it)
|
|
214
|
+
- Don't use `git add .` or `git add -A` (security risk)
|
|
@@ -0,0 +1,217 @@
|
|
|
1
|
+
# REVIEW Phase Prompt
|
|
2
|
+
|
|
3
|
+
You are executing the **REVIEW** phase of the SPIDER protocol.
|
|
4
|
+
|
|
5
|
+
## Your Goal
|
|
6
|
+
|
|
7
|
+
Perform a comprehensive review, document lessons learned, run final consultation, and prepare for PR submission.
|
|
8
|
+
|
|
9
|
+
## CRITICAL: Final Consultation Before PR
|
|
10
|
+
|
|
11
|
+
The SPIDER protocol **requires** a final consultation with GPT-5 Codex AND Gemini Pro before submitting the PR. This ensures the complete implementation is reviewed.
|
|
12
|
+
|
|
13
|
+
## Context
|
|
14
|
+
|
|
15
|
+
- **Project ID**: {{project_id}}
|
|
16
|
+
- **Project Title**: {{title}}
|
|
17
|
+
- **Current State**: {{current_state}}
|
|
18
|
+
- **Spec File**: `codev/specs/{{project_id}}-{{title}}.md`
|
|
19
|
+
- **Plan File**: `codev/plans/{{project_id}}-{{title}}.md`
|
|
20
|
+
- **Review File**: `codev/reviews/{{project_id}}-{{title}}.md`
|
|
21
|
+
|
|
22
|
+
## Prerequisites
|
|
23
|
+
|
|
24
|
+
Before review, verify:
|
|
25
|
+
1. All implementation phases are committed
|
|
26
|
+
2. All tests are passing
|
|
27
|
+
3. Build is passing
|
|
28
|
+
4. Spec compliance verified for all phases
|
|
29
|
+
|
|
30
|
+
Verify commits: `git log --oneline | grep "[Spec {{project_id}}]"`
|
|
31
|
+
|
|
32
|
+
## Process
|
|
33
|
+
|
|
34
|
+
### 1. Comprehensive Review
|
|
35
|
+
|
|
36
|
+
Review the entire implementation:
|
|
37
|
+
|
|
38
|
+
**Code Quality**:
|
|
39
|
+
- Is the code readable and maintainable?
|
|
40
|
+
- Are there any code smells?
|
|
41
|
+
- Is error handling consistent?
|
|
42
|
+
- Are there any security concerns?
|
|
43
|
+
|
|
44
|
+
**Architecture**:
|
|
45
|
+
- Does the implementation fit well with existing code?
|
|
46
|
+
- Are there any architectural concerns?
|
|
47
|
+
- Is the design scalable if needed?
|
|
48
|
+
|
|
49
|
+
**Documentation**:
|
|
50
|
+
- Is code adequately commented where needed?
|
|
51
|
+
- Are public APIs documented?
|
|
52
|
+
- Is README updated if needed?
|
|
53
|
+
|
|
54
|
+
### 2. Spec Comparison
|
|
55
|
+
|
|
56
|
+
Compare final implementation to original specification:
|
|
57
|
+
|
|
58
|
+
- What was delivered vs what was specified?
|
|
59
|
+
- Any deviations? Document why.
|
|
60
|
+
- All success criteria met?
|
|
61
|
+
|
|
62
|
+
### 3. Create Review Document
|
|
63
|
+
|
|
64
|
+
Create `codev/reviews/{{project_id}}-{{title}}.md`:
|
|
65
|
+
|
|
66
|
+
```markdown
|
|
67
|
+
# Review: {{title}}
|
|
68
|
+
|
|
69
|
+
## Summary
|
|
70
|
+
Brief description of what was implemented.
|
|
71
|
+
|
|
72
|
+
## Spec Compliance
|
|
73
|
+
- [x] Requirement 1: Implemented as specified
|
|
74
|
+
- [x] Requirement 2: Implemented with deviation (see below)
|
|
75
|
+
- [x] Requirement 3: Implemented as specified
|
|
76
|
+
|
|
77
|
+
## Deviations from Plan
|
|
78
|
+
- **Phase X**: [What changed and why]
|
|
79
|
+
|
|
80
|
+
## Lessons Learned
|
|
81
|
+
|
|
82
|
+
### What Went Well
|
|
83
|
+
- [Positive observation 1]
|
|
84
|
+
- [Positive observation 2]
|
|
85
|
+
|
|
86
|
+
### Challenges Encountered
|
|
87
|
+
- [Challenge 1]: [How it was resolved]
|
|
88
|
+
- [Challenge 2]: [How it was resolved]
|
|
89
|
+
|
|
90
|
+
### What Would Be Done Differently
|
|
91
|
+
- [Insight 1]
|
|
92
|
+
- [Insight 2]
|
|
93
|
+
|
|
94
|
+
### Methodology Improvements
|
|
95
|
+
- [Suggested improvement to SPIDER protocol]
|
|
96
|
+
- [Suggested improvement to tooling]
|
|
97
|
+
|
|
98
|
+
## Technical Debt
|
|
99
|
+
- [Any shortcuts taken that should be addressed later]
|
|
100
|
+
|
|
101
|
+
## Follow-up Items
|
|
102
|
+
- [Any items identified for future work]
|
|
103
|
+
```
|
|
104
|
+
|
|
105
|
+
### 4. Update Documentation
|
|
106
|
+
|
|
107
|
+
If needed, update:
|
|
108
|
+
- README.md (new features, changed behavior)
|
|
109
|
+
- API documentation
|
|
110
|
+
- Architecture documentation (`codev/resources/arch.md`)
|
|
111
|
+
|
|
112
|
+
### 5. Final Verification
|
|
113
|
+
|
|
114
|
+
Before PR:
|
|
115
|
+
- [ ] All tests pass (use project-specific test command)
|
|
116
|
+
- [ ] Build passes (use project-specific build command)
|
|
117
|
+
- [ ] Lint passes (if configured)
|
|
118
|
+
- [ ] No uncommitted changes: `git status`
|
|
119
|
+
- [ ] Review document complete
|
|
120
|
+
|
|
121
|
+
### 6. MANDATORY: Final Consultation (PR-Ready Review)
|
|
122
|
+
|
|
123
|
+
**Before creating the PR, run final consultation:**
|
|
124
|
+
|
|
125
|
+
```bash
|
|
126
|
+
# Run consultations in parallel (REQUIRED)
|
|
127
|
+
consult --model gemini --type pr-ready spec {{project_id}} &
|
|
128
|
+
consult --model codex --type pr-ready spec {{project_id}} &
|
|
129
|
+
wait
|
|
130
|
+
```
|
|
131
|
+
|
|
132
|
+
- Review ALL feedback from both models
|
|
133
|
+
- Address any final issues identified
|
|
134
|
+
- This is the last chance to catch problems before PR
|
|
135
|
+
|
|
136
|
+
### 7. Create Pull Request
|
|
137
|
+
|
|
138
|
+
Prepare PR with:
|
|
139
|
+
|
|
140
|
+
**Title**: `[Spec {{project_id}}] {{title}}`
|
|
141
|
+
|
|
142
|
+
**Body**:
|
|
143
|
+
```markdown
|
|
144
|
+
## Summary
|
|
145
|
+
[Brief description of the implementation]
|
|
146
|
+
|
|
147
|
+
## Changes
|
|
148
|
+
- [Change 1]
|
|
149
|
+
- [Change 2]
|
|
150
|
+
|
|
151
|
+
## Testing
|
|
152
|
+
- All unit tests passing
|
|
153
|
+
- Integration tests added for [X]
|
|
154
|
+
- Manual testing completed for [Y]
|
|
155
|
+
|
|
156
|
+
## Spec
|
|
157
|
+
Link: codev/specs/{{project_id}}-{{title}}.md
|
|
158
|
+
|
|
159
|
+
## Review
|
|
160
|
+
Link: codev/reviews/{{project_id}}-{{title}}.md
|
|
161
|
+
```
|
|
162
|
+
|
|
163
|
+
## Output
|
|
164
|
+
|
|
165
|
+
- Review document at `codev/reviews/{{project_id}}-{{title}}.md`
|
|
166
|
+
- Updated documentation (if needed)
|
|
167
|
+
- Pull request ready for submission
|
|
168
|
+
|
|
169
|
+
## Signals
|
|
170
|
+
|
|
171
|
+
Emit appropriate signals based on your progress:
|
|
172
|
+
|
|
173
|
+
- After review document is complete:
|
|
174
|
+
```
|
|
175
|
+
<signal>REVIEW_COMPLETE</signal>
|
|
176
|
+
```
|
|
177
|
+
|
|
178
|
+
- After PR is created:
|
|
179
|
+
```
|
|
180
|
+
<signal>PR_CREATED</signal>
|
|
181
|
+
```
|
|
182
|
+
|
|
183
|
+
- When ready for Architect review:
|
|
184
|
+
```
|
|
185
|
+
<signal>PR_READY</signal>
|
|
186
|
+
```
|
|
187
|
+
|
|
188
|
+
## Important Notes
|
|
189
|
+
|
|
190
|
+
1. **Final consultation is MANDATORY** - Cannot skip GPT-5 + Gemini reviews before PR
|
|
191
|
+
2. **Be honest in lessons learned** - Future you will thank present you
|
|
192
|
+
3. **Document deviations** - They're not failures, they're learnings
|
|
193
|
+
4. **Update methodology** - If you found a better way, document it
|
|
194
|
+
5. **Don't skip the checklist** - It catches last-minute issues
|
|
195
|
+
6. **Clean PR description** - Makes review easier
|
|
196
|
+
|
|
197
|
+
## What NOT to Do
|
|
198
|
+
|
|
199
|
+
- Don't skip final consultation (it's BLOCKING)
|
|
200
|
+
- Don't skip lessons learned ("nothing to report")
|
|
201
|
+
- Don't merge your own PR (Architect handles integration)
|
|
202
|
+
- Don't leave uncommitted changes
|
|
203
|
+
- Don't forget to update documentation
|
|
204
|
+
- Don't rush this phase - it's valuable for learning
|
|
205
|
+
- Don't use `git add .` or `git add -A` (security risk)
|
|
206
|
+
|
|
207
|
+
## Review Prompts for Reflection
|
|
208
|
+
|
|
209
|
+
Ask yourself:
|
|
210
|
+
- What surprised me during implementation?
|
|
211
|
+
- Where did I spend the most time? Was it avoidable?
|
|
212
|
+
- What would have helped me go faster?
|
|
213
|
+
- Did the spec adequately describe what was needed?
|
|
214
|
+
- Did the plan phases make sense in hindsight?
|
|
215
|
+
- What tests caught issues? What tests were unnecessary?
|
|
216
|
+
|
|
217
|
+
Capture these reflections in the lessons learned section.
|