@cluesmith/codev 1.5.9 → 1.5.11

package/templates/dashboard/js/activity.js

@@ -51,143 +51,17 @@ async function renderActivityTab() {
 }
 
 // Render activity tab content
+// Uses shared renderActivityContentHtml from utils.js (Maintenance Run 0004)
 function renderActivityTabContent(data) {
   const content = document.getElementById('tab-content');
-
-  if (data.commits.length === 0 && data.prs.length === 0 && data.builders.length === 0) {
-    content.innerHTML = `
-      <div class="activity-tab-container">
-        <div class="activity-empty">
-          <p>No activity recorded today</p>
-          <p style="font-size: 12px; margin-top: 8px;">Make some commits or create PRs to see your daily summary!</p>
-        </div>
-      </div>
-    `;
-    return;
-  }
-
-  const hours = Math.floor(data.timeTracking.activeMinutes / 60);
-  const mins = data.timeTracking.activeMinutes % 60;
-  const uniqueBranches = new Set(data.commits.map(c => c.branch)).size;
-  const mergedPrs = data.prs.filter(p => p.state === 'MERGED').length;
-
-  const formatTime = (isoString) => {
-    if (!isoString) return '--';
-    const date = new Date(isoString);
-    return date.toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' });
-  };
-
-  let html = '<div class="activity-tab-container"><div class="activity-summary">';
-
-  if (data.aiSummary) {
-    html += `<div class="activity-ai-summary">${escapeHtml(data.aiSummary)}</div>`;
-  }
-
-  html += `
-    <div class="activity-section">
-      <h4>Activity</h4>
-      <ul>
-        <li>${data.commits.length} commits across ${uniqueBranches} branch${uniqueBranches !== 1 ? 'es' : ''}</li>
-        <li>${data.files.length} files modified</li>
-        <li>${data.prs.length} PR${data.prs.length !== 1 ? 's' : ''} created${mergedPrs > 0 ? `, ${mergedPrs} merged` : ''}</li>
-      </ul>
-    </div>
-  `;
-
-  if (data.projectChanges && data.projectChanges.length > 0) {
-    html += `
-      <div class="activity-section">
-        <h4>Projects Touched</h4>
-        <ul>
-          ${data.projectChanges.map(p => `<li>${escapeHtml(p.id)}: ${escapeHtml(p.title)} (${escapeHtml(p.oldStatus)} → ${escapeHtml(p.newStatus)})</li>`).join('')}
-        </ul>
-      </div>
-    `;
-  }
-
-  html += `
-    <div class="activity-section">
-      <h4>Time</h4>
-      <p><span class="activity-time-value">~${hours}h ${mins}m</span> active time</p>
-      <p>First activity: ${formatTime(data.timeTracking.firstActivity)}</p>
-      <p>Last activity: ${formatTime(data.timeTracking.lastActivity)}</p>
-    </div>
-  `;
-
-  html += `
-    <div class="activity-actions">
-      <button class="btn" onclick="copyActivityToClipboard()">Copy to Clipboard</button>
-    </div>
-  `;
-
-  html += '</div></div>';
-  content.innerHTML = html;
+  content.innerHTML = renderActivityContentHtml(data, { isTab: true });
 }
 
 // Render activity summary content (for modal)
+// Uses shared renderActivityContentHtml from utils.js (Maintenance Run 0004)
 function renderActivitySummary(data) {
   const content = document.getElementById('activity-content');
-
-  if (data.commits.length === 0 && data.prs.length === 0 && data.builders.length === 0) {
-    content.innerHTML = `
-      <div class="activity-empty">
-        <p>No activity recorded today</p>
-        <p style="font-size: 12px; margin-top: 8px;">Make some commits or create PRs to see your daily summary!</p>
-      </div>
-    `;
-    return;
-  }
-
-  const hours = Math.floor(data.timeTracking.activeMinutes / 60);
-  const mins = data.timeTracking.activeMinutes % 60;
-  const uniqueBranches = new Set(data.commits.map(c => c.branch)).size;
-  const mergedPrs = data.prs.filter(p => p.state === 'MERGED').length;
-
-  const formatTime = (isoString) => {
-    if (!isoString) return '--';
-    const date = new Date(isoString);
-    return date.toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' });
-  };
-
-  let html = '<div class="activity-summary">';
-
-  if (data.aiSummary) {
-    html += `<div class="activity-ai-summary">${escapeHtml(data.aiSummary)}</div>`;
-  }
-
-  html += `
-    <div class="activity-section">
-      <h4>Activity</h4>
-      <ul>
-        <li>${data.commits.length} commits across ${uniqueBranches} branch${uniqueBranches !== 1 ? 'es' : ''}</li>
-        <li>${data.files.length} files modified</li>
-        <li>${data.prs.length} PR${data.prs.length !== 1 ? 's' : ''} created${mergedPrs > 0 ? `, ${mergedPrs} merged` : ''}</li>
-      </ul>
-    </div>
-  `;
-
-  if (data.projectChanges && data.projectChanges.length > 0) {
-    html += `
-      <div class="activity-section">
-        <h4>Projects Touched</h4>
-        <ul>
-          ${data.projectChanges.map(p => `<li>${escapeHtml(p.id)}: ${escapeHtml(p.title)} (${escapeHtml(p.oldStatus)} → ${escapeHtml(p.newStatus)})</li>`).join('')}
-        </ul>
-      </div>
-    `;
-  }
-
-  html += `
-    <div class="activity-section">
-      <h4>Time</h4>
-      <p><span class="activity-time-value">~${hours}h ${mins}m</span> active time</p>
-      <p>First activity: ${formatTime(data.timeTracking.firstActivity)}</p>
-      <p>Last activity: ${formatTime(data.timeTracking.lastActivity)}</p>
-    </div>
-  `;
-
-  html += '</div>';
-  content.innerHTML = html;
+  content.innerHTML = renderActivityContentHtml(data, { isTab: false });
 }
 
 // Close activity modal

package/templates/dashboard/js/dialogs.js

@@ -108,38 +108,9 @@ function hideContextMenu() {
 }
 
 // Handle keyboard navigation in context menu
+// Uses shared handleMenuKeydown from utils.js (Maintenance Run 0004)
 function handleContextMenuKeydown(event) {
-  const menu = document.getElementById('context-menu');
-  const items = Array.from(menu.querySelectorAll('.context-menu-item'));
-  const currentIndex = items.findIndex(item => item === document.activeElement);
-
-  switch (event.key) {
-    case 'ArrowDown':
-      event.preventDefault();
-      const nextIndex = currentIndex < items.length - 1 ? currentIndex + 1 : 0;
-      items[nextIndex].focus();
-      break;
-    case 'ArrowUp':
-      event.preventDefault();
-      const prevIndex = currentIndex > 0 ? currentIndex - 1 : items.length - 1;
-      items[prevIndex].focus();
-      break;
-    case 'Enter':
-    case ' ':
-      event.preventDefault();
-      const actionName = event.target.dataset.action;
-      if (actionName && typeof window[actionName] === 'function') {
-        window[actionName]();
-      }
-      break;
-    case 'Escape':
-      event.preventDefault();
-      hideContextMenu();
-      break;
-    case 'Tab':
-      hideContextMenu();
-      break;
-  }
+  handleMenuKeydown(event, 'context-menu', 'context-menu-item', hideContextMenu);
 }
 
 function closeActiveTab() {
@@ -186,27 +157,11 @@ function setFilePath(path) {
   document.getElementById('file-path-input').focus();
 }
 
+// Uses shared openFileTab from utils.js (Maintenance Run 0004)
 async function openFile() {
   const path = document.getElementById('file-path-input').value.trim();
   if (!path) return;
-
-  try {
-    const response = await fetch('/api/tabs/file', {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify({ path })
-    });
-
-    if (!response.ok) {
-      throw new Error(await response.text());
-    }
-
-    hideFileDialog();
-    await refresh();
-    showToast(`Opened ${path}`, 'success');
-  } catch (err) {
-    showToast('Failed to open file: ' + err.message, 'error');
-  }
+  await openFileTab(path, { onSuccess: hideFileDialog });
 }
 
 // Spawn worktree builder

package/templates/dashboard/js/files.js

@@ -181,36 +181,9 @@ async function refreshFilesTree() {
 }
 
 // Open file from tree click
+// Uses shared openFileTab from utils.js (Maintenance Run 0004)
 async function openFileFromTree(filePath) {
-  try {
-    const existingTab = tabs.find(t => t.type === 'file' && t.path === filePath);
-    if (existingTab) {
-      selectTab(existingTab.id);
-      refreshFileTab(existingTab.id);
-      return;
-    }
-
-    const response = await fetch('/api/tabs/file', {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify({ path: filePath })
-    });
-
-    if (!response.ok) {
-      throw new Error(await response.text());
-    }
-
-    await refresh();
-
-    const newTab = tabs.find(t => t.type === 'file' && t.path === filePath);
-    if (newTab) {
-      selectTab(newTab.id);
-    }
-
-    showToast(`Opened ${getFileName(filePath)}`, 'success');
-  } catch (err) {
-    showToast('Failed to open file: ' + err.message, 'error');
-  }
+  await openFileTab(filePath, { showSwitchToast: false });
 }
 
 // ========================================

package/templates/dashboard/js/main.js

@@ -26,38 +26,9 @@ function setupBroadcastChannel() {
 }
 
 // Open a file from a BroadcastChannel message
+// Uses shared openFileTab from utils.js (Maintenance Run 0004)
 async function openFileFromMessage(filePath, lineNumber) {
-  try {
-    const existingTab = tabs.find(t => t.type === 'file' && t.path === filePath);
-    if (existingTab) {
-      selectTab(existingTab.id);
-      refreshFileTab(existingTab.id);
-      showToast(`Switched to ${getFileName(filePath)}`, 'success');
-      return;
-    }
-
-    const response = await fetch('/api/tabs/file', {
-      method: 'POST',
-      headers: { 'Content-Type': 'application/json' },
-      body: JSON.stringify({ path: filePath })
-    });
-
-    if (!response.ok) {
-      throw new Error(await response.text());
-    }
-
-    const result = await response.json();
-    await refresh();
-
-    const newTab = tabs.find(t => t.type === 'file' && (t.path === filePath || t.annotationId === result.id));
-    if (newTab) {
-      selectTab(newTab.id);
-    }
-
-    showToast(`Opened ${getFileName(filePath)}${lineNumber ? ':' + lineNumber : ''}`, 'success');
-  } catch (err) {
-    showToast('Failed to open file: ' + err.message, 'error');
-  }
+  await openFileTab(filePath, { lineNumber });
 }
 
 // Refresh state from API

package/templates/dashboard/js/tabs.js

@@ -31,7 +31,7 @@ function getTerminalUrl(tab) {
 
   // File/annotation tabs - use the annotation ID for proxy routing
   if (tab.type === 'file' && tab.annotationId) {
-    return `/annotation/${tab.annotationId}`;
+    return `/annotation/${tab.annotationId}/`;
   }
 
   // Fallback for backward compatibility
@@ -494,36 +494,12 @@ function openInNewTabFromMenu(tabId) {
 }
 
 // Handle keyboard navigation in overflow menu
+// Uses shared handleMenuKeydown from utils.js (Maintenance Run 0004)
 function handleOverflowMenuKeydown(event, tabId) {
-  const menu = document.getElementById('overflow-menu');
-  const items = Array.from(menu.querySelectorAll('.overflow-menu-item'));
-  const currentIndex = items.findIndex(item => item === document.activeElement);
-
-  switch (event.key) {
-    case 'ArrowDown':
-      event.preventDefault();
-      const nextIndex = currentIndex < items.length - 1 ? currentIndex + 1 : 0;
-      items[nextIndex].focus();
-      break;
-    case 'ArrowUp':
-      event.preventDefault();
-      const prevIndex = currentIndex > 0 ? currentIndex - 1 : items.length - 1;
-      items[prevIndex].focus();
-      break;
-    case 'Enter':
-    case ' ':
-      event.preventDefault();
-      selectTabFromMenu(tabId);
-      break;
-    case 'Escape':
-      event.preventDefault();
-      hideOverflowMenu();
-      document.getElementById('overflow-btn').focus();
-      break;
-    case 'Tab':
-      hideOverflowMenu();
-      break;
-  }
+  handleMenuKeydown(event, 'overflow-menu', 'overflow-menu-item', hideOverflowMenu, {
+    onEnter: () => selectTabFromMenu(tabId),
+    focusOnEscape: 'overflow-btn'
+  });
 }
 
 // Open tab content in a new browser tab

package/templates/dashboard/js/utils.js

@@ -55,3 +55,202 @@ function showToast(message, type = 'info') {
     toast.remove();
   }, 3000);
 }
+
+// ========================================
+// Shared Utilities (Maintenance Run 0004)
+// ========================================
+
+/**
+ * Open a file in a new tab (or switch to existing)
+ * Consolidates duplicate code from main.js, files.js, dialogs.js
+ *
+ * @param {string} filePath - Path to the file to open
+ * @param {Object} options - Optional settings
+ * @param {number} options.lineNumber - Line number to show in toast
+ * @param {boolean} options.showSwitchToast - Show toast when switching to existing tab
+ * @param {Function} options.onSuccess - Callback after successful open
+ */
+async function openFileTab(filePath, options = {}) {
+  const { lineNumber, showSwitchToast = true, onSuccess } = options;
+
+  try {
+    // Check for existing tab
+    const existingTab = tabs.find(t => t.type === 'file' && t.path === filePath);
+    if (existingTab) {
+      selectTab(existingTab.id);
+      refreshFileTab(existingTab.id);
+      if (showSwitchToast) {
+        showToast(`Switched to ${getFileName(filePath)}`, 'success');
+      }
+      if (onSuccess) onSuccess();
+      return;
+    }
+
+    // Create new tab
+    const response = await fetch('/api/tabs/file', {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json' },
+      body: JSON.stringify({ path: filePath })
+    });
+
+    if (!response.ok) {
+      throw new Error(await response.text());
+    }
+
+    const result = await response.json();
+    await refresh();
+
+    // Select the new tab
+    const newTab = tabs.find(t => t.type === 'file' && (t.path === filePath || t.annotationId === result.id));
+    if (newTab) {
+      selectTab(newTab.id);
+    }
+
+    const lineInfo = lineNumber ? `:${lineNumber}` : '';
+    showToast(`Opened ${getFileName(filePath)}${lineInfo}`, 'success');
+    if (onSuccess) onSuccess();
+  } catch (err) {
+    showToast('Failed to open file: ' + err.message, 'error');
+  }
+}
+
+/**
+ * Handle keyboard navigation in dropdown menus
+ * Consolidates duplicate code from dialogs.js and tabs.js
+ *
+ * @param {KeyboardEvent} event - The keyboard event
+ * @param {string} menuId - ID of the menu element
+ * @param {string} itemClass - CSS class of menu items
+ * @param {Function} hideFunction - Function to hide the menu
+ * @param {Object} options - Optional settings
+ * @param {Function} options.onEnter - Custom handler for Enter/Space (default: call data-action)
+ * @param {string} options.focusOnEscape - Element ID to focus after Escape
+ */
+function handleMenuKeydown(event, menuId, itemClass, hideFunction, options = {}) {
+  const { onEnter, focusOnEscape } = options;
+  const menu = document.getElementById(menuId);
+  const items = Array.from(menu.querySelectorAll(`.${itemClass}`));
+  const currentIndex = items.findIndex(item => item === document.activeElement);
+
+  switch (event.key) {
+    case 'ArrowDown':
+      event.preventDefault();
+      const nextIndex = currentIndex < items.length - 1 ? currentIndex + 1 : 0;
+      items[nextIndex].focus();
+      break;
+    case 'ArrowUp':
+      event.preventDefault();
+      const prevIndex = currentIndex > 0 ? currentIndex - 1 : items.length - 1;
+      items[prevIndex].focus();
+      break;
+    case 'Enter':
+    case ' ':
+      event.preventDefault();
+      if (onEnter) {
+        onEnter(event);
+      } else {
+        const actionName = event.target.dataset.action;
+        if (actionName && typeof window[actionName] === 'function') {
+          window[actionName]();
+        }
+      }
+      break;
+    case 'Escape':
+      event.preventDefault();
+      hideFunction();
+      if (focusOnEscape) {
+        document.getElementById(focusOnEscape).focus();
+      }
+      break;
+    case 'Tab':
+      hideFunction();
+      break;
+  }
+}
+
+/**
+ * Format ISO time string for display
+ * Used by activity rendering
+ */
+function formatActivityTime(isoString) {
+  if (!isoString) return '--';
+  const date = new Date(isoString);
+  return date.toLocaleTimeString([], { hour: '2-digit', minute: '2-digit' });
+}
+
+/**
+ * Render activity summary content
+ * Consolidates duplicate code from renderActivityTabContent and renderActivitySummary
+ *
+ * @param {Object} data - Activity data
+ * @param {Object} options - Render options
+ * @param {boolean} options.isTab - Whether rendering for tab (includes wrapper and copy button)
+ * @returns {string} HTML content
+ */
+function renderActivityContentHtml(data, options = {}) {
+  const { isTab = false } = options;
+
+  if (data.commits.length === 0 && data.prs.length === 0 && data.builders.length === 0) {
+    return `
+      <div class="activity-empty">
+        <p>No activity recorded today</p>
+        <p style="font-size: 12px; margin-top: 8px;">Make some commits or create PRs to see your daily summary!</p>
+      </div>
+    `;
+  }
+
+  const hours = Math.floor(data.timeTracking.activeMinutes / 60);
+  const mins = data.timeTracking.activeMinutes % 60;
+  const uniqueBranches = new Set(data.commits.map(c => c.branch)).size;
+  const mergedPrs = data.prs.filter(p => p.state === 'MERGED').length;
+
+  let html = isTab ? '<div class="activity-tab-container"><div class="activity-summary">' : '<div class="activity-summary">';
+
+  if (data.aiSummary) {
+    html += `<div class="activity-ai-summary">${escapeHtml(data.aiSummary)}</div>`;
+  }
+
+  html += `
+    <div class="activity-section">
+      <h4>Activity</h4>
+      <ul>
+        <li>${data.commits.length} commits across ${uniqueBranches} branch${uniqueBranches !== 1 ? 'es' : ''}</li>
+        <li>${data.files.length} files modified</li>
+        <li>${data.prs.length} PR${data.prs.length !== 1 ? 's' : ''} created${mergedPrs > 0 ? `, ${mergedPrs} merged` : ''}</li>
+      </ul>
+    </div>
+  `;
+
+  if (data.projectChanges && data.projectChanges.length > 0) {
+    html += `
+      <div class="activity-section">
+        <h4>Projects Touched</h4>
+        <ul>
+          ${data.projectChanges.map(p => `<li>${escapeHtml(p.id)}: ${escapeHtml(p.title)} (${escapeHtml(p.oldStatus)} → ${escapeHtml(p.newStatus)})</li>`).join('')}
+        </ul>
+      </div>
+    `;
+  }
+
+  html += `
+    <div class="activity-section">
+      <h4>Time</h4>
+      <p><span class="activity-time-value">~${hours}h ${mins}m</span> active time</p>
+      <p>First activity: ${formatActivityTime(data.timeTracking.firstActivity)}</p>
+      <p>Last activity: ${formatActivityTime(data.timeTracking.lastActivity)}</p>
+    </div>
+  `;
+
+  if (isTab) {
+    html += `
+      <div class="activity-actions">
+        <button class="btn" onclick="copyActivityToClipboard()">Copy to Clipboard</button>
+      </div>
+    `;
+    html += '</div></div>';
+  } else {
+    html += '</div>';
+  }
+
+  return html;
+}

package/templates/open.html

@@ -622,7 +622,7 @@
       };
 
       // Add cache-busting query param to allow reload
-      img.src = '/api/image?t=' + Date.now();
+      img.src = 'api/image?t=' + Date.now();
     }
 
     // Initialize video viewer
@@ -656,7 +656,7 @@
       };
 
       // Add cache-busting query param to allow reload
-      video.src = '/api/video?t=' + Date.now();
+      video.src = 'api/video?t=' + Date.now();
     }
 
     // Update image info display (in both header and controls)
@@ -1245,7 +1245,7 @@
 
     async function saveFile() {
       try {
-        const response = await fetch('/save', {
+        const response = await fetch('save', {
           method: 'POST',
           headers: { 'Content-Type': 'application/json' },
           body: JSON.stringify({
@@ -1348,7 +1348,7 @@
       const content = editor.value;
 
       try {
-        const response = await fetch('/save', {
+        const response = await fetch('save', {
           method: 'POST',
           headers: { 'Content-Type': 'application/json' },
           body: JSON.stringify({ file: filePath, content })
@@ -1670,7 +1670,7 @@
       if (hasUnsavedChanges || editMode) return;
 
       try {
-        const res = await fetch('/api/mtime');
+        const res = await fetch('api/mtime');
         if (res.ok) {
           const data = await res.json();
           if (lastMtime === null) {
@@ -1689,21 +1689,21 @@
       // For images and videos, just reload the source
       if (isImageFile) {
         const img = document.getElementById('image-display');
-        img.src = '/api/image?t=' + Date.now();
+        img.src = 'api/image?t=' + Date.now();
         showNotification('Image reloaded');
         return;
       }
 
       if (isVideoFile) {
         const video = document.getElementById('video-display');
-        video.src = '/api/video?t=' + Date.now();
+        video.src = 'api/video?t=' + Date.now();
         showNotification('Video reloaded');
         return;
       }
 
       // For text files, fetch new content
       try {
-        const res = await fetch('/file');
+        const res = await fetch('file');
         if (res.ok) {
           const content = await res.text();
           currentContent = content;