@clue-ai/cli 0.0.9 → 0.0.11

package/src/lifecycle-guard.mjs

@@ -1,134 +1,197 @@
 const LIFECYCLE_CALL_PATTERN =
-	/\b(ClueInit|ClueIdentify|ClueSetAccount|ClueLogout)\s*\(/g;
-const SAFE_HELPER_PATTERN =
-	/\b(?:safeClue|safe_clue|safe_clue_call|safeClueCall|withClueGuard|with_clue_guard)\s*\(/g;
+	/\b(ClueInit|ClueIdentify|ClueSetAccount|ClueLogout|clue_init_fastapi|clue_init_django)\s*\(/g;
 
-const findMatchingDelimiter = (text, openIndex, open, close) => {
-	let depth = 0;
-	for (let index = openIndex; index < text.length; index += 1) {
-		const character = text[index];
-		if (character === open) depth += 1;
-		if (character === close) {
-			depth -= 1;
-			if (depth === 0) return index;
+export const stripSourceNoise = (text, { stripStrings = false } = {}) => {
+	let output = "";
+	let index = 0;
+	while (index < text.length) {
+		const char = text[index];
+		const next = text[index + 1];
+		if (char === "/" && next === "/") {
+			while (index < text.length && text[index] !== "\n") index += 1;
+			continue;
+		}
+		if (char === "#") {
+			while (index < text.length && text[index] !== "\n") index += 1;
+			continue;
 		}
+		if (char === "/" && next === "*") {
+			index += 2;
+			while (
+				index < text.length &&
+				!(text[index] === "*" && text[index + 1] === "/")
+			) {
+				if (text[index] === "\n") output += "\n";
+				index += 1;
+			}
+			index += index < text.length ? 2 : 0;
+			continue;
+		}
+		if (char === "'" || char === '"' || char === "`") {
+			const quote = char;
+			const triple =
+				quote !== "`" && text.slice(index, index + 3) === quote.repeat(3);
+			const endToken = triple ? quote.repeat(3) : quote;
+			if (!stripStrings) {
+				output += triple ? endToken : quote;
+			} else {
+				output += quote === "`" ? "``" : `${quote}${quote}`;
+			}
+			index += triple ? 3 : 1;
+			while (index < text.length) {
+				if (!triple && text[index] === "\\") {
+					if (!stripStrings) output += text.slice(index, index + 2);
+					index += 2;
+					continue;
+				}
+				if (text.slice(index, index + endToken.length) === endToken) {
+					if (!stripStrings) output += endToken;
+					index += endToken.length;
+					break;
+				}
+				if (text[index] === "\n") output += "\n";
+				if (!stripStrings && text[index] !== "\n") output += text[index];
+				index += 1;
+			}
+			continue;
+		}
+		output += char;
+		index += 1;
 	}
-	return -1;
+	return output;
 };
 
-const lineNumberForIndex = (text, index) =>
-	text.slice(0, index).split("\n").length;
+const isIdentifierCharacter = (character) =>
+	typeof character === "string" && /[A-Za-z0-9_$]/.test(character);
 
-const isAwaitedOnCallLine = (text, callIndex) => {
-	const lineStart = text.lastIndexOf("\n", callIndex - 1) + 1;
-	return /\bawait\b/.test(text.slice(lineStart, callIndex));
-};
+const startsKeyword = (text, index, keyword) =>
+	text.startsWith(keyword, index) &&
+	!isIdentifierCharacter(text[index - 1]) &&
+	!isIdentifierCharacter(text[index + keyword.length]);
 
-const isInsideSafeHelperCall = (text, callIndex) => {
-	for (const match of text.matchAll(SAFE_HELPER_PATTERN)) {
-		const helperIndex = match.index ?? 0;
-		if (helperIndex > callIndex) return false;
-		const openParenIndex = text.indexOf("(", helperIndex);
-		const closeParenIndex = findMatchingDelimiter(
-			text,
-			openParenIndex,
-			"(",
-			")",
-		);
-		if (openParenIndex < callIndex && callIndex < closeParenIndex) return true;
+const advanceQuotedString = (text, startIndex, { preserve = false } = {}) => {
+	const quote = text[startIndex];
+	const triple = quote !== "`" && text.slice(startIndex, startIndex + 3) === quote.repeat(3);
+	const endToken = triple ? quote.repeat(3) : quote;
+	let index = startIndex + (triple ? 3 : 1);
+	let value = preserve ? (triple ? endToken : quote) : "";
+	while (index < text.length) {
+		if (!triple && text[index] === "\\") {
+			if (preserve) value += text.slice(index, index + 2);
+			index += 2;
+			continue;
+		}
+		if (text.slice(index, index + endToken.length) === endToken) {
+			if (preserve) value += endToken;
+			index += endToken.length;
+			break;
+		}
+		if (preserve) value += text[index];
+		index += 1;
 	}
-	return false;
+	return { index, value };
 };
 
-const isInsideJsTryBlock = (text, callIndex) => {
-	for (const match of text.matchAll(/\btry\s*{/g)) {
-		const tryIndex = match.index ?? 0;
-		if (tryIndex > callIndex) return false;
-		const openBraceIndex = text.indexOf("{", tryIndex);
-		const closeBraceIndex = findMatchingDelimiter(
-			text,
-			openBraceIndex,
-			"{",
-			"}",
-		);
-		if (openBraceIndex < callIndex && callIndex < closeBraceIndex) return true;
+export const extractExecutableModuleStatements = (text) => {
+	const statements = [];
+	let index = 0;
+	while (index < text.length) {
+		const char = text[index];
+		const next = text[index + 1];
+		if (char === "/" && next === "/") {
+			while (index < text.length && text[index] !== "\n") index += 1;
+			continue;
+		}
+		if (char === "#") {
+			while (index < text.length && text[index] !== "\n") index += 1;
+			continue;
+		}
+		if (char === "/" && next === "*") {
+			index += 2;
+			while (
+				index < text.length &&
+				!(text[index] === "*" && text[index + 1] === "/")
+			) {
+				index += 1;
+			}
+			index += index < text.length ? 2 : 0;
+			continue;
+		}
+		if (char === "'" || char === '"' || char === "`") {
+			index = advanceQuotedString(text, index).index;
+			continue;
+		}
+		if (!startsKeyword(text, index, "import") && !startsKeyword(text, index, "export")) {
+			index += 1;
+			continue;
+		}
+		let statement = "";
+		let depth = 0;
+		while (index < text.length) {
+			const current = text[index];
+			const following = text[index + 1];
+			if (current === "/" && following === "/") {
+				while (index < text.length && text[index] !== "\n") index += 1;
+				continue;
+			}
+			if (current === "/" && following === "*") {
+				index += 2;
+				while (
+					index < text.length &&
+					!(text[index] === "*" && text[index + 1] === "/")
+				) {
+					index += 1;
+				}
+				index += index < text.length ? 2 : 0;
+				continue;
+			}
+			if (current === "'" || current === '"' || current === "`") {
+				const quoted = advanceQuotedString(text, index, { preserve: true });
+				statement += quoted.value;
+				index = quoted.index;
+				continue;
+			}
+			statement += current;
+			if (current === "{" || current === "(" || current === "[") depth += 1;
+			if (current === "}" || current === ")" || current === "]") {
+				depth = Math.max(0, depth - 1);
+			}
+			index += 1;
+			if (current === ";" && depth === 0) break;
+			if (current === "\n" && depth === 0) break;
+		}
+		const trimmed = statement.trim();
+		if (trimmed) statements.push(trimmed);
 	}
-	return false;
+	return statements;
 };
 
-const buildLines = (text) => {
-	const lines = [];
-	let start = 0;
-	for (const line of text.split("\n")) {
-		const indent = line.match(/^\s*/)?.[0].length ?? 0;
-		lines.push({
-			start,
-			end: start + line.length,
-			indent,
-			text: line,
-		});
-		start += line.length + 1;
-	}
-	return lines;
-};
+const lineNumberForIndex = (text, index) =>
+	text.slice(0, index).split("\n").length;
 
-const isInsidePythonTryBlock = (text, callIndex) => {
-	const lines = buildLines(text);
-	const callLineIndex = lines.findIndex(
-		(line) => line.start <= callIndex && callIndex <= line.end,
-	);
-	if (callLineIndex < 0) return false;
-	const callLine = lines[callLineIndex];
-	for (let index = callLineIndex - 1; index >= 0; index -= 1) {
-		const candidate = lines[index];
-		if (!candidate.text.trim()) continue;
-		if (!/^\s*try\s*:\s*(?:#.*)?$/.test(candidate.text)) continue;
-		if (candidate.indent >= callLine.indent) continue;
-		const escaped = lines
-			.slice(index + 1, callLineIndex)
-			.some(
-				(line) =>
-					line.text.trim() &&
-					line.indent <= candidate.indent &&
-					!/^\s*(?:except|finally|else)\b/.test(line.text),
-			);
-		if (!escaped) return true;
-	}
-	return false;
+const isAwaitedOnCallLine = (text, callIndex) => {
+	const lineStart = text.lastIndexOf("\n", callIndex - 1) + 1;
+	return /\bawait\b/.test(text.slice(lineStart, callIndex));
 };
 
-const hasCatchHandlerOnCall = (text, callIndex) => {
-	const openParenIndex = text.indexOf("(", callIndex);
-	const closeParenIndex = findMatchingDelimiter(text, openParenIndex, "(", ")");
-	if (closeParenIndex < 0) return false;
-	return /^\s*\.catch\s*\(/.test(text.slice(closeParenIndex + 1));
+const canonicalLifecycleApiName = (apiName) => {
+	if (apiName === "clue_init_fastapi" || apiName === "clue_init_django") {
+		return "ClueInit";
+	}
+	return apiName;
 };
 
-const isGuardedLifecycleCall = (text, callIndex) =>
-	hasCatchHandlerOnCall(text, callIndex) ||
-	isInsideSafeHelperCall(text, callIndex) ||
-	isInsideJsTryBlock(text, callIndex) ||
-	isInsidePythonTryBlock(text, callIndex);
-
 export const findLifecycleGuardViolations = (text) => {
 	const violations = [];
 	for (const match of text.matchAll(LIFECYCLE_CALL_PATTERN)) {
 		const callIndex = match.index ?? 0;
-		const apiName = match[1];
+		const apiName = canonicalLifecycleApiName(match[1]);
 		if (isAwaitedOnCallLine(text, callIndex)) {
 			violations.push({
 				api_name: apiName,
 				line: lineNumberForIndex(text, callIndex),
 				reason: "awaited_lifecycle_call",
 			});
-			continue;
-		}
-		if (!isGuardedLifecycleCall(text, callIndex)) {
-			violations.push({
-				api_name: apiName,
-				line: lineNumberForIndex(text, callIndex),
-				reason: "unguarded_lifecycle_call",
-			});
 		}
 	}
 	return violations;
@@ -136,6 +199,8 @@ export const findLifecycleGuardViolations = (text) => {
 
 export const findLifecycleCallApiNames = (text) => [
 	...new Set(
-		[...text.matchAll(LIFECYCLE_CALL_PATTERN)].map((match) => match[1]),
+		[...text.matchAll(LIFECYCLE_CALL_PATTERN)].map((match) =>
+			canonicalLifecycleApiName(match[1]),
+		),
 	),
 ];