@cloverleaf/reference-impl 0.8.3 → 0.8.5

package/VERSION

@@ -1 +1 @@
-0.8.3
+0.8.5

package/dist/discovery-config.mjs

@@ -5,7 +5,15 @@ const here = dirname(fileURLToPath(import.meta.url));
 const PACKAGE_DEFAULT = join(here, '..', 'config', 'discovery.json');
 export function loadDiscoveryConfig(repoRoot) {
     const override = join(repoRoot, '.cloverleaf', 'config', 'discovery.json');
-    const fallback = JSON.parse(readFileSync(PACKAGE_DEFAULT, 'utf-8'));
+    const rawFallback = JSON.parse(readFileSync(PACKAGE_DEFAULT, 'utf-8'));
+    const fallback = {
+        docContextUri: typeof rawFallback.docContextUri === 'string' ? rawFallback.docContextUri : '',
+        projectId: typeof rawFallback.projectId === 'string' ? rawFallback.projectId : '',
+        idStart: typeof rawFallback.idStart === 'number' ? rawFallback.idStart : 1,
+        prep_copy_dirs: Array.isArray(rawFallback.prep_copy_dirs)
+            ? rawFallback.prep_copy_dirs.filter((p) => typeof p === 'string')
+            : [],
+    };
     if (existsSync(override)) {
         try {
             const doc = JSON.parse(readFileSync(override, 'utf-8'));
@@ -22,5 +30,8 @@ function normalise(doc, fallback) {
         docContextUri: typeof doc.docContextUri === 'string' ? doc.docContextUri : fallback.docContextUri,
         projectId: typeof doc.projectId === 'string' ? doc.projectId : fallback.projectId,
         idStart: typeof doc.idStart === 'number' ? doc.idStart : fallback.idStart,
+        prep_copy_dirs: Array.isArray(doc.prep_copy_dirs)
+            ? doc.prep_copy_dirs.filter((p) => typeof p === 'string')
+            : fallback.prep_copy_dirs,
     };
 }

package/dist/prep-worktree.mjs

@@ -1,6 +1,7 @@
 import { cpSync, existsSync, rmSync } from 'node:fs';
 import { execSync } from 'node:child_process';
 import { join, dirname } from 'node:path';
+import { loadDiscoveryConfig } from './discovery-config.mjs';
 /**
  * Prepare a freshly-created git worktree of the cloverleaf monorepo for running reference-impl
  * tests. Addresses the v0.5 dogfood finding (CLV-16, CLV-17 Delivery runs) where Reviewer/QA
@@ -116,6 +117,19 @@ export function prepWorktree(mainRoot, worktreePath) {
     primeCopy(mainStandardNm, wtStandardNm);
     primeCopy(mainRefImplNm, wtRefImplNm);
     primeCopy(join(resolvedMain, 'reference-impl', 'dist'), join(worktreePath, 'reference-impl', 'dist'));
+    // Honor discovery_config.prep_copy_dirs: copy each listed gitignored directory
+    // (e.g., docs/superpowers) from mainRoot into the worktree. Walker briefs reference
+    // these paths but git checkouts of main don't carry gitignored content.
+    const discoveryConfig = loadDiscoveryConfig(resolvedMain);
+    for (const dir of discoveryConfig.prep_copy_dirs) {
+        const srcPath = join(resolvedMain, dir);
+        const dstPath = join(worktreePath, dir);
+        if (!existsSync(srcPath)) {
+            process.stderr.write(`prep-worktree: prep_copy_dirs entry '${dir}' not found at ${srcPath} — skipping.\n`);
+            continue;
+        }
+        primeCopy(srcPath, dstPath);
+    }
     execSync('npm run build', {
         cwd: join(worktreePath, 'standard'),
         stdio: 'pipe',

package/dist/qa-report.mjs

@@ -1,5 +1,8 @@
 function escape(s) {
-    return s
+    if (s === undefined || s === null)
+        return '';
+    const str = typeof s === 'string' ? s : String(s);
+    return str
         .replace(/&/g, '&')
         .replace(/</g, '&lt;')
         .replace(/>/g, '&gt;')

package/lib/discovery-config.ts

@@ -9,11 +9,20 @@ export interface DiscoveryConfig {
   docContextUri: string;
   projectId: string;
   idStart: number;
+  prep_copy_dirs: string[];
 }
 
 export function loadDiscoveryConfig(repoRoot: string): DiscoveryConfig {
   const override = join(repoRoot, '.cloverleaf', 'config', 'discovery.json');
-  const fallback = JSON.parse(readFileSync(PACKAGE_DEFAULT, 'utf-8')) as DiscoveryConfig;
+  const rawFallback = JSON.parse(readFileSync(PACKAGE_DEFAULT, 'utf-8')) as Partial<DiscoveryConfig>;
+  const fallback: DiscoveryConfig = {
+    docContextUri: typeof rawFallback.docContextUri === 'string' ? rawFallback.docContextUri : '',
+    projectId: typeof rawFallback.projectId === 'string' ? rawFallback.projectId : '',
+    idStart: typeof rawFallback.idStart === 'number' ? rawFallback.idStart : 1,
+    prep_copy_dirs: Array.isArray(rawFallback.prep_copy_dirs)
+      ? (rawFallback.prep_copy_dirs as unknown[]).filter((p): p is string => typeof p === 'string')
+      : [],
+  };
 
   if (existsSync(override)) {
     try {
@@ -31,5 +40,8 @@ function normalise(doc: Partial<DiscoveryConfig>, fallback: DiscoveryConfig): Di
     docContextUri: typeof doc.docContextUri === 'string' ? doc.docContextUri : fallback.docContextUri,
     projectId:     typeof doc.projectId     === 'string' ? doc.projectId     : fallback.projectId,
     idStart:       typeof doc.idStart       === 'number' ? doc.idStart       : fallback.idStart,
+    prep_copy_dirs: Array.isArray(doc.prep_copy_dirs)
+      ? (doc.prep_copy_dirs as unknown[]).filter((p): p is string => typeof p === 'string')
+      : fallback.prep_copy_dirs,
   };
 }

package/lib/prep-worktree.ts

@@ -1,6 +1,7 @@
 import { cpSync, existsSync, rmSync } from 'node:fs';
 import { execSync } from 'node:child_process';
 import { join, dirname } from 'node:path';
+import { loadDiscoveryConfig } from './discovery-config.js';
 
 /**
  * Prepare a freshly-created git worktree of the cloverleaf monorepo for running reference-impl
@@ -130,6 +131,20 @@ export function prepWorktree(mainRoot: string, worktreePath: string): void {
   primeCopy(mainRefImplNm, wtRefImplNm);
   primeCopy(join(resolvedMain, 'reference-impl', 'dist'), join(worktreePath, 'reference-impl', 'dist'));
 
+  // Honor discovery_config.prep_copy_dirs: copy each listed gitignored directory
+  // (e.g., docs/superpowers) from mainRoot into the worktree. Walker briefs reference
+  // these paths but git checkouts of main don't carry gitignored content.
+  const discoveryConfig = loadDiscoveryConfig(resolvedMain);
+  for (const dir of discoveryConfig.prep_copy_dirs) {
+    const srcPath = join(resolvedMain, dir);
+    const dstPath = join(worktreePath, dir);
+    if (!existsSync(srcPath)) {
+      process.stderr.write(`prep-worktree: prep_copy_dirs entry '${dir}' not found at ${srcPath} — skipping.\n`);
+      continue;
+    }
+    primeCopy(srcPath, dstPath);
+  }
+
   execSync('npm run build', {
     cwd: join(worktreePath, 'standard'),
     stdio: 'pipe',

package/lib/qa-report.ts

@@ -8,8 +8,10 @@ export interface QaRunResult {
   stderrTail: string;
 }
 
-function escape(s: string): string {
-  return s
+function escape(s: unknown): string {
+  if (s === undefined || s === null) return '';
+  const str = typeof s === 'string' ? s : String(s);
+  return str
     .replace(/&/g, '&')
     .replace(/</g, '&lt;')
     .replace(/>/g, '&gt;')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cloverleaf/reference-impl",
-  "version": "0.8.3",
+  "version": "0.8.5",
   "description": "Reference implementation of the Cloverleaf methodology as Claude Code skills. Implements the Tight Loop (Implementer + Reviewer).",
   "type": "module",
   "license": "MIT",

package/prompts/qa.md

@@ -72,6 +72,11 @@ The Standard's QA contract requires a `preview_uri`. You were passed the sentine
 - Read-only. Do NOT edit source files.
 - Use `git worktree`: do NOT `git checkout` in the main working directory.
 - Always teardown the worktree, even on error.
+- **Loading or running a module directly.** Do not improvise `node -e "import('./lib/x.js')"` to spot-check a module — sources are `.ts` and the build emits `.mjs`, so a bare `.js` import resolves to neither and fails with `ERR_MODULE_NOT_FOUND`. Use `npx tsx` instead (already in the worktree's `node_modules`): it resolves `.ts` sources **and** the project's `.js`-style import specifiers, so the natural import works. Run it from the worktree's `reference-impl/` directory; for anything the test suite already covers, prefer `npm test`.
+
+  ```bash
+  npx tsx -e "import('./lib/<module>.js').then(m => console.log(Object.keys(m)))"
+  ```
 
 ## QA Report (v0.4)
 

package/prompts/reviewer.md

@@ -65,5 +65,10 @@ A `pass` verdict MAY have an empty `findings` array or omit it. A `bounce` verdi
   Use `--detach` with a SHA rather than a branch name: when running inside a walker worktree, the feature branch (and main) may already be checked out in another worktree, causing `git worktree add` to fail with "fatal: branch … is already checked out". Detaching at a SHA bypasses this constraint entirely.
 
   This keeps `.cloverleaf/` on main intact.
+- **Loading or running a module directly.** Do not improvise `node -e "import('./lib/x.js')"` to spot-check a module — sources are `.ts` and the build emits `.mjs`, so a bare `.js` import resolves to neither and fails with `ERR_MODULE_NOT_FOUND`. Use `npx tsx` instead (already in the worktree's `node_modules`): it resolves `.ts` sources **and** the project's `.js`-style import specifiers, so the natural import works. Run it from the worktree's `reference-impl/` directory; for anything the test suite already covers, prefer `npm test`.
+
+  ```bash
+  npx tsx -e "import('./lib/<module>.js').then(m => console.log(Object.keys(m)))"
+  ```
 - Severities (per the Cloverleaf feedback schema): `blocker` = wrong behavior / missing AC / broken tests; `error` = notable defect that should be fixed but doesn't break AC; `warning` = should fix; `info` = nit / style. Use `blocker` and `error` for bounces.
 - If a criterion is subjective, lean toward pass — the task author chose those words deliberately.