@cloudcli-ai/cloudcli 1.36.3 → 1.37.1

package/server/{cursor-cli.js → modules/providers/list/cursor/cursor-runtime.provider.js}

@@ -1,11 +1,12 @@
 import crossSpawn from 'cross-spawn';
 
-import { appendImagesInputTag } from './shared/image-attachments.js';
-import { notifyRunFailed, notifyRunStopped } from './services/notification-orchestrator.js';
-import { sessionsService } from './modules/providers/services/sessions.service.js';
-import { providerAuthService } from './modules/providers/services/provider-auth.service.js';
-import { providerModelsService } from './modules/providers/services/provider-models.service.js';
-import { createCompleteMessage, createNormalizedMessage, flattenPromptForWindowsShell } from './shared/utils.js';
+import {
+  appendFilesInputTag,
+  appendImagesInputTag,
+  normalizeAttachmentDescriptors
+} from '@/shared/image-attachments.js';
+import { notifyRunFailed, notifyRunStopped } from '@/modules/notifications/index.js';
+import { createCompleteMessage, createNormalizedMessage, flattenPromptForWindowsShell } from '@/shared/utils.js';
 
 // cross-spawn resolves .cmd shims/PATHEXT on Windows and delegates to
 // child_process.spawn everywhere else.
@@ -28,11 +29,24 @@ function isWorkspaceTrustPrompt(text = '') {
   return WORKSPACE_TRUST_PATTERNS.some((pattern) => pattern.test(text));
 }
 
-async function spawnCursor(command, options = {}, ws) {
+async function spawnCursor(command, options = {}, ws, context) {
   return new Promise(async (resolve, reject) => {
-    const { sessionId, projectPath, cwd, toolsSettings, skipPermissions, model, sessionSummary, images } = options;
-    const resolvedModel = await providerModelsService.resolveResumeModel('cursor', sessionId, model);
-    let capturedSessionId = sessionId; // Track session ID throughout the process
+    const {
+      sessionId,
+      projectPath,
+      cwd,
+      toolsSettings,
+      skipPermissions,
+      model,
+      sessionSummary,
+      images,
+      files
+    } = options;
+    // Callers pass the stable app session id; the CLI resumes with the
+    // provider-native id recorded on the session row.
+    const providerSessionId = context.resolveProviderSessionId(sessionId);
+    const resolvedModel = await context.resolveResumeModel(sessionId, model);
+    let capturedSessionId = providerSessionId; // Track the provider-native session id throughout the process
     let sessionCreatedSent = false; // Track if we've already sent session-created event
     let hasRetriedWithTrust = false;
     let settled = false;
@@ -51,18 +65,25 @@ async function spawnCursor(command, options = {}, ws) {
     const baseArgs = [];
 
     // Build flags allowing both resume and prompt together (reply in existing session)
-    // Treat presence of sessionId as intention to resume, regardless of resume flag
-    if (sessionId) {
-      baseArgs.push('--resume=' + sessionId);
+    // Treat a known provider-native id as intention to resume
+    if (providerSessionId) {
+      baseArgs.push('--resume=' + providerSessionId);
     }
 
-    if (command && command.trim()) {
+    const hasAttachments =
+      normalizeAttachmentDescriptors(images).length > 0
+      || normalizeAttachmentDescriptors(files).length > 0;
+    if ((command && command.trim()) || hasAttachments) {
       // Provide a prompt (works for both new and resumed sessions). Image
       // attachments ride along as an <images_input> path list appended to the
       // prompt; the session history reader strips the tag back out for display.
       // cursor-agent is a .cmd shim on Windows, so the whole argument must be
       // newline-free or cmd.exe silently truncates it at the first newline.
-      baseArgs.push('-p', flattenPromptForWindowsShell(appendImagesInputTag(command, images)));
+      const promptWithAttachments = appendFilesInputTag(
+        appendImagesInputTag(command || '', images),
+        files
+      );
+      baseArgs.push('-p', flattenPromptForWindowsShell(promptWithAttachments));
 
       // Model overrides are applied to both new and resumed sessions so a
       // session-scoped change request can take effect on the next turn.
@@ -82,8 +103,9 @@ async function spawnCursor(command, options = {}, ws) {
     // Use cwd (actual project directory) instead of projectPath
     const workingDir = cwd || projectPath || process.cwd();
 
-    // Store process reference for potential abort
-    const processKey = capturedSessionId || Date.now().toString();
+    // Store process reference for potential abort — keyed by the app session
+    // id when the caller supplied one, so abort-by-app-id always works.
+    const processKey = sessionId || Date.now().toString();
 
     const settleOnce = (callback) => {
       if (settled) {
@@ -106,7 +128,8 @@ async function spawnCursor(command, options = {}, ws) {
 
         terminalNotificationSent = true;
 
-        const finalSessionId = capturedSessionId || sessionId || processKey;
+        // Notifications are app-facing, so they carry the app session id.
+        const finalSessionId = sessionId || capturedSessionId || processKey;
         if (code === 0 && !error) {
           notifyRunStopped({
             userId: ws?.userId || null,
@@ -167,8 +190,9 @@ async function spawnCursor(command, options = {}, ws) {
                 if (response.session_id && !capturedSessionId) {
                   capturedSessionId = response.session_id;
 
-                  // Update process key with captured session ID
-                  if (processKey !== capturedSessionId) {
+                  // Legacy/direct callers without an app session id re-key the
+                  // process under the provider-native id once it is known.
+                  if (!sessionId && processKey !== capturedSessionId) {
                     activeCursorProcesses.delete(processKey);
                     activeCursorProcesses.set(capturedSessionId, cursorProcess);
                   }
@@ -178,8 +202,8 @@ async function spawnCursor(command, options = {}, ws) {
                     ws.setSessionId(capturedSessionId);
                   }
 
-                  // Send session-created event only once for new sessions
-                  if (!sessionId && !sessionCreatedSent) {
+                  // Send session-created event only once for sessions with nothing to resume
+                  if (!providerSessionId && !sessionCreatedSent) {
                     sessionCreatedSent = true;
                     ws.send(createNormalizedMessage({ kind: 'session_created', newSessionId: capturedSessionId, model: response.model, cwd: response.cwd, sessionId: capturedSessionId, provider: 'cursor' }));
                   }
@@ -196,7 +220,7 @@ async function spawnCursor(command, options = {}, ws) {
             case 'assistant':
               // Accumulate assistant message chunks
               if (response.message && response.message.content && response.message.content.length > 0) {
-                const normalized = sessionsService.normalizeMessage('cursor', response, capturedSessionId || sessionId || null);
+                const normalized = context.normalizeMessage(response, capturedSessionId || sessionId || null);
                 for (const msg of normalized) ws.send(msg);
               }
               break;
@@ -223,7 +247,7 @@ async function spawnCursor(command, options = {}, ws) {
           }
 
           // If not JSON, send as stream delta via adapter
-          const normalized = sessionsService.normalizeMessage('cursor', line, capturedSessionId || sessionId || null);
+          const normalized = context.normalizeMessage(line, capturedSessionId || sessionId || null);
           for (const msg of normalized) ws.send(msg);
         }
       };
@@ -256,7 +280,9 @@ async function spawnCursor(command, options = {}, ws) {
 
       // Handle process completion
       cursorProcess.on('close', async (code) => {
-        const finalSessionId = capturedSessionId || sessionId || processKey;
+        // The process map is keyed by the app session id when one was given,
+        // otherwise by the captured provider id (or the timestamp fallback).
+        const finalSessionId = sessionId || capturedSessionId || processKey;
         activeCursorProcesses.delete(finalSessionId);
 
         // Flush any final unterminated stdout line before completion handling.
@@ -297,11 +323,11 @@ async function spawnCursor(command, options = {}, ws) {
         console.error('Cursor CLI process error:', error);
 
         // Clean up process reference on error
-        const finalSessionId = capturedSessionId || sessionId || processKey;
+        const finalSessionId = sessionId || capturedSessionId || processKey;
         activeCursorProcesses.delete(finalSessionId);
 
         // Check if Cursor CLI is installed for a clearer error message
-        const installed = await providerAuthService.isProviderInstalled('cursor');
+        const installed = await context.isProviderInstalled();
         const errorContent = !installed
           ? 'Cursor CLI is not installed. Please install it from https://cursor.com'
           : error.message;
@@ -346,6 +372,11 @@ function getActiveCursorSessions() {
   return Array.from(activeCursorProcesses.keys());
 }
 
+export const cursorRuntime = {
+  run: spawnCursor,
+  abort: abortCursorSession,
+};
+
 export {
   spawnCursor,
   abortCursorSession,

package/server/modules/providers/list/cursor/cursor-sessions.provider.ts

@@ -2,7 +2,7 @@ import crypto from 'node:crypto';
 import os from 'node:os';
 import path from 'node:path';
 
-import { parseImagesInputTag } from '@/shared/image-attachments.js';
+import { parseFilesInputTag, parseImagesInputTag } from '@/shared/image-attachments.js';
 import type { IProviderSessions } from '@/shared/interfaces.js';
 import type { AnyRecord, FetchHistoryOptions, FetchHistoryResult, NormalizedMessage } from '@/shared/types.js';
 import {
@@ -85,16 +85,22 @@ function unwrapUserQueryText(value: string, role: 'user' | 'assistant'): string
 function extractUserTextAndImages(
   value: string,
   role: 'user' | 'assistant',
-): { text: string; images?: Array<{ path: string; name?: string }> } {
+): {
+  text: string;
+  images?: Array<{ path: string; name?: string }>;
+  files?: Array<{ path: string; name?: string }>;
+} {
   const unwrapped = unwrapUserQueryText(value, role);
   if (role !== 'user') {
     return { text: unwrapped };
   }
 
-  const { text, attachments } = parseImagesInputTag(unwrapped);
+  const parsedImages = parseImagesInputTag(unwrapped);
+  const parsedFiles = parseFilesInputTag(parsedImages.text);
   return {
-    text,
-    images: attachments.length > 0 ? attachments : undefined,
+    text: parsedFiles.text,
+    images: parsedImages.attachments.length > 0 ? parsedImages.attachments : undefined,
+    files: parsedFiles.attachments.length > 0 ? parsedFiles.attachments : undefined,
   };
 }
 
@@ -471,16 +477,18 @@ export class CursorSessionsProvider implements IProviderSessions {
                 text = unwrapUserQueryText(content.message.content, role);
               }
             }
-            const { text: cleanText, images } = role === 'user'
+            const { text: cleanText, images, files } = role === 'user'
               ? (() => {
-                const parsed = parseImagesInputTag(text);
+                const parsedImages = parseImagesInputTag(text);
+                const parsedFiles = parseFilesInputTag(parsedImages.text);
                 return {
-                  text: parsed.text,
-                  images: parsed.attachments.length > 0 ? parsed.attachments : undefined,
+                  text: parsedFiles.text,
+                  images: parsedImages.attachments.length > 0 ? parsedImages.attachments : undefined,
+                  files: parsedFiles.attachments.length > 0 ? parsedFiles.attachments : undefined,
                 };
               })()
-              : { text, images: undefined };
-            if (cleanText?.trim() || images) {
+              : { text, images: undefined, files: undefined };
+            if (cleanText?.trim() || images || files) {
               messages.push(createNormalizedMessage({
                 id: baseId,
                 sessionId,
@@ -490,6 +498,7 @@ export class CursorSessionsProvider implements IProviderSessions {
                 role,
                 content: cleanText,
                 images,
+                files,
                 sequence: blob.sequence,
                 rowid: blob.rowid,
               }));
@@ -541,8 +550,8 @@ export class CursorSessionsProvider implements IProviderSessions {
             }
 
             if (part?.type === 'text' && part?.text) {
-              const { text: normalizedPartText, images } = extractUserTextAndImages(part.text, role);
-              if (!normalizedPartText && !images) {
+              const { text: normalizedPartText, images, files } = extractUserTextAndImages(part.text, role);
+              if (!normalizedPartText && !images && !files) {
                 continue;
               }
               messages.push(createNormalizedMessage({
@@ -554,6 +563,7 @@ export class CursorSessionsProvider implements IProviderSessions {
                 role,
                 content: normalizedPartText,
                 images,
+                files,
                 sequence: blob.sequence,
                 rowid: blob.rowid,
               }));
@@ -593,8 +603,8 @@ export class CursorSessionsProvider implements IProviderSessions {
           && content.content.trim()
           && !isInternalCursorText(content.content)
         ) {
-          const { text: normalizedText, images } = extractUserTextAndImages(content.content, role);
-          if (!normalizedText && !images) {
+          const { text: normalizedText, images, files } = extractUserTextAndImages(content.content, role);
+          if (!normalizedText && !images && !files) {
             continue;
           }
           messages.push(createNormalizedMessage({
@@ -606,6 +616,7 @@ export class CursorSessionsProvider implements IProviderSessions {
             role,
             content: normalizedText,
             images,
+            files,
             sequence: blob.sequence,
             rowid: blob.rowid,
           }));

package/server/modules/providers/list/cursor/cursor.provider.ts

@@ -1,6 +1,7 @@
 import { AbstractProvider } from '@/modules/providers/shared/base/abstract.provider.js';
 import { CursorProviderAuth } from '@/modules/providers/list/cursor/cursor-auth.provider.js';
 import { CursorProviderModels } from '@/modules/providers/list/cursor/cursor-models.provider.js';
+import { cursorRuntime } from '@/modules/providers/list/cursor/cursor-runtime.provider.js';
 import { CursorMcpProvider } from '@/modules/providers/list/cursor/cursor-mcp.provider.js';
 import { CursorSessionSynchronizer } from '@/modules/providers/list/cursor/cursor-session-synchronizer.provider.js';
 import { CursorSessionsProvider } from '@/modules/providers/list/cursor/cursor-sessions.provider.js';
@@ -8,12 +9,14 @@ import { CursorSkillsProvider } from '@/modules/providers/list/cursor/cursor-ski
 import type {
   IProviderAuth,
   IProviderModels,
+  IProviderRuntime,
   IProviderSessionSynchronizer,
   IProviderSkills,
   IProviderSessions,
 } from '@/shared/interfaces.js';
 
 export class CursorProvider extends AbstractProvider {
+  readonly runtime: IProviderRuntime = cursorRuntime;
   readonly models: IProviderModels = new CursorProviderModels();
   readonly mcp = new CursorMcpProvider();
   readonly auth: IProviderAuth = new CursorProviderAuth();