@cloudbitmaps/core 0.4.1 → 0.6.0

package/dist/index.cjs

@@ -2184,6 +2184,7 @@ function writeCrbmGeneration(driver, key, chunks, options = {}) {
     const writer = new CrbmWriter(sink, { generation: key.generation, crypto: options.crypto });
     for (const { chunkKey, bitmap } of sorted) {
       if (bitmap.isEmpty) continue;
+      bitmap.optimize?.();
       await writer.addChunk(chunkKey, bitmap.serialize(), bitmap.size);
       const pause = tick();
       if (pause !== null) await pause;
@@ -2199,6 +2200,7 @@ async function writeCrbmGenerationStream(driver, key, chunks, options = {}) {
     const writer = new CrbmWriter(sink, { generation: key.generation, crypto: options.crypto });
     for await (const { chunkKey, bitmap } of chunks) {
       if (bitmap.isEmpty) continue;
+      bitmap.optimize?.();
       await writer.addChunk(chunkKey, bitmap.serialize(), bitmap.size);
       chunkKeys.push(chunkKey);
       cardinality += bitmap.size;
@@ -2218,6 +2220,10 @@ async function publishGeneration(registry, key, options = {}) {
           currentGen: key.generation,
           wrappedDeks: options.wrappedDeks
         });
+      } else if (record.status === "destroyed") {
+        throw new ValidationError(
+          `segment "${key.segment}" was destroyed (crypto-shredded) while generation ${key.generation} was being written \u2014 refusing to publish it; the written object is unreadable. Use a new segment.`
+        );
       } else if (record.currentGen > key.generation) {
         return false;
       } else if (record.currentGen === key.generation) {
@@ -3983,7 +3989,22 @@ async function eraseNamespace(namespace, deps, options) {
   const destroyed = [];
   let segmentsShredded = 0;
   for (const ref of refs) {
-    const result = await shredSegment(ref, deps, options.allowCleartext ?? false);
+    let result;
+    try {
+      result = await shredSegment(ref, deps, options.allowCleartext ?? false);
+    } catch (err) {
+      result = {
+        segment: ref.segment,
+        namespace: ref.namespace,
+        destroyed: false,
+        cryptoShredded: false,
+        reason: isWriteConflictError(err) ? "contended" : `failed: ${err instanceof Error ? err.message : String(err)}`,
+        // Deliberately 0, and not a partial count. `eraseWarm` may have deleted rows before it threw, but the
+        // erase did not complete as a unit, so a partial figure on a failed entry would invite reading it as
+        // progress toward a destruction that did not happen. The attestation that matters is `destroyed`.
+        warmRowsDeleted: 0
+      };
+    }
     destroyed.push(result);
     if (result.cryptoShredded) {
       segmentsShredded += 1;
@@ -4046,12 +4067,13 @@ async function shredSegment(ref, deps, allowCleartext) {
 }
 async function eraseWarm(warm, ref) {
   let deleted = 0;
+  let conflicts = 0;
   for (let pass = 0; pass < MAX_WARM_PASSES; pass++) {
+    conflicts = 0;
     const rows = [];
     for await (const row of warm.listChunks(ref))
       rows.push({ chunkKey: row.chunkKey, token: row.token });
     if (rows.length === 0) break;
-    let conflicts = 0;
     for (const { chunkKey, token } of rows) {
       const chunkRef = { namespace: ref.namespace, segment: ref.segment, chunkKey };
       try {
@@ -4064,6 +4086,11 @@ async function eraseWarm(warm, ref) {
     }
     if (conflicts === 0) break;
   }
+  if (conflicts > 0) {
+    throw new WriteConflictError(
+      `destroySegment: ${conflicts} warm row(s) of "${ref.segment}" were rewritten during every one of ${MAX_WARM_PASSES} erase passes \u2014 the segment was NOT destroyed and its cleartext warm deltas are still readable. Stop writes to this segment and retry.`
+    );
+  }
   return deleted;
 }
 
@@ -4194,11 +4221,15 @@ var RetryingWarmDriver = class {
       this.deps
     );
     if (started.first.done === true) return;
-    yield started.first.value;
-    for (; ; ) {
-      const next = await started.iterator.next();
-      if (next.done === true) return;
-      yield next.value;
+    try {
+      yield started.first.value;
+      for (; ; ) {
+        const next = await started.iterator.next();
+        if (next.done === true) return;
+        yield next.value;
+      }
+    } finally {
+      await started.iterator.return?.();
     }
   }
 };