@clipboard-health/eslint-plugin 0.2.0 → 0.4.0

package/package.json

@@ -1,11 +1,14 @@
 {
   "name": "@clipboard-health/eslint-plugin",
   "description": "Clipboard's ESLint Plugin",
-  "version": "0.2.0",
+  "version": "0.4.0",
   "dependencies": {
     "@typescript-eslint/utils": "8.33.0",
     "tslib": "2.8.1"
   },
+  "devDependencies": {
+    "@typescript-eslint/parser": "7.18.0"
+  },
   "keywords": [
     "eslint",
     "plugin"

package/src/index.d.ts

@@ -1,3 +1,4 @@
 export declare const rules: {
     "enforce-ts-rest-in-controllers": import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<"missingDecorator" | "missingReturn" | "decoratorNotFromPackage" | "callNotFromPackage", [], unknown, import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
+    "require-http-module-factory": import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<"requireFactory" | "wrongPackage" | "noImport", [], unknown, import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
 };

package/src/index.js

@@ -3,7 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.rules = void 0;
 const tslib_1 = require("tslib");
 const enforce_ts_rest_in_controllers_1 = tslib_1.__importDefault(require("./lib/rules/enforce-ts-rest-in-controllers"));
+const require_http_module_factory_1 = tslib_1.__importDefault(require("./lib/rules/require-http-module-factory"));
 exports.rules = {
     "enforce-ts-rest-in-controllers": enforce_ts_rest_in_controllers_1.default,
+    "require-http-module-factory": require_http_module_factory_1.default,
 };
 //# sourceMappingURL=index.js.map

package/src/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../packages/eslint-plugin/src/index.ts"],"names":[],"mappings":";;;;AAAA,wHAAoF;AAEvE,QAAA,KAAK,GAAG;IACnB,gCAAgC,EAAE,wCAA0B;CAC7D,CAAC"}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../packages/eslint-plugin/src/index.ts"],"names":[],"mappings":";;;;AAAA,wHAAoF;AACpF,kHAA+E;AAElE,QAAA,KAAK,GAAG;IACnB,gCAAgC,EAAE,wCAA0B;IAC5D,6BAA6B,EAAE,qCAAwB;CACxD,CAAC"}

package/src/lib/rules/require-http-module-factory/index.d.ts

@@ -0,0 +1,2 @@
+declare const rule: import("@typescript-eslint/utils/dist/ts-eslint").RuleModule<"requireFactory" | "wrongPackage" | "noImport", [], unknown, import("@typescript-eslint/utils/dist/ts-eslint").RuleListener>;
+export default rule;

package/src/lib/rules/require-http-module-factory/index.js

@@ -0,0 +1,75 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const tslib_1 = require("tslib");
+/**
+ * @fileoverview Rule to require HttpModule to use registerAsync factory to avoid shared axios client issues
+ */
+const utils_1 = require("@typescript-eslint/utils");
+const createRule_1 = tslib_1.__importDefault(require("../../createRule"));
+const isHttpModuleImport = (spec) => spec.type === utils_1.AST_NODE_TYPES.ImportSpecifier &&
+    spec.imported.type === utils_1.AST_NODE_TYPES.Identifier &&
+    spec.imported.name === "HttpModule";
+const isImportsArray = (node) => {
+    const { parent } = node;
+    return (parent?.type === utils_1.AST_NODE_TYPES.Property &&
+        parent.key?.type === utils_1.AST_NODE_TYPES.Identifier &&
+        parent.key.name === "imports" &&
+        parent.value === node);
+};
+const rule = (0, createRule_1.default)({
+    name: "require-http-module-factory",
+    defaultOptions: [],
+    meta: {
+        type: "problem",
+        docs: {
+            description: "Require HttpModule to use registerAsync factory to avoid shared axios client issues",
+        },
+        schema: [],
+        messages: {
+            requireFactory: "HttpModule must use .registerAsync() with a custom factory to create a new axios client instance. Direct HttpModule imports share the global axios client and can cause interceptor conflicts.",
+            wrongPackage: "HttpModule must be imported from '@nestjs/axios' package. Using HttpModule from other packages may not provide the expected factory methods.",
+            noImport: "HttpModule is used but not imported from '@nestjs/axios'. Import HttpModule and use .registerAsync() with a custom factory.",
+        },
+    },
+    create(context) {
+        let httpModuleImportedCorrectly = false;
+        let httpModuleImportName;
+        const checkHttpModuleUsage = (element) => {
+            if (!element || element.type !== utils_1.AST_NODE_TYPES.Identifier) {
+                return;
+            }
+            const isDirectHttpModule = element.name === "HttpModule";
+            const isAliasedHttpModule = httpModuleImportedCorrectly && element.name === httpModuleImportName;
+            if (isDirectHttpModule) {
+                const messageId = httpModuleImportedCorrectly ? "requireFactory" : "noImport";
+                context.report({ node: element, messageId });
+            }
+            else if (isAliasedHttpModule) {
+                context.report({ node: element, messageId: "requireFactory" });
+            }
+        };
+        return {
+            ImportDeclaration(node) {
+                if (node.source.value !== "@nestjs/axios") {
+                    return;
+                }
+                for (const spec of node.specifiers) {
+                    if (isHttpModuleImport(spec)) {
+                        httpModuleImportedCorrectly = true;
+                        httpModuleImportName = spec.local.name;
+                    }
+                }
+            },
+            ArrayExpression(node) {
+                if (!isImportsArray(node)) {
+                    return;
+                }
+                for (const element of node.elements) {
+                    checkHttpModuleUsage(element);
+                }
+            },
+        };
+    },
+});
+exports.default = rule;
+//# sourceMappingURL=index.js.map

package/src/lib/rules/require-http-module-factory/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../../packages/eslint-plugin/src/lib/rules/require-http-module-factory/index.ts"],"names":[],"mappings":";;;AAAA;;GAEG;AACH,oDAAyE;AAEzE,0EAA0C;AAE1C,MAAM,kBAAkB,GAAG,CAAC,IAA2B,EAAW,EAAE,CAClE,IAAI,CAAC,IAAI,KAAK,sBAAc,CAAC,eAAe;IAC5C,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU;IAChD,IAAI,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,CAAC;AAEtC,MAAM,cAAc,GAAG,CAAC,IAA8B,EAAW,EAAE;IACjE,MAAM,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;IACxB,OAAO,CACL,MAAM,EAAE,IAAI,KAAK,sBAAc,CAAC,QAAQ;QACxC,MAAM,CAAC,GAAG,EAAE,IAAI,KAAK,sBAAc,CAAC,UAAU;QAC9C,MAAM,CAAC,GAAG,CAAC,IAAI,KAAK,SAAS;QAC7B,MAAM,CAAC,KAAK,KAAK,IAAI,CACtB,CAAC;AACJ,CAAC,CAAC;AAEF,MAAM,IAAI,GAAG,IAAA,oBAAU,EAAC;IACtB,IAAI,EAAE,6BAA6B;IACnC,cAAc,EAAE,EAAE;IAClB,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EACT,qFAAqF;SACxF;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,cAAc,EACZ,gMAAgM;YAClM,YAAY,EACV,8IAA8I;YAChJ,QAAQ,EACN,6HAA6H;SAChI;KACF;IAED,MAAM,CAAC,OAAO;QACZ,IAAI,2BAA2B,GAAG,KAAK,CAAC;QACxC,IAAI,oBAAwC,CAAC;QAE7C,MAAM,oBAAoB,GAAG,CAAC,OAAgD,EAAQ,EAAE;YACtF,IAAI,CAAC,OAAO,IAAI,OAAO,CAAC,IAAI,KAAK,sBAAc,CAAC,UAAU,EAAE,CAAC;gBAC3D,OAAO;YACT,CAAC;YAED,MAAM,kBAAkB,GAAG,OAAO,CAAC,IAAI,KAAK,YAAY,CAAC;YACzD,MAAM,mBAAmB,GACvB,2BAA2B,IAAI,OAAO,CAAC,IAAI,KAAK,oBAAoB,CAAC;YAEvE,IAAI,kBAAkB,EAAE,CAAC;gBACvB,MAAM,SAAS,GAAG,2BAA2B,CAAC,CAAC,CAAC,gBAAgB,CAAC,CAAC,CAAC,UAAU,CAAC;gBAC9E,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC;YAC/C,CAAC;iBAAM,IAAI,mBAAmB,EAAE,CAAC;gBAC/B,OAAO,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,gBAAgB,EAAE,CAAC,CAAC;YACjE,CAAC;QACH,CAAC,CAAC;QAEF,OAAO;YACL,iBAAiB,CAAC,IAAI;gBACpB,IAAI,IAAI,CAAC,MAAM,CAAC,KAAK,KAAK,eAAe,EAAE,CAAC;oBAC1C,OAAO;gBACT,CAAC;gBAED,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;oBACnC,IAAI,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;wBAC7B,2BAA2B,GAAG,IAAI,CAAC;wBACnC,oBAAoB,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC;oBACzC,CAAC;gBACH,CAAC;YACH,CAAC;YAED,eAAe,CAAC,IAAI;gBAClB,IAAI,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC1B,OAAO;gBACT,CAAC;gBAED,KAAK,MAAM,OAAO,IAAI,IAAI,CAAC,QAAQ,EAAE,CAAC;oBACpC,oBAAoB,CAAC,OAAO,CAAC,CAAC;gBAChC,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,kBAAe,IAAI,CAAC"}