@clinebot/core 0.0.11 → 0.0.13

package/src/storage/sqlite-team-store.ts

@@ -120,6 +120,8 @@ export class SqliteTeamStore implements TeamStore {
 	}
 
 	private ensureSchema(db: SqliteDb): void {
+		db.exec("PRAGMA journal_mode = WAL;");
+		db.exec("PRAGMA busy_timeout = 5000;");
 		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_events (
 				id INTEGER PRIMARY KEY AUTOINCREMENT,
@@ -130,16 +132,20 @@ export class SqliteTeamStore implements TeamStore {
 				causation_id TEXT,
 				correlation_id TEXT
 			);
+		`);
+		db.exec(`
 			CREATE INDEX IF NOT EXISTS idx_team_events_name_ts
 				ON team_events(team_name, ts DESC);
-
+		`);
+		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_runtime_snapshot (
 				team_name TEXT PRIMARY KEY,
 				state_json TEXT NOT NULL,
 				teammates_json TEXT NOT NULL,
 				updated_at TEXT NOT NULL
 			);
-
+		`);
+		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_tasks (
 				team_name TEXT NOT NULL,
 				task_id TEXT NOT NULL,
@@ -153,7 +159,8 @@ export class SqliteTeamStore implements TeamStore {
 				updated_at TEXT NOT NULL,
 				PRIMARY KEY(team_name, task_id)
 			);
-
+		`);
+		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_runs (
 				team_name TEXT NOT NULL,
 				run_id TEXT NOT NULL,
@@ -169,9 +176,12 @@ export class SqliteTeamStore implements TeamStore {
 				version INTEGER NOT NULL DEFAULT 1,
 				PRIMARY KEY(team_name, run_id)
 			);
+		`);
+		db.exec(`
 			CREATE INDEX IF NOT EXISTS idx_team_runs_status
 				ON team_runs(team_name, status);
-
+		`);
+		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_outcomes (
 				team_name TEXT NOT NULL,
 				outcome_id TEXT NOT NULL,
@@ -182,7 +192,8 @@ export class SqliteTeamStore implements TeamStore {
 				version INTEGER NOT NULL DEFAULT 1,
 				PRIMARY KEY(team_name, outcome_id)
 			);
-
+		`);
+		db.exec(`
 			CREATE TABLE IF NOT EXISTS team_outcome_fragments (
 				team_name TEXT NOT NULL,
 				outcome_id TEXT NOT NULL,

package/src/tools/definitions.test.ts

@@ -3,7 +3,19 @@ import {
 	createBashTool,
 	createDefaultTools,
 	createReadFilesTool,
+	createSkillsTool,
 } from "./definitions.js";
+import { INPUT_ARG_CHAR_LIMIT } from "./schemas.js";
+import type { SkillsExecutorWithMetadata } from "./types.js";
+
+function createMockSkillsExecutor(
+	fn: (...args: unknown[]) => Promise<string> = async () => "ok",
+	configuredSkills?: SkillsExecutorWithMetadata["configuredSkills"],
+): SkillsExecutorWithMetadata {
+	const executor = fn as SkillsExecutorWithMetadata;
+	executor.configuredSkills = configuredSkills;
+	return executor;
+}
 
 describe("default skills tool", () => {
 	it("is included only when enabled with a skills executor", () => {
@@ -17,18 +29,43 @@ describe("default skills tool", () => {
 
 		const toolsWithExecutor = createDefaultTools({
 			executors: {
-				skills: async () => "ok",
+				skills: createMockSkillsExecutor(),
 			},
 			enableSkills: true,
 		});
 		expect(toolsWithExecutor.map((tool) => tool.name)).toContain("skills");
 	});
 
+	it("includes configured skill names in description", () => {
+		const executor = createMockSkillsExecutor(
+			async () => "ok",
+			[
+				{ id: "commit", name: "commit", disabled: false },
+				{
+					id: "review-pr",
+					name: "review-pr",
+					description: "Review a PR",
+					disabled: false,
+				},
+				{ id: "disabled-skill", name: "disabled-skill", disabled: true },
+			],
+		);
+		const tool = createSkillsTool(executor);
+		expect(tool.description).toContain("Available skills: commit, review-pr.");
+		expect(tool.description).not.toContain("disabled-skill");
+	});
+
+	it("omits skill list from description when no skills are configured", () => {
+		const executor = createMockSkillsExecutor(async () => "ok");
+		const tool = createSkillsTool(executor);
+		expect(tool.description).not.toContain("Available skills");
+	});
+
 	it("validates and executes skill invocation input", async () => {
 		const execute = vi.fn(async () => "loaded");
 		const tools = createDefaultTools({
 			executors: {
-				skills: execute,
+				skills: createMockSkillsExecutor(execute),
 			},
 			enableReadFiles: false,
 			enableSearch: false,
@@ -310,6 +347,48 @@ describe("default read_files tool", () => {
 			}),
 		);
 	});
+
+	it("treats null line bounds as full-file boundaries", async () => {
+		const execute = vi.fn(async () => "full file");
+		const tool = createReadFilesTool(execute);
+
+		const result = await tool.execute(
+			{
+				files: [
+					{
+						path: "/tmp/example.ts",
+						start_line: null,
+						end_line: null,
+					},
+				],
+			},
+			{
+				agentId: "agent-1",
+				conversationId: "conv-1",
+				iteration: 1,
+			},
+		);
+
+		expect(result).toEqual([
+			{
+				query: "/tmp/example.ts",
+				result: "full file",
+				success: true,
+			},
+		]);
+		expect(execute).toHaveBeenCalledWith(
+			{
+				path: "/tmp/example.ts",
+				start_line: null,
+				end_line: null,
+			},
+			expect.objectContaining({
+				agentId: "agent-1",
+				conversationId: "conv-1",
+				iteration: 1,
+			}),
+		);
+	});
 });
 
 describe("zod schema conversion", () => {
@@ -329,19 +408,20 @@ describe("zod schema conversion", () => {
 							"The absolute file path of a text file to read content from",
 					},
 					start_line: {
-						type: "integer",
-						description: "Optional one-based starting line number to read from",
+						anyOf: [{ type: "integer" }, { type: "null" }],
+						description:
+							"Optional one-based starting line number to read from; use null or omit for the start of the file",
 					},
 					end_line: {
-						type: "integer",
+						anyOf: [{ type: "integer" }, { type: "null" }],
 						description:
-							"Optional one-based ending line number to read through",
+							"Optional one-based ending line number to read through; use null or omit for the end of the file",
 					},
 				},
 				required: ["path"],
 			},
 			description:
-				"Array of file read requests. Omit start_line and end_line to return the full file content; provide them to return only that inclusive one-based line range. Prefer this tool over running terminal command to get file content for better performance and reliability.",
+				"Array of file read requests. Omit start_line/end_line or set them to null to return the full file content boundaries; provide integers to return only that inclusive one-based line range. Prefer this tool over running terminal command to get file content for better performance and reliability.",
 		});
 		expect(inputSchema.required).toEqual(["files"]);
 	});
@@ -349,7 +429,7 @@ describe("zod schema conversion", () => {
 	it("exposes skills args as optional nullable in tool schemas", () => {
 		const tools = createDefaultTools({
 			executors: {
-				skills: async () => "ok",
+				skills: createMockSkillsExecutor(),
 			},
 			enableReadFiles: false,
 			enableSearch: false,
@@ -526,4 +606,53 @@ describe("default editor tool", () => {
 			expect.anything(),
 		);
 	});
+
+	it("returns a recoverable tool error when text exceeds the soft character limit", async () => {
+		const execute = vi.fn(async () => "patched");
+		const tools = createDefaultTools({
+			executors: {
+				editor: execute,
+			},
+			enableReadFiles: false,
+			enableSearch: false,
+			enableBash: false,
+			enableWebFetch: false,
+			enableSkills: false,
+			enableAskQuestion: false,
+			enableApplyPatch: false,
+			enableEditor: true,
+		});
+		const editorTool = tools.find((tool) => tool.name === "editor");
+		expect(editorTool).toBeDefined();
+		if (!editorTool) {
+			throw new Error("Expected editor tool to be defined.");
+		}
+
+		const oversizedText = "x".repeat(INPUT_ARG_CHAR_LIMIT + 1);
+		const result = await editorTool.execute(
+			{
+				path: "/tmp/example.ts",
+				new_text: oversizedText,
+			},
+			{
+				agentId: "agent-1",
+				conversationId: "conv-1",
+				iteration: 1,
+			},
+		);
+
+		expect(result).toEqual({
+			query: "edit:/tmp/example.ts",
+			result: "",
+			error: expect.stringContaining("new_text was"),
+			success: false,
+		});
+		if (typeof result !== "object" || result == null || !("error" in result)) {
+			throw new Error("Expected editor tool result to include an error.");
+		}
+		expect(result.error).toContain(
+			`recommended limit of ${INPUT_ARG_CHAR_LIMIT}`,
+		);
+		expect(execute).not.toHaveBeenCalled();
+	});
 });

package/src/tools/definitions.ts

@@ -16,6 +16,7 @@ import {
 	EditFileInputSchema,
 	type FetchWebContentInput,
 	FetchWebContentInputSchema,
+	INPUT_ARG_CHAR_LIMIT,
 	type ReadFileRequest,
 	type ReadFilesInput,
 	ReadFilesInputSchema,
@@ -38,7 +39,7 @@ import type {
 	EditorExecutor,
 	FileReadExecutor,
 	SearchExecutor,
-	SkillsExecutor,
+	SkillsExecutorWithMetadata,
 	ToolOperationResult,
 	WebFetchExecutor,
 } from "./types.js";
@@ -57,6 +58,21 @@ function formatError(error: unknown): string {
 	return String(error);
 }
 
+function getEditorSizeError(input: EditFileInput): string | null {
+	if (
+		typeof input.old_text === "string" &&
+		input.old_text.length > INPUT_ARG_CHAR_LIMIT
+	) {
+		return `Editor input too large: old_text was ${input.old_text.length} characters, exceeding the recommended limit of ${INPUT_ARG_CHAR_LIMIT}. Split the edit into smaller tool calls so later tool calls are less likely to be truncated or time out.`;
+	}
+
+	if (input.new_text.length > INPUT_ARG_CHAR_LIMIT) {
+		return `Editor input too large: new_text was ${input.new_text.length} characters, exceeding the recommended limit of ${INPUT_ARG_CHAR_LIMIT}. Split the edit into smaller tool calls so later tool calls are less likely to be truncated or time out.`;
+	}
+
+	return null;
+}
+
 /**
  * Create a timeout-wrapped promise
  */
@@ -105,7 +121,7 @@ function normalizeReadFileRequests(input: unknown): ReadFileRequest[] {
 
 function formatReadFileQuery(request: ReadFileRequest): string {
 	const { path, start_line, end_line } = request;
-	if (start_line === undefined && end_line === undefined) {
+	if (start_line == null && end_line == null) {
 		return path;
 	}
 	const start = start_line ?? 1;
@@ -113,63 +129,6 @@ function formatReadFileQuery(request: ReadFileRequest): string {
 	return `${path}:${start}-${end}`;
 }
 
-const APPLY_PATCH_TOOL_DESC = `This is a custom utility that makes it more convenient to add, remove, move, or edit code in a single file. \`apply_patch\` effectively allows you to execute a diff/patch against a file, but the format of the diff specification is unique to this task, so pay careful attention to these instructions. To use the \`apply_patch\` command, you should pass a message of the following structure as "input":
-
-%%bash
-apply_patch <<"EOF"
-*** Begin Patch
-[YOUR_PATCH]
-*** End Patch
-EOF
-
-Where [YOUR_PATCH] is the actual content of your patch, specified in the following V4A diff format.
-
-*** [ACTION] File: [path/to/file] -> ACTION can be one of Add, Update, or Delete. 
-
-In a Add File section, every line of the new file (including blank/empty lines) MUST start with a \`+\` prefix. Do not include any unprefixed lines inside an Add section
-In a Update/Delete section, repeat the following for each snippet of code that needs to be changed:
-[context_before] -> See below for further instructions on context.
-- [old_code] -> Precede the old code with a minus sign.
-+ [new_code] -> Precede the new, replacement code with a plus sign.
-[context_after] -> See below for further instructions on context.
-
-For instructions on [context_before] and [context_after]:
-- By default, show 3 lines of code immediately above and 3 lines immediately below each change. If a change is within 3 lines of a previous change, do NOT duplicate the first change’s [context_after] lines in the second change’s [context_before] lines.
-- If 3 lines of context is insufficient to uniquely identify the snippet of code within the file, use the @@ operator to indicate the class or function to which the snippet belongs. For instance, we might have:
-@@ class BaseClass
-[3 lines of pre-context]
-- [old_code]
-+ [new_code]
-[3 lines of post-context]
-
-- If a code block is repeated so many times in a class or function such that even a single @@ statement and 3 lines of context cannot uniquely identify the snippet of code, you can use multiple \`@@\` statements to jump to the right context. For instance:
-
-@@ class BaseClass
-@@ 	def method():
-[3 lines of pre-context]
-- [old_code]
-+ [new_code]
-[3 lines of post-context]
-
-Note, then, that we do not use line numbers in this diff format, as the context is enough to uniquely identify code. An example of a message that you might pass as "input" to this function, in order to apply a patch, is shown below.
-
-%%bash
-apply_patch <<"EOF"
-*** Begin Patch
-*** Update File: pygorithm/searching/binary_search.py
-@@ class BaseClass
-@@     def search():
--          pass
-+          raise NotImplementedError()
-
-@@ class Subclass
-@@     def search():
--          pass
-+          raise NotImplementedError()
-
-*** End Patch
-EOF`;
-
 // =============================================================================
 // Tool Factory Functions
 // =============================================================================
@@ -404,6 +363,63 @@ export function createWebFetchTool(
 	});
 }
 
+const APPLY_PATCH_TOOL_DESC = `This is a custom utility that makes it more convenient to add, remove, move, or edit code in a single file. \`apply_patch\` effectively allows you to execute a diff/patch against a file, but the format of the diff specification is unique to this task, so pay careful attention to these instructions. To use the \`apply_patch\` command, you should pass a message of the following structure as "input":
+
+%%bash
+apply_patch <<"EOF"
+*** Begin Patch
+[YOUR_PATCH]
+*** End Patch
+EOF
+
+Where [YOUR_PATCH] is the actual content of your patch, specified in the following V4A diff format.
+
+*** [ACTION] File: [path/to/file] -> ACTION can be one of Add, Update, or Delete. 
+
+In a Add File section, every line of the new file (including blank/empty lines) MUST start with a \`+\` prefix. Do not include any unprefixed lines inside an Add section
+In a Update/Delete section, repeat the following for each snippet of code that needs to be changed:
+[context_before] -> See below for further instructions on context.
+- [old_code] -> Precede the old code with a minus sign.
++ [new_code] -> Precede the new, replacement code with a plus sign.
+[context_after] -> See below for further instructions on context.
+
+For instructions on [context_before] and [context_after]:
+- By default, show 3 lines of code immediately above and 3 lines immediately below each change. If a change is within 3 lines of a previous change, do NOT duplicate the first change’s [context_after] lines in the second change’s [context_before] lines.
+- If 3 lines of context is insufficient to uniquely identify the snippet of code within the file, use the @@ operator to indicate the class or function to which the snippet belongs. For instance, we might have:
+@@ class BaseClass
+[3 lines of pre-context]
+- [old_code]
++ [new_code]
+[3 lines of post-context]
+
+- If a code block is repeated so many times in a class or function such that even a single @@ statement and 3 lines of context cannot uniquely identify the snippet of code, you can use multiple \`@@\` statements to jump to the right context. For instance:
+
+@@ class BaseClass
+@@ 	def method():
+[3 lines of pre-context]
+- [old_code]
++ [new_code]
+[3 lines of post-context]
+
+Note, then, that we do not use line numbers in this diff format, as the context is enough to uniquely identify code. An example of a message that you might pass as "input" to this function, in order to apply a patch, is shown below.
+
+%%bash
+apply_patch <<"EOF"
+*** Begin Patch
+*** Update File: pygorithm/searching/binary_search.py
+@@ class BaseClass
+@@     def search():
+-          pass
++          raise NotImplementedError()
+
+@@ class Subclass
+@@     def search():
+-          pass
++          raise NotImplementedError()
+
+*** End Patch
+EOF`;
+
 /**
  * Create the apply_patch tool
  *
@@ -470,7 +486,9 @@ export function createEditorTool(
 		description:
 			"An editor for controlled filesystem edits on the text file at the provided path. " +
 			"Provide `insert_line` to insert `new_text` at a specific line number. " +
-			"Otherwise, the tool replaces `old_text` with `new_text`, or creates the file with `new_text` if it does not exist.",
+			"Otherwise, the tool replaces `old_text` with `new_text`, or creates the file with `new_text` if file does not exist. " +
+			"Use this tools for making small, precise edits to existing files or creating new files over shell commands.",
+
 		inputSchema: zodToJsonSchema(EditFileInputSchema),
 		timeoutMs,
 		retryable: false, // Editing operations are stateful and should not auto-retry
@@ -478,6 +496,16 @@ export function createEditorTool(
 		execute: async (input, context) => {
 			const validatedInput = validateWithZod(EditFileInputSchema, input);
 			const operation = validatedInput.insert_line == null ? "edit" : "insert";
+			const sizeError = getEditorSizeError(validatedInput);
+
+			if (sizeError) {
+				return {
+					query: `${operation}:${validatedInput.path}`,
+					result: "",
+					error: sizeError,
+					success: false,
+				};
+			}
 
 			try {
 				const result = await withTimeout(
@@ -510,21 +538,22 @@ export function createEditorTool(
  * Invokes a configured skill by name and optional arguments.
  */
 export function createSkillsTool(
-	executor: SkillsExecutor,
+	executor: SkillsExecutorWithMetadata,
 	config: Pick<DefaultToolsConfig, "skillsTimeoutMs"> = {},
 ): Tool<SkillsInput, string> {
 	const timeoutMs = config.skillsTimeoutMs ?? 15000;
 
-	return createTool<SkillsInput, string>({
+	const baseDescription =
+		"Execute a skill within the main conversation. " +
+		"When users ask you to perform tasks, check if any available skills match. " +
+		"When users reference a slash command, invoke it with this tool. " +
+		'Input: `skill` (required) and optional `args`. Example: `skill: "pdf"`, `skill: "commit", args: "-m \\"Fix bug\\""`, `skill: "review-pr", args: "123"`, `skill: "ms-office-suite:pdf"`. ' +
+		"When a skill matches the user's request, invoking this tool is a blocking requirement before any other response. " +
+		"Never mention a skill without invoking this tool.";
+
+	const tool = createTool<SkillsInput, string>({
 		name: "skills",
-		description:
-			"Execute a skill within the main conversation. " +
-			"When users ask you to perform tasks, check if any available skills match. " +
-			'When users reference a slash command (for example "/commit" or "/review-pr"), invoke this tool. ' +
-			'Input: `skill` (required) and optional `args`. Example: `skill: "pdf"`, `skill: "commit", args: "-m \\"Fix bug\\""`, `skill: "review-pr", args: "123"`, `skill: "ms-office-suite:pdf"`. ' +
-			"Available skills are listed in system-reminder messages in the conversation. " +
-			"When a skill matches the user's request, invoking this tool is a blocking requirement before any other response. " +
-			"Never mention a skill without invoking this tool.",
+		description: baseDescription,
 		inputSchema: zodToJsonSchema(SkillsInputSchema),
 		timeoutMs,
 		retryable: false,
@@ -542,6 +571,22 @@ export function createSkillsTool(
 			);
 		},
 	});
+
+	Object.defineProperty(tool, "description", {
+		get() {
+			const skills = executor.configuredSkills
+				?.filter((s) => !s.disabled)
+				.map((s) => s.name);
+			if (skills && skills.length > 0) {
+				return `${baseDescription} Available skills: ${skills.join(", ")}.`;
+			}
+			return baseDescription;
+		},
+		enumerable: true,
+		configurable: true,
+	});
+
+	return tool;
 }
 
 /**

package/src/tools/presets.test.ts

@@ -11,10 +11,10 @@ describe("default tool presets", () => {
 		expect(ToolPresets.development.enableAskQuestion).toBe(true);
 		expect(ToolPresets.readonly.enableAskQuestion).toBe(true);
 		expect(ToolPresets.minimal.enableAskQuestion).toBe(true);
-		expect(ToolPresets.yolo.enableAskQuestion).toBe(true);
+		expect(ToolPresets.yolo.enableAskQuestion).toBe(false);
 	});
 
-	it("yolo preset enables all default tools when executors exist", () => {
+	it("yolo preset excludes ask_question even when its executor exists", () => {
 		const tools = createDefaultToolsWithPreset("yolo", {
 			executors: {
 				readFile: async () => "ok",
@@ -35,7 +35,6 @@ describe("default tool presets", () => {
 			"fetch_web_content",
 			"editor",
 			"skills",
-			"ask_question",
 		]);
 	});
 });

package/src/tools/presets.ts

@@ -88,7 +88,7 @@ export const ToolPresets = {
 	},
 
 	/**
-	 * YOLO mode (everything enabled + no approval required)
+	 * YOLO mode (automation-focused tools + no approval required)
 	 * Good for trusted local automation workflows.
 	 */
 	yolo: {
@@ -99,7 +99,7 @@ export const ToolPresets = {
 		enableApplyPatch: false,
 		enableEditor: true,
 		enableSkills: true,
-		enableAskQuestion: true,
+		enableAskQuestion: false,
 	},
 } as const satisfies Record<string, DefaultToolsConfig>;
 
@@ -115,7 +115,7 @@ export type ToolPolicyPresetName = "default" | "yolo";
 
 /**
  * Build tool policies for a preset.
- * `yolo` guarantees all tools are enabled and auto-approved.
+ * `yolo` guarantees tool policies are enabled and auto-approved.
  */
 export function createToolPoliciesWithPreset(
 	presetName: ToolPolicyPresetName,