@clickview/ship-it 0.0.5-rc.1 → 0.0.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -0,0 +1,7 @@
1
+
2
+ # Code changes
3
+ - Opting out of marketing features when we initialise google analytics
4
+
5
+
6
+ # Testing
7
+
@@ -0,0 +1,64 @@
1
+
2
+ # Before release
3
+ - Update `ClickView.UserApi.Common` to full release
4
+
5
+
6
+ # Code changes
7
+ - Bumping `ClickView.UserApi.Common` to next version so it includes the `changeOnNextLogin` property.
8
+
9
+ - Remove all legacy ADI services and utilities that are no longer needed
10
+
11
+ - Remove `ClickViewOnlineService.svc`
12
+
13
+ * Update `ShortCodeApiClient` to take in `MasterCustomerId` and `UserId` for all endpoints. Close INBOX-2612
14
+ * Include `MasterCustomerId` and `UserId` in the `SharedResource` model for creating and updating share code
15
+ * Remove code for migrating the `username` in shortcode api when doing sso user migration since everything in shortcode api is using master user id now
16
+ * Some minor code cleanup for the lack of `await`
17
+
18
+ - Replaced all use of `object` type with the appropriate model from `BatchApi`.
19
+ - Fixed serialization of request body's / request responses not working correctly
20
+
21
+ - Added images for the user actions wizard
22
+
23
+ - Moving `EmailService` into our dependency injection.
24
+ - Removing old code that was no longer used in `OnlineSignOnSecretKey`
25
+
26
+ * Partially implements CVO-535:
27
+ * Added an ajax controller with endpoints to interact with Batch API.
28
+ * Added new scopes for Batch API.
29
+ * Added support for bulk actions wizard routes in `BatchJobController`.
30
+
31
+
32
+ # Testing
33
+
34
+
35
+
36
+ * Ensure all existing share functionalities in Online still work
37
+
38
+ - n/a
39
+
40
+ - n/a
41
+
42
+ - Test the following from both a forgot password email and an activate account email from old usermanager.
43
+ - Link works and you can change your password
44
+ - Link does not work if used for a second time
45
+ - Make sure the user's email is verified after using the links
46
+ - Make sure a forgot password and activate account link generated from before this release has gone out, still works after this release has gone out. Talk to Sha to get a instances of old links.
47
+
48
+ * n/a
49
+
50
+
51
+ # Customer changes
52
+ - ClickView Online no longer supports ADI
53
+
54
+ * Nothing is changed from the customer's perspective
55
+
56
+ - Making forgot password and email activation links send from old user manager valid for 3 months. Implements CORE-566
57
+ - Making forgot password and email activation links send from old user manager one time use only. This is to improve security around the links since we have increased how long they are valid for. Implements CVO-538.
58
+ - Making forgot password and email activation links send from old user manager verify the user's email address. Implements CVO-537
59
+ - The change password view will now show
60
+
61
+
62
+ # Dependencies
63
+ * The changes to accept `CustomerId` and `UserId` in shortcode Api has already been pushed to production, so no dependency is required.
64
+
@@ -0,0 +1,45 @@
1
+
2
+ # Customer changes
3
+ - Fixed a bug where resending a user an activation email would not work. Fixes INBOX-2966
4
+
5
+ - Fixed a bug where resending a user an activation email would not work. Fixes INBOX-2931
6
+
7
+
8
+ # Code changes
9
+ * Added the customer ID to the request body for sending a email verification email
10
+
11
+ - Added the customer ID to the request body for resending an activation email
12
+
13
+ - Bumping `ClickView.UserApi.Common` to next version so it includes the `changeOnNextLogin` property.
14
+
15
+ * Replaced all use of `object` type with the appropriate model from `BatchApi`.
16
+ * Fixed serialization of request body's / request responses not working correctly
17
+
18
+ - Added images for the user actions wizard
19
+
20
+ - Partially implements CC-92:
21
+ - Added an ajax controller with endpoints to interact with Batch API.
22
+ - Added new scopes for Batch API.
23
+ - Added support for bulk actions wizard routes in `CustomerController`.
24
+
25
+
26
+ # Testing
27
+ - When you edit the email address for a user who does not have a verified email, they should successfully receive an email to verify their new email address. This should work whether they're in the customer you're currently logged into curator as or not.
28
+
29
+ - Attempting to "resend activation email" should successfully send the activation email to the selected user whether they're in the customer you're currently logged into curator as or not.
30
+
31
+
32
+ * n/a
33
+
34
+ - n/a
35
+
36
+ - n/a
37
+
38
+
39
+ # Dependencies
40
+ - https://gitlab.cvinternal.net/internal/users.api/-/merge_requests/108
41
+
42
+
43
+ # Before release
44
+ - Update `ClickView.UserApi.Common` to full release
45
+
File without changes
@@ -0,0 +1,17 @@
1
+
2
+ # Customer changes
3
+ - The text that displays in the transition at the end of onboarding will now use "Grade" instead of "Year group". Fixes INBOX-2927
4
+
5
+
6
+ # Testing
7
+ - The text that displays in the transition at the end of onboarding should now use "Grade" instead of "Year group"
8
+
9
+
10
+ - n/a
11
+
12
+
13
+ # Code changes
14
+ - Opting out of marketing features when we initialise google analytics
15
+
16
+ - Added a new image to display when a video is no longer available on a student's feed. Related to INBOX-2470
17
+
@@ -0,0 +1,161 @@
1
+ # Testing
2
+ - In LE, viewing a video description that contains special characters should now be displayed correctly. For example `'`, `"`, `>`.
3
+ - In LE, when updated a video title to be a dangerous string, it should now be handled safely in the success/error alert.
4
+ - For example: setting the title to `<img src="https://i.imgur.com/SQIDYQ5.png">` should _not_ render the image in the alert.
5
+ - In Lite, while watching a video click on the create a clip button (scissors), then click cancel. You should go back to the same point in the video.
6
+ - In Lite, share a public playlist and attempt to access it via sharelink while unauthenticated:
7
+ - The playlist page should accessible as expected
8
+ - Any public videos within the playlist should also be accessible and watchable
9
+ - In curator user manager, if you deactivate/reactivate a user, then try to re-deactivate/reactivate them back to their initial state, this should be possible with no issues. Previously, on the second attempt, the popup would be for the whatever the first attempt was (e.g. if you just deactivated them then tried to reactivate them, the popup would be the "deactivate" popup again).
10
+ - In curator user manager, if you unverify a user's email address, their old email address should no longer remain shown in the user list.
11
+ - I new user manager in Online, Lite and Curator, ensure that when setting a students password, the checkbox to force the student to change their password on next login is appropriately respected.
12
+ - Online, curator, and lite user managers all support a bulk action to change a student's year group.
13
+ - Pagination works in user manager in lite both with and without a search query.
14
+ - "Year group rollover" and "Change year group" should now appear as separate actions within the bulk user actions wizards.
15
+ - The "year group rollover" action should not be accessible if a rollover has been performed on that school recently, or if the admin has not selected every single user.
16
+ - Year group rollover works in Online's new user manager for users with bulk actions enabled.
17
+ - Curator's cannot access bulk actions if they are not a dev.
18
+ - Searching in user manager and selecting users from there to perform a bulk action on should allow you to proceed to the "action selector" step with those users.
19
+ - Performing a year group rollover action should work end to end. The year group that gets set as the graduating year group should have all students rolling over to that year deactivated.
20
+ - Test this on your own school
21
+ - Test this on another school. I was using Matt's school so I wouldn't mess with anyone else's data
22
+ - Year group rollover should not be performable more than once per customer (message Joosh if you need to perform it again for testing purposes and I will clear the database)
23
+ - If a year group rollover is performed and some users do not have a year group, an appropriate error is shown for those users once the bulk action is completed.
24
+ - If a year group rollover completely fails, an error is displayed
25
+ - If a year group rollover successfully runs with no users having errors, a success image is displayed
26
+ - Bulk action for deactivating users should work in online, curator, and lite.
27
+ - Bulk action for reactivating users should work in online, curator, and lite.
28
+ - Bulk action for deleting users should work in online, curator, and lite.
29
+ - Alerts that appear in Online after creating or deleting a playlist no longer display the text `<strong></strong>` around the playlist name.
30
+ - Alerts that appear in Online after creating or deleting a playlist are not vulnerable to XSS attacks.
31
+ * Go to curator and choose a test school that is not yours and change the email for a user, make sure that the user can receive the verification email.
32
+
33
+ * Go to curator and choose a test school that is not yours and trigger the `Resend activation email` for any pending user who has an email, make sure that the user can receive the email.
34
+ * Go to staff manager in lite and choose a pending user to resend the activation email, make sure that the user can receive the email.
35
+
36
+ - Hit `/v1/users/learner/change-password` for a user with `changeOnNextLogin` set to true, and make sure auth requires the user to change their password
37
+
38
+ - When you edit the email address for a user who does not have a verified email, they should successfully receive an email to verify their new email address. This should work whether they're in the customer you're currently logged into curator as or not.
39
+
40
+ - Attempting to "resend activation email" should successfully send the activation email to the selected user whether they're in the customer you're currently logged into curator as or not.
41
+
42
+ * Ensure all existing share functionalities in Online still work
43
+
44
+ - Test the following from both a forgot password email and an activate account email from old usermanager.
45
+ - Link works and you can change your password
46
+ - Link does not work if used for a second time
47
+ - Make sure the user's email is verified after using the links
48
+ - Make sure a forgot password and activate account link generated from before this release has gone out, still works after this release has gone out. Talk to Sha to get a instances of old links.
49
+
50
+ ## Library editor
51
+
52
+ ### Customer changes
53
+ - Fixed bug where descriptions were displaying URL encoded special characters instead of their unencoded form.
54
+ - Fixes INBOX-2912
55
+ - Closed XSS vulnerability where alerts were rendering un-escaped mark up.
56
+
57
+ ### Code changes
58
+ - Removed unnecessary extra escaping of description text.
59
+ - Escape video name when used in alerts.
60
+
61
+ ## Lite
62
+
63
+ ### Customer changes
64
+ - Clicking "cancel" in the clip editor will now take you to the play page at the same point in time. Fixes INBOX-2957.
65
+ - Fixed bug where accessing a public playlist when unauthenticated would require users to sign in
66
+ - Fixes INBOX-2971
67
+ - Slightly tweaked the copy for the classrooms list page for admins to say "Other classrooms in my school" instead of "All classrooms in my school". Fixes INBOX-2885
68
+ - The text that displays in the transition at the end of onboarding will now use "Grade" instead of "Year group". Fixes INBOX-2927
69
+
70
+ ### Code changes
71
+ - Fixed the URL being html encoded instead of slugified when hitting cancel in the clip editor.
72
+ - Updated `PlaylistView` to check the current user is authenticated before trying to fetch their presentations
73
+ - `optimize` all requests in PlaylistView
74
+ - Opting out of marketing features when we initialise google analytics
75
+ - Added a new image to display when a video is no longer available on a student's feed. Related to INBOX-2470
76
+
77
+ ## Player
78
+
79
+ ### Code changes
80
+ - The create a clip player now has an onReady function to return the reference to the player object, similar to the regular player
81
+
82
+ ## Shared
83
+
84
+ ### Customer changes
85
+ - Fixed a bug where disabled password inputs were not being styled properly. Fixes INBOX-2942.
86
+
87
+ ### Code changes
88
+ - Made `onClickRemove` optional in our `InputSelection` which is the pill that shows in the share search bar. I've re-used this element as part of the add to classroom bulk action.
89
+ - Updated `UserManagerAppLinks` so that we can customise it for each client. Curator and Lite now require settings and the addToClassroom details and confirmation steps, while Online doesn't
90
+ - Changing a students password in student manager will now have a checkbox to optionally require the student to change their password on first login. This will default to being toggled.
91
+
92
+ ![example](https://i.imgur.com/jI8NbVT.png)
93
+
94
+ ## Curator
95
+
96
+ ### Customer changes
97
+ - Fixed some issues in user manager where the UI would not reflect updates made to users. For example: deactivating, reactivating, and unverifying email actions would not properly update the UI after the action had completed. Fixes INBOX-2761
98
+
99
+ - Fixed a bug where resending a user an activation email would not work. Fixes INBOX-2966
100
+
101
+ - Fixed a bug where resending a user an activation email would not work. Fixes INBOX-2931
102
+
103
+ ### Code changes
104
+ - Endpoints in `JobRequests` now no longer accept a `customerId`
105
+ * Added the customer ID to the request body for sending a email verification email
106
+
107
+ - Added the customer ID to the request body for resending an activation email
108
+
109
+ - Bumping `ClickView.UserApi.Common` to next version so it includes the `changeOnNextLogin` property.
110
+
111
+ * Replaced all use of `object` type with the appropriate model from `BatchApi`.
112
+ * Fixed serialization of request body's / request responses not working correctly
113
+
114
+ - Added images for the user actions wizard
115
+
116
+ - Partially implements CC-92:
117
+ - Added an ajax controller with endpoints to interact with Batch API.
118
+ - Added new scopes for Batch API.
119
+ - Added support for bulk actions wizard routes in `CustomerController`.
120
+
121
+ ## Online
122
+
123
+ ### Customer changes
124
+ - Fixed a bug where alerts that appear after creating or deleting a playlist would display the text `<strong></strong>`. Fixes INBOX-2873
125
+ - ClickView Online no longer supports ADI
126
+
127
+ - Making forgot password and email activation links send from old user manager valid for 3 months. Implements CORE-566
128
+ - Making forgot password and email activation links send from old user manager one time use only. This is to improve security around the links since we have increased how long they are valid for. Implements CVO-538.
129
+ - Making forgot password and email activation links send from old user manager verify the user's email address. Implements CVO-537
130
+ - The change password view will now show
131
+
132
+ ### Code changes
133
+ - Online's alerts no longer escape the HTML passed into them. I believe this should be fine as these alerts should be using `LanguageService`, and `LanguageService` escapes any dynamic phrase options (such as playlist names). Escaping the rest of the phrase (which the dev writes) doesn't need to happen.
134
+ - Bumping `ClickView.UserApi.Common` to next version so it includes the `changeOnNextLogin` property.
135
+
136
+ - Remove all legacy ADI services and utilities that are no longer needed
137
+
138
+ - Remove `ClickViewOnlineService.svc`
139
+
140
+ * Update `ShortCodeApiClient` to take in `MasterCustomerId` and `UserId` for all endpoints. Close INBOX-2612
141
+ * Include `MasterCustomerId` and `UserId` in the `SharedResource` model for creating and updating share code
142
+ * Remove code for migrating the `username` in shortcode api when doing sso user migration since everything in shortcode api is using master user id now
143
+ * Some minor code cleanup for the lack of `await`
144
+
145
+ - Replaced all use of `object` type with the appropriate model from `BatchApi`.
146
+ - Fixed serialization of request body's / request responses not working correctly
147
+
148
+ - Added images for the user actions wizard
149
+
150
+ - Moving `EmailService` into our dependency injection.
151
+ - Removing old code that was no longer used in `OnlineSignOnSecretKey`
152
+
153
+ * Partially implements CVO-535:
154
+ * Added an ajax controller with endpoints to interact with Batch API.
155
+ * Added new scopes for Batch API.
156
+ * Added support for bulk actions wizard routes in `BatchJobController`.
157
+
158
+ # Analytics Web
159
+
160
+ ## Code changes
161
+ - Opting out of marketing features when we initialise google analytics
@@ -0,0 +1,28 @@
1
+
2
+ # Customer changes
3
+ * Fixed a bug where support changes an unverified email for a user on behalf of our customer in curator and the verification email does not get sent out automatically. Partially fixes INBOX-2966
4
+
5
+ * Fixed a bug where support triggers `Resend activation email` on behalf of our customer in curator but the email is not received by the customer. Partially fixes INBOX-2931
6
+
7
+
8
+ # Code changes
9
+ * Pass down optional `CustomerId` to backend to fetch the user with right customer associated to it
10
+ * Consolidate `SendVerificationEmailRequest` and `SendActivationEmailRequest` to `BaseSendEmailRequest`
11
+
12
+ * Added an optional `CustomerId` in `SendActivationEmailRequest` model so that it can be passed to backend to fetch the user with right customer associated to it
13
+
14
+ - `/v1/users/learner/change-password` now takes a `changeOnNextLogin` property in it's body, which it forwards on to auth when changing the password.
15
+
16
+
17
+ # Testing
18
+ * Go to curator and choose a test school that is not yours and change the email for a user, make sure that the user can receive the verification email.
19
+
20
+ * Go to curator and choose a test school that is not yours and trigger the `Resend activation email` for any pending user who has an email, make sure that the user can receive the email.
21
+ * Go to staff manager in lite and choose a pending user to resend the activation email, make sure that the user can receive the email.
22
+
23
+ - Hit `/v1/users/learner/change-password` for a user with `changeOnNextLogin` set to true, and make sure auth requires the user to change their password
24
+
25
+
26
+ # Before release
27
+ * Publish `.Common` nuget package to nuget server
28
+
@@ -0,0 +1,98 @@
1
+
2
+ # Testing
3
+ - n/a
4
+ - In LE, viewing a video description that contains special characters should now be displayed correctly. For example `'`, `"`, `>`.
5
+ - In LE, when updated a video title to be a dangerous string, it should now be handled safely in the success/error alert.
6
+ - For example: setting the title to `<img src="https://i.imgur.com/SQIDYQ5.png">` should _not_ render the image in the alert.
7
+ - In Lite, while watching a video click on the create a clip button (scissors), then click cancel. You should go back to the same point in the video.
8
+ - In Lite, share a public playlist and attempt to access it via sharelink while unauthenticated:
9
+ - The playlist page should accessible as expected
10
+ - Any public videos within the playlist should also be accessible and watchable
11
+ - n/a
12
+ - In curator user manager, if you deactivate/reactivate a user, then try to re-deactivate/reactivate them back to their initial state, this should be possible with no issues. Previously, on the second attempt, the popup would be for the whatever the first attempt was (e.g. if you just deactivated them then tried to reactivate them, the popup would be the "deactivate" popup again).
13
+ - In curator user manager, if you unverify a user's email address, their old email address should no longer remain shown in the user list.
14
+ - I new user manager in Online, Lite and Curator, ensure that when setting a students password, the checkbox to force the student to change their password on next login is appropriately respected.
15
+ - Online, curator, and lite user managers all support a bulk action to change a student's year group.
16
+ - n/a
17
+ - Pagination works in user manager in lite both with and without a search query.
18
+ - "Year group rollover" and "Change year group" should now appear as separate actions within the bulk user actions wizards.
19
+ - The "year group rollover" action should not be accessible if a rollover has been performed on that school recently, or if the admin has not selected every single user.
20
+ - Year group rollover works in Online's new user manager for users with bulk actions enabled.
21
+ - Curator's cannot access bulk actions if they are not a dev.
22
+ - Searching in user manager and selecting users from there to perform a bulk action on should allow you to proceed to the "action selector" step with those users.
23
+ - Performing a year group rollover action should work end to end. The year group that gets set as the graduating year group should have all students rolling over to that year deactivated.
24
+ - Test this on your own school
25
+ - Test this on another school. I was using Matt's school so I wouldn't mess with anyone else's data
26
+ - Year group rollover should not be performable more than once per customer (message Joosh if you need to perform it again for testing purposes and I will clear the database)
27
+ - If a year group rollover is performed and some users do not have a year group, an appropriate error is shown for those users once the bulk action is completed.
28
+ - If a year group rollover completely fails, an error is displayed
29
+ - If a year group rollover successfully runs with no users having errors, a success image is displayed
30
+ - Bulk action for deactivating users should work in online, curator, and lite.
31
+ - Bulk action for reactivating users should work in online, curator, and lite.
32
+ - Bulk action for deleting users should work in online, curator, and lite.
33
+ - Alerts that appear in Online after creating or deleting a playlist no longer display the text `<strong></strong>` around the playlist name.
34
+ - Alerts that appear in Online after creating or deleting a playlist are not vulnerable to XSS attacks.
35
+ - n/a
36
+
37
+ # Library editor
38
+
39
+ ## Customer changes
40
+ - Fixed bug where descriptions were displaying URL encoded special characters instead of their unencoded form.
41
+ - Fixes INBOX-2912
42
+ - Closed XSS vulnerability where alerts were rendering un-escaped mark up.
43
+
44
+ ## Code changes
45
+ - Removed unnecessary extra escaping of description text.
46
+ - Escape video name when used in alerts.
47
+
48
+ # Lite
49
+
50
+ ## Customer changes
51
+ - Clicking "cancel" in the clip editor will now take you to the play page at the same point in time. Fixes INBOX-2957.
52
+ - Fixed bug where accessing a public playlist when unauthenticated would require users to sign in
53
+ - Fixes INBOX-2971
54
+ - Slightly tweaked the copy for the classrooms list page for admins to say "Other classrooms in my school" instead of "All classrooms in my school". Fixes INBOX-2885
55
+
56
+ ## Code changes
57
+ - Fixed the URL being html encoded instead of slugified when hitting cancel in the clip editor.
58
+ - Updated `PlaylistView` to check the current user is authenticated before trying to fetch their presentations
59
+ - `optimize` all requests in PlaylistView
60
+
61
+ # Player
62
+
63
+ ## Code changes
64
+ - The create a clip player now has an onReady function to return the reference to the player object, similar to the regular player
65
+
66
+ # Shared
67
+
68
+ ## Customer changes
69
+ - Fixed a bug where disabled password inputs were not being styled properly. Fixes INBOX-2942.
70
+
71
+ ## Code changes
72
+ - Made `onClickRemove` optional in our `InputSelection` which is the pill that shows in the share search bar. I've re-used this element as part of the add to classroom bulk action.
73
+ - Updated `UserManagerAppLinks` so that we can customise it for each client. Curator and Lite now require settings and the addToClassroom details and confirmation steps, while Online doesn't
74
+ - Changing a students password in student manager will now have a checkbox to optionally require the student to change their password on first login. This will default to being toggled.
75
+
76
+ ![example](https://i.imgur.com/jI8NbVT.png)
77
+
78
+ # Curator
79
+
80
+ ## Customer changes
81
+ - Fixed some issues in user manager where the UI would not reflect updates made to users. For example: deactivating, reactivating, and unverifying email actions would not properly update the UI after the action had completed. Fixes INBOX-2761
82
+
83
+ ## Code changes
84
+ - Endpoints in `JobRequests` now no longer accept a `customerId`
85
+
86
+ # Dependencies
87
+ - https://gitlab.cvinternal.net/internal/users.api/-/merge_requests/107
88
+ - https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/881
89
+ - https://gitlab.cvinternal.net/clickview/front-end/ClickView.Online/-/merge_requests/3048
90
+ - https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/880
91
+
92
+ # Online
93
+
94
+ ## Customer changes
95
+ - Fixed a bug where alerts that appear after creating or deleting a playlist would display the text `<strong></strong>`. Fixes INBOX-2873
96
+
97
+ ## Code changes
98
+ - Online's alerts no longer escape the HTML passed into them. I believe this should be fine as these alerts should be using `LanguageService`, and `LanguageService` escapes any dynamic phrase options (such as playlist names). Escaping the rest of the phrase (which the dev writes) doesn't need to happen.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@clickview/ship-it",
3
- "version": "0.0.5-rc.1",
3
+ "version": "0.0.5",
4
4
  "description": "Release Manager",
5
5
  "main": "./lib/index.js",
6
6
  "bin": {