@clickview/ship-it 0.0.35-dev.10 → 0.0.35-dev.12

package/lib/src/tasks/BumpPackagesTask.js

@@ -72,13 +72,16 @@ var HOTFIX_BRANCH_REGEX = /^hotfix\/(\d|\.)+$/;
 var DEV_VERSION_REGEX = /-dev\.\d+$/;
 var RC_VERSION_REGEX = /-rc\.\d+$/;
 var SHARED_LERNA_OPTIONS = '--exact --no-git-tag-version --no-push --yes';
+// ChatGPT bs to kill `execSync` after a timeout
+// TODO: Replace `lerna version` with a better lib or our own implementation
+// so we can delete this crap
 function execSyncWithTimeout(command, timeout, options) {
     if (options === void 0) { options = {}; }
     return new Promise(function (resolve, reject) {
         var child = (0, child_process_1.spawn)(command, [], __assign({ shell: true, stdio: 'inherit' }, options));
         var timer = setTimeout(function () {
             child.kill('SIGTERM');
-            reject(new Error("Command timed out after ".concat(timeout, "ms")));
+            reject(new Error("ExecSync timeout"));
         }, timeout);
         child.on('exit', function (code, signal) {
             clearTimeout(timer);
@@ -107,7 +110,7 @@ var BumpPackagesTask = /** @class */ (function () {
     }
     BumpPackagesTask.prototype.run = function (options) {
         return __awaiter(this, void 0, void 0, function () {
-            var branch, isValid, lernaVersionCmd, error_1;
+            var branch, isValid, lernaVersionCmd;
             return __generator(this, function (_a) {
                 switch (_a.label) {
                     case 0:
@@ -131,22 +134,17 @@ var BumpPackagesTask = /** @class */ (function () {
                             utils_1.Logger.logError('Something went wrong while trying to detect which versioning script to run with Lerna.');
                             return [2 /*return*/, false];
                         }
-                        _a.label = 3;
+                        // Lerna version command hangs in NPM 10 for some reason.
+                        // We need to replace it with another lib or our own implementation.
+                        // For now, we use this util to run the command with `execSync` then time it out
+                        // to "force quit" it after 5s, because the command is hanging after successful execution.
+                        return [4 /*yield*/, execSyncWithTimeout(lernaVersionCmd, 5000)];
                     case 3:
-                        _a.trys.push([3, 5, 6, 7]);
-                        return [4 /*yield*/, execSyncWithTimeout('your lerna command', 20000)];
-                    case 4:
-                        _a.sent(); // 30 second timeout
-                        utils_1.Logger.logInfo('Command completed successfully');
-                        return [3 /*break*/, 7];
-                    case 5:
-                        error_1 = _a.sent();
-                        utils_1.Logger.logInfo('Command failed:', error_1.message);
-                        return [3 /*break*/, 7];
-                    case 6:
-                        utils_1.Logger.logInfo('Exiting process');
-                        return [2 /*return*/, true];
-                    case 7:
+                        // Lerna version command hangs in NPM 10 for some reason.
+                        // We need to replace it with another lib or our own implementation.
+                        // For now, we use this util to run the command with `execSync` then time it out
+                        // to "force quit" it after 5s, because the command is hanging after successful execution.
+                        _a.sent();
                         utils_1.Logger.logSuccess('Successfully executed Lerna versioning command.');
                         return [2 /*return*/, true];
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@clickview/ship-it",
-  "version": "0.0.35-dev.10",
+  "version": "0.0.35-dev.12",
   "description": "Release Manager",
   "main": "./lib/index.js",
   "bin": {