@clickview/ship-it 0.0.33 → 0.0.34

package/Dockerfile

@@ -1,33 +1,33 @@
-FROM node:18.11.0
-
-WORKDIR /app
-
-COPY ["src", "src/"]
-# Copy files needed to install NPM packages
-COPY ["package.json", "package-lock.json", "./"]
-
-COPY ["tsconfig.json", "config.json", ".eslintrc.json", "./"]
-
-# Set an authentication token for NPM, allowing the build machine to install private NPM packages
-ARG npm_token
-ARG milestone
-ARG command
-ARG options
-ENV cliOptions=""
-
-RUN npm config set '//registry.npmjs.org/:_authToken' $npm_token
-RUN npm config set save-exact=true
-# Note: As of writing, NPM versions beyond 8.5.5 cannot run `npm ci` without failing. Once this is fixed, the line below should be deleted
-RUN npm install -g npm@8.5.5
-
-# Install NPM packages
-RUN npm install
-
-RUN npm run build
-
-RUN npm link
-
-RUN cliOptions=$(echo "$options" | sed -e 's/^"//' -e 's/"$//') && \
-    echo "Build option: $cliOptions" && \
-    ship-it $command -m $milestone $cliOptions
-
+FROM node:18.11.0
+
+WORKDIR /app
+
+COPY ["src", "src/"]
+# Copy files needed to install NPM packages
+COPY ["package.json", "package-lock.json", "./"]
+
+COPY ["tsconfig.json", "config.json", ".eslintrc.json", "./"]
+
+# Set an authentication token for NPM, allowing the build machine to install private NPM packages
+ARG npm_token
+ARG milestone
+ARG command
+ARG options
+ENV cliOptions=""
+
+RUN npm config set '//registry.npmjs.org/:_authToken' $npm_token
+RUN npm config set save-exact=true
+# Note: As of writing, NPM versions beyond 8.5.5 cannot run `npm ci` without failing. Once this is fixed, the line below should be deleted
+RUN npm install -g npm@8.5.5
+
+# Install NPM packages
+RUN npm install
+
+RUN npm run build
+
+RUN npm link
+
+RUN cliOptions=$(echo "$options" | sed -e 's/^"//' -e 's/"$//') && \
+    echo "Build option: $cliOptions" && \
+    ship-it $command -m $milestone $cliOptions
+

package/README.md

@@ -1,48 +1,48 @@
-# Ship It
-
-## Introduction
-
-"Ship It" is a CLI tool that was created to automate aspects of our release workflow.
-
-### How To Manage A Release
-
-If you are here to learn how to manage a release, please see [this document](https://clickview.quip.com/DbEyAaVK8sqB/Release-Manager-Checklist) instead.
-
-### How To Contribute
-
-If you are here instead of learn about or contribute to this project, then you're in the right place! Keep reading :)
-
-## Prerequisites
-
-* NodeJS (and npm)
-* Access to the ClickView organization on [npm](https://www.npmjs.com). You will need to add an npm auth token to a global or local `.npmrc` file
-* Add the `Ship It` user as a `Developer` to each GitLab project you would like to manage using the Ship It CLI
-
-## Getting Started
-
-```
-git clone https://gitlab.cvinternal.net/front-end/ship-it.git
-cd ship-it
-npm install
-```
-
-After installation, you can run `npm run start -- help` to see the full list of commands.
-
-## Contributing
-
-### Open Issues
-
-All bugs / feature requests are tracked in the [issues](https://gitlab.cvinternal.net/clickview/front-end/ship-it/-/issues) section of this project.
-
-Anyone is free to pick up an issue and work on it at will! Don't be afraid, the TypeScript won't bite.
-
-### Project Architecture
-
-Each CLI command is defined in the `startup/SetupCommands.ts` file.
-
-Each command maps to a particular TypeScript class in the `commands` directory.
-These command classes typically just sequentially run a set of "tasks", where each "task" can be shared across different commands.
-Each task also exists as a TypeScript class under the `tasks` directory.
-
-All code written in this project is intended to be highly reusable! If you are contributing a new command or updating an existing one, be sure to see if the code you're looking for already exists.
-
+# Ship It
+
+## Introduction
+
+"Ship It" is a CLI tool that was created to automate aspects of our release workflow.
+
+### How To Manage A Release
+
+If you are here to learn how to manage a release, please see [this document](https://clickview.quip.com/DbEyAaVK8sqB/Release-Manager-Checklist) instead.
+
+### How To Contribute
+
+If you are here instead of learn about or contribute to this project, then you're in the right place! Keep reading :)
+
+## Prerequisites
+
+* NodeJS (and npm)
+* Access to the ClickView organization on [npm](https://www.npmjs.com). You will need to add an npm auth token to a global or local `.npmrc` file
+* Add the `Ship It` user as a `Developer` to each GitLab project you would like to manage using the Ship It CLI
+
+## Getting Started
+
+```
+git clone https://gitlab.cvinternal.net/front-end/ship-it.git
+cd ship-it
+npm install
+```
+
+After installation, you can run `npm run start -- help` to see the full list of commands.
+
+## Contributing
+
+### Open Issues
+
+All bugs / feature requests are tracked in the [issues](https://gitlab.cvinternal.net/clickview/front-end/ship-it/-/issues) section of this project.
+
+Anyone is free to pick up an issue and work on it at will! Don't be afraid, the TypeScript won't bite.
+
+### Project Architecture
+
+Each CLI command is defined in the `startup/SetupCommands.ts` file.
+
+Each command maps to a particular TypeScript class in the `commands` directory.
+These command classes typically just sequentially run a set of "tasks", where each "task" can be shared across different commands.
+Each task also exists as a TypeScript class under the `tasks` directory.
+
+All code written in this project is intended to be highly reusable! If you are contributing a new command or updating an existing one, be sure to see if the code you're looking for already exists.
+

package/config.json

@@ -1,20 +1,20 @@
-{
-  "gitLab": {
-    "accessToken": "glpat-d9TACyfNj3uaetfbGiPp",
-    "url": "https://gitlab.cvinternal.net"
-  },
-  "teamCity": {
-    "url": "http://build.cvinternal.net/",
-    "username": "shale.kuzmanovski",
-    "password": "hock-inflame-prodigy-unstrap"
-  },
-  "slack": {
-    "botToken": "xoxb-10474490612-6484075093633-vEo2cgvi7nma9DDSzPEXWDrw",
-    "channelId": "C03DX0DSG3F"
-  },
-  "trello": {
-    "apiKey": "6e887685d44e94ae9a680c010c4b622d",
-    "apiToken": "ATTA558c8969ce04b46fb9c9d6f645aa51be7f1c9dbb9b6f5f6f85ae6da2a209c1f39AAC612F",
-    "boardId": "3edi3xiO"
-  }
+{
+  "gitLab": {
+    "accessToken": "glpat-d9TACyfNj3uaetfbGiPp",
+    "url": "https://gitlab.cvinternal.net"
+  },
+  "teamCity": {
+    "url": "http://build.cvinternal.net/",
+    "username": "shale.kuzmanovski",
+    "password": "hock-inflame-prodigy-unstrap"
+  },
+  "slack": {
+    "botToken": "xoxb-10474490612-6484075093633-vEo2cgvi7nma9DDSzPEXWDrw",
+    "channelId": "C03DX0DSG3F"
+  },
+  "trello": {
+    "apiKey": "6e887685d44e94ae9a680c010c4b622d",
+    "apiToken": "ATTA558c8969ce04b46fb9c9d6f645aa51be7f1c9dbb9b6f5f6f85ae6da2a209c1f39AAC612F",
+    "boardId": "3edi3xiO"
+  }
 }

package/dist/F1/Analytics Web.md

@@ -0,0 +1,8 @@
+
+# Code changes
+- Add new illos and remove old illos.
+
+
+# Testing
+- Implements ANLT-107
+

package/dist/F1/AutoCaptions.md

@@ -0,0 +1,30 @@
+
+# Code changes
+- Move all amazon transcribe logic to `ClickView.AutoCaptions.Aws`
+- Change `IAmazonTranscribeClient` to `ITranscriptionProcessor`. Closes CORE-1374
+  - Introduce new domain models instead of using the aws client models
+  - Now contains `TranscriptionSubtitle` which has the subtitle content as a string instead of returning urls
+- `AmazonTranscribeClient` changes:
+  - Will now download the subtitle instead of leaving it up to `CaptionTaskProcessor`
+  - Moved CdnMapping call into this service as other processors need want to use the cdn for public access
+
+- Add `Directory.Build.props` to control common properties
+  - nullable is now enabled for all projects
+- Misc nullable fixes
+- `LanguageHelper` changes
+  - Define a default language for when we return a default language. HashSet does not guarantee ordering so FIrst might not be whats expected
+- Update build files to their latest versions
+  - Use the runtime docker image not aspnet as this is not an aspnet project
+
+- Replace local master api client with `ClickView.Clients.Master`
+
+- Update all packages to their latest versions
+- Replace `Serilog.AspNetCore` with `Serilog.Extensions.Hosting` since we are not in an aspnetcore context
+
+
+# Testing
+- CORE-1374
+
+
+
+

package/dist/F1/Classroom.Api.md

@@ -0,0 +1,23 @@
+
+# Before release
+* [ ] Add the following curator group ids to octo variables for production (same curator groups as user api)
+  * 5485
+  * 9518351
+  * 3699822
+  * 7204452
+  * 1550457
+  * 2046458
+  * 2046453
+  * 14069509
+  * 67079832
+  * 67080194
+  * 67080437
+
+
+# Code changes
+* Add support to allow curator group users to add students to a classroom on behalf of customers in curator
+
+
+# Testing
+* INBOX-5335
+

package/dist/F1/ClickView Online.md

@@ -0,0 +1,17 @@
+
+# Customer changes
+- Fix disabled users being shown the change password UI. Fixes INBOX-5227
+
+
+# Code changes
+- Remove `LastSignInDate` Min check that redirects to the change password screen. This should always be handled by auth now
+- Added check for if the user is disabled in `OnActionExecuting`. If they are, log the user out and redirect to the `/` root
+- Reduce the user cache time from 5min to 1min
+- Don't ignore default values in `BaseRedisDataStructure`
+  - **Note**: This could be potentially a spicy change
+  - This was changed to fix a bug where the UserProfile.Status was disabled but the `BaseMediaObject.Status was the default value. Ignore would then remove it because the "base" value was the default
+
+
+# Testing
+- INBOX-5227
+

package/dist/F1/ClickView.Curator.md

@@ -0,0 +1,100 @@
+
+# Before release
+* Please add `streamableLibraryId` config property to octo. Production id = `78688869`
+
+* Update image client to latest nuget package
+
+
+# Dependencies
+* Merge after !1314
+
+- [x] Merge and release after https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/243
+
+
+# Customer changes
+* The `Content Pipeline` fixes a bug when a video's metada (e.g. description) is updated in the curator web, and if the video has any clips, the video type will be changed from `video` to `clip`
+* 
+
+- Add streamable learning to nav
+
+- Assignees will now display their avatar
+
+
+# Code changes
+* The `Content Pipeline` updates `RightsLine` video status to `Published` after publishing videos
+
+* VideoUpdateEventHandler.HandleAsync() uses clip id rather the video id to update clip properties in mongo db
+
+* Added regions field to videos. Implements CC-823
+
+* Added null check when trying to get user token
+
+* Added parent video id and filters for clips. Implements CC-820
+
+* Added an endpoint to get dashboard videos. Implements CC-816
+
+* Added topic template column for dashboards. Implements CC-814
+
+* Supports new thumbnailText field for videos. Implements CC-812
+
+* Added `source` column. Implements CC-822
+* Added filters for `source` column
+
+* Fixed a bug where dashboard wasn't being updated correctly. Fixes CC-815
+
+* Fixed a bug where clip's interactive wasn't being synced. Fixes CC-811
+
+* Added priority column for all entities. Implements CC-804
+* Added filters for priority column. Implements CC-807
+* Using priority column to sort. Implements CC-818
+* When updating priority on a curated topic, it automatically cascade down to the videos and classification associated with that topic. Implements CC-808
+* Add an endpoint for setting priority. Implements CC-806
+
+* Using image client in curation studio project. Implements INBOX-5381
+
+* Fixed classroom search serialisation. Fixes INBOX-5336
+
+Added users.api endpoints with support to customerless users:
+* `GET` `ajax/user/{id}`: Get user by Id
+* `POST` `ajax/users/delete`: Delete users object
+* `PUT` `ajax/users/update-status`: Update user statuses (if customer is not passed, it will just update users' statuses if there's no customer).
+Implements CC-758
+
+
+# Testing
+
+* Find a video that has at least one clip created in the curator web.
+* Modify any video's metadata field e.g. description
+* Now check the video in the `Content Pipeline` doesn't change to `clip`
+
+Implements CC-823
+
+
+
+Implements CC-820
+
+Implements CC-816
+
+Implements CC-814
+
+Implements CC-812
+
+Implements CC-822
+
+Fixes CC-815
+
+Fixes CC-811
+
+* Implements CC-804
+* Implements CC-818
+* Implements CC-808
+* Implements CC-807
+* Implements CC-806
+
+
+Implements INBOX-5381
+
+Fixes INBOX-5336
+
+Implements CC-758
+

package/dist/F1/ClickView.EmailService.md

@@ -0,0 +1,53 @@
+
+# Before release
+- Move smtp settings to be under the `stmp:legacy` key instead of just `smtp`
+
+- Remove all regional resources from octo
+
+- Set `queues:notification:concurrentTaskCount` to 
+  - prod = `5` (current value is 10 but that seems high?)
+  - nonprod = 1
+
+
+# Code changes
+- Move config out of Models project and into the main web project. Closes CORE-1365
+
+- Null check user and email before doing any more work (If the user has no email, theres no point in fetching the video objects etc)
+- Enable nullable on more projects
+
+- Added ability to define multiple smtp servers. Implements CORE-1362
+  - Can define `weight` to do a weighted round robin load balancing
+- Rename `IClickViewEmailManager` to `IEmailSender`
+- Rename `ClickViewEmailManager` to `SmtpEmailSender`
+
+- Add an `obsolete` key to the template configuration, that will log an error any time an obsolete template is used 
+
+- Removed the passing of `AppConfig` to all notifications
+- Added `ThumbnailHepler` to generate thumbnails (basically the same code that was in `BaseNotification`)
+- Added `LinkGenerator` to generate links to Manage and Lite (when we dont have `AppLinks`)
+
+- Remove regional resources and use app links and launch for (Closes CORE-1364):
+  - `VideoAvailableNotification (Workspace)`
+  - `VideoAvailableNotification (Exchange)`
+  - `EditedVideoAvailable`
+
+- Use `ClickView.GoodStuff.Hosting.Queue` for the `EmailNotificationWorker`
+- Reduce the default prefetch count of `EmailNotificationWorker` from 10 to 1
+
+* Added null checks in `ClickView.EmailService.Notifications` project. Fixes INBOX-5691
+* File scoped namespace
+
+
+# Testing
+
+
+- CORE-1362
+
+- Implements CORE-1368
+
+
+- CORE-1364
+
+
+Fixes INBOX-5691
+

package/dist/F1/ClickView.OnlineApi.md

@@ -0,0 +1,13 @@
+
+# Customer changes
+- Fixes lite users not being able to login with multiple customers via SAML. Fixes INBOX-5858
+
+
+# Code changes
+- Remove multiple user profile check during update user call
+- Remove migrate user call as all users should be in master api now
+
+
+# Testing
+- INBOX-5858
+

package/dist/F1/Clients.md

@@ -0,0 +1,19 @@
+
+# ClickView.Clients.Image.v2
+
+## Code changes
+* Added `FileIdType` parameter to `GetImageMetdata` method
+
+# ClickView.Clients.Object
+
+## Code changes
+- Rename `token` and `canelToken` to `cancellationToken`
+- Add `PermissionFilterOptions` class
+
+# monorepo
+
+## Code changes
+- Updated all tests to fix nullable errors
+- Updated `ClickView.Models`
+
+# Testing

package/dist/F1/Domain.Api.md

@@ -0,0 +1,23 @@
+
+# Dependencies
+* Search API F1 release
+
+
+# Customer changes
+* New customers that are created will randomly opt in or out of new onboarding. We are targeting 50% for each targets.
+
+
+# Code changes
+* Setup onboarding option for new customers.
+  * Implements LTE-2344.
+  * Implements LTE-2343
+
+* Supporting category id and series id filter for instant search. Partially fixes: INBOX-5795
+
+
+# Testing
+* Implements LTE-2344
+* Implements LTE-2343
+
+Partially fixes: INBOX-5795
+

package/dist/F1/Exchange.Web.md

@@ -0,0 +1,8 @@
+
+# Code changes
+- Add new illos and remove old illos.
+
+
+# Testing
+- Implements EXTV-123
+

package/dist/F1/Image.Api.md

@@ -0,0 +1,8 @@
+
+# Code changes
+- Delete all images when deleted from Master.Api, not just avatar. Implements CORE-1220
+
+
+# Testing
+- CORE-1220
+

package/dist/F1/Integrations.Api.md

@@ -0,0 +1,23 @@
+
+# Before release
+- Create rabbitmq queue and bind to master events
+- Create rabbitmq user
+- Update octo config for `rabbitmq`
+
+
+# Code changes
+- Added master event listener to delete roster mappings on `User`, `Classroom` and `Customer` delete events. Closes CORE-1366
+
+- Replace `Microsoft.IdentityModel.Clients.ActiveDirectory` with `Microsoft.Identity.Client` to fix obsolete call when updating `Microsoft.IdentityModel.Clients.ActiveDirectory`. Fixes CORE-1367
+  - Followed https://learn.microsoft.com/en-us/entra/msal/dotnet/how-to/migrate-confidential-client?tabs=daemon
+  - Added in memory cache since the token should always be the same anyway and prevents getting rate limited
+
+- Update all packages to their latest versions
+
+
+# Testing
+- CORE-1366
+
+- CORE-1367
+
+

package/dist/F1/Krakend.md

@@ -0,0 +1,8 @@
+
+# Code changes
+- Add Prospect Api validate email endpoint. Fixes INBOX-4708.
+
+
+# Testing
+- N/A
+

package/dist/F1/Lite.md

@@ -0,0 +1,60 @@
+
+# Before release
+- [ ] Remove the `featuredTopics` octo variables that are no longer needed
+## Code changes
+- Remove legacy code for using `featuredTopics` on dashboards
+  - This stopped being used with the release of our new Discover dashboards early last year. 
+  - Resolves INBOX-4371
+
+
+# Dependencies
+- https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3937 should be merged before this
+
+
+# Customer changes
+- Update fav playlist banner image
+
+
+# Code changes
+- For unauthenticated users, the current user bootstrap handler will now source the content region, country code and instance region from the geolocation, if the user is not hitting a region prefixed route.
+
+- Remove `noindex` tag from template when accessing `/series` route
+- Update robots.txt to allow crawlers to traverse the `/series` route
+- Implements GROW-10
+
+- Updated `GetGoogleAnalyticsProjectId` to only restrict GA to the UK
+  - This change not only opens up to AU, but also to public pages where we don't know the instance region.
+  - Implements GROW-9
+
+- Use `ClickView.Clients.Player` instead of a local version
+
+- Minor update on new illustration.
+
+Fixing .gitlab-ci invalid yaml that caused failed piplenes and not triggering any tests. Happened because i tweaked it earlier to bypass a failed MR to push a hotfix.
+
+- Add new image for onboarding product tips
+
+- Onboarding copy is now regionalised for US users. Implements LTE-2211
+
+- Add new illos and remove old illos.
+
+
+# Testing
+
+- https://clickview.atlassian.net/browse/GROW-10
+
+- https://clickview.atlassian.net/browse/GROW-9
+
+
+- Fixes LTE-2319
+
+
+
+- Implements LTE-2211
+
+- Implements LTE-2277
+
+- Fixes INBOX-5631
+
+- n/a
+

package/dist/F1/Master.Api.md

@@ -0,0 +1,58 @@
+
+# Code changes
+- Upgrade project to .NET8.0. Closes CORE-1372
+  - Add `Directory.Build.props` to manage net version
+- Update all packages to latest
+- Replace `o.SecurityTokenValidators` logic with `MapInboundClaims`
+- Replace `AddAuthorization` with `AddAuthorizationBuilder`
+- Replace `ISystemClock` with `TimeProvider`
+
+- Cascade delete the follow assocs (part of INBOX-5213):
+  - Video -> Glance
+  - Video -> PointOfInterest
+  - Video -> Field
+  - Clip -> Glance
+  - Clip -> PointOfInterest
+
+- Cascade delete the follow assocs (part of INBOX-5213):
+  - Playlist -> Resource
+  - Video -> Resource  
+  - Video -> Link
+  - Clip -> Resource
+  - Clip -> Link
+  - Company -> Link
+  - Person -> Link
+  - Resource -> File
+
+- Cascade delete the follow assocs (part of INBOX-5213):
+  - Playlist -> Thumbnail
+  - Playlist -> Banner
+  - Playlist -> Cover
+  - Video -> Thumbnail
+  - Video -> Poster
+  - Video -> TallPoster
+  - Video -> HeroBanner
+  - Clip -> Thumbnail
+  - Interactive -> Thumbnail
+  - Series -> Banner
+  - Series -> Thumbnail
+  - Series -> Poster
+  - Series -> TallPoster
+  - Season -> Thumbnail
+  - Season -> Poster
+  - Season -> TallPoster
+  - Company -> Banner
+  - Company -> Logo
+  - Category -> Thumbnail
+  - Category -> Banner
+  - Resource -> ResourceThumbnail
+  - Link -> ResourceThumbnail
+  - User -> Avatar
+
+
+# Testing
+- CORE-1372
+
+
+
+