@clickview/ship-it 0.0.15 → 0.0.17
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -0,0 +1,890 @@
|
|
|
1
|
+
projectName,mrTitle,mrAuthor,mrAssignee,mrUrl,notes
|
|
2
|
+
ClickView.Curator,"Update MasterCategory to fix update issue, fixes STG-382",Wei Zong,Prad Nepal,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1129,
|
|
3
|
+
ClickView.Curator,"Fix image cropping issue, fixes STG-374, STG-383, STG-380, STG-356, STG-368",Wei Zong,Prad Nepal,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1128,"## Code changes
|
|
4
|
+
- Expand image before cropping
|
|
5
|
+
|
|
6
|
+
|
|
7
|
+
## Testing
|
|
8
|
+
- All the image cropping should be accuratly matching what selected by users now."
|
|
9
|
+
ClickView.Curator,Fix trial end date update failing,Joshua Taylor,Wei Zong,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1127,
|
|
10
|
+
ClickView.Curator,Fix bulk actions,Joshua Taylor,Wei Zong,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1125,
|
|
11
|
+
ClickView.Curator,allow draft and pending video from hosted library and exchange to be deleted,Ryan Wang,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1124,"## Customer changes
|
|
12
|
+
* Fixed an issue where `Pending` or `Draft` videos in Exchange queue cannot be deleted. Close INBOX-4863
|
|
13
|
+
|
|
14
|
+
|
|
15
|
+
## Code changes
|
|
16
|
+
* Allow `Pending` and `Draft` videos from Hosted library or Exchange to be deleted
|
|
17
|
+
|
|
18
|
+
|
|
19
|
+
## Testing
|
|
20
|
+
* Go to Curator->Exchange->Pending Programs and choose a program for deletion, and the program should be deleted"
|
|
21
|
+
ClickView.Curator,.NET Core,Joshua Taylor,Wei Zong,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1123,"## Code changes
|
|
22
|
+
- Upgraded to .NET Core. Implements CC-266 and implements CC-472
|
|
23
|
+
|
|
24
|
+
|
|
25
|
+
## Testing
|
|
26
|
+
- Regression test the entirety of Curator. Every single tab, every single button/action possible, and make sure they all work as expected"
|
|
27
|
+
ClickView.Curator,Move user-man image to wizard,Nan Chen,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1111,"## Code changes
|
|
28
|
+
- Move the user-manager image success and error image to the wizard folder.
|
|
29
|
+
|
|
30
|
+
|
|
31
|
+
## Testing"
|
|
32
|
+
clickview,Curator: Fix editing playlists without a cover,Joshua Taylor,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3190,"## Testing
|
|
33
|
+
- Editing the title/description of a playlist without a cover or without a banner should succeed when running this in .NET Core. Example: https://staging.clickviewcurator.com/manage/playlists/37160616. Fixes STG-361"
|
|
34
|
+
clickview,Sign up: Remove pointless check,Shale Kuzmanovski,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3189,"## Shared
|
|
35
|
+
|
|
36
|
+
### Code changes
|
|
37
|
+
- Removed a check that we don't need that was breaking auth sign up.
|
|
38
|
+
|
|
39
|
+
## Testing"
|
|
40
|
+
clickview,Lite: Presentation Slug Urls,Michael McDonnell,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3188,"## Dependencies
|
|
41
|
+
- Requires https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/368 and https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/382
|
|
42
|
+
|
|
43
|
+
## Common
|
|
44
|
+
|
|
45
|
+
### Code changes
|
|
46
|
+
- Added support for appLink middleware processing in the `BaseAppRouter`
|
|
47
|
+
|
|
48
|
+
## Lite
|
|
49
|
+
|
|
50
|
+
### Customer changes
|
|
51
|
+
- Product urls will now contains a contextual school-level segment (aka presentation slug), reflecting the content they can access.
|
|
52
|
+
- There is an explicit set of valid presentation slugs: `primary`, `secondary`, `tertiary`, `elementary`, `middle`, and `high`.
|
|
53
|
+
- Use of any other values will result in a 404 when attempting to load the page.
|
|
54
|
+
- Navigating to content within discover, topics, video, series, playlist and latest release will now contain the user's current presentation slug
|
|
55
|
+
- For example: `/primary/topics` or `/secondary/video/`
|
|
56
|
+
- In a context where a user has access to multiple presentations, using the presentation switcher will change their presentation and in turn, update their current urls.
|
|
57
|
+
- When searching for a topic, the topic's parent presentation will now dictate the presentation slug for that link (as opposed to the user's current nominated presentation).
|
|
58
|
+
- For example, searching for ""Maths"" in the US will yield topic results from multiple presentations. Selecting any one of these topics will navigate to the topic and set the presentation slug for that presentation.
|
|
59
|
+
- This does not modify the user's underlying presentation selection and instead only exists for browsing. The presentation selector should remain unchanged in this circumstance.
|
|
60
|
+
- Videos displayed in search results will currently use the user's existing presentation, this is due to the fact that a video can exist in multiple presentations.
|
|
61
|
+
- All former urls (without the presentation slug) will continue to resolve and work as expected. All subsequent links with the product after that initial page load will incorporate the users' nominated presentation (applies to both public and authenticated states).
|
|
62
|
+
- Specific contextual details:
|
|
63
|
+
- For public/anonymous browsing:
|
|
64
|
+
- The base region URL (i.e. `/au`, `/us`) will continue to prompt the user to select a presentation if they haven't already nominated one
|
|
65
|
+
- Where a user accesses the public product via a URL containing the presentation slug, they will _not_ be prompted to nominate a presentation and the page will load as expected
|
|
66
|
+
- All former public urls (without the presentation slug) will continue to resolve and work as expected. All subsequent links with the product after that initial page load will incorporate the users' nominated presentation.
|
|
67
|
+
- For authenticated browsing:
|
|
68
|
+
- The region segment should not be part of the url (as in public), but the presentation slug should be present.
|
|
69
|
+
- Videos within `My Videos`, `Favorites` and `My Shares` will all contain slugs using the user's current presentation. This includes videos that the user has uploaded themselves. While this doesn't explicitly fit the model of content being contextual to a school-level, it was a trade-off made to ensure consistency across all videos.
|
|
70
|
+
- It is currently not possible to access a link that contains a presentation slug not used in the user's own region.
|
|
71
|
+
- For example: A US user accessing a url that has `primary` or `secondary` in the URL will not resolve correctly as it's not part of their available presentation set.
|
|
72
|
+
- In future, we will prompt the user that they're attempting to access content outside of their region and re-direct them to the appropriate matching topic in their own presentation. This was not in scope of the current changes.
|
|
73
|
+
|
|
74
|
+
### Code changes
|
|
75
|
+
- Add `presentationSlug` segment to discover, topics, video, series, playlist and latest release URLs
|
|
76
|
+
- Added new middleware for processing URL segments and applink resolution
|
|
77
|
+
- `RegisterRouteMiddleware` is executed at start up to manage:
|
|
78
|
+
- Region prefix resolution by an AppRouter
|
|
79
|
+
- Presentation slug resolution by an AppRouter
|
|
80
|
+
- Creates ""synthetic"" routes for all valid presentation routes. These are not exposed to underlying applications and allow existing applinks to be resolved transparently.
|
|
81
|
+
- `RegisterAppLinkMiddleware` is executed at start up to manage:
|
|
82
|
+
- Interception and mutation of applinks during route execution
|
|
83
|
+
- There's 3 lifecycle methods:
|
|
84
|
+
- `onBeforeExecute`: Used to augment an applink when building hrefs and internal route lookups
|
|
85
|
+
- `onExecute`: Used to augment an applink _before_ out Filter middleware executes
|
|
86
|
+
- `onAfterExexcute`: Used to augment an applink after Filter middleware has executed, but before invoking the routes method handler in an application. With this mechanism it's possible to modify which args and params are passed down to the application layer.
|
|
87
|
+
- Removed legacy `DashboardView` and `ClassificationView`
|
|
88
|
+
- We'll be able to deprecate the domain options as a result of this
|
|
89
|
+
|
|
90
|
+
## Testing
|
|
91
|
+
- In NP:
|
|
92
|
+
- Both as an authenticated and public user:
|
|
93
|
+
- Topic pages and Discover pages load as expected for Staff, Student and Public.
|
|
94
|
+
- Feature switch access to all legacy/non-discover code has been removed.
|
|
95
|
+
- The assumption here is that all NP customers + users now have access to Discover-based dashboards + topics
|
|
96
|
+
- Major-regression testing is required to ensure that page routes still work as expected
|
|
97
|
+
- Discover and topic pages should all load as expected for both Students and Teachers (regression for removal of legacy code)
|
|
98
|
+
- Navigating to content within discover, topics, video, series, playlist and latest release will now contain the user's current presentation slug.
|
|
99
|
+
- The only exception is where page-loading direct into a legacy link, howevever, all links on the page should have a presentation slug.
|
|
100
|
+
- Changing presentations via the switcher should change the presentation URL for subsequent links.
|
|
101
|
+
- Loading links without a presentation slug should continue to load as expected (backwards compatibility)
|
|
102
|
+
- Searching for a topic that's outside of the user's current presentation and navigating to it should update the URL to be the topic's presentation.
|
|
103
|
+
- Page loading a topic that's outside of the user's presentation should load as expected.
|
|
104
|
+
- The presentation switcher should always show the user's nominated presentation, even if they're on a page of content that belongs to a different presentation.
|
|
105
|
+
- As an authenticated user:
|
|
106
|
+
- Discover and topic pages should all load as expected (regression for removal of legacy code)
|
|
107
|
+
- Student discover and feed should still work as expected
|
|
108
|
+
- The following URLs have been updated to support both public region prefixes and presentation slugs:
|
|
109
|
+
- `{presentationSlug}` must be one of the following values `primary`, `secondary`, `tertiary`, `elementary`, `middle`, and `high`.
|
|
110
|
+
- Use of any other value should yield a 404
|
|
111
|
+
```
|
|
112
|
+
Root:
|
|
113
|
+
- Public:
|
|
114
|
+
- {region}(/)
|
|
115
|
+
- {region}/{presentationSlug}(/)
|
|
116
|
+
- Authenticated:
|
|
117
|
+
- (/)
|
|
118
|
+
- {presentationSlug}(/)
|
|
119
|
+
Topics:
|
|
120
|
+
- Public:
|
|
121
|
+
- {region}/topics(/)
|
|
122
|
+
- {region}/topics/:id/topics
|
|
123
|
+
- {region}/topics/:id(/:slug)
|
|
124
|
+
- {region}/{presentationSlug}/topics(/)
|
|
125
|
+
- {region}/{presentationSlug}/topics/:id/topics
|
|
126
|
+
- {region}/{presentationSlug}/topics/:id(/:slug)
|
|
127
|
+
- Authenticated:
|
|
128
|
+
- /topics(/)
|
|
129
|
+
- /topics/:id/topics
|
|
130
|
+
- /topics/:id(/:slug)
|
|
131
|
+
- {presentationSlug}/topics(/)
|
|
132
|
+
- {presentationSlug}/topics/:id/topics
|
|
133
|
+
- {presentationSlug}/topics/:id(/:slug)
|
|
134
|
+
Latest Releases:
|
|
135
|
+
- Public:
|
|
136
|
+
- {region}/latest-releases
|
|
137
|
+
- {region}/latest-releases/:id(/:slug)
|
|
138
|
+
- {region}/{presentationSlug}/latest-releases
|
|
139
|
+
- {region}/{presentationSlug}/latest-releases/:id(/:slug)
|
|
140
|
+
- Authenticated:
|
|
141
|
+
- /latest-releases
|
|
142
|
+
- /latest-releases/:id(/:slug)
|
|
143
|
+
- /{presentationSlug}/latest-releases
|
|
144
|
+
- /{presentationSlug}/latest-releases/:id(/:slug)
|
|
145
|
+
Discover:
|
|
146
|
+
- Public:
|
|
147
|
+
- {region}/discover(/)
|
|
148
|
+
- {region}/discover/:id/:name
|
|
149
|
+
- {region}/{presentationSlug}/discover(/)
|
|
150
|
+
- {region}/{presentationSlug}/discover/:id/:name
|
|
151
|
+
- Authenticated:
|
|
152
|
+
- /discover(/)
|
|
153
|
+
- /discover/:id/:name
|
|
154
|
+
- /{presentationSlug}/discover(/)
|
|
155
|
+
- /{presentationSlug}/discover/:id/:name
|
|
156
|
+
Content pages:
|
|
157
|
+
- Public:
|
|
158
|
+
- {region}/playlists/:id(/:slug)
|
|
159
|
+
- {region}/series/:id(/:slug)
|
|
160
|
+
- {region}/videos/:id(/:slug)
|
|
161
|
+
- {region}/{presentationSlug}/playlists/:id(/:slug)
|
|
162
|
+
- {region}/{presentationSlug}/series/:id(/:slug)
|
|
163
|
+
- {region}/{presentationSlug}/videos/:id(/:slug)
|
|
164
|
+
- Authenticated:
|
|
165
|
+
- /playlists/:id(/:slug)
|
|
166
|
+
- /series/:id(/:slug)
|
|
167
|
+
- /videos/:id(/:slug)
|
|
168
|
+
- {presentationSlug}/playlists/:id(/:slug)
|
|
169
|
+
- {presentationSlug}/series/:id(/:slug)
|
|
170
|
+
- {presentationSlug}/videos/:id(/:slug)
|
|
171
|
+
```
|
|
172
|
+
- In LE/Analytics:
|
|
173
|
+
- Regression testing of link navigation. Everything should work as expected.
|
|
174
|
+
- This one need only be quick. They use the same app router we use in NP, so we just need to make sure it hasn't broken anything.
|
|
175
|
+
- Share links for video, playlists should continue to resolve.
|
|
176
|
+
- Video links that are resolved via launch should continue to work as expected (for example, those from RSS)"
|
|
177
|
+
clickview,"Lite: Check analytics product for ""view usage"" actions",Joshua Taylor,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3187,"## Lite
|
|
178
|
+
|
|
179
|
+
### Customer changes
|
|
180
|
+
- The ""View usage"" actions on clips and videos, and ""View results"" action on interactives will no longer appear for users who don't have access to the analytics product, such as free trial users. Fixes INBOX-4858
|
|
181
|
+
|
|
182
|
+
## Testing
|
|
183
|
+
- As a trial user, you should not be able to see the ""View usage"" action on videos you have uploaded to NP."
|
|
184
|
+
clickview,Fix video counts in playlist header,Nan Chen,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3186,"## Lite
|
|
185
|
+
|
|
186
|
+
### Customer changes
|
|
187
|
+
- Fix the video count in the playlist header is not updating when a video is removed. Fix INBOX-4865
|
|
188
|
+
|
|
189
|
+
## Shared
|
|
190
|
+
|
|
191
|
+
### Code changes
|
|
192
|
+
- Add an invalidation key to the request to remove the video from a playlist to get updated playlist data.
|
|
193
|
+
|
|
194
|
+
## Testing
|
|
195
|
+
- In lite, viewing a playlist, remove videos from the list. The video count in the header should be updated accordingly."
|
|
196
|
+
clickview,#curator Add video title to EditVideoTagsView,Nan Chen,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3185,"## Curator
|
|
197
|
+
|
|
198
|
+
### Customer changes
|
|
199
|
+
- Added video title to Tags tab on video edit page in Curator. Implements INBOX-4867
|
|
200
|
+
|
|
201
|
+
## Testing
|
|
202
|
+
- In the Curator, editing tags of a video, there should be a video title on the top."
|
|
203
|
+
clickview,Curator: Add search bar and filter buttons,Joshua Taylor,Nan Chen,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3182,"## Curator
|
|
204
|
+
|
|
205
|
+
### Customer changes
|
|
206
|
+
- (dev only) Curation studio now contains a search bar and filter buttons that don't work. Implements CC-533
|
|
207
|
+
|
|
208
|
+
## Testing"
|
|
209
|
+
clickview,Auth: Social sign up support + Domain settings support,Shale Kuzmanovski,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3181,"## Auth
|
|
210
|
+
|
|
211
|
+
### Customer changes
|
|
212
|
+
- [Internal Access] When signing in via google or microsoft, users will now be prompted to tell us if they are an educator or a student.
|
|
213
|
+
- [Internal Access] When signing into auth with a user that has no customers (i.e. Google and Microsoft sign up), you will be prompted to selected a prospect using the prospect selector from the Lite sign up. If you select an active customer who has correctly configured their domain settings, you will be able to either request to join the school, or automatically join the school, depending on the domain settings setup.
|
|
214
|
+
|
|
215
|
+
### Code changes
|
|
216
|
+
- Auth is now importing common, shared and analytics. As it currently stands, we will have to run a bundle analyzer with every release of auth to ensure that legacy dependencies are not pulled in, until we can come up with a dependency validation solution for the project.
|
|
217
|
+
- The `CustomerView` is not immediately redirecting to the `ProspectSelectView` if the user does not have any customers.
|
|
218
|
+
- The `IdpButton` has been split out into `IdpButton` and `GlobalIdpButton`.
|
|
219
|
+
- `GlobalIdpButton` is used for IDPs that are displayed before we have a username or email.
|
|
220
|
+
- `IdpButton` is used to select SSO after we are able to use the username or email to pull a list of IDPs (Which are just school names for any SAML setups)
|
|
221
|
+
|
|
222
|
+
## Lite
|
|
223
|
+
|
|
224
|
+
### Customer changes
|
|
225
|
+
- [Internal Access] When signing up, added the ability to automatically join active customer accounts, if they have set their domain settings to allow you to do so.
|
|
226
|
+
|
|
227
|
+
## Shared
|
|
228
|
+
|
|
229
|
+
### Code changes
|
|
230
|
+
- The sign up app has been re-worked so that a `productName` is passed in by both auth and lite, in order to differentiate behavior. Similarly the `SignUpAjaxUrls` now takes a `productName` in order to define the types that we actually need from our injected URLs.
|
|
231
|
+
- Added a `RequestAccess` step and `RequestedAccess` completion step, for requesting to join a school. Currently this is only used by Auth, but will be used by Lite also once the backend support for Lite is completed.
|
|
232
|
+
- The `CompletedStepItem` has been reworked so that for students, the same messages and images are shown for the new `user-auto-join-allowed` and 'user-`join-approval-required` trial status.
|
|
233
|
+
- The unmanagable `requestTrial` function has been refactored out of the `SearchSchoolStepItem` to try to make it more managable. This hasn't been done in the most elegant way, but has definitely improved the readability.
|
|
234
|
+
|
|
235
|
+
## Testing
|
|
236
|
+
#### Regression tests
|
|
237
|
+
We need to test signing up for one of each of the following types of prospects from Lite. The prospect status can be checked by looking for the `/v1/prospects/_146766174306594881/trial-status` request in the network tab before submitting the school select form:
|
|
238
|
+
- `active` Customer who is currently trialing
|
|
239
|
+
- `not-required` Customer who already has full access
|
|
240
|
+
- `available` Customer does not exist
|
|
241
|
+
- `unsupported` Secondary school in UK or AU
|
|
242
|
+
- Can't find my school (not a status, but needs a good test)
|
|
243
|
+
#### New feature tests
|
|
244
|
+
Testing these features will require help from development to set up certain parameters properly, as it will require writing directly to databases. Talk to Sha or Ryan, they should be able to help you set stuff up.
|
|
245
|
+
##### Auth
|
|
246
|
+
1. Go to auth, and use the following command in the console to set cookies to opt into features.
|
|
247
|
+
```
|
|
248
|
+
document.cookie = ""features.social-signup=true;"";
|
|
249
|
+
document.cookie = ""features.user-no-customers=true;"";
|
|
250
|
+
document.cookie = ""features.account-linking=true;"";
|
|
251
|
+
```
|
|
252
|
+
These cookies are set up to only last your session.
|
|
253
|
+
2. Click on the sign in button from Lite (This is important), and then when you get to auth add the `&emulateUSA=true` query param.
|
|
254
|
+
3. Sign in with Google and/or Microsoft
|
|
255
|
+
4. Select `Educator`
|
|
256
|
+
5. Repeat all of the tests that are listed under Testing -> Sign up changes -> Regression tests, but for Lite
|
|
257
|
+
6. With a school who has a request to join domain settings set up, request to join a school.
|
|
258
|
+
7. With a school who has auto join domain set up, request to join a school.
|
|
259
|
+
##### Lite
|
|
260
|
+
1. With a school who has auto join domain set up, request to join a school."
|
|
261
|
+
clickview,Special event/anan browsing,Nan Chen,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3177,"## Dependencies
|
|
262
|
+
- https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/381
|
|
263
|
+
|
|
264
|
+
## Common
|
|
265
|
+
|
|
266
|
+
### Code changes
|
|
267
|
+
- Update DateHelper isValid method.
|
|
268
|
+
|
|
269
|
+
## Lite
|
|
270
|
+
|
|
271
|
+
### Customer changes
|
|
272
|
+
- Now, public user can see special event calendar in Lite. Implements LTE-1871
|
|
273
|
+
- Now if you try to visit calendar with an invalid month, a error state page will be displayed.
|
|
274
|
+
|
|
275
|
+
### Code changes
|
|
276
|
+
- Remove the `monthDate` query param, and add it to the route.
|
|
277
|
+
|
|
278
|
+
## Shared
|
|
279
|
+
|
|
280
|
+
### Code changes
|
|
281
|
+
- Update Calendar applink in DiscoverHeader.
|
|
282
|
+
|
|
283
|
+
## Testing
|
|
284
|
+
- In Lite, an anonymous user should able to visit Calendar page.
|
|
285
|
+
- In Lite, visit an invalid calendar page, (`/calendar/{date}` where the date doesn't align to MMM-YYYY format), an error state should be displayed. There is an link navigate you back to the current month calendar page."
|
|
286
|
+
clickview,Sign up: Decouple from core dependencies,Shale Kuzmanovski,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3175,"## Shared
|
|
287
|
+
|
|
288
|
+
### Code changes
|
|
289
|
+
- The sign up app should no longer pull in a large number of dependencies it really doesn't need. i.e. (Backbone, Marionette, Underscore, Moment, every single one of our SVGs)
|
|
290
|
+
|
|
291
|
+
## Testing"
|
|
292
|
+
clickview,Add new support article for content permission,Nan Chen,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3173,"## Lite
|
|
293
|
+
|
|
294
|
+
### Customer changes
|
|
295
|
+
- Now in content permission page, there is a link to learn more about content permission. Implements INBOX-4830
|
|
296
|
+
|
|
297
|
+
## Shared
|
|
298
|
+
|
|
299
|
+
### Code changes
|
|
300
|
+
- Add new SupportArticle Id.
|
|
301
|
+
|
|
302
|
+
## Testing
|
|
303
|
+
- In lite, got to `/settings/content-permissions` page, there should be a link to this support article: https://support.clickvieweducation.com/hc/en-au/articles/14692125209497-Content-Permissions-and-Year-Group-Access"
|
|
304
|
+
clickview,Sign up: Ignore unknown prospect types,Shale Kuzmanovski,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3172,"## Shared
|
|
305
|
+
|
|
306
|
+
### Code changes
|
|
307
|
+
- If a prospect type is `Unknown`, the prospect type will not be sent to braze. Fixes INBOX-4777.
|
|
308
|
+
|
|
309
|
+
## Testing"
|
|
310
|
+
clickview,Sign up: Prevent student data from entering braze,Shale Kuzmanovski,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3171,"## Shared
|
|
311
|
+
|
|
312
|
+
### Code changes
|
|
313
|
+
- No longer sending data for braze for a niche use case: If a user selects `I'm an educator` initially, then proceeds to enter their job title as `student` or `parent` in the job title section. NOTE: This change only applies to schools who are not yet supported (i.e. Secondary Schools in AU and UK). Fixes INBOX-4796.
|
|
314
|
+
|
|
315
|
+
## Testing"
|
|
316
|
+
clickview,Curator: Fix topic reports,Joshua Taylor,Nan Chen,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3168,"## Curator
|
|
317
|
+
|
|
318
|
+
### Customer changes
|
|
319
|
+
- Fixed a bug where if you exported a dashboard's videos, or a topic's video table, and any video had commas or a ""#"" symbol in it, the CSV would be missing content. Fixes INBOX-4843
|
|
320
|
+
|
|
321
|
+
## Testing
|
|
322
|
+
- Export a topic's video table in Curator, when one of the video names has a ""#"" or a "","" in it. The exported CSV should contain all of the video information but the ""#"" and "","" should be removed from the names.
|
|
323
|
+
- Export a topic dashboard's videos in Curator, when one of the video names has a ""#"" or a "","" in it. The exported CSV should contain all of the video information but the ""#"" and "","" should be removed from the names."
|
|
324
|
+
clickview,Lite: Fix library requests,Joshua Taylor,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3167,"## Lite
|
|
325
|
+
|
|
326
|
+
### Customer changes
|
|
327
|
+
- Fixed an issue where the ""add to library"" action would sometimes fail. Fixes INBOX-4852
|
|
328
|
+
|
|
329
|
+
### Code changes
|
|
330
|
+
- Fixed a bug where sometimes making a library request would fail because the `sourceCategoryId` wasn't in the `sourceLibraryId`. Now, the `sourceCategoryId` will always be a category within the `sourceLibraryId`.
|
|
331
|
+
|
|
332
|
+
## Testing
|
|
333
|
+
- Check out https://clickview.atlassian.net/browse/INBOX-4852. Sometimes, the ""add to library"" request would fail. Test this on a few ClickView videos and they should all work. Preferably test this on an account whose customer has a lot of libraries associated."
|
|
334
|
+
clickview,Lite: Update audience abbreviations for England Primary,Joshua Taylor,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3166,"## Lite
|
|
335
|
+
|
|
336
|
+
### Customer changes
|
|
337
|
+
- Audience badges for UK Primary will now be more abbreviated (implements INBOX-4771). Some examples include:
|
|
338
|
+
- ""Reception"" will now be shortened to ""R"" if it is displayed in a range, e.g. ""R - Upper KS2""
|
|
339
|
+
- If the range is ""Lower Key Stage X - Upper Key Stage X"" the ""Upper"" and ""Lower"" words will now be shortened to ""U"" and ""L"". Example: ""L KS2 - KS2""
|
|
340
|
+
|
|
341
|
+
## Testing
|
|
342
|
+
- Audience badges for UK Primary will now be more abbreviated. Some examples include:
|
|
343
|
+
- ""Reception"" will now be shortened to ""R"" if it is displayed in a range, e.g. ""R - Upper KS2""
|
|
344
|
+
- If the range is ""Lower Key Stage X - Upper Key Stage X"" the ""Upper"" and ""Lower"" words will now be shortened to ""U"" and ""L"". Example: ""L KS2 - KS2"""
|
|
345
|
+
clickview,Sign up: New Job title for US and AU,Shale Kuzmanovski,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3164,"## Auth
|
|
346
|
+
|
|
347
|
+
### Customer changes
|
|
348
|
+
- Added new job titles when signing up. Implements INBOX-4840.
|
|
349
|
+
- `Head of Subject` for AU
|
|
350
|
+
- `Subject lead` for US
|
|
351
|
+
|
|
352
|
+
## Lite
|
|
353
|
+
|
|
354
|
+
### Customer changes
|
|
355
|
+
- Added new job titles when signing up. Implements INBOX-4840
|
|
356
|
+
- `Head of Subject` for AU
|
|
357
|
+
- `Subject lead` for US
|
|
358
|
+
|
|
359
|
+
## Testing"
|
|
360
|
+
clickview,Updated the .npmrc example,Boris Berak,Boris Berak,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3162,"## Monorepo
|
|
361
|
+
|
|
362
|
+
### Code changes
|
|
363
|
+
- Simplified the example .npmrc file (the previous example was deceitful as it worked in some situations but not in others).
|
|
364
|
+
|
|
365
|
+
## Testing"
|
|
366
|
+
clickview,Lite: Show sign up popup for public resources,Michael McDonnell,Nan Chen,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3160,"## Lite
|
|
367
|
+
|
|
368
|
+
### Customer changes
|
|
369
|
+
- Clicking on a resource on the public play page will now display the sign-up popup
|
|
370
|
+
|
|
371
|
+
### Code changes
|
|
372
|
+
- Add local permission for `ViewVideoResourceItems`
|
|
373
|
+
- Add `canViewResourceItems` to `useVideoFeatureAccess`
|
|
374
|
+
- Update `childAppLink` handling for public `ResourceWidgetItem`
|
|
375
|
+
|
|
376
|
+
## Testing
|
|
377
|
+
- In NP:
|
|
378
|
+
- As an authenticated user:
|
|
379
|
+
- Clicking on resource items should continue to show the resource preview as expected (regression)
|
|
380
|
+
- As a public user:
|
|
381
|
+
- Clicking on resource items will now display the sign-up popup. The one exception is link resources, which continue to function as they do today."
|
|
382
|
+
clickview,All: Remove usage of useSetPageTitle across products outside of Lite,Michael McDonnell,Nan Chen,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3158,"## Dependencies
|
|
383
|
+
- Builds upon https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3153, which should be merged first
|
|
384
|
+
|
|
385
|
+
## Common
|
|
386
|
+
|
|
387
|
+
### Code changes
|
|
388
|
+
- Remove `useSetPageTitle`
|
|
389
|
+
- Removed `PageTitleContext`
|
|
390
|
+
- Replaced all usage of `useSetPageTitle` with `useSetPageMetadata`
|
|
391
|
+
|
|
392
|
+
## Curator
|
|
393
|
+
|
|
394
|
+
### Code changes
|
|
395
|
+
- Updated `FullScreenLayoutComponent` to use `PageMetadataContext`
|
|
396
|
+
|
|
397
|
+
## Library Editor
|
|
398
|
+
|
|
399
|
+
### Code changes
|
|
400
|
+
- Replaced all usage of `useSetPageTitle` with `useSetPageMetadata`
|
|
401
|
+
|
|
402
|
+
## Online
|
|
403
|
+
|
|
404
|
+
### Code changes
|
|
405
|
+
- Replaced all usage of `useSetPageTitle` with `useSetPageMetadata`
|
|
406
|
+
|
|
407
|
+
## Reports
|
|
408
|
+
|
|
409
|
+
### Code changes
|
|
410
|
+
- Replaced all usage of `useSetPageTitle` with `useSetPageMetadata`
|
|
411
|
+
- Updated `ReportsLayout` to use `PageMetadataContext`
|
|
412
|
+
|
|
413
|
+
## Testing
|
|
414
|
+
- In LE:
|
|
415
|
+
- General regression test of page titles. All titles should continue to update in the browser while browsing the product.
|
|
416
|
+
- In Reports/New Analytics:
|
|
417
|
+
- General regression test of page titles. All titles should continue to update in the browser while browsing the product.
|
|
418
|
+
- In Online:
|
|
419
|
+
- General regression test of page titles. All titles should continue to update in the browser while browsing the product.
|
|
420
|
+
- Dashboard, Topics (inc Content Updates), Workspace Edit Video page, Exchange landing, M+TV Landing and Playlists page should load as expected with page titles set.
|
|
421
|
+
- Creating a playlist, editing the playlist details and deleting a playlist should all update the page title while the popup is on screen, then revert back to the old page title once the popup closes.
|
|
422
|
+
- In NP:
|
|
423
|
+
- General regression test of all core pages to ensure that the page title is being set
|
|
424
|
+
- Areas of focus (newer react-based pages):
|
|
425
|
+
- Play video in playlist
|
|
426
|
+
- Edit video in playlist
|
|
427
|
+
- Remove video from playlist
|
|
428
|
+
- Delete playlist
|
|
429
|
+
- View classification/topic playlist
|
|
430
|
+
- Userman: Bulk user upload account review page
|
|
431
|
+
- Userman: Staff management page
|
|
432
|
+
- Userman: Student management page
|
|
433
|
+
- Share playlist popup"
|
|
434
|
+
clickview,Lite: Replace usage of useSetPageTitle with useSetPageMetadata,Michael McDonnell,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3153,"## Dependencies
|
|
435
|
+
- Requires changes from https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3150
|
|
436
|
+
|
|
437
|
+
## Lite
|
|
438
|
+
|
|
439
|
+
### Code changes
|
|
440
|
+
- Replace all usage of `useSetPageTitle` in `projects/lite/*` with `useSetPageMetadata`
|
|
441
|
+
- Remove unnecessary page title changes for Playlist popups
|
|
442
|
+
|
|
443
|
+
## Testing
|
|
444
|
+
- In NP:
|
|
445
|
+
- As an authenticated user:
|
|
446
|
+
- All pages should continue to correctly update the title page when navigating throughout the product (regression test)
|
|
447
|
+
- As a public user:
|
|
448
|
+
- All public pages should continue to correctly update the title page when navigating throughout the product (regression test)
|
|
449
|
+
- Dev test: `description` meta tag should now be populated on all content pages"
|
|
450
|
+
clickview,Minor documentation updates,Boris Berak,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3149,"## Monorepo
|
|
451
|
+
|
|
452
|
+
### Code changes
|
|
453
|
+
- Added some documentation about Node, NPM and `.npmrc` prerequisites.
|
|
454
|
+
- Changed the `Getting Started` section to include an initial `npm ci` step and removed the instruction to install `lerna` and `symlin-dir` globally as this does not appear to be necessary anymore.
|
|
455
|
+
- Also added `.DS_Store` to the `.gitignore` because MacOS generates these annoying hidden files every time you open a folder using the file explorer.
|
|
456
|
+
|
|
457
|
+
## Testing"
|
|
458
|
+
clickview,Curation Studio: Wire up single actions,Joshua Taylor,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3145,"## Dependencies
|
|
459
|
+
- https://gitlab.cvinternal.net/clickview/front-end/ClickView.Curator/-/merge_requests/1120
|
|
460
|
+
|
|
461
|
+
## Curator
|
|
462
|
+
|
|
463
|
+
### Customer changes
|
|
464
|
+
- (dev only) All forms in the Ingestion stage of Curation Studio have been wired up to backend endpoints (although the form data that's fetched when you open the form is still mocked. any changes you make though will be persisted to the backend). Implements CC-528
|
|
465
|
+
|
|
466
|
+
## Testing
|
|
467
|
+
- In Curation Studio, in the ingestion tab, test every single form for the first video in the table (called ""Harry Potter and the Sorcerers Stone""). When you open each form, the data will be incorrect (which is fine because the fetching part is mocked still). But, when you make changes in the form and hit ""save"", these will be persisted in the database for video with ID `3713754`. If you refresh this page: https://staging.clickviewcurator.com/hostedlibraries/programs/3713754, the changes you made should be visible in that form (although they won't be visible in curation studio yet)."
|
|
468
|
+
clickview,Curation Studio Bulk Actions: Bulk job & result,Nan Chen,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3144,"## Curator
|
|
469
|
+
|
|
470
|
+
### Customer changes
|
|
471
|
+
- (dev only) Implement bulk actions in the curation studio. Now curator can see the bulk action progress and result in the popup. Implement CC-508
|
|
472
|
+
|
|
473
|
+
## Shared
|
|
474
|
+
|
|
475
|
+
### Code changes
|
|
476
|
+
- Add new bulk action type & data & name enum.
|
|
477
|
+
|
|
478
|
+
## Testing
|
|
479
|
+
- In the assembly line, all the bulk actions, except 'Add to libraries', should be working when you use real video id from staging."
|
|
480
|
+
clickview,Fix hover portal render,Nan Chen,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3136,"## Shared
|
|
481
|
+
|
|
482
|
+
### Code changes
|
|
483
|
+
- Fix a warning in HoverToPortalContainer when clicking on the thumbnail and jumping to the play page. Fix INBOX-4726
|
|
484
|
+
|
|
485
|
+
## Testing
|
|
486
|
+
- n/a"
|
|
487
|
+
clickview,Curation Studio: Resourcing Table,Joshua Taylor,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3124,"## Curator
|
|
488
|
+
|
|
489
|
+
### Customer changes
|
|
490
|
+
- (dev only) Added a table to the resourcing tab. Implements CC-511
|
|
491
|
+
|
|
492
|
+
## Testing"
|
|
493
|
+
clickview,Lite: Update media query utils,Joshua Taylor,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/2957,"## Curator
|
|
494
|
+
|
|
495
|
+
### Code changes
|
|
496
|
+
- Added `BreakpointsContextProvider`
|
|
497
|
+
|
|
498
|
+
## Library Editor
|
|
499
|
+
|
|
500
|
+
### Code changes
|
|
501
|
+
- Added `BreakpointsContextProvider`
|
|
502
|
+
|
|
503
|
+
## Lite
|
|
504
|
+
|
|
505
|
+
### Code changes
|
|
506
|
+
- Replaced usage of `@include media` with Bootstrap's media query mixin. Partially implements INBOX-4474
|
|
507
|
+
- Replaced usage of `useGetMediaQueryString` with `useBreakpoints`. Partially implements INBOX-4474
|
|
508
|
+
- Added `BreakpointsContextProvider`
|
|
509
|
+
|
|
510
|
+
## Online
|
|
511
|
+
|
|
512
|
+
### Code changes
|
|
513
|
+
- Added `BreakpointsContextProvider`
|
|
514
|
+
|
|
515
|
+
## Reports
|
|
516
|
+
|
|
517
|
+
### Code changes
|
|
518
|
+
- Added `BreakpointsContextProvider`
|
|
519
|
+
|
|
520
|
+
## Shared
|
|
521
|
+
|
|
522
|
+
### Code changes
|
|
523
|
+
- Added a new `BreakpointsContext`, which calls `useMediaQuery` for each breakpoint and passes the current breakpoint down to all children. This is accessible through the `useBreakpoints` hook. Partially implements INBOX-4474
|
|
524
|
+
|
|
525
|
+
## Styles
|
|
526
|
+
|
|
527
|
+
### Code changes
|
|
528
|
+
- Replaced usage of `@include media` with Bootstrap's media query mixin. Partially implements INBOX-4474
|
|
529
|
+
|
|
530
|
+
## Testing
|
|
531
|
+
- Regression test the responsiveness of a curated topics page is the same as in production
|
|
532
|
+
- Regression test the responsiveness a play page is the same as in production
|
|
533
|
+
- Regression test the responsiveness of the discover page is the same as in production
|
|
534
|
+
- Regression test the responsiveness of a playlist page is the same as in production"
|
|
535
|
+
Users.Api,Fix delete user,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/197,"## Before release
|
|
536
|
+
* [ ] Update `ClickView.Clients.*` nuget to the stable release version
|
|
537
|
+
|
|
538
|
+
|
|
539
|
+
## Customer changes
|
|
540
|
+
* Fixed an issue where an exception is thrown when deleting a user. Close STG-394
|
|
541
|
+
|
|
542
|
+
|
|
543
|
+
## Code changes
|
|
544
|
+
* Update `ClickView.Clients.Master` to use the latest change in nuget package
|
|
545
|
+
* Fixed a compilation error introduced in this MR https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/187
|
|
546
|
+
|
|
547
|
+
|
|
548
|
+
## Testing
|
|
549
|
+
* A user can be deleted successfully when deleting a user in user manager"
|
|
550
|
+
Users.Api,Approved domain error handling,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/196,"## Code changes
|
|
551
|
+
* Include `Id` in the `SetApprovedDomainError` so that the frontend can use it to map the error if an `Id` is available
|
|
552
|
+
* Validate all input domains and return error per domain if any
|
|
553
|
+
|
|
554
|
+
|
|
555
|
+
## Testing
|
|
556
|
+
* Setting two domains, one is in the blacklist and another is empty, and two errors should be returned and one for each domain."
|
|
557
|
+
Users.Api,Join request error handling,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/195,"## Code changes
|
|
558
|
+
* Throw `UserNotFoundException` (`404 Not Found` in response) if a user does not exist or has been deleted
|
|
559
|
+
* Throw `CreateJoinRequestException` with different problem type (`400 Bad Request` in response) when creating join request
|
|
560
|
+
* `create-join-request-failed` error code is returned if no specific problem type is specified
|
|
561
|
+
* `user-type-not-supported` error code is returned if attempting to create join request for a learner account
|
|
562
|
+
* `join-not-required` error code is returned if the user is already part of the customer
|
|
563
|
+
* `join-request-already-pending` error code is returned if the user has already had a pending join request
|
|
564
|
+
* `join-request-already-denied` error code is returned if the user has already had a denied join request
|
|
565
|
+
* `user-email-invalid` error code is returned if the user does not have a valid email
|
|
566
|
+
* `user-email-domain-not-approved` error code is returned if the user's email domain is not an approved domain
|
|
567
|
+
* `join-request-not-allowed` error code is returned if the customer does not want any user to request to join
|
|
568
|
+
* Allow new join request notification to be sent for `AccessType.RequiresApproval` and `AccessType.Anyone`
|
|
569
|
+
* Set join request to `JoinRequestStatus.Approved` only if the customer's approved domain access type is `AccessType.Immediate`
|
|
570
|
+
* Allow unverified email to be used for approved domain verification
|
|
571
|
+
|
|
572
|
+
|
|
573
|
+
## Testing"
|
|
574
|
+
Users.Api,Invite colleague no owner,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/194,"## Code changes
|
|
575
|
+
* Add new endpoint `POST v1/invites/internal` to allow sign up app in lite to create invitation on behalf of customer if the customer has full access and has auto-join enabled.
|
|
576
|
+
|
|
577
|
+
|
|
578
|
+
## Testing"
|
|
579
|
+
Users.Api,Handle auto join customer,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/193,"## Code changes
|
|
580
|
+
* Update `CreateTrialAsync(ulong userId, CreateTrialRequest request)` to allow user to be added to the paid customer if the customer has auto join enabled and no braze and analytics event will be logged in this case
|
|
581
|
+
|
|
582
|
+
|
|
583
|
+
## Testing
|
|
584
|
+
* Staff signs in via Google or Microsoft and chooses a paid customer with auto-join enabled, the user should be able to sign in to that school immediately"
|
|
585
|
+
Users.Api,Set approved domains,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/192,"## Before release
|
|
586
|
+
* [ ] Run `004-approved_domains_drop_columns.sql` script to drop both `Deleted` and `DateDeleted` columns
|
|
587
|
+
|
|
588
|
+
|
|
589
|
+
## Code changes
|
|
590
|
+
* Add a new endpoint `PUT v1/customers/{id}/approved-domains` to bulk add/update/delete domains
|
|
591
|
+
* Add new access types
|
|
592
|
+
* `NotAllowed` - allow school to opt out join requests specifically, so that no one can request to join the school
|
|
593
|
+
* `Anyone` - allow any user to request to join the school
|
|
594
|
+
* Hard delete the record if deleting an approved domain is needed
|
|
595
|
+
* Add `ApprovedDomainEntity` to separate data layer model from api view model
|
|
596
|
+
* Add `UserAutoJoinAllowed` and `UserJoinApprovalRequired` status to `ProspectTrialStatus` enum
|
|
597
|
+
* Update `GET v1/trials/prospects/{prosectId}/status` to return two new statuses for the active non-trial customer if they have approved domain setup to allow join request
|
|
598
|
+
* Add `SetApprovedDomainError` to be included in `problems` property in the `400 Bad Request` response with error code `domain-validation-failed` if there is any error while setting the approved domain for a customer
|
|
599
|
+
* `domain-duplicated`: The provided domains in the request body contain duplicated domain for the same customer
|
|
600
|
+
* `domain-not-certified`: The provided domain is in our domain blacklist
|
|
601
|
+
* `domain-already-exists`: The provided domain has already existed
|
|
602
|
+
* `domain-empty`: The provided domain is an empty string
|
|
603
|
+
* `deletion-item-missing-id`: The Id is not provided when an item is set to be deleted
|
|
604
|
+
|
|
605
|
+
|
|
606
|
+
## Testing
|
|
607
|
+
* Hitting the endpoint `PUT v1/customers/{id}/approved-domains` with a list of domains should add them for the customer if not exists and update them if they already exists and also delete them if `ShouldDelete` property is set to `true`
|
|
608
|
+
* Hitting `GET v1/trials/prospects/{prosectId}/status` endpoint with prospectId that is an active customer and has approved domain setup"
|
|
609
|
+
Users.Api,Add new access type,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/191,
|
|
610
|
+
Users.Api,Check customer trial status,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/190,
|
|
611
|
+
Users.Api,Create unverified email domain when creating trials,Kevin Wellalagodage,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/187,"## Before release
|
|
612
|
+
- Update `ClickView.Clients.Prospect` to release version
|
|
613
|
+
|
|
614
|
+
|
|
615
|
+
## Code changes
|
|
616
|
+
- Create an unverified email domain in User API for every new trial. Implements CORE-1124
|
|
617
|
+
|
|
618
|
+
|
|
619
|
+
## Testing
|
|
620
|
+
- Create a new trial and then ask Kevin if an unverified email domain has been created."
|
|
621
|
+
Users.Api,Respect allow signup property,Kevin Wellalagodage,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/185,"## Code changes
|
|
622
|
+
- Only allow sign ups for customers with an access policy that has `AllowSignup` set to `true`. Implements INBOX-4744
|
|
623
|
+
|
|
624
|
+
|
|
625
|
+
## Testing
|
|
626
|
+
- Ensure that sign up doesn't work for a school that has the `bdm_v1` access policy."
|
|
627
|
+
Users.Api,Use ClickView.Clients.Permission,Kevin Wellalagodage,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/184,"## Before release
|
|
628
|
+
* [ ] Update `ClickView.Clients` to release versions
|
|
629
|
+
|
|
630
|
+
|
|
631
|
+
## Code changes
|
|
632
|
+
- Use ClickView.Clients.Permission instead of local implementation
|
|
633
|
+
|
|
634
|
+
|
|
635
|
+
## Testing
|
|
636
|
+
- Sign up for a trial and ensure that the trial banner is shown
|
|
637
|
+
- [Create a customer](https://staging.clickviewcurator.com/customers/new) and ensure that they have the correct products"
|
|
638
|
+
Users.Api,Replace master client with clients package,Jorge Arai,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/users.api/-/merge_requests/183,"## Customer changes
|
|
639
|
+
|
|
640
|
+
|
|
641
|
+
## Code changes
|
|
642
|
+
- Removed existing Master Api clients
|
|
643
|
+
- Added Master Api Clients package
|
|
644
|
+
- Reviewed/adjusted all master API endpoints requests.
|
|
645
|
+
Implements INBOX-4367
|
|
646
|
+
|
|
647
|
+
|
|
648
|
+
## Testing
|
|
649
|
+
- All user API features should work as expected"
|
|
650
|
+
Clients,use v1/objects for delete method,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/clients/-/merge_requests/97,"## ClickView.Clients.Master
|
|
651
|
+
### Customer changes
|
|
652
|
+
* Fixed an issue where Method not allowed error is thrown when deleting a user. Close STG-394
|
|
653
|
+
### Code changes
|
|
654
|
+
* Use `v1/objects/{id}` for DELETE method
|
|
655
|
+
|
|
656
|
+
|
|
657
|
+
## Testing"
|
|
658
|
+
Clients,Create join request,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/clients/-/merge_requests/96,"## ClickView.Clients.User
|
|
659
|
+
### Code changes
|
|
660
|
+
- Add `CreateJoinRequestAsync` to create join requests for existing users.
|
|
661
|
+
|
|
662
|
+
|
|
663
|
+
## Testing"
|
|
664
|
+
Clients,Add create domain method to Prospect client,Kevin Wellalagodage,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/clients/-/merge_requests/95,"## ClickView.Clients.Prospect
|
|
665
|
+
### Code changes
|
|
666
|
+
- Add `CreateDomainAsync` method
|
|
667
|
+
- Remove brittle tests. Implements INBOX-4818
|
|
668
|
+
|
|
669
|
+
|
|
670
|
+
## Testing"
|
|
671
|
+
Subjects.API,Order classification paths,Kevin Wellalagodage,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/clickview.subjects.api/-/merge_requests/198,"## Customer changes
|
|
672
|
+
- Curriculum links should be sorted alphabetically.
|
|
673
|
+
|
|
674
|
+
|
|
675
|
+
## Code changes
|
|
676
|
+
- Alphabetically sort paths returned by classification paths endpoints. Fixes INBOX-4857:
|
|
677
|
+
- `v1/presentations/{presentationId}/objects/{masterObjectId}/classifications/paths`
|
|
678
|
+
- `v1/customers/{customerId}/users/{userId}/objects/{masterObjectId}/classifications/paths`
|
|
679
|
+
|
|
680
|
+
|
|
681
|
+
## Testing
|
|
682
|
+
- Ensure [curriculum links](https://www.staging.clickview.net/videos/25918299/1-times-table) are ordered alphabetically."
|
|
683
|
+
Subjects.API,Bump common to final version,Michael McDonnell,Michael McDonnell,https://gitlab.cvinternal.net/clickview/back-end/clickview.subjects.api/-/merge_requests/197,"## Code changes
|
|
684
|
+
- Bump `Subjects.Common` to final version for `1.20.1`
|
|
685
|
+
|
|
686
|
+
|
|
687
|
+
## Testing
|
|
688
|
+
- N/A"
|
|
689
|
+
Lite,Sign up auto join,Shale Kuzmanovski,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/385,"## Code changes
|
|
690
|
+
- Added a new endpoint to support auto joining when signing up. Talking to `/v1/invites/internal` in user api.
|
|
691
|
+
|
|
692
|
+
|
|
693
|
+
## Testing"
|
|
694
|
+
Lite,Server-initiated 404s,Michael McDonnell,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/383,"## Customer changes
|
|
695
|
+
- The server will now issue a `404` when attempting to a content page with an invalid id
|
|
696
|
+
|
|
697
|
+
|
|
698
|
+
## Code changes
|
|
699
|
+
- Updated `OpenGraphService` to raise an exception if it can't access an object based on the supplied param
|
|
700
|
+
|
|
701
|
+
|
|
702
|
+
## Testing
|
|
703
|
+
- In Np, attempting to go page load on existing routes with incorrect id's will now return a 404
|
|
704
|
+
- Previously, the server would return a `200` with the JS then showing a separate error screen"
|
|
705
|
+
Lite,Set Presso slug and ValidPresentationSlugs for Auth'd and Public users,Michael McDonnell,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/382,"## Dependencies
|
|
706
|
+
- Required by https://gitlab.cvinternal.net/clickview/front-end/clickview/-/merge_requests/3178
|
|
707
|
+
|
|
708
|
+
|
|
709
|
+
## Code changes
|
|
710
|
+
- Updated `AppAsync` in BaseController to bootstrp the presentation slugs for both Auth and Public users
|
|
711
|
+
|
|
712
|
+
|
|
713
|
+
## Testing
|
|
714
|
+
- N/A"
|
|
715
|
+
Lite,Special event ana browsing,Nan Chen,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/381,"## Code changes
|
|
716
|
+
- Add calendar setting for public browsing.
|
|
717
|
+
- Add new calendar invalid date error image asset.
|
|
718
|
+
|
|
719
|
+
|
|
720
|
+
## Testing
|
|
721
|
+
- n/a"
|
|
722
|
+
Lite,Add movies and tv filter icons,Nan Chen,Joshua Taylor,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/380,"## Code changes
|
|
723
|
+
- Add new movies and tv search filter button icons.
|
|
724
|
+
|
|
725
|
+
|
|
726
|
+
## Testing"
|
|
727
|
+
Lite,Add new favourites-playlist image assets,Nan Chen,Michael McDonnell,https://gitlab.cvinternal.net/clickview/front-end/lite/-/merge_requests/379,"## Code changes
|
|
728
|
+
- Added new banner & cover for hardcode favorite playlist.
|
|
729
|
+
|
|
730
|
+
|
|
731
|
+
## Testing"
|
|
732
|
+
Master.Auth,Create prospect,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/419,"## Dependencies
|
|
733
|
+
- Can be undrafted and merged after https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/418
|
|
734
|
+
|
|
735
|
+
|
|
736
|
+
## Code changes
|
|
737
|
+
- The endpoint to create prospects was removed from Gateway by Kev in this MR: https://gitlab.cvinternal.net/clickview/back-end/krakend/-/merge_requests/113. So I've added a `/ajax/trials/prospects` endpoint for creating prospects in the ""Can't find my school"" sign up workflow.
|
|
738
|
+
|
|
739
|
+
|
|
740
|
+
## Testing"
|
|
741
|
+
Master.Auth,Join request,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/418,"## Before release
|
|
742
|
+
- Updated `ClickView.Clients.User` to version `2.15.0`.
|
|
743
|
+
|
|
744
|
+
|
|
745
|
+
## Dependencies
|
|
746
|
+
- Can be undrafted and merged after https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/417
|
|
747
|
+
|
|
748
|
+
|
|
749
|
+
## Code changes
|
|
750
|
+
- Added a `/ajax/trials/join-request` endpoint, which is using the user api client to create a join request.
|
|
751
|
+
|
|
752
|
+
|
|
753
|
+
## Testing"
|
|
754
|
+
Master.Auth,Sign up images,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/417,"## Dependencies
|
|
755
|
+
- Can be undrafted and merged after https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/416
|
|
756
|
+
|
|
757
|
+
|
|
758
|
+
## Code changes
|
|
759
|
+
- Adding the images that are required for the sign up app.
|
|
760
|
+
|
|
761
|
+
|
|
762
|
+
## Testing"
|
|
763
|
+
Master.Auth,Front end config,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/416,"## Dependencies
|
|
764
|
+
- You can undraft and review after https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/415 has been merged. Sorry about this I was just building on top of your work so I could test everything.
|
|
765
|
+
|
|
766
|
+
|
|
767
|
+
## Code changes
|
|
768
|
+
- Adding an endpoint to fetch config values that are required by the sign up app in the frontend.
|
|
769
|
+
|
|
770
|
+
|
|
771
|
+
## Testing"
|
|
772
|
+
Master.Auth,Content security policy,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/415,"## Before release
|
|
773
|
+
* [ ] Add gateway api to octo variables
|
|
774
|
+
|
|
775
|
+
|
|
776
|
+
## Code changes
|
|
777
|
+
* Support adding script and connect sources to CSP middleware
|
|
778
|
+
* Add google map and gateway to connect sources
|
|
779
|
+
* Add google map to script sources
|
|
780
|
+
* Remove no longer used used css file from `_layout.cshtml`
|
|
781
|
+
|
|
782
|
+
|
|
783
|
+
## Testing"
|
|
784
|
+
Master.Auth,Email to select customer,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/414,"## Code changes
|
|
785
|
+
* Pass down user mail to `SelectCustomerStepResponse` so that the frontend can use it to fetch potential customers from prospect api
|
|
786
|
+
|
|
787
|
+
|
|
788
|
+
## Testing"
|
|
789
|
+
Master.Auth,Select user type step,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/Master.Auth/-/merge_requests/413,"## Customer changes
|
|
790
|
+
* Allow user to select user type if they sign in using social sign up idp providers, like Google or Microsoft
|
|
791
|
+
|
|
792
|
+
|
|
793
|
+
## Code changes
|
|
794
|
+
* Add `SelectUserTypeStepResponse` to get user type input from user for social sign up feature only
|
|
795
|
+
* Populate new user data from Google and Microsoft claims
|
|
796
|
+
* Do not update user role for the existing user if user signs in via social sign up idp like Google or Microsoft
|
|
797
|
+
|
|
798
|
+
|
|
799
|
+
## Testing
|
|
800
|
+
* A new user can be created if a user choose a user type when setting both `features.social-signup` and `features.user-no-customers` to `true` in cookie"
|
|
801
|
+
Krakend,Adding prospects lookups endpoint,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/krakend/-/merge_requests/117,"## Code changes
|
|
802
|
+
- Exposing the prospect lookup endpoint publicly so that it can be used by the sign up app to fetch customerIds.
|
|
803
|
+
|
|
804
|
+
|
|
805
|
+
## Testing"
|
|
806
|
+
Krakend,Adding an email query param to the trial-status request,Shale Kuzmanovski,Ryan Wang,https://gitlab.cvinternal.net/clickview/back-end/krakend/-/merge_requests/116,"## Code changes
|
|
807
|
+
- Adding an `email` query param to the `/v1/prospects/{prospectId}/trial-status` user api endpoint.
|
|
808
|
+
|
|
809
|
+
|
|
810
|
+
## Testing"
|
|
811
|
+
Krakend,add v1/users/remove endpoint,Ryan Wang,Kevin Wellalagodage,https://gitlab.cvinternal.net/clickview/back-end/krakend/-/merge_requests/115,"## Code changes
|
|
812
|
+
* Add a new endpoint `POST v1/users/remove` to remove users from a customer
|
|
813
|
+
|
|
814
|
+
|
|
815
|
+
## Testing
|
|
816
|
+
* Post the below body to `v1/users/remove` should remove users from a customer
|
|
817
|
+
```
|
|
818
|
+
public abstract class SelectUsersRequest
|
|
819
|
+
{
|
|
820
|
+
public virtual ulong CustomerId { get; set; }
|
|
821
|
+
public virtual UserType? UserType { get; set; }
|
|
822
|
+
public virtual UserRole? UserRole { get; set; }
|
|
823
|
+
public virtual IEnumerable<ObjectStatus> UserStatuses { get; set; }
|
|
824
|
+
public virtual IEnumerable<int> YearGroupValues { get; set; }
|
|
825
|
+
public virtual List<ulong> UserIds { get; set; }
|
|
826
|
+
public virtual string SearchQuery { get; set; }
|
|
827
|
+
}
|
|
828
|
+
```"
|
|
829
|
+
Krakend,add approved domain endpoints,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/krakend/-/merge_requests/114,"## Code changes
|
|
830
|
+
* Add endpoint `GET v1/approved-domains` to get a list of approved domains and customers by domain name
|
|
831
|
+
* Add endpoint `POST v1/approved-domains` to create a new approved domain for a customer
|
|
832
|
+
* Add endpoint `PUT v1/approved-domains/{id}` to update domain name for a customer by approved domain id
|
|
833
|
+
* Add endpoint `DELETE v1/approved-domains/{id}` to delete a customer's approved domain by approved domain id
|
|
834
|
+
* Add endpoint `GET v1/customers/{id}/approved-domains` to get a list of approved domains for a customer filtered by `accessType`
|
|
835
|
+
|
|
836
|
+
|
|
837
|
+
## Testing"
|
|
838
|
+
Master.Api,"Add directed assoc between contentRegion with interactives with 1:M cardinality, implements partial of CC-529",Wei Zong,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/Master.Api/-/merge_requests/759,"## Code changes
|
|
839
|
+
- Add directed assoc between contentRegion with interactives with 1:M cardinality. This is mainly for curation studio to allow curators to create interactive for multiple regions.
|
|
840
|
+
|
|
841
|
+
|
|
842
|
+
## Testing
|
|
843
|
+
- An interactive and content region should be associated with M:M cardinality undirectionally.
|
|
844
|
+
- http://localhost:52899/v2/objects/39835524?query=contentRegions should return
|
|
845
|
+
- "
|
|
846
|
+
ClickView Online,Copy broadcast to workspace,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Online/-/merge_requests/3209,"## Before release
|
|
847
|
+
* [ ] Update `ClickView.DomainApi.Models` nuget package to a stable version
|
|
848
|
+
|
|
849
|
+
|
|
850
|
+
## Dependencies
|
|
851
|
+
* https://gitlab.cvinternal.net/clickview/back-end/Domain.Api/-/merge_requests/1086
|
|
852
|
+
|
|
853
|
+
|
|
854
|
+
## Customer changes
|
|
855
|
+
* Fixed an issue where subtitle is not showing up when adding Tv guide video to Workspace. Close INBOX-4482
|
|
856
|
+
|
|
857
|
+
|
|
858
|
+
## Code changes
|
|
859
|
+
* Call `POST v2/videos/{id}/copy` endpoint in domain api to push curated ad-free TV guide video to workspace
|
|
860
|
+
|
|
861
|
+
|
|
862
|
+
## Testing
|
|
863
|
+
* Go to Online and Choose a TV program that has been curated by content team with subtitle and add it to Workspace, the subtitle should be appearing for the video in Workspace"
|
|
864
|
+
ClickView Online,Clean up old staff request,Ryan Wang,Shale Kuzmanovski,https://gitlab.cvinternal.net/clickview/front-end/ClickView.Online/-/merge_requests/3208,"## Before release
|
|
865
|
+
* [ ] Update `ClickView.DomainApi.Models` nuget package to a stable version
|
|
866
|
+
|
|
867
|
+
|
|
868
|
+
## Dependencies
|
|
869
|
+
* https://gitlab.cvinternal.net/clickview/back-end/Domain.Api/-/merge_requests/1086
|
|
870
|
+
|
|
871
|
+
|
|
872
|
+
## Code changes
|
|
873
|
+
* Update some nuget packages to the latest version
|
|
874
|
+
* Clean up legacy staff request code
|
|
875
|
+
|
|
876
|
+
|
|
877
|
+
## Testing"
|
|
878
|
+
Domain.Api,Copy video workspace,Ryan Wang,Prad Nepal,https://gitlab.cvinternal.net/clickview/back-end/Domain.Api/-/merge_requests/1086,"## Before release
|
|
879
|
+
* [ ] Bump up `ClickView.DomainApi.Models.Common` version to main release version and push it to nuget server
|
|
880
|
+
|
|
881
|
+
|
|
882
|
+
## Customer changes
|
|
883
|
+
* Fixed an issue where subtitle is not showing up when adding Tv guide video to Workspace. Close INBOX-4482
|
|
884
|
+
|
|
885
|
+
|
|
886
|
+
## Code changes
|
|
887
|
+
* Add capability to `POST v2/videos/{id}/copy` endpoint to allow Online to use it for adding TV guide video to workspace
|
|
888
|
+
|
|
889
|
+
|
|
890
|
+
## Testing"
|
|
@@ -10,5 +10,6 @@ exports.MONOREPO_PACKAGE_JSON_FILES = [
|
|
|
10
10
|
'packages/projects/library-editor/package.json',
|
|
11
11
|
'packages/projects/lite/package.json',
|
|
12
12
|
'packages/projects/online/package.json',
|
|
13
|
-
'packages/projects/reports/package.json'
|
|
13
|
+
'packages/projects/reports/package.json',
|
|
14
|
+
'packages/projects/exchange/package.json'
|
|
14
15
|
];
|
|
@@ -11,4 +11,5 @@ exports.TeamCityBuildIds = (_a = {},
|
|
|
11
11
|
_a[constants_1.PROJECT_NAMES.frontend.reports] = 'Web_AnalyticsWeb_BuildAndPackageDocker',
|
|
12
12
|
_a[constants_1.PROJECT_NAMES.frontend.lite] = 'ClickViewLiteWeb_BuildAndPackageDocker',
|
|
13
13
|
_a[constants_1.PROJECT_NAMES.backend.auth] = 'auth_web_B',
|
|
14
|
+
_a[constants_1.PROJECT_NAMES.frontend.exchange] = 'ExchangeWeb_BuildAndPackageDocker',
|
|
14
15
|
_a);
|
|
@@ -73,7 +73,9 @@ var ROOT_DIRECTORIES = {
|
|
|
73
73
|
// Reports
|
|
74
74
|
970: 'src/ClickView.Analytics.Web',
|
|
75
75
|
// Auth
|
|
76
|
-
54: 'src/ClickView.Auth'
|
|
76
|
+
54: 'src/ClickView.Auth',
|
|
77
|
+
// Exchange
|
|
78
|
+
1114: 'src/ClickView.Exchange'
|
|
77
79
|
};
|
|
78
80
|
var InstallPackagesTask = /** @class */ (function () {
|
|
79
81
|
function InstallPackagesTask(service) {
|
|
@@ -81,9 +83,9 @@ var InstallPackagesTask = /** @class */ (function () {
|
|
|
81
83
|
}
|
|
82
84
|
InstallPackagesTask.prototype.run = function (_options) {
|
|
83
85
|
return __awaiter(this, void 0, void 0, function () {
|
|
84
|
-
var milestone, options, projects, monorepo, consumingProjects, _a, monorepoBranch, monorepoBranchName, versions, _i, consumingProjects_1, project, _b, branch, branchName, hasUpdates;
|
|
85
|
-
return __generator(this, function (
|
|
86
|
-
switch (
|
|
86
|
+
var milestone, options, projects, monorepo, consumingProjects, _a, monorepoBranch, monorepoBranchName, versions, _i, consumingProjects_1, project, _b, branch, branchName, hasUpdates, _c;
|
|
87
|
+
return __generator(this, function (_d) {
|
|
88
|
+
switch (_d.label) {
|
|
87
89
|
case 0:
|
|
88
90
|
utils_1.Logger.logTask('Installing npm packages');
|
|
89
91
|
if (!_options.monorepoBranchName && !_options.milestone) {
|
|
@@ -95,8 +97,8 @@ var InstallPackagesTask = /** @class */ (function () {
|
|
|
95
97
|
utils_1.Logger.logInfo("Searching for a merge request in project \"monorepo\" with branch name \"".concat(_options.monorepoBranchName, "\"..."));
|
|
96
98
|
return [4 /*yield*/, this.service.getMilestoneByBranchName(utils_1.ProjectIds.MONOREPO_PROJECT_ID, _options.monorepoBranchName)];
|
|
97
99
|
case 1:
|
|
98
|
-
milestone =
|
|
99
|
-
|
|
100
|
+
milestone = _d.sent();
|
|
101
|
+
_d.label = 2;
|
|
100
102
|
case 2:
|
|
101
103
|
if (!milestone)
|
|
102
104
|
return [2 /*return*/, false];
|
|
@@ -109,7 +111,7 @@ var InstallPackagesTask = /** @class */ (function () {
|
|
|
109
111
|
};
|
|
110
112
|
return [4 /*yield*/, this.service.getProjects(options)];
|
|
111
113
|
case 3:
|
|
112
|
-
projects =
|
|
114
|
+
projects = _d.sent();
|
|
113
115
|
monorepo = projects.find(function (p) { return p.id.toString() === utils_1.ProjectIds.MONOREPO_PROJECT_ID; });
|
|
114
116
|
consumingProjects = projects.filter(function (p) { return p.id.toString() !== utils_1.ProjectIds.MONOREPO_PROJECT_ID; });
|
|
115
117
|
if (!monorepo) {
|
|
@@ -122,40 +124,43 @@ var InstallPackagesTask = /** @class */ (function () {
|
|
|
122
124
|
}
|
|
123
125
|
return [4 /*yield*/, this.service.getNextBranchInfo(monorepo.id, options.version)];
|
|
124
126
|
case 4:
|
|
125
|
-
_a =
|
|
127
|
+
_a = _d.sent(), monorepoBranch = _a.branch, monorepoBranchName = _a.branchName;
|
|
126
128
|
if (!monorepoBranch) {
|
|
127
129
|
utils_1.Logger.logError("[".concat(monorepo.title, "]: [").concat(monorepoBranchName, "] branch does not exist"));
|
|
128
130
|
return [2 /*return*/, false];
|
|
129
131
|
}
|
|
130
132
|
return [4 /*yield*/, this.getPackageVersions(monorepoBranchName)];
|
|
131
133
|
case 5:
|
|
132
|
-
versions =
|
|
134
|
+
versions = _d.sent();
|
|
133
135
|
utils_1.Logger.logMessage("Versions identified for ".concat(monorepoBranchName));
|
|
134
136
|
Object.keys(versions).forEach(function (key) {
|
|
135
137
|
utils_1.Logger.logMessage("- [".concat(key, "]: ").concat(versions[key]));
|
|
136
138
|
});
|
|
137
139
|
utils_1.Logger.logMessage('\nInstalling packages:\n');
|
|
138
140
|
_i = 0, consumingProjects_1 = consumingProjects;
|
|
139
|
-
|
|
141
|
+
_d.label = 6;
|
|
140
142
|
case 6:
|
|
141
|
-
if (!(_i < consumingProjects_1.length)) return [3 /*break*/,
|
|
143
|
+
if (!(_i < consumingProjects_1.length)) return [3 /*break*/, 13];
|
|
142
144
|
project = consumingProjects_1[_i];
|
|
143
|
-
|
|
145
|
+
_d.label = 7;
|
|
144
146
|
case 7:
|
|
145
|
-
|
|
147
|
+
_d.trys.push([7, 11, , 12]);
|
|
148
|
+
return [4 /*yield*/, this.service.getNextBranchInfo(project.id, options.version)];
|
|
149
|
+
case 8:
|
|
150
|
+
_b = _d.sent(), branch = _b.branch, branchName = _b.branchName;
|
|
146
151
|
if (!branch) {
|
|
147
152
|
utils_1.Logger.logError("[".concat(project.title, "]: [").concat(branchName, "] does not exist"));
|
|
148
|
-
return [3 /*break*/,
|
|
153
|
+
return [3 /*break*/, 12];
|
|
149
154
|
}
|
|
150
155
|
return [4 /*yield*/, this.updateAndSavePackageFiles(project, options.milestone, branchName, versions)];
|
|
151
|
-
case
|
|
152
|
-
hasUpdates =
|
|
156
|
+
case 9:
|
|
157
|
+
hasUpdates = _d.sent();
|
|
153
158
|
/**
|
|
154
159
|
* If there are no changes to the versions, we're done here
|
|
155
160
|
*/
|
|
156
161
|
if (!hasUpdates) {
|
|
157
162
|
utils_1.Logger.logWarning("[".concat(project.title, "]: [").concat(branchName, "] does not require any updates"));
|
|
158
|
-
return [3 /*break*/,
|
|
163
|
+
return [3 /*break*/, 12];
|
|
159
164
|
}
|
|
160
165
|
/**
|
|
161
166
|
* Run npm i to update our package log file
|
|
@@ -167,17 +172,21 @@ var InstallPackagesTask = /** @class */ (function () {
|
|
|
167
172
|
* Commit our updated package.json and package-lock.json
|
|
168
173
|
*/
|
|
169
174
|
return [4 /*yield*/, this.commitUpdatedFiles(project, options.milestone, branchName)];
|
|
170
|
-
case
|
|
175
|
+
case 10:
|
|
171
176
|
/**
|
|
172
177
|
* Commit our updated package.json and package-lock.json
|
|
173
178
|
*/
|
|
174
|
-
|
|
179
|
+
_d.sent();
|
|
175
180
|
utils_1.Logger.logMessage("[".concat(project.title, "]: File changes committed"));
|
|
176
|
-
|
|
177
|
-
case
|
|
181
|
+
return [3 /*break*/, 12];
|
|
182
|
+
case 11:
|
|
183
|
+
_c = _d.sent();
|
|
184
|
+
utils_1.Logger.logError("[".concat(project.title, "]: Something went wrong while attempting to install packages. Please manually check if this project should have any monorepo packages installed."));
|
|
185
|
+
return [3 /*break*/, 12];
|
|
186
|
+
case 12:
|
|
178
187
|
_i++;
|
|
179
188
|
return [3 /*break*/, 6];
|
|
180
|
-
case
|
|
189
|
+
case 13: return [2 /*return*/, true];
|
|
181
190
|
}
|
|
182
191
|
});
|
|
183
192
|
});
|