@cliangdev/flux-plugin 0.1.0-dev.588ae42 → 0.2.0-dev.2b9c207

package/src/server/adapters/__tests__/dependency-ops.test.ts

@@ -194,8 +194,12 @@ describe("LinearAdapter - Dependency Operations", () => {
       const mockRelation = {
         id: "relation_1",
         type: "blocks",
-        issue: { id: "issue_epic_1", identifier: "ENG-42" },
-        relatedIssue: { id: "issue_epic_2", identifier: "ENG-43" },
+        // Linear SDK returns promises for lazy-loaded related objects
+        issue: Promise.resolve({ id: "issue_epic_1", identifier: "ENG-42" }),
+        relatedIssue: Promise.resolve({
+          id: "issue_epic_2",
+          identifier: "ENG-43",
+        }),
         delete: mockDelete,
       };
 
@@ -208,7 +212,7 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_2",
         identifier: "ENG-43",
         _raw: {
-          relations: mock(async () => ({
+          inverseRelations: mock(async () => ({
             nodes: [mockRelation],
           })),
         },
@@ -235,7 +239,7 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_1",
         identifier: "ENG-42",
         _raw: {
-          relations: mock(async () => ({ nodes: [] })),
+          inverseRelations: mock(async () => ({ nodes: [] })),
         },
       });
 
@@ -265,7 +269,7 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_2",
         identifier: "ENG-43",
         _raw: {
-          relations: mock(async () => ({
+          inverseRelations: mock(async () => ({
             nodes: [], // No relations
           })),
         },
@@ -294,19 +298,31 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_1",
         identifier: "ENG-43",
         _raw: {
-          relations: mock(async () => ({
+          inverseRelations: mock(async () => ({
             nodes: [
               {
                 id: "relation_1",
                 type: "blocks",
-                issue: { id: "issue_epic_2", identifier: "ENG-42" },
-                relatedIssue: { id: "issue_epic_1", identifier: "ENG-43" },
+                issue: Promise.resolve({
+                  id: "issue_epic_2",
+                  identifier: "ENG-42",
+                }),
+                relatedIssue: Promise.resolve({
+                  id: "issue_epic_1",
+                  identifier: "ENG-43",
+                }),
               },
               {
                 id: "relation_2",
                 type: "blocks",
-                issue: { id: "issue_epic_3", identifier: "ENG-44" },
-                relatedIssue: { id: "issue_epic_1", identifier: "ENG-43" },
+                issue: Promise.resolve({
+                  id: "issue_epic_3",
+                  identifier: "ENG-44",
+                }),
+                relatedIssue: Promise.resolve({
+                  id: "issue_epic_1",
+                  identifier: "ENG-43",
+                }),
               },
             ],
           })),
@@ -328,7 +344,7 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_1",
         identifier: "ENG-42",
         _raw: {
-          relations: mock(async () => ({
+          inverseRelations: mock(async () => ({
             nodes: [],
           })),
         },
@@ -349,25 +365,43 @@ describe("LinearAdapter - Dependency Operations", () => {
         id: "issue_epic_1",
         identifier: "ENG-43",
         _raw: {
-          relations: mock(async () => ({
+          inverseRelations: mock(async () => ({
             nodes: [
               {
                 id: "relation_1",
                 type: "blocks",
-                issue: { id: "issue_epic_2", identifier: "ENG-42" },
-                relatedIssue: { id: "issue_epic_1", identifier: "ENG-43" },
+                issue: Promise.resolve({
+                  id: "issue_epic_2",
+                  identifier: "ENG-42",
+                }),
+                relatedIssue: Promise.resolve({
+                  id: "issue_epic_1",
+                  identifier: "ENG-43",
+                }),
               },
               {
                 id: "relation_2",
                 type: "duplicate",
-                issue: { id: "issue_epic_3", identifier: "ENG-44" },
-                relatedIssue: { id: "issue_epic_1", identifier: "ENG-43" },
+                issue: Promise.resolve({
+                  id: "issue_epic_3",
+                  identifier: "ENG-44",
+                }),
+                relatedIssue: Promise.resolve({
+                  id: "issue_epic_1",
+                  identifier: "ENG-43",
+                }),
               },
               {
                 id: "relation_3",
                 type: "related",
-                issue: { id: "issue_epic_4", identifier: "ENG-45" },
-                relatedIssue: { id: "issue_epic_1", identifier: "ENG-43" },
+                issue: Promise.resolve({
+                  id: "issue_epic_4",
+                  identifier: "ENG-45",
+                }),
+                relatedIssue: Promise.resolve({
+                  id: "issue_epic_1",
+                  identifier: "ENG-43",
+                }),
               },
             ],
           })),

package/src/server/adapters/linear/adapter.ts

@@ -887,16 +887,22 @@ export class LinearAdapter implements BackendAdapter {
     if (!blockedIssue) throw new Error(`Issue not found: ${ref}`);
     if (!blockerIssue) throw new Error(`Issue not found: ${dependsOnRef}`);
 
+    // Use inverseRelations to find relations where blockedIssue is the target
     const relations = await this.client.execute<any>(() =>
-      blockedIssue._raw.relations(),
+      blockedIssue._raw.inverseRelations(),
     );
 
-    const relationToDelete = relations.nodes.find(
-      (rel: any) =>
-        rel.type === "blocks" &&
-        rel.issue.id === blockerIssue.id &&
-        rel.relatedIssue.id === blockedIssue.id,
-    );
+    // Find the relation to delete - need to await rel.issue since it's lazy-loaded
+    let relationToDelete: any = null;
+    for (const rel of relations.nodes) {
+      if (rel.type === "blocks") {
+        const relIssue = await rel.issue;
+        if (relIssue?.id === blockerIssue.id) {
+          relationToDelete = rel;
+          break;
+        }
+      }
+    }
 
     if (!relationToDelete) {
       throw new Error(
@@ -911,18 +917,17 @@ export class LinearAdapter implements BackendAdapter {
     const issue = await this.fetchIssue(ref);
     if (!issue) throw new Error(`Issue not found: ${ref}`);
 
+    // Use inverseRelations to get relations where this issue is the target (relatedIssueId)
+    // This finds issues that block this one
     const relations = await this.client.execute<any>(() =>
-      issue._raw.relations(),
+      issue._raw.inverseRelations(),
     );
 
     const blockingRefs: string[] = [];
     for (const rel of relations.nodes) {
-      if (
-        rel.type === "blocks" &&
-        rel.relatedIssue &&
-        (rel.relatedIssue as any).id === issue.id
-      ) {
-        const blockerIssue = rel.issue as any;
+      if (rel.type === "blocks") {
+        // Linear SDK returns lazy-loaded promises for related objects
+        const blockerIssue = await rel.issue;
         if (blockerIssue?.identifier) {
           blockingRefs.push(blockerIssue.identifier);
         }

package/src/server/adapters/local-adapter.ts

@@ -312,6 +312,14 @@ export class LocalAdapter implements BackendAdapter {
       cascade.epics++;
     }
 
+    // Delete PRD dependencies
+    const deletedDeps = db
+      .query(
+        "DELETE FROM prd_dependencies WHERE prd_id = ? OR depends_on_prd_id = ?",
+      )
+      .run(prd.id, prd.id);
+    cascade.dependencies += deletedDeps.changes;
+
     remove(db, "prds", prd.id);
 
     return { deleted: ref, cascade };
@@ -710,7 +718,15 @@ export class LocalAdapter implements BackendAdapter {
       throw new Error("Dependencies must be between entities of the same type");
     }
 
-    if (entityType === "E") {
+    if (entityType === "P") {
+      const prd = findByRef<PrdRow>(db, "prds", ref);
+      const dependsOnPrd = findByRef<PrdRow>(db, "prds", dependsOnRef);
+      if (!prd || !dependsOnPrd) throw new Error("PRD not found");
+
+      db.query(
+        "INSERT OR IGNORE INTO prd_dependencies (prd_id, depends_on_prd_id) VALUES (?, ?)",
+      ).run(prd.id, dependsOnPrd.id);
+    } else if (entityType === "E") {
       const epic = findByRef<EpicRow>(db, "epics", ref);
       const dependsOnEpic = findByRef<EpicRow>(db, "epics", dependsOnRef);
       if (!epic || !dependsOnEpic) throw new Error("Epic not found");
@@ -726,8 +742,6 @@ export class LocalAdapter implements BackendAdapter {
       db.query(
         "INSERT OR IGNORE INTO task_dependencies (task_id, depends_on_task_id) VALUES (?, ?)",
       ).run(task.id, dependsOnTask.id);
-    } else {
-      throw new Error("Dependencies can only be added to Epics or Tasks");
     }
   }
 
@@ -735,7 +749,15 @@ export class LocalAdapter implements BackendAdapter {
     const db = getDb();
     const entityType = getEntityType(ref);
 
-    if (entityType === "E") {
+    if (entityType === "P") {
+      const prd = findByRef<PrdRow>(db, "prds", ref);
+      const dependsOnPrd = findByRef<PrdRow>(db, "prds", dependsOnRef);
+      if (!prd || !dependsOnPrd) throw new Error("PRD not found");
+
+      db.query(
+        "DELETE FROM prd_dependencies WHERE prd_id = ? AND depends_on_prd_id = ?",
+      ).run(prd.id, dependsOnPrd.id);
+    } else if (entityType === "E") {
       const epic = findByRef<EpicRow>(db, "epics", ref);
       const dependsOnEpic = findByRef<EpicRow>(db, "epics", dependsOnRef);
       if (!epic || !dependsOnEpic) throw new Error("Epic not found");
@@ -758,7 +780,20 @@ export class LocalAdapter implements BackendAdapter {
     const db = getDb();
     const entityType = getEntityType(ref);
 
-    if (entityType === "E") {
+    if (entityType === "P") {
+      const prd = findByRef<PrdRow>(db, "prds", ref);
+      if (!prd) return [];
+
+      const deps = db
+        .query(
+          `SELECT p.ref FROM prd_dependencies pd
+           JOIN prds p ON pd.depends_on_prd_id = p.id
+           WHERE pd.prd_id = ?`,
+        )
+        .all(prd.id) as { ref: string }[];
+
+      return deps.map((d) => d.ref);
+    } else if (entityType === "E") {
       const epic = findByRef<EpicRow>(db, "epics", ref);
       if (!epic) return [];
 

package/src/server/db/schema.ts

@@ -77,6 +77,15 @@ CREATE TABLE IF NOT EXISTS task_dependencies (
   FOREIGN KEY (depends_on_task_id) REFERENCES tasks(id)
 );
 
+-- PRD Dependencies
+CREATE TABLE IF NOT EXISTS prd_dependencies (
+  prd_id TEXT NOT NULL,
+  depends_on_prd_id TEXT NOT NULL,
+  PRIMARY KEY (prd_id, depends_on_prd_id),
+  FOREIGN KEY (prd_id) REFERENCES prds(id),
+  FOREIGN KEY (depends_on_prd_id) REFERENCES prds(id)
+);
+
 -- Indexes for common queries
 CREATE INDEX IF NOT EXISTS idx_prds_project ON prds(project_id);
 CREATE INDEX IF NOT EXISTS idx_prds_status ON prds(status);

package/src/server/index.ts

@@ -11,7 +11,6 @@ import {
   createTaskTool,
   deleteEntityTool,
   getEntityTool,
-  getProjectContextTool,
   getStatsTool,
   getVersionTool,
   initProjectTool,
@@ -47,7 +46,6 @@ const tools: ToolDefinition[] = [
   // Query tools
   getEntityTool,
   queryEntitiesTool,
-  getProjectContextTool,
   initProjectTool,
   getStatsTool,
   getVersionTool,

package/src/server/tools/__tests__/crud.test.ts

@@ -53,6 +53,7 @@ describe("CRUD MCP Tools", () => {
       expect(result.ref).toBeDefined();
       expect(result.status).toBe("DRAFT");
       expect(result.id).toBeDefined();
+      expect(result.dependencies).toEqual([]);
     });
 
     test("creates PRD with optional fields", async () => {
@@ -64,6 +65,17 @@ describe("CRUD MCP Tools", () => {
       expect(result.description).toBe("A description");
       expect(result.tag).toBe("mvp");
     });
+
+    test("creates PRD with depends_on", async () => {
+      const prd1 = (await createPrdTool.handler({ title: "PRD 1" })) as any;
+      const prd2 = (await createPrdTool.handler({ title: "PRD 2" })) as any;
+      const prd3 = (await createPrdTool.handler({
+        title: "PRD 3",
+        depends_on: [prd1.ref, prd2.ref],
+      })) as any;
+
+      expect(prd3.dependencies).toEqual([prd1.ref, prd2.ref]);
+    });
   });
 
   describe("create_epic", () => {
@@ -77,6 +89,7 @@ describe("CRUD MCP Tools", () => {
       expect(epic.title).toBe("Test Epic");
       expect(epic.ref).toBeDefined();
       expect(epic.status).toBe("PENDING");
+      expect(epic.dependencies).toEqual([]);
     });
 
     test("creates epic with acceptance criteria", async () => {
@@ -94,6 +107,25 @@ describe("CRUD MCP Tools", () => {
         createEpicTool.handler({ prd_ref: "INVALID-P999", title: "Test" }),
       ).rejects.toThrow("PRD not found");
     });
+
+    test("creates epic with depends_on", async () => {
+      const prd = (await createPrdTool.handler({ title: "Test PRD" })) as any;
+      const epic1 = (await createEpicTool.handler({
+        prd_ref: prd.ref,
+        title: "Epic 1",
+      })) as any;
+      const epic2 = (await createEpicTool.handler({
+        prd_ref: prd.ref,
+        title: "Epic 2",
+      })) as any;
+      const epic3 = (await createEpicTool.handler({
+        prd_ref: prd.ref,
+        title: "Epic 3",
+        depends_on: [epic1.ref, epic2.ref],
+      })) as any;
+
+      expect(epic3.dependencies).toEqual([epic1.ref, epic2.ref]);
+    });
   });
 
   describe("create_task", () => {
@@ -111,6 +143,7 @@ describe("CRUD MCP Tools", () => {
       expect(task.title).toBe("Test Task");
       expect(task.ref).toBeDefined();
       expect(task.priority).toBe("MEDIUM");
+      expect(task.dependencies).toEqual([]);
     });
 
     test("creates task with priority", async () => {
@@ -126,6 +159,29 @@ describe("CRUD MCP Tools", () => {
       })) as any;
       expect(task.priority).toBe("HIGH");
     });
+
+    test("creates task with depends_on", async () => {
+      const prd = (await createPrdTool.handler({ title: "Test PRD" })) as any;
+      const epic = (await createEpicTool.handler({
+        prd_ref: prd.ref,
+        title: "Test Epic",
+      })) as any;
+      const task1 = (await createTaskTool.handler({
+        epic_ref: epic.ref,
+        title: "Task 1",
+      })) as any;
+      const task2 = (await createTaskTool.handler({
+        epic_ref: epic.ref,
+        title: "Task 2",
+      })) as any;
+      const task3 = (await createTaskTool.handler({
+        epic_ref: epic.ref,
+        title: "Task 3",
+        depends_on: [task1.ref, task2.ref],
+      })) as any;
+
+      expect(task3.dependencies).toEqual([task1.ref, task2.ref]);
+    });
   });
 
   describe("update_entity", () => {
@@ -183,6 +239,19 @@ describe("CRUD MCP Tools", () => {
       const result = (await deleteEntityTool.handler({ ref: epic.ref })) as any;
       expect(result.cascade.tasks).toBe(2);
     });
+
+    test("cascade deletes PRD with dependencies", async () => {
+      const prd1 = (await createPrdTool.handler({ title: "PRD 1" })) as any;
+      const prd2 = (await createPrdTool.handler({ title: "PRD 2" })) as any;
+      await addDependencyTool.handler({
+        ref: prd2.ref,
+        depends_on_ref: prd1.ref,
+      });
+
+      const result = (await deleteEntityTool.handler({ ref: prd1.ref })) as any;
+      expect(result.deleted).toBe(prd1.ref);
+      expect(result.cascade.dependencies).toBe(1);
+    });
   });
 
   describe("dependencies", () => {
@@ -210,6 +279,26 @@ describe("CRUD MCP Tools", () => {
       expect(removeResult.success).toBe(true);
     });
 
+    test("adds and removes PRD dependency", async () => {
+      const prd1 = (await createPrdTool.handler({ title: "PRD 1" })) as any;
+      const prd2 = (await createPrdTool.handler({ title: "PRD 2" })) as any;
+
+      const addResult = (await addDependencyTool.handler({
+        ref: prd2.ref,
+        depends_on_ref: prd1.ref,
+      })) as any;
+      expect(addResult.success).toBe(true);
+      expect(addResult.ref).toBe(prd2.ref);
+      expect(addResult.depends_on).toBe(prd1.ref);
+
+      const removeResult = (await removeDependencyTool.handler({
+        ref: prd2.ref,
+        depends_on_ref: prd1.ref,
+      })) as any;
+      expect(removeResult.success).toBe(true);
+      expect(removeResult.removed_dependency).toBe(prd1.ref);
+    });
+
     test("prevents self-dependency", async () => {
       const prd = (await createPrdTool.handler({ title: "Test PRD" })) as any;
       const epic = (await createEpicTool.handler({
@@ -221,6 +310,26 @@ describe("CRUD MCP Tools", () => {
         addDependencyTool.handler({ ref: epic.ref, depends_on_ref: epic.ref }),
       ).rejects.toThrow("depend on itself");
     });
+
+    test("prevents PRD self-dependency", async () => {
+      const prd = (await createPrdTool.handler({ title: "Test PRD" })) as any;
+
+      await expect(
+        addDependencyTool.handler({ ref: prd.ref, depends_on_ref: prd.ref }),
+      ).rejects.toThrow("depend on itself");
+    });
+
+    test("prevents cross-type dependencies between PRD and Epic", async () => {
+      const prd = (await createPrdTool.handler({ title: "Test PRD" })) as any;
+      const epic = (await createEpicTool.handler({
+        prd_ref: prd.ref,
+        title: "Epic",
+      })) as any;
+
+      await expect(
+        addDependencyTool.handler({ ref: prd.ref, depends_on_ref: epic.ref }),
+      ).rejects.toThrow("same type");
+    });
   });
 
   describe("criteria", () => {

package/src/server/tools/__tests__/mcp-interface.test.ts

@@ -10,7 +10,12 @@ process.env.FLUX_PROJECT_ROOT = TEST_DIR;
 import { z } from "zod";
 import { config } from "../../config.js";
 import { closeDb, initDb } from "../../db/index.js";
-import { createError, registerTools, type ToolDefinition } from "../index.js";
+import {
+  createError,
+  createProjectNotInitializedError,
+  registerTools,
+  type ToolDefinition,
+} from "../index.js";
 
 describe("MCP Interface", () => {
   beforeEach(() => {
@@ -44,6 +49,42 @@ describe("MCP Interface", () => {
     });
   });
 
+  describe("createProjectNotInitializedError", () => {
+    test("creates error with setup instructions", () => {
+      const error = createProjectNotInitializedError("/test/cwd", "/test/root");
+
+      expect(error.error).toBe(true);
+      expect(error.code).toBe("PROJECT_NOT_INITIALIZED");
+      expect(error.message).toContain("/test/cwd");
+      expect(error.message).toContain("/test/root");
+      expect(error.setup.instructions).toBeDefined();
+      expect(error.setup.options).toHaveLength(2);
+    });
+
+    test("includes command option for interactive setup", () => {
+      const error = createProjectNotInitializedError("/cwd", "/root");
+      const commandOption = error.setup.options.find(
+        (o) => o.method === "command",
+      );
+
+      expect(commandOption).toBeDefined();
+      expect(commandOption?.name).toBe("/flux");
+      expect(commandOption?.description).toContain("Interactive");
+    });
+
+    test("includes tool option with required params", () => {
+      const error = createProjectNotInitializedError("/cwd", "/root");
+      const toolOption = error.setup.options.find((o) => o.method === "tool");
+
+      expect(toolOption).toBeDefined();
+      expect(toolOption?.name).toBe("init_project");
+      expect(toolOption?.params).toBeDefined();
+      expect(toolOption?.params?.name).toBeDefined();
+      expect(toolOption?.params?.vision).toBeDefined();
+      expect(toolOption?.params?.adapter).toBeDefined();
+    });
+  });
+
   describe("registerTools", () => {
     test("sets up list tools handler", () => {
       const handlers: Record<string, Function> = {};
@@ -287,7 +328,7 @@ describe("Project Validation", () => {
     }
   });
 
-  test("returns PROJECT_NOT_FOUND for tools requiring project", async () => {
+  test("returns PROJECT_NOT_INITIALIZED with setup instructions for tools requiring project", async () => {
     const handlers: Record<string, Function> = {};
     const mockServer = {
       setRequestHandler: mock((schema: any, handler: Function) => {
@@ -317,7 +358,11 @@ describe("Project Validation", () => {
     expect(result.isError).toBe(true);
     const parsedError = JSON.parse(result.content[0].text);
     expect(parsedError.error).toBe(true);
-    expect(parsedError.code).toBe("PROJECT_NOT_FOUND");
+    expect(parsedError.code).toBe("PROJECT_NOT_INITIALIZED");
+    expect(parsedError.setup).toBeDefined();
+    expect(parsedError.setup.instructions).toBeDefined();
+    expect(parsedError.setup.options).toBeDefined();
+    expect(parsedError.setup.options.length).toBe(2);
   });
 
   test("allows init_project without existing project", async () => {
@@ -353,7 +398,7 @@ describe("Project Validation", () => {
     expect(handlerMock).toHaveBeenCalled();
   });
 
-  test("allows get_project_context without existing project", async () => {
+  test("allows get_version without existing project", async () => {
     const handlers: Record<string, Function> = {};
     const mockServer = {
       setRequestHandler: mock((schema: any, handler: Function) => {
@@ -363,11 +408,11 @@ describe("Project Validation", () => {
       }),
     };
 
-    const handlerMock = mock(async () => ({ initialized: false }));
+    const handlerMock = mock(async () => ({ version: "1.0.0" }));
 
     const testTool: ToolDefinition = {
-      name: "get_project_context",
-      description: "Get project context",
+      name: "get_version",
+      description: "Get version",
       inputSchema: z.object({}),
       handler: handlerMock,
     };
@@ -377,7 +422,7 @@ describe("Project Validation", () => {
     const callHandler = handlers.call;
     const result = await callHandler({
       params: {
-        name: "get_project_context",
+        name: "get_version",
         arguments: {},
       },
     });
@@ -385,4 +430,49 @@ describe("Project Validation", () => {
     expect(result.isError).toBeUndefined();
     expect(handlerMock).toHaveBeenCalled();
   });
+
+  test("setup options have correct structure", async () => {
+    const handlers: Record<string, Function> = {};
+    const mockServer = {
+      setRequestHandler: mock((schema: any, handler: Function) => {
+        if (schema.shape?.method?.value === "tools/call") {
+          handlers.call = handler;
+        }
+      }),
+    };
+
+    const testTool: ToolDefinition = {
+      name: "query_entities",
+      description: "Query entities",
+      inputSchema: z.object({ type: z.string() }),
+      handler: async () => ({ items: [] }),
+    };
+
+    registerTools(mockServer as any, [testTool]);
+
+    const callHandler = handlers.call;
+    const result = await callHandler({
+      params: {
+        name: "query_entities",
+        arguments: { type: "prd" },
+      },
+    });
+
+    expect(result.isError).toBe(true);
+    const parsedError = JSON.parse(result.content[0].text);
+
+    const commandOption = parsedError.setup.options.find(
+      (o: any) => o.method === "command",
+    );
+    expect(commandOption.name).toBe("/flux");
+    expect(commandOption.description).toBeTruthy();
+
+    const toolOption = parsedError.setup.options.find(
+      (o: any) => o.method === "tool",
+    );
+    expect(toolOption.name).toBe("init_project");
+    expect(toolOption.params.name).toBeTruthy();
+    expect(toolOption.params.vision).toBeTruthy();
+    expect(toolOption.params.adapter).toBeTruthy();
+  });
 });