@cleocode/core 2026.3.69 → 2026.3.71

package/src/store/sqlite.ts

@@ -405,6 +405,27 @@ import type { RequiredColumn } from './migration-manager.js';
 
 const REQUIRED_TASK_COLUMNS: RequiredColumn[] = [{ name: 'pipeline_stage', ddl: 'text' }];
 
+/**
+ * Required columns that MUST exist on the sessions table before the
+ * wave0-schema-hardening migration runs.
+ *
+ * The wave0 migration rebuilds the sessions table via:
+ *   INSERT INTO __new_sessions(..., provider_id, stats_json, resume_count, grade_mode)
+ *   SELECT ..., provider_id, stats_json, resume_count, grade_mode FROM sessions
+ *
+ * If an existing sessions table (created before these columns were added) is
+ * missing any of them, the SELECT fails with "no such column". ensureColumns()
+ * adds them as NULL-able columns before the migration runs, making the SELECT safe.
+ *
+ * @see https://github.com/anthropics/cleo/issues/83
+ */
+const REQUIRED_SESSION_COLUMNS: RequiredColumn[] = [
+  { name: 'provider_id', ddl: 'text' },
+  { name: 'stats_json', ddl: 'text' },
+  { name: 'resume_count', ddl: 'integer' },
+  { name: 'grade_mode', ddl: 'integer' },
+];
+
 /**
  * Run drizzle migrations to create/update tables.
  *
@@ -426,6 +447,13 @@ function runMigrations(nativeDb: DatabaseSync, db: NodeSQLiteDatabase<typeof sch
   // Bootstrap baseline + reconcile stale journal entries
   reconcileJournal(nativeDb, migrationsFolder, 'tasks', 'sqlite');
 
+  // Pre-migration column safety: ensure sessions table has the columns that the
+  // wave0-schema-hardening migration SELECTs during its table rebuild. Without
+  // this, upgrading from a pre-wave0 DB fails with "no such column: provider_id".
+  // Must run BEFORE migrateWithRetry so the migration's INSERT...SELECT succeeds.
+  // @see https://github.com/anthropics/cleo/issues/83
+  ensureColumns(nativeDb, 'sessions', REQUIRED_SESSION_COLUMNS, 'sqlite');
+
   // Run pending migrations with SQLITE_BUSY retry
   migrateWithRetry(db, migrationsFolder);
 

package/src/tasks/__tests__/complete-unblocks.test.ts

@@ -23,7 +23,10 @@ describe('completeTask unblocked tasks', () => {
     await writeFile(
       join(env.cleoDir, 'config.json'),
       JSON.stringify({
-        enforcement: { session: { requiredForMutate: false } },
+        enforcement: {
+          session: { requiredForMutate: false },
+          acceptance: { mode: 'off' },
+        },
         lifecycle: { mode: 'off' },
         verification: { enabled: false },
       }),

package/src/tasks/__tests__/complete.test.ts

@@ -22,7 +22,10 @@ describe('completeTask', () => {
     // Pin CLEO_DIR so concurrent workers cannot contaminate path resolution
     process.env['CLEO_DIR'] = env.cleoDir;
     await writeConfig({
-      enforcement: { session: { requiredForMutate: false } },
+      enforcement: {
+        session: { requiredForMutate: false },
+        acceptance: { mode: 'off' },
+      },
       lifecycle: { mode: 'off' },
       verification: { enabled: false },
     });
@@ -162,7 +165,10 @@ describe('completeTask', () => {
         type: 'task',
       },
     ]);
-    await writeConfig({ verification: { enabled: true } });
+    await writeConfig({
+      enforcement: { acceptance: { mode: 'off' } },
+      verification: { enabled: true },
+    });
 
     await expect(completeTask({ taskId: 'T001' }, env.tempDir, accessor)).rejects.toThrow(
       'missing verification metadata',
@@ -180,9 +186,11 @@ describe('completeTask', () => {
         type: 'task',
       },
     ]);
-    // Remove config.json so verification defaults to disabled (opt-in)
-    const { rm } = await import('node:fs/promises');
-    await rm(join(env.cleoDir, 'config.json'), { force: true });
+    // Write a config that only disables acceptance enforcement but no verification
+    // settings — verifying that verification defaults to disabled (opt-in behavior).
+    await writeConfig({
+      enforcement: { acceptance: { mode: 'off' } },
+    });
 
     const result = await completeTask({ taskId: 'T001' }, env.tempDir, accessor);
     expect(result.task.status).toBe('done');
@@ -199,7 +207,10 @@ describe('completeTask', () => {
         type: 'task',
       },
     ]);
-    await writeConfig({ verification: { enabled: false } });
+    await writeConfig({
+      enforcement: { acceptance: { mode: 'off' } },
+      verification: { enabled: false },
+    });
 
     const result = await completeTask({ taskId: 'T001' }, env.tempDir, accessor);
     expect(result.task.status).toBe('done');
@@ -228,6 +239,7 @@ describe('completeTask', () => {
       },
     ]);
     await writeConfig({
+      enforcement: { acceptance: { mode: 'off' } },
       verification: {
         enabled: true,
         requiredGates: ['implemented', 'testsPassed'],

package/src/tasks/__tests__/epic-enforcement.test.ts

@@ -12,7 +12,7 @@
  * @epic T056
  */
 
-import { writeFile } from 'node:fs/promises';
+import { unlink, writeFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it } from 'vitest';
 import { createTestDb, type TestDbEnv } from '../../store/__tests__/test-db-helper.js';
@@ -80,6 +80,9 @@ describe('getLifecycleMode', () => {
   });
 
   it('returns strict by default when no config', async () => {
+    // Remove the config.json written by createTestDb() so getLifecycleMode
+    // sees no project config and falls back to the 'strict' default.
+    await unlink(join(env.cleoDir, 'config.json'));
     const mode = await getLifecycleMode(env.tempDir);
     expect(mode).toBe('strict');
   });

package/src/tasks/__tests__/update.test.ts

@@ -24,7 +24,10 @@ describe('updateTask', () => {
     await writeFile(
       join(env.cleoDir, 'config.json'),
       JSON.stringify({
-        enforcement: { session: { requiredForMutate: false } },
+        enforcement: {
+          session: { requiredForMutate: false },
+          acceptance: { mode: 'off' },
+        },
         lifecycle: { mode: 'off' },
         verification: { enabled: false },
       }),

package/src/tasks/complete.ts

@@ -7,7 +7,7 @@
 import type { Task, TaskRef, VerificationGate } from '@cleocode/contracts';
 // safeAppendLog replaced by tx.appendLog inside transaction (T023)
 import { ExitCode } from '@cleocode/contracts';
-import { loadConfig } from '../config.js';
+import { getRawConfigValue, loadConfig } from '../config.js';
 import { CleoError } from '../errors.js';
 import { requireActiveSession } from '../sessions/session-enforcement.js';
 import type { DataAccessor } from '../store/data-accessor.js';
@@ -69,7 +69,11 @@ async function loadCompletionEnforcement(cwd?: string): Promise<CompletionEnforc
   const acceptanceMode = acceptance?.mode ?? (isTest ? 'off' : 'block');
   const acceptanceRequiredForPriorities =
     acceptance?.requiredForPriorities ?? (isTest ? [] : ['critical', 'high', 'medium', 'low']);
-  const verificationEnabled = verificationCfg?.enabled ?? !isTest;
+  // Use getRawConfigValue to read only the project-level config (no DEFAULTS cascade).
+  // This ensures the isTest fallback activates when verification.enabled is not explicitly set.
+  const rawVerificationEnabled = await getRawConfigValue('verification.enabled', cwd);
+  const verificationEnabled =
+    rawVerificationEnabled !== undefined ? (rawVerificationEnabled as boolean) : !isTest;
   const verificationRequiredGates =
     (verificationCfg?.requiredGates ?? []).filter(isVerificationGate).length > 0
       ? (verificationCfg?.requiredGates ?? []).filter(isVerificationGate)
@@ -278,12 +282,8 @@ export async function completeTask(
     }
   }
 
-  // Regenerate .cleo/memory-bridge.md (best-effort, T5240)
-  import('../memory/memory-bridge.js')
-    .then(({ refreshMemoryBridge }) => refreshMemoryBridge(cwd ?? process.cwd()))
-    .catch(() => {
-      /* Memory bridge refresh is best-effort */
-    });
+  // NOTE: Memory bridge refresh is now handled by the onToolComplete hook
+  // via memory-bridge-refresh.ts (T138). No direct call needed here.
 
   // Auto-extract memory from task completion (best-effort, T-audit)
   import('../memory/auto-extract.js')

package/templates/config.template.json

@@ -106,5 +106,24 @@
 
   "retention": {
     "autoEndActiveAfterDays": 7
+  },
+
+  "brain": {
+    "autoCapture": true,
+    "captureFiles": false,
+    "captureMcp": false,
+    "captureWork": false,
+    "embedding": {
+      "enabled": true,
+      "provider": "local"
+    },
+    "memoryBridge": {
+      "autoRefresh": true,
+      "contextAware": true,
+      "maxTokens": 2000
+    },
+    "summarization": {
+      "enabled": true
+    }
   }
 }

package/templates/global-config.template.json

@@ -36,5 +36,24 @@
   },
   "defaults": {
     "priority": "medium"
+  },
+
+  "brain": {
+    "autoCapture": true,
+    "captureFiles": false,
+    "captureMcp": false,
+    "captureWork": false,
+    "embedding": {
+      "enabled": true,
+      "provider": "local"
+    },
+    "memoryBridge": {
+      "autoRefresh": true,
+      "contextAware": true,
+      "maxTokens": 2000
+    },
+    "summarization": {
+      "enabled": true
+    }
   }
 }