@clemrig/factory 0.8.0 → 0.9.0

package/dist/app/workflows/stages/plan.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"plan.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/plan.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,EAEL,UAAU,EACV,IAAI,GACL,MAAM,eAAe,CAAC;AACvB,OAAO,EACL,iBAAiB,EACjB,UAAU,EACV,WAAW,EACX,UAAU,GACX,MAAM,yBAAyB,CAAC;AACjC,OAAO,KAAK,GAAG,MAAM,wBAAwB,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,2BAA2B,CAAC;AACxE,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,UAAU,CAAC;AAEtD,oGAAoG;AACpG,MAAM,UAAU,OAAO,CAAC,OAAqB;IAC3C,OAAO,KAAK,CAAC;QACX,OAAO;QACP,MAAM,EAAE,UAAU;QAClB,OAAO,EAAE,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC;YACvB,KAAK,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI;YACxB,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,IAAI;SACxB,CAAC;KACH,CAAC,CAAC;AACL,CAAC;AAED,wEAAwE;AACxE,MAAM,CAAC,MAAM,SAAS,GAAG,UAAU,CAAC;IAClC,MAAM,EAAE,UAAU;IAClB,IAAI,EAAE,MAAM;IACZ,KAAK,EAAE,CAAC,IAAI,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,WAAW,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,QAAQ,CAAC;CACrE,CAAC,CAAC;AAEH,uEAAuE;AACvE,MAAM,CAAC,MAAM,UAAU,GAAG,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,EAAE;IAC3D,MAAM,CAAC,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;IACvB,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,QAAQ,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC;IAC1C,MAAM,aAAa,CACjB,GAAG,EACH,IAAI,EACJ,MAAM,EACN,UAAU,CAAC,IAAI,EAAE,EAAE,KAAK,EAAE,QAAQ,EAAE,UAAU,EAAE,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC,CACnE,CAAC;IACF,MAAM,UAAU,GAAG,MAAM,GAAG,CAAC,MAAM,CAAC,GAAG,EAAE,iBAAiB,CAAC,IAAI,CAAC,EAAE;QAChE,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC;KAC3B,CAAC,CAAC;IACH,GAAG,CAAC,sBAAsB,IAAI,CAAC,KAAK,CAAC,MAAM,cAAc,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;IAC9E,OAAO,EAAE,UAAU,EAAE,CAAC;AACxB,CAAC,CAAC,CAAC"}

package/dist/app/workflows/stages/prepare.d.ts

@@ -0,0 +1,14 @@
+import { type Stage } from "@clemrig/flow";
+import { type VerifyCommand } from "../../../domain/verification.js";
+/**
+ * Every reason not to deliver the issue, found without changing anything; then
+ * the base must pass its checks, and the run takes the issue's branch.
+ */
+export declare function prepareIssue(checks: VerifyCommand[]): Stage<"ok">;
+/**
+ * The same starting conditions as an issue's; then the base must pass its
+ * checks, and the run takes its own branch, `tidy-<run>`, for the cleanup it
+ * will choose. Unless a cleanup waits for the operator: one at a time, and
+ * the run ends there.
+ */
+export declare function prepareTidy(checks: VerifyCommand[]): Stage<"ready" | "waiting">;

package/dist/app/workflows/stages/prepare.js

@@ -0,0 +1,195 @@
+import { code, step } from "@clemrig/flow";
+import { ghVersionProblem } from "../../../domain/pull-request.js";
+import { parseSpec } from "../../../domain/spec.js";
+import { isTidyBranch, tidySlug } from "../../../domain/tidy.js";
+import { failureFeedback, } from "../../../domain/verification.js";
+import { runBrowser } from "../../../system/browser.js";
+import { runChecks } from "../../../system/checks.js";
+import * as git from "../../../system/git.js";
+import * as github from "../../../system/github.js";
+import { artifactPath, hasArtifact, isIssue, readArtifact, } from "../../../system/issues.js";
+import { withTreeLock } from "../../../system/lock.js";
+import { screenshotsFolder } from "../../../system/run-files.js";
+import { message, short } from "./run.js";
+import { journalChecks } from "./verify.js";
+/** Why the repository cannot start a run: it must be on its main branch, without changes, as on origin. */
+async function baseProblems(dir, base) {
+    const problems = [];
+    if ((await git.currentBranch(dir)) !== base)
+        problems.push(`Switch to ${base} first`);
+    if (await git.hasChanges(dir))
+        problems.push("Commit or discard the changes in progress first");
+    await git.fetchBranch(dir, base);
+    if ((await git.commitOf(dir, "HEAD")) !==
+        (await git.commitOf(dir, git.remoteRef(base))))
+        problems.push(`${base} must match origin/${base}: push or pull first`);
+    return problems;
+}
+/** The repository on GitHub, when gh is recent enough and logged in to open its pull request; otherwise why not. */
+async function gitHubProblems(dir) {
+    const problems = [];
+    const version = await github
+        .version(dir)
+        .then(ghVersionProblem, (error) => message(error));
+    if (version)
+        problems.push(version);
+    if (!(await github.isAuthenticated(dir))) {
+        problems.push("gh is not logged in: run gh auth login");
+        return { problems };
+    }
+    try {
+        return { repository: await github.repository(dir), problems };
+    }
+    catch (error) {
+        problems.push(`gh cannot read the repository on GitHub: ${message(error)}`);
+        return { problems };
+    }
+}
+/** The dependencies that are not delivered: no plan.md on the main branch, which is checked out. */
+async function dependencyProblems(dir, slug, base, dependencies) {
+    const problems = [];
+    for (const dependency of dependencies) {
+        if (await hasArtifact(dir, dependency, "plan"))
+            continue;
+        if (await isIssue(dir, dependency))
+            problems.push(`Issue ${slug} depends on ${dependency}, which is not delivered (its plan.md is not on ${base}): deliver it first, or revise the dependency with the issue skill (/issue ${slug})`);
+        else
+            problems.push(`Issue ${slug} depends on ${dependency}, which is no issue of .factory/issues/: fix spec.md with the issue skill (/issue ${slug})`);
+    }
+    return problems;
+}
+function cannotStart(problems) {
+    return new Error(["Cannot start:", ...problems.map((problem) => `- ${problem}`)].join("\n"));
+}
+/** The main branch must pass its own checks before any agent; the checks with `when` wait for a change. */
+async function checkBase(dir, checks, base, log) {
+    const result = await runChecks(dir, checks, [], journalChecks(log, ` on ${base}`));
+    if (!result.ok)
+        throw new Error(`${base} does not pass its own checks:\n${failureFeedback(result.check, result.cause, result.output)}`);
+}
+/**
+ * The agents' browser and screenshots folder, kept in the run's folder,
+ * outside the repository: made before the run takes the tree, so that a
+ * failure leaves it on the main branch.
+ */
+async function agentWorkspace(dir, runDir) {
+    const browser = await runBrowser(dir, runDir);
+    const screenshotsDir = await screenshotsFolder(runDir);
+    return { ...(browser ? { browser } : {}), screenshotsDir };
+}
+/**
+ * Runs `work`, which takes the tree, once it is found on the main branch at
+ * the base commit the run approved. One run at a time per working tree:
+ * another one started `meanwhile` may have moved it. Checking and taking the
+ * tree happen under one lock, so that two runs never both find it free; the
+ * run starts from the approved commit, never from theirs.
+ */
+async function withFreeTree(dir, { base, baseCommit }, meanwhile, work) {
+    return withTreeLock(dir, async () => {
+        const branch = await git.currentBranch(dir);
+        const head = await git.commitOf(dir, "HEAD");
+        if (branch !== base || head !== baseCommit)
+            throw new Error(`The repository moved ${meanwhile} (now ${branch || "detached"} at ${short(head)}): another run is using it; start again once it is done`);
+        return work();
+    });
+}
+/**
+ * Every reason not to deliver the issue, found without changing anything; then
+ * the base must pass its checks, and the run takes the issue's branch.
+ */
+export function prepareIssue(checks) {
+    return step(async ({ dir, state, log, runDir }) => {
+        const slug = String(state.input.issue);
+        const base = await git.defaultBranch(dir);
+        const problems = [];
+        // The run commits and force-pushes on the branch the slug names.
+        if (slug === base)
+            problems.push(`Issue ${slug} names the main branch: its branch would replace ${base}; rename the issue`);
+        problems.push(...(await baseProblems(dir, base)));
+        const text = await readArtifact(dir, slug, "spec");
+        const spec = text === undefined ? undefined : parseSpec(text, slug);
+        if (!spec)
+            problems.push(`Issue ${slug} has no spec.md`);
+        else if (!spec.ok)
+            problems.push(...spec.problems.map((problem) => `spec.md: ${problem}`), `Fix spec.md with the issue skill (/issue ${slug}), then commit and push it`);
+        else
+            problems.push(...(await dependencyProblems(dir, slug, base, spec.value.dependencies)));
+        if (await hasArtifact(dir, slug, "plan"))
+            problems.push(`Issue ${slug} is already delivered (its plan.md is on ${base}): start a new issue`);
+        const { repository, problems: gitHub } = await gitHubProblems(dir);
+        problems.push(...gitHub);
+        if (problems.length > 0 || !spec?.ok || text === undefined || !repository)
+            throw cannotStart(problems);
+        log(`Starting point valid: ${base} matches origin, spec with ${spec.value.criteria.length} criteria, gh logged in`);
+        const baseCommit = await git.commitOf(dir, "HEAD");
+        await checkBase(dir, checks, base, log);
+        const workspace = await agentWorkspace(dir, runDir);
+        await withFreeTree(dir, { base, baseCommit }, `while ${base}'s checks ran`, () => git.switchTo(dir, slug, baseCommit));
+        log(`Created branch ${slug} from ${base} at ${short(baseCommit)}`);
+        return {
+            slug,
+            title: spec.value.title,
+            spec: text,
+            objective: spec.value.objective,
+            criteria: spec.value.criteria,
+            repository,
+            ...workspace,
+            base,
+            baseCommit,
+            specPath: artifactPath(slug, "spec"),
+            planPath: artifactPath(slug, "plan"),
+        };
+    });
+}
+/**
+ * The same starting conditions as an issue's; then the base must pass its
+ * checks, and the run takes its own branch, `tidy-<run>`, for the cleanup it
+ * will choose. Unless a cleanup waits for the operator: one at a time, and
+ * the run ends there.
+ */
+export function prepareTidy(checks) {
+    return code(["ready", "waiting"], async ({ dir, state, log, runDir }) => {
+        const slug = tidySlug(state.id);
+        const base = await git.defaultBranch(dir);
+        const problems = await baseProblems(dir, base);
+        const { repository, problems: gitHub } = await gitHubProblems(dir);
+        problems.push(...gitHub);
+        if (problems.length > 0 || !repository)
+            throw cannotStart(problems);
+        log(`Starting point valid: ${base} matches origin, gh logged in`);
+        const baseCommit = await git.commitOf(dir, "HEAD");
+        await checkBase(dir, checks, base, log);
+        const workspace = await agentWorkspace(dir, runDir);
+        const { openPullRequests, waiting } = await withFreeTree(dir, { base, baseCommit }, `while ${base}'s checks ran`, async () => {
+            // Read once the tree is found free: a run is back on the main branch
+            // only once its pull request is open.
+            const openPullRequests = await github.openPullRequests(dir);
+            const waiting = openPullRequests.find(({ branch }) => isTidyBranch(branch));
+            if (!waiting)
+                await git.switchTo(dir, slug, baseCommit);
+            return { openPullRequests, waiting };
+        });
+        if (waiting)
+            return {
+                outcome: "waiting",
+                reason: `A cleanup waits for the operator: ${waiting.url}`,
+                data: { waitingFor: waiting.url },
+            };
+        log(`Created branch ${slug} from ${base} at ${short(baseCommit)}`);
+        return {
+            outcome: "ready",
+            reason: `${base} passes its checks, no cleanup waiting`,
+            data: {
+                slug,
+                repository,
+                ...workspace,
+                base,
+                baseCommit,
+                specPath: artifactPath(slug, "spec"),
+                planPath: artifactPath(slug, "plan"),
+                openPullRequests,
+            },
+        };
+    });
+}
+//# sourceMappingURL=prepare.js.map

package/dist/app/workflows/stages/prepare.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"prepare.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/prepare.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAwB,IAAI,EAAE,MAAM,eAAe,CAAC;AACjE,OAAO,EAAE,gBAAgB,EAAE,MAAM,iCAAiC,CAAC;AACnE,OAAO,EAAE,SAAS,EAAE,MAAM,yBAAyB,CAAC;AACpD,OAAO,EAAE,YAAY,EAAE,QAAQ,EAAE,MAAM,yBAAyB,CAAC;AACjE,OAAO,EACL,eAAe,GAEhB,MAAM,iCAAiC,CAAC;AACzC,OAAO,EAAE,UAAU,EAAE,MAAM,4BAA4B,CAAC;AACxD,OAAO,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtD,OAAO,KAAK,GAAG,MAAM,wBAAwB,CAAC;AAC9C,OAAO,KAAK,MAAM,MAAM,2BAA2B,CAAC;AACpD,OAAO,EACL,YAAY,EACZ,WAAW,EACX,OAAO,EACP,YAAY,GACb,MAAM,2BAA2B,CAAC;AACnC,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AACvD,OAAO,EAAE,iBAAiB,EAAE,MAAM,8BAA8B,CAAC;AACjE,OAAO,EAAc,OAAO,EAAE,KAAK,EAAE,MAAM,UAAU,CAAC;AACtD,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAE5C,2GAA2G;AAC3G,KAAK,UAAU,YAAY,CAAC,GAAW,EAAE,IAAY;IACnD,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,IAAI,CAAC,MAAM,GAAG,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,KAAK,IAAI;QACzC,QAAQ,CAAC,IAAI,CAAC,aAAa,IAAI,QAAQ,CAAC,CAAC;IAC3C,IAAI,MAAM,GAAG,CAAC,UAAU,CAAC,GAAG,CAAC;QAC3B,QAAQ,CAAC,IAAI,CAAC,iDAAiD,CAAC,CAAC;IACnE,MAAM,GAAG,CAAC,WAAW,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;IACjC,IACE,CAAC,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACjC,CAAC,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,GAAG,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC;QAE9C,QAAQ,CAAC,IAAI,CAAC,GAAG,IAAI,sBAAsB,IAAI,sBAAsB,CAAC,CAAC;IACzE,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,oHAAoH;AACpH,KAAK,UAAU,cAAc,CAC3B,GAAW;IAEX,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,MAAM,OAAO,GAAG,MAAM,MAAM;SACzB,OAAO,CAAC,GAAG,CAAC;SACZ,IAAI,CAAC,gBAAgB,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC;IACrD,IAAI,OAAO;QAAE,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACpC,IAAI,CAAC,CAAC,MAAM,MAAM,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;QACzC,QAAQ,CAAC,IAAI,CAAC,wCAAwC,CAAC,CAAC;QACxD,OAAO,EAAE,QAAQ,EAAE,CAAC;IACtB,CAAC;IACD,IAAI,CAAC;QACH,OAAO,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,QAAQ,EAAE,CAAC;IAChE,CAAC;IAAC,OAAO,KAAK,EAAE,CAAC;QACf,QAAQ,CAAC,IAAI,CAAC,4CAA4C,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAC5E,OAAO,EAAE,QAAQ,EAAE,CAAC;IACtB,CAAC;AACH,CAAC;AAED,oGAAoG;AACpG,KAAK,UAAU,kBAAkB,CAC/B,GAAW,EACX,IAAY,EACZ,IAAY,EACZ,YAAsB;IAEtB,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,KAAK,MAAM,UAAU,IAAI,YAAY,EAAE,CAAC;QACtC,IAAI,MAAM,WAAW,CAAC,GAAG,EAAE,UAAU,EAAE,MAAM,CAAC;YAAE,SAAS;QACzD,IAAI,MAAM,OAAO,CAAC,GAAG,EAAE,UAAU,CAAC;YAChC,QAAQ,CAAC,IAAI,CACX,SAAS,IAAI,eAAe,UAAU,mDAAmD,IAAI,8EAA8E,IAAI,GAAG,CACnL,CAAC;;YAEF,QAAQ,CAAC,IAAI,CACX,SAAS,IAAI,eAAe,UAAU,qFAAqF,IAAI,GAAG,CACnI,CAAC;IACN,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,SAAS,WAAW,CAAC,QAAkB;IACrC,OAAO,IAAI,KAAK,CACd,CAAC,eAAe,EAAE,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,KAAK,OAAO,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAC3E,CAAC;AACJ,CAAC;AAED,2GAA2G;AAC3G,KAAK,UAAU,SAAS,CACtB,GAAW,EACX,MAAuB,EACvB,IAAY,EACZ,GAAQ;IAER,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,GAAG,EACH,MAAM,EACN,EAAE,EACF,aAAa,CAAC,GAAG,EAAE,OAAO,IAAI,EAAE,CAAC,CAClC,CAAC;IACF,IAAI,CAAC,MAAM,CAAC,EAAE;QACZ,MAAM,IAAI,KAAK,CACb,GAAG,IAAI,mCAAmC,eAAe,CAAC,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,CAAC,EAAE,CACvG,CAAC;AACN,CAAC;AAED;;;;GAIG;AACH,KAAK,UAAU,cAAc,CAC3B,GAAW,EACX,MAAc;IAEd,MAAM,OAAO,GAAG,MAAM,UAAU,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;IAC9C,MAAM,cAAc,GAAG,MAAM,iBAAiB,CAAC,MAAM,CAAC,CAAC;IACvD,OAAO,EAAE,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,cAAc,EAAE,CAAC;AAC7D,CAAC;AAED;;;;;;GAMG;AACH,KAAK,UAAU,YAAY,CACzB,GAAW,EACX,EAAE,IAAI,EAAE,UAAU,EAAsC,EACxD,SAAiB,EACjB,IAAsB;IAEtB,OAAO,YAAY,CAAC,GAAG,EAAE,KAAK,IAAI,EAAE;QAClC,MAAM,MAAM,GAAG,MAAM,GAAG,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC;QAC5C,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QAC7C,IAAI,MAAM,KAAK,IAAI,IAAI,IAAI,KAAK,UAAU;YACxC,MAAM,IAAI,KAAK,CACb,wBAAwB,SAAS,SAAS,MAAM,IAAI,UAAU,OAAO,KAAK,CAAC,IAAI,CAAC,yDAAyD,CAC1I,CAAC;QACJ,OAAO,IAAI,EAAE,CAAC;IAChB,CAAC,CAAC,CAAC;AACL,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,YAAY,CAAC,MAAuB;IAClD,OAAO,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,MAAM,EAAE,EAAE,EAAE;QAChD,MAAM,IAAI,GAAG,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;QACvC,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,QAAQ,GAAa,EAAE,CAAC;QAC9B,iEAAiE;QACjE,IAAI,IAAI,KAAK,IAAI;YACf,QAAQ,CAAC,IAAI,CACX,SAAS,IAAI,oDAAoD,IAAI,oBAAoB,CAC1F,CAAC;QACJ,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,MAAM,YAAY,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC;QAClD,MAAM,IAAI,GAAG,MAAM,YAAY,CAAC,GAAG,EAAE,IAAI,EAAE,MAAM,CAAC,CAAC;QACnD,MAAM,IAAI,GAAG,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,SAAS,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;QACpE,IAAI,CAAC,IAAI;YAAE,QAAQ,CAAC,IAAI,CAAC,SAAS,IAAI,iBAAiB,CAAC,CAAC;aACpD,IAAI,CAAC,IAAI,CAAC,EAAE;YACf,QAAQ,CAAC,IAAI,CACX,GAAG,IAAI,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,YAAY,OAAO,EAAE,CAAC,EACxD,4CAA4C,IAAI,4BAA4B,CAC7E,CAAC;;YAEF,QAAQ,CAAC,IAAI,CACX,GAAG,CAAC,MAAM,kBAAkB,CAAC,GAAG,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CACxE,CAAC;QACJ,IAAI,MAAM,WAAW,CAAC,GAAG,EAAE,IAAI,EAAE,MAAM,CAAC;YACtC,QAAQ,CAAC,IAAI,CACX,SAAS,IAAI,4CAA4C,IAAI,sBAAsB,CACpF,CAAC;QACJ,MAAM,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,MAAM,cAAc,CAAC,GAAG,CAAC,CAAC;QACnE,QAAQ,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;QACzB,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,IAAI,EAAE,EAAE,IAAI,IAAI,KAAK,SAAS,IAAI,CAAC,UAAU;YACvE,MAAM,WAAW,CAAC,QAAQ,CAAC,CAAC;QAC9B,GAAG,CACD,yBAAyB,IAAI,8BAA8B,IAAI,CAAC,KAAK,CAAC,QAAQ,CAAC,MAAM,yBAAyB,CAC/G,CAAC;QACF,MAAM,UAAU,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACnD,MAAM,SAAS,CAAC,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC;QACxC,MAAM,SAAS,GAAG,MAAM,cAAc,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,YAAY,CAChB,GAAG,EACH,EAAE,IAAI,EAAE,UAAU,EAAE,EACpB,SAAS,IAAI,eAAe,EAC5B,GAAG,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,IAAI,EAAE,UAAU,CAAC,CAC1C,CAAC;QACF,GAAG,CAAC,kBAAkB,IAAI,SAAS,IAAI,OAAO,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACnE,OAAO;YACL,IAAI;YACJ,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK;YACvB,IAAI,EAAE,IAAI;YACV,SAAS,EAAE,IAAI,CAAC,KAAK,CAAC,SAAS;YAC/B,QAAQ,EAAE,IAAI,CAAC,KAAK,CAAC,QAAQ;YAC7B,UAAU;YACV,GAAG,SAAS;YACZ,IAAI;YACJ,UAAU;YACV,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC;YACpC,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC;SACrC,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,WAAW,CACzB,MAAuB;IAEvB,OAAO,IAAI,CAAC,CAAC,OAAO,EAAE,SAAS,CAAC,EAAE,KAAK,EAAE,EAAE,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,MAAM,EAAE,EAAE,EAAE;QACtE,MAAM,IAAI,GAAG,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC;QAChC,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC;QAC1C,MAAM,QAAQ,GAAG,MAAM,YAAY,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;QAC/C,MAAM,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,MAAM,cAAc,CAAC,GAAG,CAAC,CAAC;QACnE,QAAQ,CAAC,IAAI,CAAC,GAAG,MAAM,CAAC,CAAC;QACzB,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,IAAI,CAAC,UAAU;YAAE,MAAM,WAAW,CAAC,QAAQ,CAAC,CAAC;QACpE,GAAG,CAAC,yBAAyB,IAAI,+BAA+B,CAAC,CAAC;QAClE,MAAM,UAAU,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACnD,MAAM,SAAS,CAAC,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC;QACxC,MAAM,SAAS,GAAG,MAAM,cAAc,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;QACpD,MAAM,EAAE,gBAAgB,EAAE,OAAO,EAAE,GAAG,MAAM,YAAY,CACtD,GAAG,EACH,EAAE,IAAI,EAAE,UAAU,EAAE,EACpB,SAAS,IAAI,eAAe,EAC5B,KAAK,IAAI,EAAE;YACT,qEAAqE;YACrE,sCAAsC;YACtC,MAAM,gBAAgB,GAAG,MAAM,MAAM,CAAC,gBAAgB,CAAC,GAAG,CAAC,CAAC;YAC5D,MAAM,OAAO,GAAG,gBAAgB,CAAC,IAAI,CAAC,CAAC,EAAE,MAAM,EAAE,EAAE,EAAE,CACnD,YAAY,CAAC,MAAM,CAAC,CACrB,CAAC;YACF,IAAI,CAAC,OAAO;gBAAE,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC;YACxD,OAAO,EAAE,gBAAgB,EAAE,OAAO,EAAE,CAAC;QACvC,CAAC,CACF,CAAC;QACF,IAAI,OAAO;YACT,OAAO;gBACL,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,qCAAqC,OAAO,CAAC,GAAG,EAAE;gBAC1D,IAAI,EAAE,EAAE,UAAU,EAAE,OAAO,CAAC,GAAG,EAAE;aAClC,CAAC;QACJ,GAAG,CAAC,kBAAkB,IAAI,SAAS,IAAI,OAAO,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACnE,OAAO;YACL,OAAO,EAAE,OAAO;YAChB,MAAM,EAAE,GAAG,IAAI,wCAAwC;YACvD,IAAI,EAAE;gBACJ,IAAI;gBACJ,UAAU;gBACV,GAAG,SAAS;gBACZ,IAAI;gBACJ,UAAU;gBACV,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC;gBACpC,QAAQ,EAAE,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC;gBACpC,gBAAgB;aACjB;SACF,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC"}

package/dist/app/workflows/stages/resume.d.ts

@@ -0,0 +1,7 @@
+import type { StageContext } from "@clemrig/flow";
+/**
+ * A failed delivery resumes on its branch, at the commit its stage started
+ * from, with its changes in progress and none in .factory/ but the plan it may
+ * have written; `prepare` checks everything again, and a delivered run is done.
+ */
+export declare function resumeProblem({ dir, state, }: Pick<StageContext, "dir" | "state">): Promise<string | undefined>;

package/dist/app/workflows/stages/resume.js

@@ -0,0 +1,54 @@
+import * as git from "../../../system/git.js";
+import { artifactPath } from "../../../system/issues.js";
+import { facts, short, specCommitOf } from "./run.js";
+/**
+ * A failed delivery resumes on its branch, at the commit its stage started
+ * from, with its changes in progress and none in .factory/ but the plan it may
+ * have written; `prepare` checks everything again, and a delivered run is done.
+ */
+export async function resumeProblem({ dir, state, }) {
+    if (state.stage === "prepare")
+        return undefined;
+    // Its pull request is open: only its screenshots remain to attach, from the
+    // run's folder, whatever the repository is on.
+    if (state.stage === "attach")
+        return undefined;
+    // Stopped once its last stage was done, such as by Ctrl-C.
+    const { pullRequest } = state.data;
+    if (typeof pullRequest === "string")
+        return `the run already delivered its pull request ${pullRequest}`;
+    // An earlier factory read neither the repository on GitHub nor the spec's
+    // objective: the pull request this run would open needs them.
+    if (typeof state.data.repository !== "object")
+        return "the run started with an earlier version of the factory, whose data this one does not read: start a new run";
+    // The review and the description start from the tree the review reads,
+    // which Git may have pruned meanwhile.
+    const { reviewedTree } = state.data;
+    if ((state.stage === "review" || state.stage === "describe") &&
+        typeof reviewedTree === "string" &&
+        !(await git.hasObject(dir, reviewedTree)))
+        return `the tree the ${state.stage === "review" ? "review" : "description"} reads is no longer in Git (removed by git gc): start a new run`;
+    const f = facts(state);
+    const { slug, specPath, planPath } = f;
+    // Until the plan is committed, the branch is at the spec's commit: the base
+    // commit, until a cleanup commits its own.
+    const { planCommit } = state.data;
+    const expected = typeof planCommit === "string" ? planCommit : specCommitOf(f);
+    const branch = await git.currentBranch(dir);
+    const head = await git.commitOf(dir, "HEAD");
+    const problems = [];
+    if (branch !== slug || head !== expected)
+        problems.push(`the repository must be on ${slug} at ${short(expected)}, where the run stopped, with its changes in progress; it is on ${branch || "a detached HEAD"} at ${short(head)}${state.stage === "deliver" && branch === slug
+            ? `; if the run already committed its changes, git reset --soft ${short(expected)} puts them back in progress`
+            : ""}`);
+    // `commit-spec` and `commit-plan` write their files again before committing them.
+    const rewritten = state.stage === "commit-spec"
+        ? [artifactPath(slug, "issue"), specPath]
+        : state.stage === "commit-plan"
+            ? [planPath]
+            : [];
+    if (await git.hasChanges(dir, ".factory", rewritten))
+        problems.push(".factory/ has changes in progress, which a run never delivers: discard them");
+    return problems.length ? problems.join("; ") : undefined;
+}
+//# sourceMappingURL=resume.js.map

package/dist/app/workflows/stages/resume.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"resume.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/resume.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,GAAG,MAAM,wBAAwB,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,MAAM,2BAA2B,CAAC;AACzD,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,UAAU,CAAC;AAEtD;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,EAClC,GAAG,EACH,KAAK,GAC+B;IACpC,IAAI,KAAK,CAAC,KAAK,KAAK,SAAS;QAAE,OAAO,SAAS,CAAC;IAChD,4EAA4E;IAC5E,+CAA+C;IAC/C,IAAI,KAAK,CAAC,KAAK,KAAK,QAAQ;QAAE,OAAO,SAAS,CAAC;IAC/C,2DAA2D;IAC3D,MAAM,EAAE,WAAW,EAAE,GAAG,KAAK,CAAC,IAAI,CAAC;IACnC,IAAI,OAAO,WAAW,KAAK,QAAQ;QACjC,OAAO,8CAA8C,WAAW,EAAE,CAAC;IACrE,0EAA0E;IAC1E,8DAA8D;IAC9D,IAAI,OAAO,KAAK,CAAC,IAAI,CAAC,UAAU,KAAK,QAAQ;QAC3C,OAAO,4GAA4G,CAAC;IACtH,uEAAuE;IACvE,uCAAuC;IACvC,MAAM,EAAE,YAAY,EAAE,GAAG,KAAK,CAAC,IAAI,CAAC;IACpC,IACE,CAAC,KAAK,CAAC,KAAK,KAAK,QAAQ,IAAI,KAAK,CAAC,KAAK,KAAK,UAAU,CAAC;QACxD,OAAO,YAAY,KAAK,QAAQ;QAChC,CAAC,CAAC,MAAM,GAAG,CAAC,SAAS,CAAC,GAAG,EAAE,YAAY,CAAC,CAAC;QAEzC,OAAO,gBAAgB,KAAK,CAAC,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,aAAa,iEAAiE,CAAC;IAC9I,MAAM,CAAC,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;IACvB,MAAM,EAAE,IAAI,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAC;IACvC,4EAA4E;IAC5E,2CAA2C;IAC3C,MAAM,EAAE,UAAU,EAAE,GAAG,KAAK,CAAC,IAAI,CAAC;IAClC,MAAM,QAAQ,GACZ,OAAO,UAAU,KAAK,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IAChE,MAAM,MAAM,GAAG,MAAM,GAAG,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC;IAC5C,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC;IAC7C,MAAM,QAAQ,GAAa,EAAE,CAAC;IAC9B,IAAI,MAAM,KAAK,IAAI,IAAI,IAAI,KAAK,QAAQ;QACtC,QAAQ,CAAC,IAAI,CACX,6BAA6B,IAAI,OAAO,KAAK,CAAC,QAAQ,CAAC,mEAAmE,MAAM,IAAI,iBAAiB,OAAO,KAAK,CAAC,IAAI,CAAC,GACrK,KAAK,CAAC,KAAK,KAAK,SAAS,IAAI,MAAM,KAAK,IAAI;YAC1C,CAAC,CAAC,gEAAgE,KAAK,CAAC,QAAQ,CAAC,6BAA6B;YAC9G,CAAC,CAAC,EACN,EAAE,CACH,CAAC;IACJ,kFAAkF;IAClF,MAAM,SAAS,GACb,KAAK,CAAC,KAAK,KAAK,aAAa;QAC3B,CAAC,CAAC,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE,QAAQ,CAAC;QACzC,CAAC,CAAC,KAAK,CAAC,KAAK,KAAK,aAAa;YAC7B,CAAC,CAAC,CAAC,QAAQ,CAAC;YACZ,CAAC,CAAC,EAAE,CAAC;IACX,IAAI,MAAM,GAAG,CAAC,UAAU,CAAC,GAAG,EAAE,UAAU,EAAE,SAAS,CAAC;QAClD,QAAQ,CAAC,IAAI,CACX,6EAA6E,CAC9E,CAAC;IACJ,OAAO,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;AAC3D,CAAC"}

package/dist/app/workflows/stages/review.d.ts

@@ -0,0 +1,16 @@
+import { type AgentProfile, type Stage } from "@clemrig/flow";
+/**
+ * Every change since the plan, new files included, and the tree the review
+ * reads; a large diff is read from a file, part by part.
+ */
+export declare const diff: Stage<"ok">;
+/**
+ * The reviewing agent: it judges the change against the spec, from the code
+ * and the checks alone. From the second round on, it first reviews the change
+ * knowing nothing of the earlier reviews, then, in the same conversation,
+ * checks what the previous one found against the code as it is now, and gives
+ * its whole review again: nothing found earlier is lost on the way.
+ */
+export declare function reviewer(profile: AgentProfile): Stage<"ok" | "modified">;
+/** An unmet criterion or a blocking finding sends the change back, unless the operator accepted the review. */
+export declare const judgeReview: Stage<"approved" | "changes" | "invalid">;

package/dist/app/workflows/stages/review.js

@@ -0,0 +1,103 @@
+import { agent, gate, step, z, } from "@clemrig/flow";
+import { largeChangeLines, reviewChanges, reviewOutput, reviewProblem, } from "../../../domain/review.js";
+import * as git from "../../../system/git.js";
+import { keepInRun } from "../../../system/run-files.js";
+import { browserContext, readers, reading } from "./agents.js";
+import { facts, reviewRounds } from "./run.js";
+/**
+ * A new conversation for each review, and for a review started again after it
+ * changed the repository; a correction of its format resumes it.
+ */
+function reviewSession(state) {
+    const restarts = state.retries?.["review.modified"] ?? 0;
+    return `review-${reviewRounds(state)}${restarts > 0 ? `-${restarts}` : ""}`;
+}
+/**
+ * Every change since the plan, new files included, and the tree the review
+ * reads; a large diff is read from a file, part by part.
+ */
+export const diff = step(async ({ dir, state, log, runDir }) => {
+    const { planCommit } = facts(state);
+    const reviewedTree = await git.snapshot(dir);
+    const patch = await git.diff(dir, planCommit, reviewedTree);
+    if (patch.truncated)
+        throw new Error("The changes are too large to review (over 2 MiB of diff): the run stops");
+    const files = await git.diffStat(dir, planCommit, reviewedTree);
+    const lines = patch.text.split("\n").length;
+    log(`Changes since the plan: ${files.length} files, ${lines} diff lines`);
+    const changes = lines <= largeChangeLines
+        ? { files, lines, large: false, diff: patch.text }
+        : {
+            files,
+            lines,
+            large: true,
+            diffFile: await keepInRun(runDir, "diff.patch", patch.text),
+        };
+    if (changes.large)
+        log(`Large change: the review reads its diff from ${changes.diffFile}`);
+    return { changes, reviewedTree };
+});
+/**
+ * The reviewing agent: it judges the change against the spec, from the code
+ * and the checks alone. From the second round on, it first reviews the change
+ * knowing nothing of the earlier reviews, then, in the same conversation,
+ * checks what the previous one found against the code as it is now, and gives
+ * its whole review again: nothing found earlier is lost on the way.
+ */
+export function reviewer(profile) {
+    const call = (context) => agent({ profile, schema: reviewOutput, session: reviewSession, context });
+    const fresh = call(({ state }) => {
+        const { slug, spec, changes, checks } = facts(state);
+        return { issue: slug, spec, changes, checks, ...browserContext(state) };
+    });
+    const recheck = call(({ state }) => ({
+        previous: facts(state).reviews?.at(-1),
+    }));
+    return reading(readers.review, {
+        ...fresh,
+        async run(context) {
+            const first = await fresh.run(context);
+            if ((facts(context.state).reviews ?? []).length === 0)
+                return first;
+            return recheck.run(context);
+        },
+    });
+}
+/** An unmet criterion or a blocking finding sends the change back, unless the operator accepted the review. */
+export const judgeReview = gate(["approved", "changes", "invalid"], async ({ state }) => {
+    const parsed = reviewOutput.safeParse(state.output);
+    if (!parsed.success)
+        return {
+            outcome: "invalid",
+            reason: `Invalid structured output:\n${z.prettifyError(parsed.error)}`,
+        };
+    const problem = reviewProblem(parsed.data, facts(state).criteria);
+    if (problem)
+        return { outcome: "invalid", reason: problem };
+    const changes = reviewChanges(parsed.data);
+    // Each review judged is kept, the last one apart for the stages after.
+    const judged = {
+        review: parsed.data,
+        reviews: [...(facts(state).reviews ?? []), parsed.data],
+    };
+    // The operator resumed the run to deliver it as the review left it.
+    if (changes && state.data.acceptedReview === true)
+        return {
+            outcome: "approved",
+            reason: "The operator accepted the review's unmet criteria and blocking findings",
+            data: judged,
+        };
+    if (changes)
+        return {
+            outcome: "changes",
+            reason: "The review requires changes",
+            feedback: changes,
+            data: judged,
+        };
+    return {
+        outcome: "approved",
+        reason: "Every criterion is met and nothing blocks",
+        data: judged,
+    };
+});
+//# sourceMappingURL=review.js.map

package/dist/app/workflows/stages/review.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/review.ts"],"names":[],"mappings":"AAAA,OAAO,EAEL,KAAK,EACL,IAAI,EAIJ,IAAI,EACJ,CAAC,GACF,MAAM,eAAe,CAAC;AACvB,OAAO,EAEL,gBAAgB,EAChB,aAAa,EACb,YAAY,EACZ,aAAa,GACd,MAAM,2BAA2B,CAAC;AACnC,OAAO,KAAK,GAAG,MAAM,wBAAwB,CAAC;AAC9C,OAAO,EAAE,SAAS,EAAE,MAAM,8BAA8B,CAAC;AACzD,OAAO,EAAE,cAAc,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC/D,OAAO,EAAE,KAAK,EAAE,YAAY,EAAE,MAAM,UAAU,CAAC;AAE/C;;;GAGG;AACH,SAAS,aAAa,CAAC,KAAyB;IAC9C,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;IACzD,OAAO,UAAU,YAAY,CAAC,KAAK,CAAC,GAAG,QAAQ,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,QAAQ,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;AAC9E,CAAC;AAED;;;GAGG;AACH,MAAM,CAAC,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,EAAE,EAAE,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,MAAM,EAAE,EAAE,EAAE;IAC7D,MAAM,EAAE,UAAU,EAAE,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;IACpC,MAAM,YAAY,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC;IAC7C,MAAM,KAAK,GAAG,MAAM,GAAG,CAAC,IAAI,CAAC,GAAG,EAAE,UAAU,EAAE,YAAY,CAAC,CAAC;IAC5D,IAAI,KAAK,CAAC,SAAS;QACjB,MAAM,IAAI,KAAK,CACb,yEAAyE,CAC1E,CAAC;IACJ,MAAM,KAAK,GAAG,MAAM,GAAG,CAAC,QAAQ,CAAC,GAAG,EAAE,UAAU,EAAE,YAAY,CAAC,CAAC;IAChE,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;IAC5C,GAAG,CAAC,2BAA2B,KAAK,CAAC,MAAM,WAAW,KAAK,aAAa,CAAC,CAAC;IAC1E,MAAM,OAAO,GACX,KAAK,IAAI,gBAAgB;QACvB,CAAC,CAAC,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,IAAI,EAAE,KAAK,CAAC,IAAI,EAAE;QAClD,CAAC,CAAC;YACE,KAAK;YACL,KAAK;YACL,KAAK,EAAE,IAAI;YACX,QAAQ,EAAE,MAAM,SAAS,CAAC,MAAM,EAAE,YAAY,EAAE,KAAK,CAAC,IAAI,CAAC;SAC5D,CAAC;IACR,IAAI,OAAO,CAAC,KAAK;QACf,GAAG,CAAC,gDAAgD,OAAO,CAAC,QAAQ,EAAE,CAAC,CAAC;IAC1E,OAAO,EAAE,OAAO,EAAE,YAAY,EAAE,CAAC;AACnC,CAAC,CAAC,CAAC;AAEH;;;;;;GAMG;AACH,MAAM,UAAU,QAAQ,CAAC,OAAqB;IAC5C,MAAM,IAAI,GAAG,CAAC,OAAyD,EAAE,EAAE,CACzE,KAAK,CAAC,EAAE,OAAO,EAAE,MAAM,EAAE,YAAY,EAAE,OAAO,EAAE,aAAa,EAAE,OAAO,EAAE,CAAC,CAAC;IAC5E,MAAM,KAAK,GAAG,IAAI,CAAC,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE;QAC/B,MAAM,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,MAAM,EAAE,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;QACrD,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,EAAE,MAAM,EAAE,GAAG,cAAc,CAAC,KAAK,CAAC,EAAE,CAAC;IAC1E,CAAC,CAAC,CAAC;IACH,MAAM,OAAO,GAAG,IAAI,CAAC,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC,CAAC;QACnC,QAAQ,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC;KACvC,CAAC,CAAC,CAAC;IACJ,OAAO,OAAO,CAAC,OAAO,CAAC,MAAM,EAAE;QAC7B,GAAG,KAAK;QACR,KAAK,CAAC,GAAG,CAAC,OAAO;YACf,MAAM,KAAK,GAAG,MAAM,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;YACvC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,OAAO,IAAI,EAAE,CAAC,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO,KAAK,CAAC;YACpE,OAAO,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAC9B,CAAC;KACF,CAAC,CAAC;AACL,CAAC;AAED,+GAA+G;AAC/G,MAAM,CAAC,MAAM,WAAW,GAAG,IAAI,CAC7B,CAAC,UAAU,EAAE,SAAS,EAAE,SAAS,CAAC,EAClC,KAAK,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE;IAClB,MAAM,MAAM,GAAG,YAAY,CAAC,SAAS,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC;IACpD,IAAI,CAAC,MAAM,CAAC,OAAO;QACjB,OAAO;YACL,OAAO,EAAE,SAAS;YAClB,MAAM,EAAE,+BAA+B,CAAC,CAAC,aAAa,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE;SACvE,CAAC;IACJ,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,QAAQ,CAAC,CAAC;IAClE,IAAI,OAAO;QAAE,OAAO,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC;IAC5D,MAAM,OAAO,GAAG,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IAC3C,uEAAuE;IACvE,MAAM,MAAM,GAAG;QACb,MAAM,EAAE,MAAM,CAAC,IAAI;QACnB,OAAO,EAAE,CAAC,GAAG,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,OAAO,IAAI,EAAE,CAAC,EAAE,MAAM,CAAC,IAAI,CAAC;KACxD,CAAC;IACF,oEAAoE;IACpE,IAAI,OAAO,IAAI,KAAK,CAAC,IAAI,CAAC,cAAc,KAAK,IAAI;QAC/C,OAAO;YACL,OAAO,EAAE,UAAU;YACnB,MAAM,EACJ,yEAAyE;YAC3E,IAAI,EAAE,MAAM;SACb,CAAC;IACJ,IAAI,OAAO;QACT,OAAO;YACL,OAAO,EAAE,SAAS;YAClB,MAAM,EAAE,6BAA6B;YACrC,QAAQ,EAAE,OAAO;YACjB,IAAI,EAAE,MAAM;SACb,CAAC;IACJ,OAAO;QACL,OAAO,EAAE,UAAU;QACnB,MAAM,EAAE,2CAA2C;QACnD,IAAI,EAAE,MAAM;KACb,CAAC;AACJ,CAAC,CACF,CAAC"}

package/dist/app/workflows/stages/run.d.ts

@@ -0,0 +1,60 @@
+import type { RunState } from "@clemrig/flow";
+import type { FactoryDefinition } from "../../../domain/definition.js";
+import type { Description } from "../../../domain/description.js";
+import type { Plan } from "../../../domain/plan.js";
+import type { Changes, Implementation, Review } from "../../../domain/review.js";
+import type { Criterion } from "../../../domain/spec.js";
+import type { KeptCheck } from "../../../system/run-files.js";
+/** What the workflows use: the factory requires the budget, a workflow also runs without one. */
+export type Settings = Pick<FactoryDefinition, "verify" | "profiles"> & {
+    maxCostUsd?: number;
+};
+/** What the stages record in the run's data, each once its stage has passed. */
+export interface Facts {
+    slug: string;
+    title: string;
+    spec: string;
+    /** The spec's Objective, which the pull request recalls. */
+    objective: string;
+    criteria: Criterion[];
+    /** The repository on GitHub: its page, and whether anyone can see it. */
+    repository: {
+        url: string;
+        public: boolean;
+    };
+    /** The agents' browser, when `.factory/` installs one. */
+    browser?: string;
+    /** Where the describing agent puts its screenshots. */
+    screenshotsDir: string;
+    base: string;
+    /** The main branch's commit the run's branch starts from. */
+    baseCommit: string;
+    /** The commit of the spec a cleanup writes, once committed; an issue's spec was approved on the base. */
+    specCommit?: string;
+    specPath: string;
+    planPath: string;
+    plan: Plan;
+    planCommit: string;
+    implementation: Implementation;
+    checks: KeptCheck[];
+    /** The checks whose `when` no changed file matched. */
+    skippedChecks: string[];
+    changes: Changes;
+    /** The working tree the review reads, as a tree object: what it must leave as it found it. */
+    reviewedTree: string;
+    /** The review the run judged last: approved, or accepted by the operator. */
+    review: Review;
+    /** Every review the run judged, in order; absent from runs of an earlier factory. */
+    reviews?: Review[];
+    /** Set when the operator resumed the run to deliver it despite its review. */
+    acceptedReview?: boolean;
+    description: Description;
+    pullRequest: string;
+}
+export declare function facts(state: Readonly<RunState>): Facts;
+/** The commit that holds the spec the run delivers: a cleanup's own, once committed, else the base commit. */
+export declare function specCommitOf({ specCommit, baseCommit }: Facts): string;
+/** Corrections the review asked for so far. */
+export declare function reviewRounds(state: Readonly<RunState>): number;
+export declare function short(commit: string): string;
+export declare const message: (error: unknown) => string;

package/dist/app/workflows/stages/run.js

@@ -0,0 +1,16 @@
+export function facts(state) {
+    return state.data;
+}
+/** The commit that holds the spec the run delivers: a cleanup's own, once committed, else the base commit. */
+export function specCommitOf({ specCommit, baseCommit }) {
+    return specCommit ?? baseCommit;
+}
+/** Corrections the review asked for so far. */
+export function reviewRounds(state) {
+    return state.retries?.["reviewed.changes"] ?? 0;
+}
+export function short(commit) {
+    return commit.slice(0, 7);
+}
+export const message = (error) => error instanceof Error ? error.message : String(error);
+//# sourceMappingURL=run.js.map

package/dist/app/workflows/stages/run.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"run.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/run.ts"],"names":[],"mappings":"AAyDA,MAAM,UAAU,KAAK,CAAC,KAAyB;IAC7C,OAAO,KAAK,CAAC,IAAwB,CAAC;AACxC,CAAC;AAED,8GAA8G;AAC9G,MAAM,UAAU,YAAY,CAAC,EAAE,UAAU,EAAE,UAAU,EAAS;IAC5D,OAAO,UAAU,IAAI,UAAU,CAAC;AAClC,CAAC;AAED,+CAA+C;AAC/C,MAAM,UAAU,YAAY,CAAC,KAAyB;IACpD,OAAO,KAAK,CAAC,OAAO,EAAE,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC;AAClD,CAAC;AAED,MAAM,UAAU,KAAK,CAAC,MAAc;IAClC,OAAO,MAAM,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;AAC5B,CAAC;AAED,MAAM,CAAC,MAAM,OAAO,GAAG,CAAC,KAAc,EAAE,EAAE,CACxC,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC"}

package/dist/app/workflows/stages/verify.d.ts

@@ -0,0 +1,11 @@
+import { type Log, type Stage } from "@clemrig/flow";
+import { type VerifyCommand } from "../../../domain/verification.js";
+import { type CheckProgress } from "../../../system/checks.js";
+/** Journals each check as it starts, passes or is skipped: they can take minutes. */
+export declare function journalChecks(log: Log, where?: string): (event: CheckProgress) => void;
+/**
+ * The repository's checks on the change, a check with `when` only if a file
+ * changed since the plan matches it; a failure goes back to the implementing
+ * agent with the end of its output, the whole of it kept in the run.
+ */
+export declare function verify(checks: VerifyCommand[]): Stage<"passed" | "failed">;

package/dist/app/workflows/stages/verify.js

@@ -0,0 +1,47 @@
+import { code } from "@clemrig/flow";
+import { failureFeedback, seconds, } from "../../../domain/verification.js";
+import { runChecks } from "../../../system/checks.js";
+import * as git from "../../../system/git.js";
+import { keepCheckOutputs, keepFailedCheck, } from "../../../system/run-files.js";
+import { facts } from "./run.js";
+/** Journals each check as it starts, passes or is skipped: they can take minutes. */
+export function journalChecks(log, where = "") {
+    return (event) => {
+        const { check } = event;
+        if (event.status === "started")
+            log(`Running ${check.name}${where}: ${check.command.join(" ")}`);
+        else if (event.status === "skipped")
+            log(`Skipped ${check.name}${where}: no change matches ${check.when?.join(", ")}`);
+        else
+            log(`${check.name} passed in ${seconds(event.durationMs)}`);
+    };
+}
+/**
+ * The repository's checks on the change, a check with `when` only if a file
+ * changed since the plan matches it; a failure goes back to the implementing
+ * agent with the end of its output, the whole of it kept in the run.
+ */
+export function verify(checks) {
+    return code(["passed", "failed"], async ({ dir, state, log, runDir }) => {
+        const result = await runChecks(dir, checks, await git.changedFiles(dir, facts(state).planCommit), journalChecks(log));
+        if (result.ok)
+            return {
+                outcome: "passed",
+                reason: "Every check passed",
+                data: {
+                    // What each check wrote stays with the run, for the review.
+                    checks: await keepCheckOutputs(runDir, result.passed),
+                    skippedChecks: result.skipped.map(({ name }) => name),
+                },
+            };
+        // All it wrote, the agent receives its end only.
+        const kept = await keepFailedCheck(runDir, result.check.name, result.output);
+        log(`${result.check.name} failed: ${result.cause}; its output is in ${kept}`);
+        return {
+            outcome: "failed",
+            reason: `${result.check.name} failed: ${result.cause}`,
+            feedback: failureFeedback(result.check, result.cause, result.output),
+        };
+    });
+}
+//# sourceMappingURL=verify.js.map

package/dist/app/workflows/stages/verify.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"verify.js","sourceRoot":"","sources":["../../../../src/app/workflows/stages/verify.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAwB,MAAM,eAAe,CAAC;AAC3D,OAAO,EACL,eAAe,EACf,OAAO,GAER,MAAM,iCAAiC,CAAC;AACzC,OAAO,EAAsB,SAAS,EAAE,MAAM,2BAA2B,CAAC;AAC1E,OAAO,KAAK,GAAG,MAAM,wBAAwB,CAAC;AAC9C,OAAO,EACL,gBAAgB,EAChB,eAAe,GAChB,MAAM,8BAA8B,CAAC;AACtC,OAAO,EAAE,KAAK,EAAE,MAAM,UAAU,CAAC;AAEjC,qFAAqF;AACrF,MAAM,UAAU,aAAa,CAC3B,GAAQ,EACR,KAAK,GAAG,EAAE;IAEV,OAAO,CAAC,KAAK,EAAE,EAAE;QACf,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,CAAC;QACxB,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS;YAC5B,GAAG,CAAC,WAAW,KAAK,CAAC,IAAI,GAAG,KAAK,KAAK,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;aAC9D,IAAI,KAAK,CAAC,MAAM,KAAK,SAAS;YACjC,GAAG,CACD,WAAW,KAAK,CAAC,IAAI,GAAG,KAAK,uBAAuB,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,CAC7E,CAAC;;YACC,GAAG,CAAC,GAAG,KAAK,CAAC,IAAI,cAAc,OAAO,CAAC,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;IACnE,CAAC,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,MAAM,CAAC,MAAuB;IAC5C,OAAO,IAAI,CAAC,CAAC,QAAQ,EAAE,QAAQ,CAAC,EAAE,KAAK,EAAE,EAAE,GAAG,EAAE,KAAK,EAAE,GAAG,EAAE,MAAM,EAAE,EAAE,EAAE;QACtE,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,GAAG,EACH,MAAM,EACN,MAAM,GAAG,CAAC,YAAY,CAAC,GAAG,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,UAAU,CAAC,EACpD,aAAa,CAAC,GAAG,CAAC,CACnB,CAAC;QACF,IAAI,MAAM,CAAC,EAAE;YACX,OAAO;gBACL,OAAO,EAAE,QAAQ;gBACjB,MAAM,EAAE,oBAAoB;gBAC5B,IAAI,EAAE;oBACJ,4DAA4D;oBAC5D,MAAM,EAAE,MAAM,gBAAgB,CAAC,MAAM,EAAE,MAAM,CAAC,MAAM,CAAC;oBACrD,aAAa,EAAE,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,EAAE,EAAE,EAAE,CAAC,IAAI,CAAC;iBACtD;aACF,CAAC;QACJ,iDAAiD;QACjD,MAAM,IAAI,GAAG,MAAM,eAAe,CAChC,MAAM,EACN,MAAM,CAAC,KAAK,CAAC,IAAI,EACjB,MAAM,CAAC,MAAM,CACd,CAAC;QACF,GAAG,CACD,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,YAAY,MAAM,CAAC,KAAK,sBAAsB,IAAI,EAAE,CACzE,CAAC;QACF,OAAO;YACL,OAAO,EAAE,QAAQ;YACjB,MAAM,EAAE,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,YAAY,MAAM,CAAC,KAAK,EAAE;YACtD,QAAQ,EAAE,eAAe,CAAC,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,CAAC;SACrE,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC"}

package/dist/app/workflows/tidy.d.ts

@@ -0,0 +1,7 @@
+import type { Settings } from "./stages/run.js";
+/**
+ * Chooses the cleanup of the code that comes first, recent code first, and
+ * writes it as an issue with its spec; then plans, implements, checks and
+ * reviews it like any issue, and describes it in the pull request it opens.
+ */
+export declare function tidy(definition: Settings): import("@clemrig/flow").Workflow;