@clearstory/drywall-react 7.1.0 → 7.2.1

package/dist/eslint-config/index.js

@@ -1,9 +1,13 @@
-import e from "./no-system-props.js";
-import l from "./prefer-vars-palette.js";
+import e from "./no-shorthand-spacing.js";
+import l from "./no-system-props.js";
+import a from "./prefer-logical-properties.js";
+import o from "./prefer-vars-palette.js";
 const r = {
   rules: {
-    "no-system-props": e,
-    "prefer-vars-palette": l
+    "no-shorthand-spacing": e,
+    "no-system-props": l,
+    "prefer-logical-properties": a,
+    "prefer-vars-palette": o
   },
   configs: {}
 };
@@ -13,21 +17,25 @@ r.configs.recommended = {
     "@clearstory/drywall-react": r
   },
   rules: {
+    "@clearstory/drywall-react/no-shorthand-spacing": "error",
     "@clearstory/drywall-react/no-system-props": "error",
+    "@clearstory/drywall-react/prefer-logical-properties": "error",
     "@clearstory/drywall-react/prefer-vars-palette": "error"
   }
 };
-const t = {
+const y = {
   name: "@clearstory/drywall-react",
   plugins: {
     "@clearstory/drywall-react": r
   },
   rules: {
+    "@clearstory/drywall-react/no-shorthand-spacing": "error",
     "@clearstory/drywall-react/no-system-props": "error",
+    "@clearstory/drywall-react/prefer-logical-properties": "error",
     "@clearstory/drywall-react/prefer-vars-palette": "error"
   }
 };
 export {
-  t as default,
+  y as default,
   r as plugin
 };

package/dist/eslint-config/no-shorthand-spacing.d.ts

@@ -0,0 +1,3 @@
+import { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/eslint-config/no-shorthand-spacing.js

@@ -0,0 +1,57 @@
+import { createSxVisitor as i } from "./sx-utils.js";
+const s = {
+  p: "padding",
+  pt: "paddingTop",
+  pr: "paddingRight",
+  pb: "paddingBottom",
+  pl: "paddingLeft",
+  px: "paddingX",
+  py: "paddingY",
+  m: "margin",
+  mt: "marginTop",
+  mr: "marginRight",
+  mb: "marginBottom",
+  ml: "marginLeft",
+  mx: "marginX",
+  my: "marginY"
+}, g = {
+  meta: {
+    type: "suggestion",
+    fixable: "code",
+    docs: {
+      description: "Disallow MUI spacing shorthands (p, pt, m, mx, etc.) in sx props",
+      category: "Best Practices",
+      recommended: !0
+    },
+    messages: {
+      shorthandSpacing: 'Use "{{replacement}}" instead of shorthand "{{property}}" in sx for readability.'
+    },
+    schema: []
+  },
+  create(a) {
+    return i({
+      onProperty(n, e) {
+        const t = s[n];
+        t && a.report({
+          node: e,
+          messageId: "shorthandSpacing",
+          data: { property: n, replacement: t },
+          fix(p) {
+            const r = e;
+            if (e.type === "Literal") {
+              const o = a.sourceCode.getText(r)[0];
+              return p.replaceText(
+                r,
+                `${o}${t}${o}`
+              );
+            }
+            return p.replaceText(r, t);
+          }
+        });
+      }
+    });
+  }
+};
+export {
+  g as default
+};

package/dist/eslint-config/no-system-props.js

@@ -14,7 +14,6 @@ const g = [
   "outlineColor",
   "borderRadius",
   // colors
-  "color",
   "bgcolor",
   "backgroundColor",
   // spacing
@@ -122,11 +121,12 @@ const g = [
   "typography",
   // other common system props
   "spacing"
-], d = ["Box", "Stack", "Typography", "Link"], u = {
-  Typography: ["color"],
-  // semantic colors only
-  Link: ["color"]
-}, h = {
+], c = {
+  Container: ["maxWidth"],
+  Dialog: ["maxWidth"],
+  InputAdornment: ["position"],
+  TableCell: ["padding"]
+}, f = {
   meta: {
     type: "problem",
     docs: {
@@ -139,48 +139,41 @@ const g = [
     },
     schema: []
   },
-  create(n) {
-    const o = /* @__PURE__ */ new Set(), s = /* @__PURE__ */ new Set();
+  create(l) {
+    const r = /* @__PURE__ */ new Map(), m = /* @__PURE__ */ new Set();
     return {
-      ImportDeclaration(l) {
-        const r = l;
-        r.source.value === "@clearstory/drywall-react" && r.specifiers.forEach((e) => {
-          e.type === "ImportSpecifier" && e.imported && d.includes(e.imported.name) ? o.add(e.local.name) : e.type === "ImportNamespaceSpecifier" && s.add(e.local.name);
+      ImportDeclaration(i) {
+        const o = i;
+        o.source.value === "@clearstory/drywall-react" && o.specifiers.forEach((e) => {
+          e.type === "ImportSpecifier" && e.imported ? r.set(e.local.name, e.imported.name) : e.type === "ImportNamespaceSpecifier" && m.add(e.local.name);
         });
       },
-      JSXOpeningElement(l) {
-        const r = l;
+      JSXOpeningElement(i) {
+        const o = i;
         let e;
-        if ("name" in r.name) {
-          if (e = r.name.name, !o.has(e))
+        if ("name" in o.name) {
+          if (e = o.name.name, !r.has(e))
             return;
-        } else if (r.name.type === "JSXMemberExpression") {
-          const t = r.name.object.name;
-          if (e = r.name.property.name, !s.has(t) || !d.includes(e))
+        } else if (o.name.type === "JSXMemberExpression") {
+          const t = o.name.object.name;
+          if (e = o.name.property.name, !m.has(t))
             return;
         } else
           return;
         const p = [];
-        r.attributes.forEach((t) => {
-          const i = t;
-          if (i.type !== "JSXAttribute" || !i.name)
+        o.attributes.forEach((t) => {
+          const n = t;
+          if (n.type !== "JSXAttribute" || !n.name)
             return;
-          const a = i.name.name;
+          const a = n.name.name;
           if (a === "sx" || !g.includes(a))
             return;
-          const m = u[e];
-          if (m && m.includes(a))
-            if (a === "color" && i.value) {
-              const c = f(i.value);
-              if (y(c))
-                return;
-            } else
-              return;
-          p.push(
-            i
+          const s = r.get(e) ?? e, d = c[s];
+          d && d.includes(a) || p.push(
+            n
           );
         }), p.forEach((t) => {
-          n.report({
+          l.report({
             node: t,
             messageId: "systemProp",
             data: {
@@ -193,30 +186,6 @@ const g = [
     };
   }
 };
-function f(n) {
-  if (!n) return null;
-  const o = n;
-  if (o.type === "Literal")
-    return String(o.value);
-  if (o.type === "JSXExpressionContainer" && o.expression) {
-    if (o.expression.type === "Literal")
-      return String(o.expression.value);
-    if (o.expression.type === "Identifier")
-      return o.expression.name || null;
-  }
-  return null;
-}
-function y(n) {
-  return [
-    "inherit",
-    "primary",
-    "secondary",
-    "error",
-    "warning",
-    "info",
-    "success"
-  ].includes(n || "");
-}
 export {
-  h as default
+  f as default
 };

package/dist/eslint-config/prefer-logical-properties.d.ts

@@ -0,0 +1,3 @@
+import { Rule } from 'eslint';
+declare const rule: Rule.RuleModule;
+export default rule;

package/dist/eslint-config/prefer-logical-properties.js

@@ -0,0 +1,72 @@
+import { createSxVisitor as d } from "./sx-utils.js";
+const l = {
+  // Positioning (inset)
+  top: "insetBlockStart",
+  bottom: "insetBlockEnd",
+  left: "insetInlineStart",
+  right: "insetInlineEnd",
+  // Padding
+  paddingTop: "paddingBlockStart",
+  paddingBottom: "paddingBlockEnd",
+  paddingLeft: "paddingInlineStart",
+  paddingRight: "paddingInlineEnd",
+  paddingX: "paddingInline",
+  paddingY: "paddingBlock",
+  // Margin
+  marginTop: "marginBlockStart",
+  marginBottom: "marginBlockEnd",
+  marginLeft: "marginInlineStart",
+  marginRight: "marginInlineEnd",
+  marginX: "marginInline",
+  marginY: "marginBlock",
+  // Border
+  borderTop: "borderBlockStart",
+  borderBottom: "borderBlockEnd",
+  borderLeft: "borderInlineStart",
+  borderRight: "borderInlineEnd",
+  // Border color
+  borderTopColor: "borderBlockStartColor",
+  borderBottomColor: "borderBlockEndColor",
+  borderLeftColor: "borderInlineStartColor",
+  borderRightColor: "borderInlineEndColor"
+}, g = {
+  meta: {
+    type: "suggestion",
+    fixable: "code",
+    docs: {
+      description: "Enforce CSS logical properties instead of physical direction properties in sx props",
+      category: "Best Practices",
+      recommended: !0
+    },
+    messages: {
+      physicalProperty: 'Use logical property "{{replacement}}" instead of "{{property}}" in sx for RTL support.'
+    },
+    schema: []
+  },
+  create(t) {
+    return d({
+      onProperty(n, o) {
+        const r = l[n];
+        r && t.report({
+          node: o,
+          messageId: "physicalProperty",
+          data: { property: n, replacement: r },
+          fix(i) {
+            const e = o;
+            if (o.type === "Literal") {
+              const a = t.sourceCode.getText(e)[0];
+              return i.replaceText(
+                e,
+                `${a}${r}${a}`
+              );
+            }
+            return i.replaceText(e, r);
+          }
+        });
+      }
+    });
+  }
+};
+export {
+  g as default
+};

package/dist/eslint-config/prefer-vars-palette.js

@@ -1,4 +1,5 @@
-const b = /* @__PURE__ */ new Set([
+import { createSxVisitor as l } from "./sx-utils.js";
+const f = /* @__PURE__ */ new Set([
   "color",
   "backgroundColor",
   "bgcolor",
@@ -22,7 +23,7 @@ const b = /* @__PURE__ */ new Set([
   "initial",
   "unset",
   "none"
-]), C = {
+]), d = {
   meta: {
     type: "suggestion",
     docs: {
@@ -36,155 +37,94 @@ const b = /* @__PURE__ */ new Set([
     },
     schema: []
   },
-  create(t) {
-    return {
-      JSXOpeningElement(e) {
-        const r = e.attributes.find(
-          (s) => s.type === "JSXAttribute" && s.name?.name === "sx"
-        );
-        if (!r) return;
-        const o = r.value;
-        if (o && o.type === "JSXExpressionContainer") {
-          const s = o.expression;
-          y(t, s);
-        }
+  create(s) {
+    return l({
+      onProperty(t, r, e) {
+        f.has(t) && i(s, t, e);
+      },
+      onCallback(t) {
+        c(s, t);
       }
-    };
+    });
   }
 };
-function y(t, e) {
-  if (e)
-    switch (e.type) {
-      case "ObjectExpression":
-        u(t, e);
-        break;
-      case "ArrowFunctionExpression":
-      case "FunctionExpression": {
-        d(t, e);
-        const n = g(e);
-        n && u(t, n);
-        break;
-      }
-      case "ArrayExpression": {
-        e.elements.forEach((r) => {
-          r && y(t, r);
-        });
-        break;
-      }
-    }
-}
-function u(t, e) {
-  e.properties.forEach((r) => {
-    if (r.type !== "Property") return;
-    const o = r, s = m(o.key, o.computed);
-    if (!s) return;
-    const i = o.value;
-    if (i.type === "ObjectExpression") {
-      u(t, i);
-      return;
-    }
-    if (b.has(s)) {
-      if (i.type === "ArrowFunctionExpression" || i.type === "FunctionExpression") {
-        d(t, i);
-        return;
-      }
-      if (i.type === "Literal") {
-        const a = i.value;
-        typeof a == "string" && !p.has(a) && t.report({
-          node: i,
-          messageId: "stringColor",
-          data: { value: a, property: s }
-        });
-        return;
-      }
-      if (i.type === "TemplateLiteral") {
-        const a = i;
-        if (a.expressions.length === 0) {
-          const c = a.quasis[0]?.value.raw;
-          c && !p.has(c) && t.report({
-            node: i,
-            messageId: "stringColor",
-            data: { value: c, property: s }
-          });
-        }
-        return;
-      }
-      if (i.type === "ConditionalExpression") {
-        const a = i;
-        l(t, a.consequent, s), l(t, a.alternate, s);
-      }
+function i(s, t, r) {
+  if (r.type === "ObjectExpression") {
+    const e = r.properties;
+    for (const o of e) {
+      if (o.type === "SpreadElement" || o.type !== "Property") continue;
+      i(s, t, o.value);
     }
-  });
-}
-function l(t, e, n) {
-  if (e.type === "Literal") {
-    const r = e.value;
-    typeof r == "string" && !p.has(r) && t.report({
-      node: e,
+    return;
+  }
+  if (r.type === "ArrowFunctionExpression" || r.type === "FunctionExpression") {
+    c(s, r);
+    return;
+  }
+  if (r.type === "Literal") {
+    const e = r.value;
+    typeof e == "string" && !p.has(e) && s.report({
+      node: r,
       messageId: "stringColor",
-      data: { value: r, property: n }
+      data: { value: e, property: t }
     });
-  } else if (e.type === "ConditionalExpression") {
-    const r = e;
-    l(t, r.consequent, n), l(t, r.alternate, n);
+    return;
+  }
+  if (r.type === "TemplateLiteral") {
+    const e = r;
+    if (e.expressions.length === 0) {
+      const o = e.quasis[0]?.value.raw;
+      o && !p.has(o) && s.report({
+        node: r,
+        messageId: "stringColor",
+        data: { value: o, property: t }
+      });
+    }
+    return;
+  }
+  if (r.type === "ConditionalExpression") {
+    const e = r;
+    i(s, t, e.consequent), i(s, t, e.alternate);
   }
 }
-function d(t, e) {
-  const n = e.params;
-  if (!n || n.length === 0) return;
-  const r = n[0];
-  if (r.type === "Identifier") {
-    const o = r.name, s = e.body;
-    f(t, s, o);
-  } else r.type === "ObjectPattern" && r.properties.forEach((s) => {
-    if (s.type !== "Property") return;
-    s.key.name === "palette" && t.report({
-      node: s,
+function c(s, t) {
+  const r = t.params;
+  if (!r || r.length === 0) return;
+  const e = r[0];
+  if (e.type === "Identifier") {
+    const o = e.name, n = t.body;
+    a(s, n, o);
+  } else e.type === "ObjectPattern" && e.properties.forEach((n) => {
+    if (n.type !== "Property") return;
+    n.key.name === "palette" && s.report({
+      node: n,
       messageId: "useVarsPalette",
       data: { access: "destructured palette" }
     });
   });
 }
-function f(t, e, n) {
-  if (!(!e || typeof e != "object")) {
-    if (e.type === "MemberExpression") {
-      const r = e.object, o = e.property;
-      if (r.type === "Identifier" && r.name === n && o.name === "palette") {
-        t.report({
-          node: e,
+function a(s, t, r) {
+  if (!(!t || typeof t != "object")) {
+    if (t.type === "MemberExpression") {
+      const e = t.object, o = t.property;
+      if (e.type === "Identifier" && e.name === r && o.name === "palette") {
+        s.report({
+          node: t,
           messageId: "useVarsPalette",
-          data: { access: `${n}.palette` }
+          data: { access: `${r}.palette` }
         });
         return;
       }
     }
-    for (const r of Object.keys(e)) {
-      if (r === "parent") continue;
-      const o = e[r];
-      o && typeof o == "object" && (Array.isArray(o) ? o.forEach((s) => {
-        s && typeof s == "object" && "type" in s && f(t, s, n);
-      }) : "type" in o && f(t, o, n));
+    for (const e of Object.keys(t)) {
+      if (e === "parent") continue;
+      const o = t[e];
+      o && typeof o == "object" && (Array.isArray(o) ? o.forEach((n) => {
+        n && typeof n == "object" && "type" in n && a(s, n, r);
+      }) : "type" in o && a(s, o, r));
     }
   }
 }
-function g(t) {
-  const e = t.body;
-  if (e.type === "ObjectExpression")
-    return e;
-  if (e.type === "BlockStatement") {
-    const n = e.body;
-    for (const r of n)
-      if (r.type === "ReturnStatement") {
-        const o = r.argument;
-        if (o?.type === "ObjectExpression")
-          return o;
-      }
-  }
-  return null;
-}
-function m(t, e) {
-  return t.type === "Identifier" && !e ? t.name || null : t.type === "Literal" && typeof t.value == "string" ? t.value : null;
-}
 export {
-  C as default
+  d as default
 };

package/dist/eslint-config/sx-utils.d.ts

@@ -0,0 +1,53 @@
+import { Rule } from 'eslint';
+/**
+ * Shared AST traversal utilities for ESLint rules that inspect MUI `sx` props.
+ *
+ * Provides a visitor pattern that:
+ * 1. Finds the `sx` attribute on JSXOpeningElement nodes
+ * 2. Traverses the expression (object, callback, or array)
+ * 3. Recurses into nested objects (pseudo-selectors like "&:hover")
+ * 4. Calls rule-specific callbacks for each property encountered
+ */
+/**
+ * Minimal AST node type for traversal within ESLint rules.
+ */
+export type ASTNode = Record<string, unknown> & {
+    type: string;
+};
+export interface SxVisitorCallbacks {
+    /**
+     * Called for each property in an sx object expression, including properties
+     * inside nested objects (pseudo-selectors like "&:hover").
+     * Recursion into nested objects is handled automatically by the visitor.
+     */
+    onProperty: (keyName: string, keyNode: ASTNode, valueNode: ASTNode) => void;
+    /**
+     * Called when the sx value (or an array element) is a callback function
+     * (ArrowFunctionExpression or FunctionExpression). Fires before the
+     * returned object's properties are visited via onProperty.
+     */
+    onCallback?: (func: ASTNode) => void;
+}
+/**
+ * Creates a JSXOpeningElement visitor that locates the `sx` attribute
+ * and walks its value, invoking the provided callbacks for each property.
+ */
+export declare function createSxVisitor(callbacks: SxVisitorCallbacks): Rule.RuleListener;
+/**
+ * Walk an sx value expression (object, callback, or array) and invoke
+ * the provided callbacks for each property encountered.
+ */
+export declare function visitSxValue(node: ASTNode, callbacks: SxVisitorCallbacks): void;
+/**
+ * Extract the returned ObjectExpression from a function/arrow function body.
+ */
+export declare function getReturnedObjectExpression(func: ASTNode): ASTNode | null;
+/**
+ * Get the string name of a property key.
+ * Returns null for computed keys or non-string keys.
+ */
+export declare function getKeyName(key: {
+    type: string;
+    name?: string;
+    value?: string;
+}, computed: boolean): string | null;

package/dist/eslint-config/sx-utils.js

@@ -0,0 +1,67 @@
+function f(e) {
+  return {
+    JSXOpeningElement(t) {
+      const n = t.attributes.find(
+        (i) => i.type === "JSXAttribute" && i.name?.name === "sx"
+      );
+      if (!n) return;
+      const r = n.value;
+      if (r && r.type === "JSXExpressionContainer") {
+        const i = r.expression;
+        u(i, e);
+      }
+    }
+  };
+}
+function u(e, t) {
+  if (e)
+    switch (e.type) {
+      case "ObjectExpression":
+        o(e, t);
+        break;
+      case "ArrowFunctionExpression":
+      case "FunctionExpression": {
+        t.onCallback?.(e);
+        const s = p(e);
+        s && o(s, t);
+        break;
+      }
+      case "ArrayExpression": {
+        e.elements.forEach((n) => {
+          n && u(n, t);
+        });
+        break;
+      }
+    }
+}
+function o(e, t) {
+  e.properties.forEach((n) => {
+    if (n.type !== "Property") return;
+    const r = n, i = c(r.key, r.computed);
+    i && (r.value.type === "ObjectExpression" && o(r.value, t), t.onProperty(i, r.key, r.value));
+  });
+}
+function p(e) {
+  const t = e.body;
+  if (t.type === "ObjectExpression")
+    return t;
+  if (t.type === "BlockStatement") {
+    const s = t.body;
+    for (const n of s)
+      if (n.type === "ReturnStatement") {
+        const r = n.argument;
+        if (r?.type === "ObjectExpression")
+          return r;
+      }
+  }
+  return null;
+}
+function c(e, t) {
+  return e.type === "Identifier" && !t ? e.name || null : e.type === "Literal" && typeof e.value == "string" ? e.value : null;
+}
+export {
+  f as createSxVisitor,
+  c as getKeyName,
+  p as getReturnedObjectExpression,
+  u as visitSxValue
+};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@clearstory/drywall-react",
-  "version": "7.1.0",
+  "version": "7.2.1",
   "license": "UNLICENSED",
   "description": "a Clearstory software design system",
   "type": "module",