@clearlydev/nx-archweave 0.3.2 → 0.4.0

package/README.md

@@ -209,7 +209,7 @@ Review is fully optional and isn't tied to one provider.
 
 - If review is disabled, zero review artifacts are generated.
 - If review is enabled, the workflow **green-skips** (it never fails) until you register the provider's secret.
-- A round marker stops the workflow after `--maxRounds` reviews per PR (1–5, default 3).
+- A round marker stops the workflow after `--maxRounds` reviews per PR (1–5, default 3). A later commit has no AI verdict, so the `review` check fails on it; merge it with your branch ruleset's bypass.
 
 | `--provider` | Workflow file | Required secret |
 | --- | --- | --- |

package/dist/bin/review-verdict.js

@@ -1,257 +1,14 @@
 #!/usr/bin/env node
+import "../generators/_chunks/chunk-SFXU6IUS.js";
+import {
+  VERDICT_MARKER,
+  runVerdictGate
+} from "../generators/_chunks/chunk-ALSXKTLM.js";
 
 // src/bin/review-verdict.ts
 import { spawnSync } from "node:child_process";
 import { randomBytes } from "node:crypto";
 import { appendFileSync, realpathSync } from "node:fs";
-
-// ../review-policy/dist/schema/review-finding.js
-function computeVerdict(findings) {
-  if (findings.some((f) => f.priority === "P0" || f.priority === "P1"))
-    return "BLOCK";
-  if (findings.some((f) => f.priority === "P2"))
-    return "CHANGES_RECOMMENDED";
-  if (findings.length > 0)
-    return "APPROVE_WITH_NOTES";
-  return "APPROVE";
-}
-
-// ../review-policy/dist/verdict-gate/findings-block.js
-var FINDINGS_MARKER = "<!-- archweave-findings-v1 -->";
-var FINDINGS_SCHEMA_ID = "archweave/findings@1";
-var PRIORITIES = ["P0", "P1", "P2", "P3", "Nit"];
-function findingKey(f) {
-  return `${f.file}:${f.lineRange.start}:${f.category}`;
-}
-function extractFindingsBlock(commentBody) {
-  const markerIndex = commentBody.lastIndexOf(FINDINGS_MARKER);
-  if (markerIndex === -1)
-    return { status: "missing" };
-  const after = commentBody.slice(markerIndex + FINDINGS_MARKER.length);
-  const open = /```json[ \t]*\r?\n/.exec(after);
-  if (!open)
-    return { status: "invalid" };
-  const contentStart = open.index + open[0].length;
-  let parsed;
-  let found = false;
-  for (let close = after.indexOf("```", contentStart); close !== -1; close = after.indexOf("```", close + 3)) {
-    try {
-      parsed = JSON.parse(after.slice(contentStart, close));
-      found = true;
-      break;
-    } catch {
-    }
-  }
-  if (!found)
-    return { status: "invalid" };
-  if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed))
-    return { status: "invalid" };
-  const obj = parsed;
-  if (obj.schema !== FINDINGS_SCHEMA_ID || !Array.isArray(obj.findings))
-    return { status: "invalid" };
-  const findings = [];
-  for (const raw of obj.findings) {
-    const finding = normalizeFinding(raw);
-    if (finding === null)
-      return { status: "invalid" };
-    findings.push(finding);
-  }
-  return { status: "ok", findings };
-}
-function normalizeFinding(raw) {
-  if (raw === null || typeof raw !== "object")
-    return null;
-  const r = raw;
-  const lineRange = r["lineRange"];
-  if (!PRIORITIES.includes(r["priority"]) || typeof r["category"] !== "string" || typeof r["title"] !== "string" || typeof r["file"] !== "string" || lineRange === null || lineRange === void 0 || typeof lineRange !== "object" || typeof lineRange.start !== "number" || !Number.isInteger(lineRange.start) || lineRange.start < 1) {
-    return null;
-  }
-  const str = (value) => typeof value === "string" ? value : "";
-  return {
-    priority: r["priority"],
-    category: r["category"],
-    title: r["title"],
-    file: r["file"],
-    lineRange: { start: lineRange.start, ...typeof lineRange.end === "number" ? { end: lineRange.end } : {} },
-    evidence: str(r["evidence"]),
-    impact: str(r["impact"]),
-    reproductionCondition: str(r["reproductionCondition"]),
-    recommendation: str(r["recommendation"]),
-    confidence: r["confidence"] === "plausible" ? "plausible" : "confirmed"
-  };
-}
-
-// ../review-policy/dist/renderers/render-review-comment.js
-var COPY = {
-  en: {
-    terminationBanner: (maxRounds) => `> \u26A0\uFE0F **Automated review ended.** The maximum of ${maxRounds} review rounds has been reached with blocking findings (P0/P1) still open. Later pushes aren't reviewed by AI, so review them yourself before merging.`,
-    verdictLines: {
-      BLOCK: "**Verdict: BLOCK** \u2014 P0/P1 findings must be resolved before this change can merge.",
-      CHANGES_RECOMMENDED: "**Verdict: CHANGES_RECOMMENDED** \u2014 P2 findings should be addressed.",
-      APPROVE_WITH_NOTES: "**Verdict: APPROVE_WITH_NOTES** \u2014 only advisory notes below; safe to merge.",
-      APPROVE: "**Verdict: APPROVE** \u2014 no findings."
-    },
-    mainSection: "## Correctness & Security",
-    overEngineeringSection: "## Over-engineering",
-    nitSection: "## Nits",
-    roundHistoryHeading: "**Round history:**",
-    roundLine: (round, fixed, remaining) => `- round ${round}: ${fixed} fixed, ${remaining} remaining`,
-    fieldLabels: {
-      file: "File",
-      evidence: "Evidence",
-      impact: "Impact",
-      reproduction: "Reproduction",
-      recommendation: "Recommendation",
-      confidence: "Confidence"
-    }
-  },
-  ko: {
-    terminationBanner: (maxRounds) => `> \u26A0\uFE0F **\uC790\uB3D9 \uB9AC\uBDF0 \uC885\uB8CC.** \uCD5C\uB300 ${maxRounds}\uD68C\uC758 \uB9AC\uBDF0 \uB77C\uC6B4\uB4DC\uC5D0 \uB3C4\uB2EC\uD588\uC9C0\uB9CC \uBCD1\uD569\uC744 \uB9C9\uB294 finding(P0/P1)\uC774 \uB0A8\uC544 \uC788\uC2B5\uB2C8\uB2E4. \uC774\uD6C4 push\uB294 AI\uAC00 \uB9AC\uBDF0\uD558\uC9C0 \uC54A\uC73C\uB2C8, \uBCD1\uD569 \uC804\uC5D0 \uC9C1\uC811 \uB9AC\uBDF0\uD558\uC138\uC694.`,
-    verdictLines: {
-      BLOCK: "**\uD310\uC815: BLOCK** \u2014 \uBCD1\uD569 \uC804\uC5D0 P0/P1 finding\uC744 \uD574\uACB0\uD574\uC57C \uD569\uB2C8\uB2E4.",
-      CHANGES_RECOMMENDED: "**\uD310\uC815: CHANGES_RECOMMENDED** \u2014 P2 finding\uC744 \uD574\uACB0\uD558\uB294 \uAC83\uC744 \uAD8C\uC7A5\uD569\uB2C8\uB2E4.",
-      APPROVE_WITH_NOTES: "**\uD310\uC815: APPROVE_WITH_NOTES** \u2014 \uCC38\uACE0\uC6A9 \uB178\uD2B8\uB9CC \uC788\uC2B5\uB2C8\uB2E4. \uBCD1\uD569\uD574\uB3C4 \uC548\uC804\uD569\uB2C8\uB2E4.",
-      APPROVE: "**\uD310\uC815: APPROVE** \u2014 finding\uC774 \uC5C6\uC2B5\uB2C8\uB2E4."
-    },
-    mainSection: "## \uC815\uD655\uC131 & \uBCF4\uC548",
-    overEngineeringSection: "## \uACFC\uC789 \uC124\uACC4",
-    nitSection: "## \uC0AC\uC18C\uD55C \uC9C0\uC801 (Nit)",
-    roundHistoryHeading: "**\uB77C\uC6B4\uB4DC \uC774\uB825:**",
-    roundLine: (round, fixed, remaining) => `- ${round}\uB77C\uC6B4\uB4DC: \uD574\uACB0 ${fixed}\uAC74, \uBBF8\uD574\uACB0 ${remaining}\uAC74`,
-    fieldLabels: {
-      file: "\uD30C\uC77C",
-      evidence: "\uADFC\uAC70",
-      impact: "\uC601\uD5A5",
-      reproduction: "\uC7AC\uD604 \uC870\uAC74",
-      recommendation: "\uAD8C\uC7A5 \uC870\uCE58",
-      confidence: "\uD655\uC2E0\uB3C4"
-    }
-  }
-};
-function verdictLine(verdict, locale) {
-  return COPY[locale].verdictLines[verdict];
-}
-function terminationBannerLine(maxRounds, locale) {
-  return COPY[locale].terminationBanner(maxRounds);
-}
-
-// ../review-policy/dist/verdict-gate/verdict-comment.js
-var VERDICT_MARKER = "<!-- archweave-verdict -->";
-var HISTORY_HEADING = { en: "**Round history:**", ko: "**\uB77C\uC6B4\uB4DC \uC774\uB825:**" };
-var ROUND_LINE = {
-  en: (round, fixed, remaining) => `- round ${round}: ${fixed} fixed, ${remaining} remaining`,
-  ko: (round, fixed, remaining) => `- ${round}\uCC28: ${fixed}\uAC74 \uD574\uACB0, ${remaining}\uAC74 \uC794\uC874`
-};
-var UNPARSEABLE_NOTICE = {
-  en: "\u26A0\uFE0F The review comment could not be machine-read (missing or invalid findings block). The verdict gate stays green; please review this PR manually.",
-  ko: "\u26A0\uFE0F \uB9AC\uBDF0 \uCF54\uBA58\uD2B8\uB97C \uAE30\uACC4 \uD310\uB3C5\uD558\uC9C0 \uBABB\uD588\uC2B5\uB2C8\uB2E4(findings \uBE14\uB85D \uB204\uB77D \uB610\uB294 \uC190\uC0C1). verdict \uAC8C\uC774\uD2B8\uB294 \uB179\uC0C9\uC73C\uB85C \uB450\uB2C8 \uC774 PR\uC740 \uC0AC\uB78C\uC774 \uC9C1\uC811 \uB9AC\uBDF0\uD574 \uC8FC\uC138\uC694."
-};
-var NO_ROUND_NOTICE = {
-  en: "\u26A0\uFE0F This run of the review posted no summary comment for the current commit, so there is no verdict for it (an earlier round is never reused). The verdict gate stays green; please review this PR manually.",
-  ko: "\u26A0\uFE0F \uC774\uBC88 \uB9AC\uBDF0 \uC2E4\uD589\uC774 \uD604\uC7AC \uCEE4\uBC0B\uC5D0 \uB300\uD55C \uC694\uC57D \uCF54\uBA58\uD2B8\uB97C \uAC8C\uC2DC\uD558\uC9C0 \uC54A\uC544 verdict\uAC00 \uC5C6\uC2B5\uB2C8\uB2E4(\uC774\uC804 \uB77C\uC6B4\uB4DC\uB294 \uC7AC\uC0AC\uC6A9\uD558\uC9C0 \uC54A\uC2B5\uB2C8\uB2E4). verdict \uAC8C\uC774\uD2B8\uB294 \uB179\uC0C9\uC73C\uB85C \uB450\uB2C8 \uC774 PR\uC740 \uC0AC\uB78C\uC774 \uC9C1\uC811 \uB9AC\uBDF0\uD574 \uC8FC\uC138\uC694."
-};
-var NO_SUMMARY_NOTICE = {
-  en: "\u26D4 AI review posted no summary for this commit, so there is no verdict for it and the review check fails. Review this PR manually, or re-run all jobs to review it again.",
-  ko: "\u26D4 AI \uB9AC\uBDF0\uAC00 \uC774 \uCEE4\uBC0B\uC5D0 \uB300\uD55C \uC694\uC57D\uC744 \uAC8C\uC2DC\uD558\uC9C0 \uC54A\uC544 verdict\uAC00 \uC5C6\uACE0, review \uCCB4\uD06C\uB294 \uC2E4\uD328\uD569\uB2C8\uB2E4. \uC774 PR\uC744 \uC9C1\uC811 \uB9AC\uBDF0\uD558\uAC70\uB098, \uBAA8\uB4E0 \uC7A1\uC744 \uB2E4\uC2DC \uC2E4\uD589\uD574 \uB2E4\uC2DC \uB9AC\uBDF0\uBC1B\uC73C\uC138\uC694."
-};
-var UNREADABLE_SUMMARY_NOTICE = {
-  en: "\u26D4 AI review posted a summary whose findings block could not be machine-read (missing or invalid), so there is no verdict for this commit and the review check fails. Review this PR manually, or re-run all jobs to review it again.",
-  ko: "\u26D4 AI \uB9AC\uBDF0 \uC694\uC57D\uC758 findings \uBE14\uB85D\uC744 \uAE30\uACC4 \uD310\uB3C5\uD558\uC9C0 \uBABB\uD574(\uB204\uB77D \uB610\uB294 \uC190\uC0C1) \uC774 \uCEE4\uBC0B\uC758 verdict\uAC00 \uC5C6\uACE0, review \uCCB4\uD06C\uB294 \uC2E4\uD328\uD569\uB2C8\uB2E4. \uC774 PR\uC744 \uC9C1\uC811 \uB9AC\uBDF0\uD558\uAC70\uB098, \uBAA8\uB4E0 \uC7A1\uC744 \uB2E4\uC2DC \uC2E4\uD589\uD574 \uB2E4\uC2DC \uB9AC\uBDF0\uBC1B\uC73C\uC138\uC694."
-};
-function renderCommitLine(locale, shortSha) {
-  return locale === "en" ? `<sub>Commit \`${shortSha}\` \xB7 this comment is updated on every review round.</sub>` : `<sub>\uCEE4\uBC0B \`${shortSha}\` \xB7 \uC774 \uCF54\uBA58\uD2B8\uB294 \uB9AC\uBDF0 \uB77C\uC6B4\uB4DC\uB9C8\uB2E4 \uAC31\uC2E0\uB429\uB2C8\uB2E4.</sub>`;
-}
-var HEAD_LINE = {
-  en: (sha) => renderCommitLine("en", sha.slice(0, 7)),
-  ko: (sha) => renderCommitLine("ko", sha.slice(0, 7))
-};
-function withHead(lines, locale, headSha) {
-  return (headSha === void 0 ? lines : [...lines, "", HEAD_LINE[locale](headSha)]).join("\n");
-}
-function renderUnparseableNotice(locale, headSha, failClosed = false) {
-  return withHead([VERDICT_MARKER, (failClosed ? UNREADABLE_SUMMARY_NOTICE : UNPARSEABLE_NOTICE)[locale]], locale, headSha);
-}
-function renderNoSummaryNotice(locale, headSha) {
-  return withHead([VERDICT_MARKER, NO_SUMMARY_NOTICE[locale]], locale, headSha);
-}
-function renderNoRoundNotice(locale, headSha) {
-  return withHead([VERDICT_MARKER, NO_ROUND_NOTICE[locale]], locale, headSha);
-}
-function renderVerdictComment(input) {
-  const lines = [VERDICT_MARKER];
-  if (input.isFinalRound && input.verdict === "BLOCK") {
-    lines.push(terminationBannerLine(input.maxRounds, input.locale), "");
-  }
-  lines.push(verdictLine(input.verdict, input.locale));
-  if (input.history.length > 1) {
-    lines.push("", HISTORY_HEADING[input.locale]);
-    for (let i = 0; i < input.history.length; i++) {
-      if (i === 0)
-        continue;
-      const entry = input.history[i];
-      lines.push(ROUND_LINE[input.locale](entry.round, entry.fixedFindingKeys.length, entry.remainingFindingKeys.length));
-    }
-  }
-  return withHead(lines, input.locale, input.headSha);
-}
-
-// ../review-policy/dist/verdict-gate/verdict-gate.js
-var ROUND_MARKER = "<!-- archweave-review-round -->";
-function collectRounds(comments) {
-  return comments.filter((c) => c.body.includes(ROUND_MARKER) && !c.body.includes(VERDICT_MARKER)).map((c, index) => ({ round: index + 1, id: c.id, extraction: extractFindingsBlock(c.body) }));
-}
-var LINE_DRIFT = 3;
-function sameDefect(a, b) {
-  if (a.file !== b.file)
-    return false;
-  const aEnd = a.lineRange.end ?? a.lineRange.start;
-  const bEnd = b.lineRange.end ?? b.lineRange.start;
-  return a.lineRange.start <= bEnd + LINE_DRIFT && b.lineRange.start <= aEnd + LINE_DRIFT;
-}
-function computeRoundHistory(rounds) {
-  const parsed = rounds.filter((r) => r.extraction.status === "ok");
-  const history = [];
-  for (let i = 0; i < parsed.length; i++) {
-    const keys = new Set(parsed[i].extraction.findings.map(findingKey));
-    if (i === 0) {
-      history.push({ round: parsed[i].round, fixedFindingKeys: [], remainingFindingKeys: [...keys] });
-      continue;
-    }
-    const current = parsed[i].extraction.findings;
-    history.push({
-      round: parsed[i].round,
-      fixedFindingKeys: parsed[i - 1].extraction.findings.filter((finding) => !current.some((now) => sameDefect(finding, now))).map(findingKey),
-      remainingFindingKeys: [...keys]
-    });
-  }
-  return history;
-}
-function runVerdictGate(input) {
-  const rounds = collectRounds(input.comments);
-  const reviewRan = input.reviewRan === true;
-  if (rounds.length === 0) {
-    return reviewRan ? { kind: "no-summary", commentBody: renderNoSummaryNotice(input.locale, input.headSha) } : { kind: "no-review" };
-  }
-  const latest = rounds[rounds.length - 1];
-  if (input.roundAfterId !== void 0 && (latest.id === void 0 || latest.id <= input.roundAfterId)) {
-    return reviewRan ? { kind: "no-summary", commentBody: renderNoSummaryNotice(input.locale, input.headSha) } : { kind: "no-round", commentBody: renderNoRoundNotice(input.locale, input.headSha) };
-  }
-  if (latest.extraction.status !== "ok") {
-    return { kind: "unparseable", commentBody: renderUnparseableNotice(input.locale, input.headSha, reviewRan), failClosed: reviewRan };
-  }
-  const verdict = computeVerdict(latest.extraction.findings);
-  const commentBody = renderVerdictComment({
-    verdict,
-    history: computeRoundHistory(rounds),
-    maxRounds: input.maxRounds,
-    locale: input.locale,
-    isFinalRound: rounds.length >= input.maxRounds,
-    headSha: input.headSha
-  });
-  return { kind: "verdict", verdict, commentBody, exitCode: verdict === "BLOCK" ? 1 : 0 };
-}
-
-// src/bin/review-verdict.ts
 var realExec = (command, args, stdin) => {
   const result = spawnSync(command, args, { encoding: "utf-8", input: stdin });
   return { status: result.status ?? null, stdout: result.stdout ?? "" };
@@ -276,13 +33,16 @@ function renderStepOutputs(commentBody, previousId, blocked, reason) {
   ].join("\n");
 }
 var UNREAD_COMMENTS_ERROR = "::error title=Review verdict not computed::Could not read PR comments, so the verdict could not be computed. Re-run the failed jobs to retry. If it fails again, check that the review job has pull-requests: read.";
+var MISCONFIGURED_ERROR = "::error title=Review verdict not computed::The verdict gate is missing GITHUB_REPOSITORY or ARCHWEAVE_PR_NUMBER, or ARCHWEAVE_MAX_ROUNDS is not a whole number from 1, so no verdict was computed. Regenerate the workflow with add-review --onConflict=overwrite if it was edited by hand.";
 function runReviewVerdictBin(env, exec, writeOutput = realWriteOutput) {
   const logs = [];
   const repo = env["GITHUB_REPOSITORY"];
   const pr = env["ARCHWEAVE_PR_NUMBER"];
   const maxRounds = Number(env["ARCHWEAVE_MAX_ROUNDS"]);
   const locale = env["ARCHWEAVE_LOCALE"] === "ko" ? "ko" : "en";
+  const outputPath = outputModePath(env);
   if (!repo || !pr || !Number.isInteger(maxRounds) || maxRounds < 1) {
+    if (outputPath !== void 0) return { exitCode: 1, logs: [MISCONFIGURED_ERROR] };
     logs.push("verdict gate: required environment missing or malformed \u2014 skipping (check stays green).");
     return { exitCode: 0, logs };
   }
@@ -290,7 +50,6 @@ function runReviewVerdictBin(env, exec, writeOutput = realWriteOutput) {
   const roundAfterId = watermark !== void 0 && /^\d+$/.test(watermark) ? Number(watermark) : void 0;
   const sha = env["ARCHWEAVE_HEAD_SHA"];
   const headSha = sha !== void 0 && /^[0-9a-f]{7,40}$/i.test(sha) ? sha : void 0;
-  const outputPath = outputModePath(env);
   const fetched = exec("gh", ["api", `repos/${repo}/issues/${pr}/comments`, "--paginate"]);
   const pages = fetched.status === 0 ? splitConcatenatedJson(fetched.stdout) : null;
   if (pages === null) {