@claude-flow/shared 3.0.0-alpha.7 → 3.0.0-alpha.8
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-flow/daemon-state.json +135 -0
- package/.claude-flow/data/pending-insights.jsonl +2 -0
- package/.claude-flow/data/ranked-context.json +5 -0
- package/.claude-flow/logs/daemon.log +45 -0
- package/.claude-flow/logs/headless/audit_1777379186972_h5un5x_prompt.log +3210 -0
- package/.claude-flow/logs/headless/audit_1777379186972_h5un5x_result.log +117 -0
- package/.claude-flow/logs/headless/audit_1777379816437_w0eaul_prompt.log +3210 -0
- package/.claude-flow/logs/headless/audit_1777379816437_w0eaul_result.log +53 -0
- package/.claude-flow/logs/headless/audit_1777380440097_621y8m_prompt.log +3210 -0
- package/.claude-flow/logs/headless/audit_1777380440097_621y8m_result.log +75 -0
- package/.claude-flow/logs/headless/optimize_1777379306973_an4lmy_prompt.log +3504 -0
- package/.claude-flow/logs/headless/optimize_1777379306973_an4lmy_result.log +166 -0
- package/.claude-flow/logs/headless/optimize_1777380274732_apxz3s_prompt.log +3504 -0
- package/.claude-flow/logs/headless/optimize_1777380274732_apxz3s_result.log +219 -0
- package/.claude-flow/logs/headless/testgaps_1777379546969_dvf2a1_prompt.log +3189 -0
- package/.claude-flow/logs/headless/testgaps_1777379546969_dvf2a1_result.log +155 -0
- package/.claude-flow/metrics/codebase-map.json +11 -0
- package/.claude-flow/metrics/consolidation.json +6 -0
- package/.claude-flow/sessions/current.json +13 -0
- package/.swarm/hnsw.index +0 -0
- package/.swarm/hnsw.metadata.json +1 -0
- package/.swarm/memory.db +0 -0
- package/.swarm/memory.db-shm +0 -0
- package/.swarm/memory.db-wal +0 -0
- package/.swarm/schema.sql +305 -0
- package/dist/core/config/schema.d.ts +96 -96
- package/dist/events/event-store.d.ts.map +1 -1
- package/dist/events/event-store.js +20 -9
- package/dist/events/event-store.js.map +1 -1
- package/dist/hooks/executor.d.ts.map +1 -1
- package/dist/hooks/executor.js +7 -4
- package/dist/hooks/executor.js.map +1 -1
- package/dist/hooks/verify-exports.test.js +6 -6
- package/dist/hooks/verify-exports.test.js.map +1 -1
- package/dist/mcp/server.d.ts.map +1 -1
- package/dist/mcp/server.js +3 -6
- package/dist/mcp/server.js.map +1 -1
- package/dist/mcp/types.d.ts +4 -6
- package/dist/mcp/types.d.ts.map +1 -1
- package/dist/mcp/types.js.map +1 -1
- package/package.json +3 -2
- package/ruvector.db +0 -0
- package/src/events/event-store.ts +18 -9
- package/src/hooks/executor.ts +7 -5
- package/src/hooks/verify-exports.test.ts +6 -6
- package/src/mcp/server.ts +3 -6
- package/src/mcp/types.ts +4 -6
- package/tsconfig.tsbuildinfo +1 -1
- package/.agentic-flow/intelligence.json +0 -16
- package/__tests__/coverage/base.css +0 -224
- package/__tests__/coverage/block-navigation.js +0 -87
- package/__tests__/coverage/coverage-final.json +0 -50
- package/__tests__/coverage/favicon.png +0 -0
- package/__tests__/coverage/index.html +0 -326
- package/__tests__/coverage/lcov-report/base.css +0 -224
- package/__tests__/coverage/lcov-report/block-navigation.js +0 -87
- package/__tests__/coverage/lcov-report/favicon.png +0 -0
- package/__tests__/coverage/lcov-report/index.html +0 -326
- package/__tests__/coverage/lcov-report/prettify.css +0 -1
- package/__tests__/coverage/lcov-report/prettify.js +0 -2
- package/__tests__/coverage/lcov-report/sort-arrow-sprite.png +0 -0
- package/__tests__/coverage/lcov-report/sorter.js +0 -210
- package/__tests__/coverage/lcov-report/src/core/config/defaults.ts.html +0 -706
- package/__tests__/coverage/lcov-report/src/core/config/index.html +0 -161
- package/__tests__/coverage/lcov-report/src/core/config/loader.ts.html +0 -898
- package/__tests__/coverage/lcov-report/src/core/config/schema.ts.html +0 -649
- package/__tests__/coverage/lcov-report/src/core/config/validator.ts.html +0 -712
- package/__tests__/coverage/lcov-report/src/core/event-bus.ts.html +0 -793
- package/__tests__/coverage/lcov-report/src/core/index.html +0 -116
- package/__tests__/coverage/lcov-report/src/core/interfaces/event.interface.ts.html +0 -886
- package/__tests__/coverage/lcov-report/src/core/interfaces/index.html +0 -116
- package/__tests__/coverage/lcov-report/src/core/orchestrator/event-coordinator.ts.html +0 -451
- package/__tests__/coverage/lcov-report/src/core/orchestrator/health-monitor.ts.html +0 -727
- package/__tests__/coverage/lcov-report/src/core/orchestrator/index.html +0 -176
- package/__tests__/coverage/lcov-report/src/core/orchestrator/lifecycle-manager.ts.html +0 -874
- package/__tests__/coverage/lcov-report/src/core/orchestrator/session-manager.ts.html +0 -922
- package/__tests__/coverage/lcov-report/src/core/orchestrator/task-manager.ts.html +0 -1036
- package/__tests__/coverage/lcov-report/src/events/domain-events.ts.html +0 -1837
- package/__tests__/coverage/lcov-report/src/events/event-store.ts.html +0 -1849
- package/__tests__/coverage/lcov-report/src/events/example-usage.ts.html +0 -964
- package/__tests__/coverage/lcov-report/src/events/index.html +0 -176
- package/__tests__/coverage/lcov-report/src/events/projections.ts.html +0 -1768
- package/__tests__/coverage/lcov-report/src/events/state-reconstructor.ts.html +0 -1132
- package/__tests__/coverage/lcov-report/src/events.ts.html +0 -1186
- package/__tests__/coverage/lcov-report/src/hooks/example-usage.ts.html +0 -1582
- package/__tests__/coverage/lcov-report/src/hooks/executor.ts.html +0 -1222
- package/__tests__/coverage/lcov-report/src/hooks/index.html +0 -191
- package/__tests__/coverage/lcov-report/src/hooks/registry.ts.html +0 -1084
- package/__tests__/coverage/lcov-report/src/hooks/safety/bash-safety.ts.html +0 -1897
- package/__tests__/coverage/lcov-report/src/hooks/safety/file-organization.ts.html +0 -1504
- package/__tests__/coverage/lcov-report/src/hooks/safety/git-commit.ts.html +0 -1954
- package/__tests__/coverage/lcov-report/src/hooks/safety/index.html +0 -146
- package/__tests__/coverage/lcov-report/src/hooks/session-hooks.ts.html +0 -1762
- package/__tests__/coverage/lcov-report/src/hooks/task-hooks.ts.html +0 -1624
- package/__tests__/coverage/lcov-report/src/hooks/types.ts.html +0 -1156
- package/__tests__/coverage/lcov-report/src/index.html +0 -176
- package/__tests__/coverage/lcov-report/src/mcp/connection-pool.ts.html +0 -1399
- package/__tests__/coverage/lcov-report/src/mcp/index.html +0 -176
- package/__tests__/coverage/lcov-report/src/mcp/server.ts.html +0 -2407
- package/__tests__/coverage/lcov-report/src/mcp/session-manager.ts.html +0 -1369
- package/__tests__/coverage/lcov-report/src/mcp/tool-registry.ts.html +0 -1783
- package/__tests__/coverage/lcov-report/src/mcp/transport/http.ts.html +0 -1756
- package/__tests__/coverage/lcov-report/src/mcp/transport/index.html +0 -146
- package/__tests__/coverage/lcov-report/src/mcp/transport/stdio.ts.html +0 -1057
- package/__tests__/coverage/lcov-report/src/mcp/transport/websocket.ts.html +0 -1537
- package/__tests__/coverage/lcov-report/src/mcp/types.ts.html +0 -1780
- package/__tests__/coverage/lcov-report/src/plugin-interface.ts.html +0 -2074
- package/__tests__/coverage/lcov-report/src/plugin-loader.ts.html +0 -1999
- package/__tests__/coverage/lcov-report/src/plugin-registry.ts.html +0 -1897
- package/__tests__/coverage/lcov-report/src/plugins/official/hive-mind-plugin.ts.html +0 -1075
- package/__tests__/coverage/lcov-report/src/plugins/official/index.html +0 -131
- package/__tests__/coverage/lcov-report/src/plugins/official/maestro-plugin.ts.html +0 -1609
- package/__tests__/coverage/lcov-report/src/resilience/bulkhead.ts.html +0 -916
- package/__tests__/coverage/lcov-report/src/resilience/circuit-breaker.ts.html +0 -1063
- package/__tests__/coverage/lcov-report/src/resilience/index.html +0 -161
- package/__tests__/coverage/lcov-report/src/resilience/rate-limiter.ts.html +0 -1345
- package/__tests__/coverage/lcov-report/src/resilience/retry.ts.html +0 -757
- package/__tests__/coverage/lcov-report/src/security/index.html +0 -131
- package/__tests__/coverage/lcov-report/src/security/input-validation.ts.html +0 -880
- package/__tests__/coverage/lcov-report/src/security/secure-random.ts.html +0 -562
- package/__tests__/coverage/lcov-report/src/types/index.html +0 -131
- package/__tests__/coverage/lcov-report/src/types/swarm.types.ts.html +0 -850
- package/__tests__/coverage/lcov-report/src/types/task.types.ts.html +0 -700
- package/__tests__/coverage/lcov-report/src/types.ts.html +0 -1186
- package/__tests__/coverage/lcov-report/src/utils/index.html +0 -116
- package/__tests__/coverage/lcov-report/src/utils/secure-logger.ts.html +0 -856
- package/__tests__/coverage/lcov.info +0 -19877
- package/__tests__/coverage/prettify.css +0 -1
- package/__tests__/coverage/prettify.js +0 -2
- package/__tests__/coverage/sort-arrow-sprite.png +0 -0
- package/__tests__/coverage/sorter.js +0 -210
- package/__tests__/coverage/src/core/config/defaults.ts.html +0 -706
- package/__tests__/coverage/src/core/config/index.html +0 -161
- package/__tests__/coverage/src/core/config/loader.ts.html +0 -898
- package/__tests__/coverage/src/core/config/schema.ts.html +0 -649
- package/__tests__/coverage/src/core/config/validator.ts.html +0 -712
- package/__tests__/coverage/src/core/event-bus.ts.html +0 -793
- package/__tests__/coverage/src/core/index.html +0 -116
- package/__tests__/coverage/src/core/interfaces/event.interface.ts.html +0 -886
- package/__tests__/coverage/src/core/interfaces/index.html +0 -116
- package/__tests__/coverage/src/core/orchestrator/event-coordinator.ts.html +0 -451
- package/__tests__/coverage/src/core/orchestrator/health-monitor.ts.html +0 -727
- package/__tests__/coverage/src/core/orchestrator/index.html +0 -176
- package/__tests__/coverage/src/core/orchestrator/lifecycle-manager.ts.html +0 -874
- package/__tests__/coverage/src/core/orchestrator/session-manager.ts.html +0 -922
- package/__tests__/coverage/src/core/orchestrator/task-manager.ts.html +0 -1036
- package/__tests__/coverage/src/events/domain-events.ts.html +0 -1837
- package/__tests__/coverage/src/events/event-store.ts.html +0 -1849
- package/__tests__/coverage/src/events/example-usage.ts.html +0 -964
- package/__tests__/coverage/src/events/index.html +0 -176
- package/__tests__/coverage/src/events/projections.ts.html +0 -1768
- package/__tests__/coverage/src/events/state-reconstructor.ts.html +0 -1132
- package/__tests__/coverage/src/events.ts.html +0 -1186
- package/__tests__/coverage/src/hooks/example-usage.ts.html +0 -1582
- package/__tests__/coverage/src/hooks/executor.ts.html +0 -1222
- package/__tests__/coverage/src/hooks/index.html +0 -191
- package/__tests__/coverage/src/hooks/registry.ts.html +0 -1084
- package/__tests__/coverage/src/hooks/safety/bash-safety.ts.html +0 -1897
- package/__tests__/coverage/src/hooks/safety/file-organization.ts.html +0 -1504
- package/__tests__/coverage/src/hooks/safety/git-commit.ts.html +0 -1954
- package/__tests__/coverage/src/hooks/safety/index.html +0 -146
- package/__tests__/coverage/src/hooks/session-hooks.ts.html +0 -1762
- package/__tests__/coverage/src/hooks/task-hooks.ts.html +0 -1624
- package/__tests__/coverage/src/hooks/types.ts.html +0 -1156
- package/__tests__/coverage/src/index.html +0 -176
- package/__tests__/coverage/src/mcp/connection-pool.ts.html +0 -1399
- package/__tests__/coverage/src/mcp/index.html +0 -176
- package/__tests__/coverage/src/mcp/server.ts.html +0 -2407
- package/__tests__/coverage/src/mcp/session-manager.ts.html +0 -1369
- package/__tests__/coverage/src/mcp/tool-registry.ts.html +0 -1783
- package/__tests__/coverage/src/mcp/transport/http.ts.html +0 -1756
- package/__tests__/coverage/src/mcp/transport/index.html +0 -146
- package/__tests__/coverage/src/mcp/transport/stdio.ts.html +0 -1057
- package/__tests__/coverage/src/mcp/transport/websocket.ts.html +0 -1537
- package/__tests__/coverage/src/mcp/types.ts.html +0 -1780
- package/__tests__/coverage/src/plugin-interface.ts.html +0 -2074
- package/__tests__/coverage/src/plugin-loader.ts.html +0 -1999
- package/__tests__/coverage/src/plugin-registry.ts.html +0 -1897
- package/__tests__/coverage/src/plugins/official/hive-mind-plugin.ts.html +0 -1075
- package/__tests__/coverage/src/plugins/official/index.html +0 -131
- package/__tests__/coverage/src/plugins/official/maestro-plugin.ts.html +0 -1609
- package/__tests__/coverage/src/resilience/bulkhead.ts.html +0 -916
- package/__tests__/coverage/src/resilience/circuit-breaker.ts.html +0 -1063
- package/__tests__/coverage/src/resilience/index.html +0 -161
- package/__tests__/coverage/src/resilience/rate-limiter.ts.html +0 -1345
- package/__tests__/coverage/src/resilience/retry.ts.html +0 -757
- package/__tests__/coverage/src/security/index.html +0 -131
- package/__tests__/coverage/src/security/input-validation.ts.html +0 -880
- package/__tests__/coverage/src/security/secure-random.ts.html +0 -562
- package/__tests__/coverage/src/types/index.html +0 -131
- package/__tests__/coverage/src/types/swarm.types.ts.html +0 -850
- package/__tests__/coverage/src/types/task.types.ts.html +0 -700
- package/__tests__/coverage/src/types.ts.html +0 -1186
- package/__tests__/coverage/src/utils/index.html +0 -116
- package/__tests__/coverage/src/utils/secure-logger.ts.html +0 -856
|
@@ -0,0 +1,166 @@
|
|
|
1
|
+
[2026-04-28T12:29:34.705Z] RESULT
|
|
2
|
+
============================================================
|
|
3
|
+
{
|
|
4
|
+
"success": true,
|
|
5
|
+
"output": "I'll analyze the provided codebase files for performance issues across the requested categories.\n\n## Performance Analysis\n\n---\n\n### 1. N+1 IO Pattern — `session-manager.ts`\n\n**Problem:** `terminateAllSessions` calls `terminateSession` in a loop, each of which fires a separate `persistSessions()` disk write. N sessions = N file writes.\n\n```typescript\n// CURRENT — N async writes, each writing the full sessions.json\nasync terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n const batchSize = 5;\n for (let i = 0; i < sessions.length; i += batchSize) {\n const batch = sessions.slice(i, i + batchSize);\n await Promise.allSettled(batch.map(s => this.terminateSession(s.id)));\n // ↑ each terminateSession calls persistSessions() — batched calls, but still N writes\n }\n}\n```\n\n**Fix:** Suppress persistence during batch, flush once after:\n\n```typescript\nasync terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n // Mark all terminated in-memory first (no I/O)\n for (const session of sessions) {\n session.status = 'terminated';\n session.endTime = new Date();\n this.eventBus.emit(SystemEventTypes.SESSION_TERMINATED, {\n sessionId: session.id,\n agentId: session.agentId,\n duration: session.endTime.getTime() - session.startTime.getTime(),\n });\n this.sessionProfiles.delete(session.id);\n }\n // Single write after all mutations\n await this.persistSessions();\n}\n```\n\n---\n\n### 2. No React Code Found\n\nThe codebase is entirely backend TypeScript. No React components or rendering logic is present — skipping this section.\n\n---\n\n### 3. Caching Opportunities\n\n#### 3a. `HealthMonitor.getStatus()` — no result cache\n\n**Problem:** External callers (e.g., `getComponentHealth`) trigger a full re-evaluation of all checks even though the interval already runs them. Under load, every MCP status request re-runs every check.\n\n```typescript\n// CURRENT — runs all checks on every call\nasync getStatus(): Promise<IHealthStatus> { /* runs all checks */ }\n\nasync getComponentHealth(name: string) {\n const status = await this.getStatus(); // ← full re-evaluation\n return status.components[name];\n}\n```\n\n**Fix:** Cache the last result with a short TTL:\n\n```typescript\nprivate lastStatus: IHealthStatus | undefined;\nprivate lastStatusAt = 0;\nprivate readonly STATUS_CACHE_MS = 5000;\n\nasync getStatus(): Promise<IHealthStatus> {\n const now = Date.now();\n if (this.lastStatus && now - this.lastStatusAt < this.STATUS_CACHE_MS) {\n return this.lastStatus;\n }\n const status = await this.computeStatus(); // extracted method\n this.lastStatus = status;\n this.lastStatusAt = now;\n return status;\n}\n```\n\n#### 3b. `ConfigLoader.findConfigFile` — repeated filesystem probes\n\n**Problem:** `findConfigFile` probes all `CONFIG_FILE_NAMES` on every `load()` call with no caching. Repeated calls hit the filesystem unnecessarily.\n\n```typescript\n// Simple memoization\nprivate configFileCache = new Map<string, string | null>();\n\nprivate async findConfigFile(directory: string): Promise<string | null> {\n if (this.configFileCache.has(directory)) {\n return this.configFileCache.get(directory) ?? null;\n }\n // ...existing probe logic...\n this.configFileCache.set(directory, result);\n return result;\n}\n```\n\n#### 3c. `TaskManager.getTasks` — linear scan on hot path\n\n**Problem:** Every status/type/agent filter call creates a new array from the Map and scans all tasks. For 1000+ tasks, this is expensive on polling paths.\n\n**Fix:** Maintain secondary indexes:\n\n```typescript\nprivate tasksByStatus = new Map<TaskStatus, Set<string>>();\nprivate tasksByAgent = new Map<string, Set<string>>();\n\n// In createTask, assignTask, completeTask etc., keep indexes updated.\n// getTasks then becomes:\ngetTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (filter?.status) {\n const ids = this.tasksByStatus.get(filter.status) ?? new Set();\n return Array.from(ids, id => this.tasks.get(id)!).filter(Boolean);\n }\n // ...etc\n}\n```\n\n---\n\n### 4. Memory Leaks\n\n#### 4a. `EventBus` — `subscriptions` Map never pruned\n\n**Problem:** `subscribe()` adds to both `this.handlers` and `this.subscriptions`. `off()` only removes from `handlers`. The `subscriptions` Map grows indefinitely.\n\n```typescript\n// CURRENT — off() doesn't touch this.subscriptions\noff(type: string, handler: IEventHandler): void {\n const handlers = this.handlers.get(type);\n if (handlers) {\n handlers.delete(handler);\n // ↑ subscriptions map still holds the entry\n }\n}\n```\n\n**Fix:** Ensure `removeSubscription` is implemented and called consistently:\n\n```typescript\nprivate removeSubscription(id: string): void {\n const sub = this.subscriptions.get(id);\n if (!sub) return;\n for (const type of sub.filter.types ?? ['*']) {\n const handlers = this.handlers.get(type);\n handlers?.delete(sub.handler);\n if (handlers?.size === 0) this.handlers.delete(type);\n }\n this.subscriptions.delete(id);\n}\n```\n\n#### 4b. `TaskManager.tasks` Map — completed tasks never evicted\n\n**Problem:** `this.tasks` accumulates every task ever created. The `cleanup` method exists in the interface but is never called automatically. This is an unbounded grow.\n\n**Fix:** Add a periodic self-cleaning or call cleanup in `completeTask`/`failTask` for tasks older than a configurable retention window. At minimum, schedule it:\n\n```typescript\nconstructor(private eventBus: IEventBus, queue?: ITaskQueue) {\n this.queue = queue ?? new TaskQueue();\n // Evict completed/failed tasks older than 1 hour every 10 minutes\n setInterval(() => {\n const cutoff = new Date(Date.now() - 3_600_000);\n this.cleanup(cutoff).catch(() => {});\n }, 600_000).unref(); // .unref() so it doesn't prevent process exit\n}\n```\n\n#### 4c. `HealthMonitor.history` — repeated array re-allocation\n\n**Problem:** Trimming creates a new array every interval cycle, generating GC pressure at the rate of `checkInterval`.\n\n```typescript\n// CURRENT — new array on every trim\nthis.history = this.history.slice(-this.config.historyLimit);\n```\n\n**Fix:** Splice in-place or use a fixed circular buffer:\n\n```typescript\nprivate addToHistory(status: IHealthStatus): void {\n this.history.push(status);\n if (this.history.length > this.config.historyLimit) {\n this.history.splice(0, this.history.length - this.config.historyLimit);\n }\n}\n```\n\n---\n\n### 5. Redundant Computations\n\n#### 5a. `TaskQueue.enqueue` — O(n log n) sort on every insertion\n\n**Problem:** Calling `Array.sort` after each enqueue is O(n log n). For a queue that receives many tasks, this adds up fast.\n\n```typescript\n// CURRENT\nasync enqueue(task: ITask): Promise<void> {\n this.tasks.push(task);\n this.tasks.sort((a, b) => b.priority - a.priority); // O(n log n) every time\n}\n```\n\n**Fix:** Binary-search insertion to maintain sorted order at O(log n):\n\n```typescript\nasync enqueue(task: ITask): Promise<void> {\n let lo = 0, hi = this.tasks.length;\n while (lo < hi) {\n const mid = (lo + hi) >>> 1;\n if (this.tasks[mid].priority >= task.priority) lo = mid + 1;\n else hi = mid;\n }\n this.tasks.splice(lo, 0, task);\n}\n```\n\n#### 5b. `EventBus.dispatchEvent` — Set allocated per event\n\n**Problem:** A new `Set<IEventHandler>` is created on every dispatched event just to deduplicate handlers from two sources.\n\n```typescript\n// CURRENT — allocates a Set for every event\nprivate dispatchEvent<T>(event: IEvent<T>): void {\n const allHandlers = new Set<IEventHandler>(); // ← new allocation per event\n // ...\n}\n```\n\n**Fix:** Iterate directly, checking for presence in the first set:\n\n```typescript\nprivate dispatchEvent<T>(event: IEvent<T>): void {\n const typeHandlers = this.handlers.get(event.type);\n const wildcardHandlers = this.handlers.get('*');\n\n if (typeHandlers) {\n for (const handler of typeHandlers) this.invokeHandler(event, handler);\n }\n if (wildcardHandlers) {\n for (const handler of wildcardHandlers) {\n if (!typeHandlers?.has(handler)) this.invokeHandler(event, handler);\n }\n }\n}\n```\n\n#### 5c. `TaskManager.getTasks` — multi-pass filter\n\n**Problem:** When multiple filter properties are specified, separate `.filter()` calls each allocate a new array.\n\n```typescript\n// CURRENT — up to 3 array allocations\nif (filter.status) tasks = tasks.filter(t => t.status === filter.status);\nif (filter.type) tasks = tasks.filter(t => t.type === filter.type);\nif (filter.assignedAgent) tasks = tasks.filter(t => t.assignedAgent === filter.assignedAgent);\n```\n\n**Fix:** Single-pass composite filter:\n\n```typescript\ngetTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (!filter) return Array.from(this.tasks.values());\n const { status, type, assignedAgent } = filter;\n const result: ITask[] = [];\n for (const t of this.tasks.values()) {\n if (status && t.status !== status) continue;\n if (type && t.type !== type) continue;\n if (assignedAgent && t.assignedAgent !== assignedAgent) continue;\n result.push(t);\n }\n return result;\n}\n```\n\n---\n\n### Priority Summary\n\n| Severity | Issue | File |\n|---|---|---|\n| High | N+1 disk writes on `terminateAllSessions` | `session-manager.ts` |\n| High | `TaskManager.tasks` unbounded growth | `task-manager.ts` |\n| High | `EventBus.subscriptions` never pruned | `event-bus.ts` |\n| Medium | `HealthMonitor.getStatus` re-evaluates on every external call | `health-monitor.ts` |\n| Medium | `TaskQueue.enqueue` O(n log n) sort per insert | `task-manager.ts` |\n| Low | `dispatchEvent` per-event Set allocation | `event-bus.ts` |\n| Low | `getTasks` multi-pass filter | `task-manager.ts` |\n| Low | `history.slice` allocation per interval | `health-monitor.ts` |\n",
|
|
6
|
+
"parsedOutput": {
|
|
7
|
+
"sections": [
|
|
8
|
+
{
|
|
9
|
+
"title": "Performance Analysis",
|
|
10
|
+
"content": "\n---\n\n",
|
|
11
|
+
"level": 2
|
|
12
|
+
},
|
|
13
|
+
{
|
|
14
|
+
"title": "1. N+1 IO Pattern — `session-manager.ts`",
|
|
15
|
+
"content": "\n**Problem:** `terminateAllSessions` calls `terminateSession` in a loop, each of which fires a separate `persistSessions()` disk write. N sessions = N file writes.\n\n```typescript\n// CURRENT — N async writes, each writing the full sessions.json\nasync terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n const batchSize = 5;\n for (let i = 0; i < sessions.length; i += batchSize) {\n const batch = sessions.slice(i, i + batchSize);\n await Promise.allSettled(batch.map(s => this.terminateSession(s.id)));\n // ↑ each terminateSession calls persistSessions() — batched calls, but still N writes\n }\n}\n```\n\n**Fix:** Suppress persistence during batch, flush once after:\n\n```typescript\nasync terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n // Mark all terminated in-memory first (no I/O)\n for (const session of sessions) {\n session.status = 'terminated';\n session.endTime = new Date();\n this.eventBus.emit(SystemEventTypes.SESSION_TERMINATED, {\n sessionId: session.id,\n agentId: session.agentId,\n duration: session.endTime.getTime() - session.startTime.getTime(),\n });\n this.sessionProfiles.delete(session.id);\n }\n // Single write after all mutations\n await this.persistSessions();\n}\n```\n\n---\n\n",
|
|
16
|
+
"level": 3
|
|
17
|
+
},
|
|
18
|
+
{
|
|
19
|
+
"title": "2. No React Code Found",
|
|
20
|
+
"content": "\nThe codebase is entirely backend TypeScript. No React components or rendering logic is present — skipping this section.\n\n---\n\n",
|
|
21
|
+
"level": 3
|
|
22
|
+
},
|
|
23
|
+
{
|
|
24
|
+
"title": "3. Caching Opportunities",
|
|
25
|
+
"content": "\n",
|
|
26
|
+
"level": 3
|
|
27
|
+
},
|
|
28
|
+
{
|
|
29
|
+
"title": "3a. `HealthMonitor.getStatus()` — no result cache",
|
|
30
|
+
"content": "\n**Problem:** External callers (e.g., `getComponentHealth`) trigger a full re-evaluation of all checks even though the interval already runs them. Under load, every MCP status request re-runs every check.\n\n```typescript\n// CURRENT — runs all checks on every call\nasync getStatus(): Promise<IHealthStatus> { /* runs all checks */ }\n\nasync getComponentHealth(name: string) {\n const status = await this.getStatus(); // ← full re-evaluation\n return status.components[name];\n}\n```\n\n**Fix:** Cache the last result with a short TTL:\n\n```typescript\nprivate lastStatus: IHealthStatus | undefined;\nprivate lastStatusAt = 0;\nprivate readonly STATUS_CACHE_MS = 5000;\n\nasync getStatus(): Promise<IHealthStatus> {\n const now = Date.now();\n if (this.lastStatus && now - this.lastStatusAt < this.STATUS_CACHE_MS) {\n return this.lastStatus;\n }\n const status = await this.computeStatus(); // extracted method\n this.lastStatus = status;\n this.lastStatusAt = now;\n return status;\n}\n```\n\n",
|
|
31
|
+
"level": 4
|
|
32
|
+
},
|
|
33
|
+
{
|
|
34
|
+
"title": "3b. `ConfigLoader.findConfigFile` — repeated filesystem probes",
|
|
35
|
+
"content": "\n**Problem:** `findConfigFile` probes all `CONFIG_FILE_NAMES` on every `load()` call with no caching. Repeated calls hit the filesystem unnecessarily.\n\n```typescript\n// Simple memoization\nprivate configFileCache = new Map<string, string | null>();\n\nprivate async findConfigFile(directory: string): Promise<string | null> {\n if (this.configFileCache.has(directory)) {\n return this.configFileCache.get(directory) ?? null;\n }\n // ...existing probe logic...\n this.configFileCache.set(directory, result);\n return result;\n}\n```\n\n",
|
|
36
|
+
"level": 4
|
|
37
|
+
},
|
|
38
|
+
{
|
|
39
|
+
"title": "3c. `TaskManager.getTasks` — linear scan on hot path",
|
|
40
|
+
"content": "\n**Problem:** Every status/type/agent filter call creates a new array from the Map and scans all tasks. For 1000+ tasks, this is expensive on polling paths.\n\n**Fix:** Maintain secondary indexes:\n\n```typescript\nprivate tasksByStatus = new Map<TaskStatus, Set<string>>();\nprivate tasksByAgent = new Map<string, Set<string>>();\n\n// In createTask, assignTask, completeTask etc., keep indexes updated.\n// getTasks then becomes:\ngetTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (filter?.status) {\n const ids = this.tasksByStatus.get(filter.status) ?? new Set();\n return Array.from(ids, id => this.tasks.get(id)!).filter(Boolean);\n }\n // ...etc\n}\n```\n\n---\n\n",
|
|
41
|
+
"level": 4
|
|
42
|
+
},
|
|
43
|
+
{
|
|
44
|
+
"title": "4. Memory Leaks",
|
|
45
|
+
"content": "\n",
|
|
46
|
+
"level": 3
|
|
47
|
+
},
|
|
48
|
+
{
|
|
49
|
+
"title": "4a. `EventBus` — `subscriptions` Map never pruned",
|
|
50
|
+
"content": "\n**Problem:** `subscribe()` adds to both `this.handlers` and `this.subscriptions`. `off()` only removes from `handlers`. The `subscriptions` Map grows indefinitely.\n\n```typescript\n// CURRENT — off() doesn't touch this.subscriptions\noff(type: string, handler: IEventHandler): void {\n const handlers = this.handlers.get(type);\n if (handlers) {\n handlers.delete(handler);\n // ↑ subscriptions map still holds the entry\n }\n}\n```\n\n**Fix:** Ensure `removeSubscription` is implemented and called consistently:\n\n```typescript\nprivate removeSubscription(id: string): void {\n const sub = this.subscriptions.get(id);\n if (!sub) return;\n for (const type of sub.filter.types ?? ['*']) {\n const handlers = this.handlers.get(type);\n handlers?.delete(sub.handler);\n if (handlers?.size === 0) this.handlers.delete(type);\n }\n this.subscriptions.delete(id);\n}\n```\n\n",
|
|
51
|
+
"level": 4
|
|
52
|
+
},
|
|
53
|
+
{
|
|
54
|
+
"title": "4b. `TaskManager.tasks` Map — completed tasks never evicted",
|
|
55
|
+
"content": "\n**Problem:** `this.tasks` accumulates every task ever created. The `cleanup` method exists in the interface but is never called automatically. This is an unbounded grow.\n\n**Fix:** Add a periodic self-cleaning or call cleanup in `completeTask`/`failTask` for tasks older than a configurable retention window. At minimum, schedule it:\n\n```typescript\nconstructor(private eventBus: IEventBus, queue?: ITaskQueue) {\n this.queue = queue ?? new TaskQueue();\n // Evict completed/failed tasks older than 1 hour every 10 minutes\n setInterval(() => {\n const cutoff = new Date(Date.now() - 3_600_000);\n this.cleanup(cutoff).catch(() => {});\n }, 600_000).unref(); // .unref() so it doesn't prevent process exit\n}\n```\n\n",
|
|
56
|
+
"level": 4
|
|
57
|
+
},
|
|
58
|
+
{
|
|
59
|
+
"title": "4c. `HealthMonitor.history` — repeated array re-allocation",
|
|
60
|
+
"content": "\n**Problem:** Trimming creates a new array every interval cycle, generating GC pressure at the rate of `checkInterval`.\n\n```typescript\n// CURRENT — new array on every trim\nthis.history = this.history.slice(-this.config.historyLimit);\n```\n\n**Fix:** Splice in-place or use a fixed circular buffer:\n\n```typescript\nprivate addToHistory(status: IHealthStatus): void {\n this.history.push(status);\n if (this.history.length > this.config.historyLimit) {\n this.history.splice(0, this.history.length - this.config.historyLimit);\n }\n}\n```\n\n---\n\n",
|
|
61
|
+
"level": 4
|
|
62
|
+
},
|
|
63
|
+
{
|
|
64
|
+
"title": "5. Redundant Computations",
|
|
65
|
+
"content": "\n",
|
|
66
|
+
"level": 3
|
|
67
|
+
},
|
|
68
|
+
{
|
|
69
|
+
"title": "5a. `TaskQueue.enqueue` — O(n log n) sort on every insertion",
|
|
70
|
+
"content": "\n**Problem:** Calling `Array.sort` after each enqueue is O(n log n). For a queue that receives many tasks, this adds up fast.\n\n```typescript\n// CURRENT\nasync enqueue(task: ITask): Promise<void> {\n this.tasks.push(task);\n this.tasks.sort((a, b) => b.priority - a.priority); // O(n log n) every time\n}\n```\n\n**Fix:** Binary-search insertion to maintain sorted order at O(log n):\n\n```typescript\nasync enqueue(task: ITask): Promise<void> {\n let lo = 0, hi = this.tasks.length;\n while (lo < hi) {\n const mid = (lo + hi) >>> 1;\n if (this.tasks[mid].priority >= task.priority) lo = mid + 1;\n else hi = mid;\n }\n this.tasks.splice(lo, 0, task);\n}\n```\n\n",
|
|
71
|
+
"level": 4
|
|
72
|
+
},
|
|
73
|
+
{
|
|
74
|
+
"title": "5b. `EventBus.dispatchEvent` — Set allocated per event",
|
|
75
|
+
"content": "\n**Problem:** A new `Set<IEventHandler>` is created on every dispatched event just to deduplicate handlers from two sources.\n\n```typescript\n// CURRENT — allocates a Set for every event\nprivate dispatchEvent<T>(event: IEvent<T>): void {\n const allHandlers = new Set<IEventHandler>(); // ← new allocation per event\n // ...\n}\n```\n\n**Fix:** Iterate directly, checking for presence in the first set:\n\n```typescript\nprivate dispatchEvent<T>(event: IEvent<T>): void {\n const typeHandlers = this.handlers.get(event.type);\n const wildcardHandlers = this.handlers.get('*');\n\n if (typeHandlers) {\n for (const handler of typeHandlers) this.invokeHandler(event, handler);\n }\n if (wildcardHandlers) {\n for (const handler of wildcardHandlers) {\n if (!typeHandlers?.has(handler)) this.invokeHandler(event, handler);\n }\n }\n}\n```\n\n",
|
|
76
|
+
"level": 4
|
|
77
|
+
},
|
|
78
|
+
{
|
|
79
|
+
"title": "5c. `TaskManager.getTasks` — multi-pass filter",
|
|
80
|
+
"content": "\n**Problem:** When multiple filter properties are specified, separate `.filter()` calls each allocate a new array.\n\n```typescript\n// CURRENT — up to 3 array allocations\nif (filter.status) tasks = tasks.filter(t => t.status === filter.status);\nif (filter.type) tasks = tasks.filter(t => t.type === filter.type);\nif (filter.assignedAgent) tasks = tasks.filter(t => t.assignedAgent === filter.assignedAgent);\n```\n\n**Fix:** Single-pass composite filter:\n\n```typescript\ngetTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (!filter) return Array.from(this.tasks.values());\n const { status, type, assignedAgent } = filter;\n const result: ITask[] = [];\n for (const t of this.tasks.values()) {\n if (status && t.status !== status) continue;\n if (type && t.type !== type) continue;\n if (assignedAgent && t.assignedAgent !== assignedAgent) continue;\n result.push(t);\n }\n return result;\n}\n```\n\n---\n\n",
|
|
81
|
+
"level": 4
|
|
82
|
+
},
|
|
83
|
+
{
|
|
84
|
+
"title": "Priority Summary",
|
|
85
|
+
"content": "| Severity | Issue | File |\n|---|---|---|\n| High | N+1 disk writes on `terminateAllSessions` | `session-manager.ts` |\n| High | `TaskManager.tasks` unbounded growth | `task-manager.ts` |\n| High | `EventBus.subscriptions` never pruned | `event-bus.ts` |\n| Medium | `HealthMonitor.getStatus` re-evaluates on every external call | `health-monitor.ts` |\n| Medium | `TaskQueue.enqueue` O(n log n) sort per insert | `task-manager.ts` |\n| Low | `dispatchEvent` per-event Set allocation | `event-bus.ts` |\n| Low | `getTasks` multi-pass filter | `task-manager.ts` |\n| Low | `history.slice` allocation per interval | `health-monitor.ts` |",
|
|
86
|
+
"level": 3
|
|
87
|
+
}
|
|
88
|
+
],
|
|
89
|
+
"codeBlocks": [
|
|
90
|
+
{
|
|
91
|
+
"language": "typescript",
|
|
92
|
+
"code": "// CURRENT — N async writes, each writing the full sessions.json\nasync terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n const batchSize = 5;\n for (let i = 0; i < sessions.length; i += batchSize) {\n const batch = sessions.slice(i, i + batchSize);\n await Promise.allSettled(batch.map(s => this.terminateSession(s.id)));\n // ↑ each terminateSession calls persistSessions() — batched calls, but still N writes\n }\n}"
|
|
93
|
+
},
|
|
94
|
+
{
|
|
95
|
+
"language": "typescript",
|
|
96
|
+
"code": "async terminateAllSessions(): Promise<void> {\n const sessions = this.getActiveSessions();\n // Mark all terminated in-memory first (no I/O)\n for (const session of sessions) {\n session.status = 'terminated';\n session.endTime = new Date();\n this.eventBus.emit(SystemEventTypes.SESSION_TERMINATED, {\n sessionId: session.id,\n agentId: session.agentId,\n duration: session.endTime.getTime() - session.startTime.getTime(),\n });\n this.sessionProfiles.delete(session.id);\n }\n // Single write after all mutations\n await this.persistSessions();\n}"
|
|
97
|
+
},
|
|
98
|
+
{
|
|
99
|
+
"language": "typescript",
|
|
100
|
+
"code": "// CURRENT — runs all checks on every call\nasync getStatus(): Promise<IHealthStatus> { /* runs all checks */ }\n\nasync getComponentHealth(name: string) {\n const status = await this.getStatus(); // ← full re-evaluation\n return status.components[name];\n}"
|
|
101
|
+
},
|
|
102
|
+
{
|
|
103
|
+
"language": "typescript",
|
|
104
|
+
"code": "private lastStatus: IHealthStatus | undefined;\nprivate lastStatusAt = 0;\nprivate readonly STATUS_CACHE_MS = 5000;\n\nasync getStatus(): Promise<IHealthStatus> {\n const now = Date.now();\n if (this.lastStatus && now - this.lastStatusAt < this.STATUS_CACHE_MS) {\n return this.lastStatus;\n }\n const status = await this.computeStatus(); // extracted method\n this.lastStatus = status;\n this.lastStatusAt = now;\n return status;\n}"
|
|
105
|
+
},
|
|
106
|
+
{
|
|
107
|
+
"language": "typescript",
|
|
108
|
+
"code": "// Simple memoization\nprivate configFileCache = new Map<string, string | null>();\n\nprivate async findConfigFile(directory: string): Promise<string | null> {\n if (this.configFileCache.has(directory)) {\n return this.configFileCache.get(directory) ?? null;\n }\n // ...existing probe logic...\n this.configFileCache.set(directory, result);\n return result;\n}"
|
|
109
|
+
},
|
|
110
|
+
{
|
|
111
|
+
"language": "typescript",
|
|
112
|
+
"code": "private tasksByStatus = new Map<TaskStatus, Set<string>>();\nprivate tasksByAgent = new Map<string, Set<string>>();\n\n// In createTask, assignTask, completeTask etc., keep indexes updated.\n// getTasks then becomes:\ngetTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (filter?.status) {\n const ids = this.tasksByStatus.get(filter.status) ?? new Set();\n return Array.from(ids, id => this.tasks.get(id)!).filter(Boolean);\n }\n // ...etc\n}"
|
|
113
|
+
},
|
|
114
|
+
{
|
|
115
|
+
"language": "typescript",
|
|
116
|
+
"code": "// CURRENT — off() doesn't touch this.subscriptions\noff(type: string, handler: IEventHandler): void {\n const handlers = this.handlers.get(type);\n if (handlers) {\n handlers.delete(handler);\n // ↑ subscriptions map still holds the entry\n }\n}"
|
|
117
|
+
},
|
|
118
|
+
{
|
|
119
|
+
"language": "typescript",
|
|
120
|
+
"code": "private removeSubscription(id: string): void {\n const sub = this.subscriptions.get(id);\n if (!sub) return;\n for (const type of sub.filter.types ?? ['*']) {\n const handlers = this.handlers.get(type);\n handlers?.delete(sub.handler);\n if (handlers?.size === 0) this.handlers.delete(type);\n }\n this.subscriptions.delete(id);\n}"
|
|
121
|
+
},
|
|
122
|
+
{
|
|
123
|
+
"language": "typescript",
|
|
124
|
+
"code": "constructor(private eventBus: IEventBus, queue?: ITaskQueue) {\n this.queue = queue ?? new TaskQueue();\n // Evict completed/failed tasks older than 1 hour every 10 minutes\n setInterval(() => {\n const cutoff = new Date(Date.now() - 3_600_000);\n this.cleanup(cutoff).catch(() => {});\n }, 600_000).unref(); // .unref() so it doesn't prevent process exit\n}"
|
|
125
|
+
},
|
|
126
|
+
{
|
|
127
|
+
"language": "typescript",
|
|
128
|
+
"code": "// CURRENT — new array on every trim\nthis.history = this.history.slice(-this.config.historyLimit);"
|
|
129
|
+
},
|
|
130
|
+
{
|
|
131
|
+
"language": "typescript",
|
|
132
|
+
"code": "private addToHistory(status: IHealthStatus): void {\n this.history.push(status);\n if (this.history.length > this.config.historyLimit) {\n this.history.splice(0, this.history.length - this.config.historyLimit);\n }\n}"
|
|
133
|
+
},
|
|
134
|
+
{
|
|
135
|
+
"language": "typescript",
|
|
136
|
+
"code": "// CURRENT\nasync enqueue(task: ITask): Promise<void> {\n this.tasks.push(task);\n this.tasks.sort((a, b) => b.priority - a.priority); // O(n log n) every time\n}"
|
|
137
|
+
},
|
|
138
|
+
{
|
|
139
|
+
"language": "typescript",
|
|
140
|
+
"code": "async enqueue(task: ITask): Promise<void> {\n let lo = 0, hi = this.tasks.length;\n while (lo < hi) {\n const mid = (lo + hi) >>> 1;\n if (this.tasks[mid].priority >= task.priority) lo = mid + 1;\n else hi = mid;\n }\n this.tasks.splice(lo, 0, task);\n}"
|
|
141
|
+
},
|
|
142
|
+
{
|
|
143
|
+
"language": "typescript",
|
|
144
|
+
"code": "// CURRENT — allocates a Set for every event\nprivate dispatchEvent<T>(event: IEvent<T>): void {\n const allHandlers = new Set<IEventHandler>(); // ← new allocation per event\n // ...\n}"
|
|
145
|
+
},
|
|
146
|
+
{
|
|
147
|
+
"language": "typescript",
|
|
148
|
+
"code": "private dispatchEvent<T>(event: IEvent<T>): void {\n const typeHandlers = this.handlers.get(event.type);\n const wildcardHandlers = this.handlers.get('*');\n\n if (typeHandlers) {\n for (const handler of typeHandlers) this.invokeHandler(event, handler);\n }\n if (wildcardHandlers) {\n for (const handler of wildcardHandlers) {\n if (!typeHandlers?.has(handler)) this.invokeHandler(event, handler);\n }\n }\n}"
|
|
149
|
+
},
|
|
150
|
+
{
|
|
151
|
+
"language": "typescript",
|
|
152
|
+
"code": "// CURRENT — up to 3 array allocations\nif (filter.status) tasks = tasks.filter(t => t.status === filter.status);\nif (filter.type) tasks = tasks.filter(t => t.type === filter.type);\nif (filter.assignedAgent) tasks = tasks.filter(t => t.assignedAgent === filter.assignedAgent);"
|
|
153
|
+
},
|
|
154
|
+
{
|
|
155
|
+
"language": "typescript",
|
|
156
|
+
"code": "getTasks(filter?: Partial<Pick<ITask, 'status' | 'type' | 'assignedAgent'>>): ITask[] {\n if (!filter) return Array.from(this.tasks.values());\n const { status, type, assignedAgent } = filter;\n const result: ITask[] = [];\n for (const t of this.tasks.values()) {\n if (status && t.status !== status) continue;\n if (type && t.type !== type) continue;\n if (assignedAgent && t.assignedAgent !== assignedAgent) continue;\n result.push(t);\n }\n return result;\n}"
|
|
157
|
+
}
|
|
158
|
+
]
|
|
159
|
+
},
|
|
160
|
+
"durationMs": 67731,
|
|
161
|
+
"model": "sonnet",
|
|
162
|
+
"sandboxMode": "permissive",
|
|
163
|
+
"workerType": "optimize",
|
|
164
|
+
"timestamp": "2026-04-28T12:29:34.704Z",
|
|
165
|
+
"executionId": "optimize_1777379306973_an4lmy"
|
|
166
|
+
}
|