@claude-flow/cli 3.7.0-alpha.7 → 3.7.0-alpha.70

package/dist/src/commands/hooks.js

@@ -8,6 +8,16 @@ import { callMCPTool, MCPClientError } from '../mcp-client.js';
 import { storeCommand } from './transfer-store.js';
 import { existsSync, readFileSync, statSync } from 'node:fs';
 import { join } from 'node:path';
+/**
+ * #1686 — `?? 0` only defaults null/undefined; NaN slips through and
+ * surfaces as `"NaN"` (or earlier crashed `.toFixed`) in the metrics
+ * dashboard and pretrain output. Coerce to a finite number, fall back
+ * to `fallback` when the input is null/undefined/non-numeric/NaN/Infinity.
+ */
+function safeNum(value, fallback = 0) {
+    const n = typeof value === 'number' ? value : Number(value);
+    return Number.isFinite(n) ? n : fallback;
+}
 /**
  * Read coverage data from disk. Checks these locations in order:
  * 1. coverage/coverage-summary.json (Jest/Istanbul)
@@ -260,7 +270,7 @@ const preEditCommand = {
     ],
     action: async (ctx) => {
         // Default file to 'unknown' for backward compatibility (env var may be empty)
-        const filePath = ctx.args[0] || ctx.flags.file || 'unknown';
+        const filePath = ctx.flags.file || ctx.args[0] || 'unknown';
         const operation = ctx.flags.operation || 'update';
         output.printInfo(`Analyzing context for: ${output.highlight(filePath)}`);
         try {
@@ -365,7 +375,7 @@ const postEditCommand = {
     ],
     action: async (ctx) => {
         // Default file to 'unknown' for backward compatibility (env var may be empty)
-        const filePath = ctx.args[0] || ctx.flags.file || 'unknown';
+        const filePath = ctx.flags.file || ctx.args[0] || 'unknown';
         // Default success to true for backward compatibility (PostToolUse = success, PostToolUseFailure = failure)
         const success = ctx.flags.success !== undefined ? ctx.flags.success : true;
         output.printInfo(`Recording outcome for: ${output.highlight(filePath)}`);
@@ -448,7 +458,7 @@ const preCommandCommand = {
         { command: 'claude-flow hooks pre-command -c "npm install lodash"', description: 'Check package install' }
     ],
     action: async (ctx) => {
-        const command = ctx.args[0] || ctx.flags.command;
+        const command = ctx.flags.command || ctx.args[0];
         if (!command) {
             output.printError('Command is required. Use --command or -c flag.');
             return { success: false, exitCode: 1 };
@@ -557,7 +567,7 @@ const postCommandCommand = {
         { command: 'claude-flow hooks post-command -c "npm build" --success false -e 1', description: 'Record failed build' }
     ],
     action: async (ctx) => {
-        const command = ctx.args[0] || ctx.flags.command;
+        const command = ctx.flags.command || ctx.args[0];
         // Default success to true for backward compatibility
         const success = ctx.flags.success !== undefined ? ctx.flags.success : true;
         if (!command) {
@@ -629,7 +639,7 @@ const routeCommand = {
         { command: 'claude-flow hooks route -t "Optimize database queries" -K 5', description: 'Get top 5 suggestions' }
     ],
     action: async (ctx) => {
-        const task = ctx.args[0] || ctx.flags.task;
+        const task = ctx.flags.task || ctx.args[0];
         const topK = ctx.flags.topK || 3;
         if (!task) {
             output.printError('Task description is required. Use --task or -t flag.');
@@ -741,7 +751,7 @@ const explainCommand = {
         { command: 'claude-flow hooks explain -t "Optimize queries" -a coder --verbose', description: 'Verbose explanation for specific agent' }
     ],
     action: async (ctx) => {
-        const task = ctx.args[0] || ctx.flags.task;
+        const task = ctx.flags.task || ctx.args[0];
         if (!task) {
             output.printError('Task description is required. Use --task or -t flag.');
             return { success: false, exitCode: 1 };
@@ -903,8 +913,10 @@ const pretrainCommand = {
             });
             spinner.succeed('Pretraining completed');
             // Normalize shape: prefer `statistics`, fall back to `stats` for older tools.
+            // #1686 — coerce duration through safeNum so a NaN from the underlying
+            // pretrain pipeline surfaces as `0.0s` rather than `NaNs`.
             const stats = (rawResult.statistics ?? rawResult.stats ?? {});
-            const durationMs = rawResult.duration ?? rawResult.statistics?.executionTime ?? 0;
+            const durationMs = safeNum(rawResult.duration ?? rawResult.statistics?.executionTime);
             const result = { ...rawResult, stats, duration: durationMs };
             if (ctx.flags.format === 'json') {
                 output.printJson(result);
@@ -1089,18 +1101,19 @@ const metricsCommand = {
                 category: ctx.flags.category,
             });
             // Normalize across both shapes; default every numeric to 0 so toFixed
-            // never sees null/undefined.
-            const totalPatterns = rawMetrics.patterns?.total ?? rawMetrics.summary?.patternsLearned ?? 0;
-            const successfulPatterns = rawMetrics.patterns?.successful ?? Math.round((rawMetrics.summary?.successRate ?? 0) * totalPatterns);
-            const failedPatterns = rawMetrics.patterns?.failed ?? Math.max(0, totalPatterns - successfulPatterns);
-            const avgConfidence = rawMetrics.patterns?.avgConfidence ?? rawMetrics.summary?.avgQuality ?? 0;
-            const routingAccuracy = rawMetrics.agents?.routingAccuracy
-                ?? (rawMetrics.routing?.avgConfidence ?? 0);
-            const totalRoutes = rawMetrics.agents?.totalRoutes ?? rawMetrics.routing?.totalRoutes ?? 0;
+            // never sees null/undefined. #1686 — also coerce NaN through `safeNum`
+            // because `?? 0` only catches null/undefined; an upstream NaN would
+            // still land in `.toFixed(...)` and surface as `"NaN"`.
+            const totalPatterns = safeNum(rawMetrics.patterns?.total ?? rawMetrics.summary?.patternsLearned);
+            const successfulPatterns = safeNum(rawMetrics.patterns?.successful ?? Math.round(safeNum(rawMetrics.summary?.successRate) * totalPatterns));
+            const failedPatterns = Math.max(0, safeNum(rawMetrics.patterns?.failed ?? totalPatterns - successfulPatterns));
+            const avgConfidence = safeNum(rawMetrics.patterns?.avgConfidence ?? rawMetrics.summary?.avgQuality);
+            const routingAccuracy = safeNum(rawMetrics.agents?.routingAccuracy ?? rawMetrics.routing?.avgConfidence);
+            const totalRoutes = safeNum(rawMetrics.agents?.totalRoutes ?? rawMetrics.routing?.totalRoutes);
             const topAgent = rawMetrics.agents?.topAgent ?? rawMetrics.routing?.topAgents?.[0]?.agent ?? 'n/a';
-            const totalCommands = rawMetrics.commands?.totalExecuted ?? rawMetrics.commands?.totalCommands ?? 0;
-            const commandSuccessRate = rawMetrics.commands?.successRate ?? 0;
-            const avgRiskScore = rawMetrics.commands?.avgRiskScore ?? rawMetrics.commands?.avgExecutionTime ?? 0;
+            const totalCommands = safeNum(rawMetrics.commands?.totalExecuted ?? rawMetrics.commands?.totalCommands);
+            const commandSuccessRate = safeNum(rawMetrics.commands?.successRate);
+            const avgRiskScore = safeNum(rawMetrics.commands?.avgRiskScore ?? rawMetrics.commands?.avgExecutionTime);
             const result = {
                 ...rawMetrics,
                 patterns: { total: totalPatterns, successful: successfulPatterns, failed: failedPatterns, avgConfidence },
@@ -1211,7 +1224,7 @@ const transferFromProjectCommand = {
         { command: 'claude-flow hooks transfer from-project -s ../prod --filter security -m 0.9', description: 'Transfer high-confidence security patterns' }
     ],
     action: async (ctx) => {
-        const sourcePath = ctx.args[0] || ctx.flags.source;
+        const sourcePath = ctx.flags.source || ctx.args[0];
         const minConfidence = ctx.flags.minConfidence || 0.7;
         if (!sourcePath) {
             output.printError('Source project path is required. Use --source or -s flag.');
@@ -1409,7 +1422,7 @@ const preTaskCommand = {
     ],
     action: async (ctx) => {
         const taskId = ctx.flags.taskId || `task-${Date.now().toString(36)}`;
-        const description = ctx.args[0] || ctx.flags.description;
+        const description = ctx.flags.description || ctx.args[0];
         if (!description) {
             output.printError('Description is required: --description "your task"');
             return { success: false, exitCode: 1 };
@@ -1694,7 +1707,7 @@ const sessionRestoreCommand = {
         { command: 'claude-flow hooks session-restore -i session-12345', description: 'Restore specific session' }
     ],
     action: async (ctx) => {
-        const sessionId = ctx.args[0] || ctx.flags.sessionId || 'latest';
+        const sessionId = ctx.flags.sessionId || ctx.args[0] || 'latest';
         output.printInfo(`Restoring session: ${output.highlight(sessionId)}`);
         try {
             const result = await callMCPTool('hooks_session-restore', {
@@ -2506,7 +2519,7 @@ const coverageRouteCommand = {
         { command: 'claude-flow hooks coverage-route -t "add tests" --threshold 90', description: 'Route with custom threshold' }
     ],
     action: async (ctx) => {
-        const task = ctx.args[0] || ctx.flags.task;
+        const task = ctx.flags.task || ctx.args[0];
         const threshold = ctx.flags.threshold || 80;
         const useRuvector = !ctx.flags['no-ruvector'];
         if (!task) {
@@ -2726,7 +2739,7 @@ const coverageSuggestCommand = {
         { command: 'claude-flow hooks coverage-suggest -p src/services --threshold 90', description: 'Stricter threshold' }
     ],
     action: async (ctx) => {
-        const targetPath = ctx.args[0] || ctx.flags.path;
+        const targetPath = ctx.flags.path || ctx.args[0];
         const threshold = ctx.flags.threshold || 80;
         const limit = ctx.flags.limit || 20;
         if (!targetPath) {
@@ -3289,7 +3302,13 @@ const statuslineCommand = {
         },
         {
             name: 'compact',
-            description: 'Compact single-line output',
+            description: 'Compact single-line output (auto-enabled when terminal width < 100 cols)',
+            type: 'boolean',
+            default: false
+        },
+        {
+            name: 'full',
+            description: 'Force the full multi-line output even on narrow terminals',
             type: 'boolean',
             default: false
         },
@@ -3518,8 +3537,16 @@ const statuslineCommand = {
             output.printJson(statusData);
             return { success: true, data: statusData };
         }
-        // Compact output
-        if (ctx.flags.compact) {
+        // #1153: auto-collapse to compact on narrow terminals so the full
+        // 6+ line statusline doesn't dominate the screen. Honors:
+        //   - explicit --compact → compact
+        //   - explicit --full    → full (overrides auto-detection)
+        //   - else                → compact when terminal < 100 cols (full multi-line
+        //                            output expects ~100 cols of horizontal space)
+        const COMPACT_WIDTH_THRESHOLD = 100;
+        const terminalCols = process.stdout.columns ?? 80;
+        const autoCompact = !ctx.flags.full && terminalCols < COMPACT_WIDTH_THRESHOLD;
+        if (ctx.flags.compact || autoCompact) {
             const line = `DDD:${progress.domainsCompleted}/${progress.totalDomains} CVE:${security.cvesFixed}/${security.totalCves} Swarm:${swarm.activeAgents}/${swarm.maxAgents} Ctx:${system.contextPct}% Int:${system.intelligencePct}%`;
             output.writeln(line);
             return { success: true, data: statusData };
@@ -3950,7 +3977,7 @@ const modelRouteCommand = {
         { command: 'claude-flow hooks model-route -t "architect auth system"', description: 'Route complex task (likely opus)' },
     ],
     action: async (ctx) => {
-        const task = ctx.args[0] || ctx.flags.task;
+        const task = ctx.flags.task || ctx.args[0];
         if (!task) {
             output.printError('Task description required. Use --task or -t flag.');
             return { success: false, exitCode: 1 };
@@ -4258,7 +4285,7 @@ const taskCompletedCommand = {
         { command: 'claude-flow hooks task-completed -i task-456 --notify-lead --quality 0.95', description: 'Complete with quality score' }
     ],
     action: async (ctx) => {
-        const taskId = ctx.args[0] || ctx.flags.taskId;
+        const taskId = ctx.flags.taskId || ctx.args[0];
         const trainPatterns = ctx.flags.trainPatterns !== false;
         const notifyLead = ctx.flags.notifyLead !== false;
         const success = ctx.flags.success !== false;
@@ -4336,7 +4363,7 @@ const notifyCommand = {
         { command: 'claude-flow hooks notify -m "Test failed" -l error', description: 'Send error notification' },
     ],
     action: async (ctx) => {
-        const message = ctx.args[0] || ctx.flags.message;
+        const message = ctx.flags.message || ctx.args[0];
         const level = ctx.flags.level || 'info';
         if (!message) {
             output.printError('Message is required: --message "your message"');