@classytic/promo 0.2.3 → 0.2.5

package/CHANGELOG.md

@@ -3,6 +3,59 @@
 Format based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 adhering to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.2.5] — 2026-05-08
+
+### Fixed
+
+- **§P8 dispatch — `outbox.save` failures now propagate.** [src/events/dispatch.ts](src/events/dispatch.ts)
+  previously caught `outbox.save` errors and only logged them, swallowing
+  the failure. Per PACKAGE_RULES §P8 the outbox row is the durability
+  anchor for the transactional-outbox pattern: if the save fails, the
+  caller's transaction MUST roll back so the business doc and the event
+  row land atomically. Swallowing meant a parent doc could commit while
+  the event vanished, with no relay row to recover from. Fix re-throws
+  after logging, matching the textbook §P8 shape used in
+  `@classytic/loyalty` 0.2.3 and `@classytic/order`.
+- `events.publish` failures continue to be swallowed (correctly, per §P8 —
+  the host's outbox relay re-publishes from the durable row), with logging
+  preserved for observability.
+
+### Changed
+
+- **Peer-dep ranges tightened** — `@classytic/mongokit` `>=3.13.3`
+  (was `>=3.13.0`) and `@classytic/repo-core` `>=0.4.2` (was `>=0.4.0`).
+  3.13.3 preserves `errorLabels` on `MongoServerError` so concurrent
+  transactional writes (the `claim()`-based program / voucher state
+  transitions) retry correctly under contention; 0.4.2 adds the typed
+  `FindAllOptions` shape with optional `limit?` for callers that need
+  bounded non-paginated reads.
+
+### Audited (no change required)
+
+- Two `Model.*` raw-driver sites in
+  [src/repositories/pending-evaluation.repository.ts](src/repositories/pending-evaluation.repository.ts)
+  (`findOneAndDelete`, `deleteOne`) confirmed as the documented atomic
+  take-and-return semantic that mongokit's `delete()` doesn't expose.
+  Tenant scoping is re-implemented at the repository layer (mirrors
+  `multiTenantPlugin`'s injection) so the bypass keeps cross-tenant
+  isolation intact.
+- `customIdPlugin` not used — §P9 dual-id resolution N/A.
+
+## [0.2.4]
+
+### Fixed
+
+- **`evaluation.preview` / `evaluation.evaluate`**: submitted codes are now
+  trimmed (in addition to uppercased) before resolution. `'  bigboss10  '`
+  resolves to `'BIGBOSS10'` and is reported under that canonical form in
+  `appliedCodes`. Duplicates after normalization are de-duped (a single code
+  submitted multiple times appears once).
+- **Empty-cart preview**: when `items` is empty (or `subtotal <= 0`), the
+  engine now rejects all submitted codes with `reason: 'Cart is empty'`
+  instead of listing them under `appliedCodes` with `totalDiscount: 0`. Hosts
+  that surface `appliedCodes` directly to the UI no longer need to special-case
+  zero-item carts.
+
 ## [0.2.0]
 
 Structural rewrite on top of the 0.1.0 shape. The public API is now a

package/dist/index.mjs

@@ -501,6 +501,7 @@ async function dispatchPromoEvent(deps, event, ctx) {
 		await deps.outbox.save(event, saveOptions);
 	} catch (err) {
 		logger.error(`[promo] outbox.save failed for ${event.type}:`, err);
+		throw err;
 	}
 	if (deps.events) try {
 		await deps.events.publish(event);
@@ -1125,7 +1126,23 @@ var EvaluationService = class {
 		await dispatchPromoEvent(this.dispatchDeps, createEvent$1(PromoEvents.EVALUATION_ROLLED_BACK, { evaluationId }, ctx), ctx);
 	}
 	async doEvaluate(input, ctx, isPreview) {
-		const submittedCodes = (input.codes ?? []).map((c) => c.toUpperCase());
+		const submittedCodes = Array.from(new Set((input.codes ?? []).map((c) => c.trim().toUpperCase()).filter((c) => c.length > 0)));
+		if (input.items.length === 0 || input.subtotal <= 0) return {
+			evaluationId: randomBytes(16).toString("hex"),
+			cartHash: computeCartHash(input),
+			appliedDiscounts: [],
+			freeProducts: [],
+			totalDiscount: 0,
+			subtotalAfterDiscount: Math.max(0, input.subtotal),
+			appliedCodes: [],
+			rejectedCodes: submittedCodes.map((code) => ({
+				code,
+				reason: "Cart is empty"
+			})),
+			warnings: [],
+			isPreview,
+			programsApplied: []
+		};
 		const programs = await this.programRepo.findActive(void 0, ctx);
 		const programIds = programs.map((p) => p._id);
 		const [allRules, allRewards] = await Promise.all([this.ruleRepo.findAll({ programId: { $in: programIds } }, ctx), this.rewardRepo.findAll({ programId: { $in: programIds } }, ctx)]);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@classytic/promo",
-  "version": "0.2.3",
+  "version": "0.2.5",
   "description": "Production-grade promotion, coupon, and discount engine for MongoDB — programs, rules, rewards, vouchers, gift cards, buy-x-get-y",
   "author": "Classytic",
   "homepage": "https://www.npmjs.com/package/@classytic/promo",
@@ -57,18 +57,18 @@
     "release": "npm run push -- main && npm run release:tag && npm publish"
   },
   "peerDependencies": {
-    "@classytic/mongokit": ">=3.13.0",
+    "@classytic/mongokit": ">=3.13.3",
     "@classytic/primitives": ">=0.5.0",
-    "@classytic/repo-core": ">=0.4.0",
+    "@classytic/repo-core": ">=0.4.2",
     "mongoose": ">=9.4.1",
     "zod": ">=4.0.0"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.4.9",
     "@classytic/dev-tools": "^0.2.0",
-    "@classytic/mongokit": ">=3.13.0",
+    "@classytic/mongokit": "^3.13.3",
     "@classytic/primitives": ">=0.5.0",
-    "@classytic/repo-core": ">=0.4.0",
+    "@classytic/repo-core": "^0.4.2",
     "@types/node": "^25.5.0",
     "@vitest/coverage-v8": "^3.2.4",
     "knip": "^6.3.0",