@classytic/arc-notifications 0.6.0 → 0.6.2

package/dist/index.mjs

@@ -340,14 +340,39 @@ function interpolate$1(template, vars) {
 		return v === void 0 || v === null ? `{${key}}` : String(v);
 	});
 }
+const UNRESOLVED = /\{\w+\}/;
+/**
+* Interpolate a MACHINE field — a link, an entity ref — and return `undefined`
+* when any placeholder went unresolved.
+*
+* Leaving `{key}` verbatim is right for COPY: a literal `{orderNumber}` in a
+* sentence is a visible bug someone fixes. It is wrong for a field something
+* PARSES, because the placeholder becomes a plausible value:
+*
+* - `link: '/dashboard/orders?_id={orderId}'` filters for the literal string and
+*   returns zero rows, which reads as "the order was deleted".
+* - `entityId: '{orderId}'` is the SAME identity for every order, so a feed that
+*   deduplicates on it collapses distinct orders into one notification — worse
+*   than not deduplicating.
+*
+* Absent degrades honestly: the link falls back to the unfiltered list, and a
+* missing entity ref makes the feed skip dedup rather than dedupe wrongly.
+*/
+function interpolateRef(template, vars) {
+	const out = interpolate$1(template, vars);
+	return UNRESOLVED.test(out) ? void 0 : out;
+}
 /** Render a trigger's in-app template against event data + priority. */
 function renderInApp(template, vars, priority = "normal") {
+	const link = template.link === void 0 ? void 0 : interpolateRef(template.link, vars);
+	const entityType = template.entityType === void 0 ? void 0 : interpolateRef(template.entityType, vars);
+	const entityId = template.entityId === void 0 ? void 0 : interpolateRef(template.entityId, vars);
 	return {
 		title: interpolate$1(template.title, vars),
 		message: interpolate$1(template.message, vars),
-		...template.link !== void 0 ? { link: interpolate$1(template.link, vars) } : {},
-		...template.entityType !== void 0 ? { entityType: interpolate$1(template.entityType, vars) } : {},
-		...template.entityId !== void 0 ? { entityId: interpolate$1(template.entityId, vars) } : {},
+		...link !== void 0 ? { link } : {},
+		...entityType !== void 0 ? { entityType } : {},
+		...entityId !== void 0 ? { entityId } : {},
 		priority
 	};
 }
@@ -1288,11 +1313,20 @@ function candidateChannels(t, catalog) {
 	* knows what it registered, so a connector that exists is offered and one that
 	* does not is absent, with no edit in this package.
 	*
-	* Falling back to the trigger's own declaration keeps a caller that supplies
-	* no catalog working: the degradation is "no NEW channels offered", never
-	* "no channels at all".
+	* A genuine UNION, not `catalog ?? declared`. The fallback form silently DROPPED
+	* a code-declared channel the catalog happened not to carry: `channels:
+	* ['telegram']` under a catalog of `['email']` expanded to `[in-app, email]`,
+	* so no telegram trigger existed to dispatch. And the loss was invisible from
+	* the operator's side rather than merely quiet — `defaults.channels` is
+	* `declaredChannels(t)`, which still contains telegram, so
+	* `resolveEffectiveSettings` reported the channel ENABLED while nothing was
+	* subscribed to deliver it. Supplying a catalog must only ever ADD reach; a
+	* trigger's own declaration is the floor.
+	*
+	* With no catalog this still degrades to the declared set — "no NEW channels
+	* offered", never "no channels at all".
 	*/
-	const configurable = (catalog?.list() ?? t.channels ?? []).filter((c) => c !== IN_APP_CHANNEL);
+	const configurable = [...catalog?.list() ?? [], ...t.channels ?? []].filter((c) => c !== IN_APP_CHANNEL);
 	const unique = [...new Set(configurable)];
 	/**
 	* A customer audience never gets `in-app`: buyers are not dashboard users, so

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@classytic/arc-notifications",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "Notifications module for @classytic/arc — domain events → multi-channel notifications via @classytic/notifications, with DB-draftable templates, repo-backed delivery log, and a templates resource",
   "type": "module",
   "exports": {