@clappr/player 0.13.0 → 0.14.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@clappr/player",
-  "version": "0.13.0",
+  "version": "0.14.0",
   "description": "An extensible media player for the web",
   "main": "dist/clappr.js",
   "scripts": {
@@ -34,10 +34,11 @@
   },
   "homepage": "https://github.com/clappr/clappr",
   "devDependencies": {
-    "@clappr/core": "^0.15.0",
-    "@clappr/hlsjs-playback": "^2.0.1",
-    "@clappr/plugins": "^0.9.9",
+    "@clappr/core": "^0.16.0",
+    "@clappr/hlsjs-playback": "^3.0.0",
+    "@clappr/plugins": "^0.9.10",
     "@rollup/plugin-replace": "^2.4.2",
+    "hls.js": "^1",
     "rollup-plugin-filesize": "^9.1.1",
     "rollup-plugin-serve": "^1.1.0"
   },

package/src/dist.smoke.test.js

@@ -12,6 +12,7 @@ const { TextEncoder, TextDecoder } = require('util')
 global.TextEncoder = global.TextEncoder || TextEncoder
 global.TextDecoder = global.TextDecoder || TextDecoder
 const { JSDOM } = require('jsdom')
+const { expectNoNativeClasses, expectEs5Subclassable } = require('../../../test/dist-contract')
 
 const DIST = path.join(__dirname, '..', 'dist')
 const pkg = require('../package.json')
@@ -121,6 +122,16 @@ describe.each([
   test('exports plugins that extend the same-bundle plugin bases', () => {
     assertSharedBundleContract(resolveClappr(loadArtifact(filename)))
   })
+
+  test('plugin bases are ES5-subclassable', () => {
+    // Behavioral contract for full + plainhtml5: third-party ES5 plugins call
+    // Parent.call(this, ...) on these bases (#2540). Syntax scan below cannot
+    // cover full clappr(.min).js — embedded hls.js ships native classes.
+    const C = resolveClappr(loadArtifact(filename))
+    expectEs5Subclassable(C.BaseObject)
+    expectEs5Subclassable(C.UIObject)
+    expectEs5Subclassable(C.UICorePlugin, { options: {} })
+  })
 })
 
 describe('full player HLS', () => {
@@ -128,6 +139,12 @@ describe('full player HLS', () => {
     const C = resolveClappr(loadArtifact(filename))
     expect(Object.getPrototypeOf(C.HLS.prototype)).toBe(C.HTML5Video.prototype)
   })
+
+  test.each(FULL_PLAYER)('%s embeds its own hls.js copy', filename => {
+    const C = resolveClappr(loadArtifact(filename))
+    expect(C.HLS.HLSJS).toBeDefined()
+    expect(C.HLS.HLSJS).not.toBe(require('hls.js'))
+  })
 })
 
 describe('plainhtml5 bundle', () => {
@@ -135,6 +152,12 @@ describe('plainhtml5 bundle', () => {
     const C = resolveClappr(loadArtifact(filename))
     expect(C.HLS).toBeUndefined()
   })
+
+  // Syntax-only on plainhtml5: full player embeds hls.js (native class). ES5
+  // subclassability of Clappr bases is asserted for all artifacts above.
+  test.each(PLAINHTML5)('%s does not emit native class syntax', filename => {
+    expectNoNativeClasses(readArtifact(filename))
+  })
 })
 
 describe('UMD global and AMD branches', () => {