@clairejs/server 3.22.9 → 3.22.10

package/README.md

@@ -1,5 +1,9 @@
 ## Change Log
 
+#### 3.22.10
+
+-   fix aws job scheduler name space job removal issue
+
 #### 3.22.9
 
 -   fix typing issue with job handler function

package/dist/job/AwsJobScheduler.d.ts

@@ -12,10 +12,10 @@ export declare class AwsJobScheduler extends AbstractJobScheduler {
     protected readonly db: AbstractDbAdapter;
     protected readonly uniqueJobIdFactory: () => string;
     protected readonly apiLambdaFunctionArn: string;
+    protected readonly jobNamespace: string;
     protected readonly eventBusName: string;
-    protected readonly jobNamePrefix: string;
     protected readonly eventbridge: aws.EventBridge;
-    constructor(logger: AbstractLogger, db: AbstractDbAdapter, uniqueJobIdFactory: () => string, apiLambdaFunctionArn: string, eventBusName?: string, jobNamePrefix?: string);
+    constructor(logger: AbstractLogger, db: AbstractDbAdapter, uniqueJobIdFactory: () => string, apiLambdaFunctionArn: string, jobNamespace: string, eventBusName?: string);
     handleCron(jobInfo: ScheduledJob): Promise<void>;
     protected afterJob(_job: ScheduledJob, _tx: ITransaction): Promise<void>;
     private generateCronFromTimestamp;

package/dist/job/AwsJobScheduler.js

@@ -21,17 +21,17 @@ let AwsJobScheduler = class AwsJobScheduler extends AbstractJobScheduler {
     db;
     uniqueJobIdFactory;
     apiLambdaFunctionArn;
+    jobNamespace;
     eventBusName;
-    jobNamePrefix;
     eventbridge = new aws.EventBridge();
-    constructor(logger, db, uniqueJobIdFactory, apiLambdaFunctionArn, eventBusName = "default", jobNamePrefix = "claire-aws-job-") {
+    constructor(logger, db, uniqueJobIdFactory, apiLambdaFunctionArn, jobNamespace, eventBusName = "default") {
         super(logger, db);
         this.logger = logger;
         this.db = db;
         this.uniqueJobIdFactory = uniqueJobIdFactory;
         this.apiLambdaFunctionArn = apiLambdaFunctionArn;
+        this.jobNamespace = jobNamespace;
         this.eventBusName = eventBusName;
-        this.jobNamePrefix = jobNamePrefix;
     }
     async handleCron(jobInfo) {
         this.logger.debug(`Handle cron`, jobInfo);
@@ -59,7 +59,7 @@ let AwsJobScheduler = class AwsJobScheduler extends AbstractJobScheduler {
         const allRules = await this.eventbridge
             .listRules({
             EventBusName: this.eventBusName,
-            NamePrefix: this.jobNamePrefix,
+            NamePrefix: this.jobNamespace,
         })
             .promise();
         const allJobs = await Promise.all((allRules.Rules || []).map(async (rule) => {
@@ -83,7 +83,7 @@ let AwsJobScheduler = class AwsJobScheduler extends AbstractJobScheduler {
     async scheduleJob(jobInfo) {
         this.logger.debug("Scheduling job: ", jobInfo);
         if (jobInfo.cron || jobInfo.at) {
-            const jobId = `${this.jobNamePrefix}${this.uniqueJobIdFactory()}`;
+            const jobId = `${this.jobNamespace}${this.uniqueJobIdFactory()}`;
             let cronExpression;
             if (jobInfo.at) {
                 cronExpression = this.generateCronFromTimestamp(jobInfo.at);
@@ -139,8 +139,10 @@ let AwsJobScheduler = class AwsJobScheduler extends AbstractJobScheduler {
         //-- remove job that no more exist
         const nomoreExistJobs = scheduledJobs.filter((job) => !allJobs.find((j) => j.jobName === job.jobName));
         for (const job of nomoreExistJobs) {
-            this.logger.info(`Removing stale job: ${job.jobName} of id: ${job.id}`);
-            await this.removeJob(job.id);
+            if (job.id) {
+                this.logger.info(`Removing stale job: ${job.jobName} of id: ${job.id}`);
+                await this.removeJob(job.id);
+            }
         }
         if (nomoreExistJobs.length) {
             this.logger.info(`Cleaned up: ${nomoreExistJobs.length} stale jobs`);
@@ -184,6 +186,6 @@ let AwsJobScheduler = class AwsJobScheduler extends AbstractJobScheduler {
 AwsJobScheduler = __decorate([
     LogContext(),
     __metadata("design:paramtypes", [AbstractLogger,
-        AbstractDbAdapter, Function, String, Object, Object])
+        AbstractDbAdapter, Function, String, String, Object])
 ], AwsJobScheduler);
 export { AwsJobScheduler };

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@clairejs/server",
-    "version": "3.22.9",
+    "version": "3.22.10",
     "description": "Claire server NodeJs framework written in Typescript.",
     "types": "dist/index.d.ts",
     "main": "dist/index.js",