@ckeditor/ckeditor5-utils 35.1.0 → 35.2.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-utils",
-  "version": "35.1.0",
+  "version": "35.2.0",
   "description": "Miscellaneous utilities used by CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -14,10 +14,10 @@
     "lodash-es": "^4.17.15"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-build-classic": "^35.1.0",
-    "@ckeditor/ckeditor5-editor-classic": "^35.1.0",
-    "@ckeditor/ckeditor5-core": "^35.1.0",
-    "@ckeditor/ckeditor5-engine": "^35.1.0",
+    "@ckeditor/ckeditor5-build-classic": "^35.2.0",
+    "@ckeditor/ckeditor5-editor-classic": "^35.2.0",
+    "@ckeditor/ckeditor5-core": "^35.2.0",
+    "@ckeditor/ckeditor5-engine": "^35.2.0",
     "@types/lodash-es": "^4.17.6",
     "typescript": "^4.6.4"
   },

package/src/dom/rect.js

@@ -9,7 +9,6 @@ import isRange from './isrange';
 import isWindow from './iswindow';
 import getBorderWidths from './getborderwidths';
 import isText from './istext';
-import { isElement } from 'lodash-es';
 const rectProperties = ['top', 'right', 'bottom', 'left', 'width', 'height'];
 /**
  * A helper class representing a `ClientRect` object, e.g. value returned by
@@ -352,13 +351,13 @@ function isBody(value) {
     }
     return value === value.ownerDocument.body;
 }
-// Checks if provided object is a DOM Element.
-//
-// It's just a wrapper for lodash `isElement` but with type guard.
+// Checks if provided object "looks like" a DOM Element and has API required by `Rect` class.
 //
 // @private
 // @param {*} value
 // @returns {Boolean}
 function isDomElement(value) {
-    return isElement(value);
+    // Note: earlier we used `isElement()` from lodash library, however that function is less performant because
+    // it makes complicated checks to make sure that given value is a DOM element.
+    return value !== null && typeof value === 'object' && value.nodeType === 1 && typeof value.getBoundingClientRect === 'function';
 }

package/src/keystrokehandler.js

@@ -71,7 +71,7 @@ export default class KeystrokeHandler {
      * the {@link module:utils/keyboard~parseKeystroke} function.
      * @param {Function} callback A function called with the
      * {@link module:engine/view/observer/keyobserver~KeyEventData key event data} object and
-     * a helper funcion to call both `preventDefault()` and `stopPropagation()` on the underlying event.
+     * a helper function to call both `preventDefault()` and `stopPropagation()` on the underlying event.
      * @param {Object} [options={}] Additional options.
      * @param {module:utils/priorities~PriorityString|Number} [options.priority='normal'] The priority of the keystroke
      * callback. The higher the priority value the sooner the callback will be executed. Keystrokes having the same priority

package/src/splicearray.js

@@ -0,0 +1,39 @@
+/**
+ * @license Copyright (c) 2003-2022, CKSource Holding sp. z o.o. All rights reserved.
+ * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license
+ */
+/**
+ * @module utils/splicearray
+ */
+const BIG_CHUNK_SIZE = 10000;
+/**
+ * Splices one array into another. To be used instead of `Array.prototype.splice` as the latter may
+ * throw "Maximum call stack size exceeded" when passed huge number of items to insert.
+ *
+ * Note: in contrary to Array.splice, this function does not modify the original `target`.
+ *
+ * 		spliceArray( [ 1, 2 ], [ 3, 4 ], 0, 0 );		// [ 3, 4, 1, 2 ]
+ * 		spliceArray( [ 1, 2 ], [ 3, 4 ], 1, 1 );		// [ 1, 3, 4 ]
+ * 		spliceArray( [ 1, 2 ], [ 3, 4 ], 1, 0 );		// [ 1, 3, 4, 2 ]
+ * 		spliceArray( [ 1, 2 ], [ 3, 4 ], 2, 0 );		// [ 1, 2, 3, 4 ]
+ * 		spliceArray( [ 1, 2 ], [], 0, 1 );				// [ 2 ]
+ *
+ * @private
+ * @param {Array} target Array to be spliced.
+ * @param {Array} source Array of elements to be inserted to target.
+ * @param {Number} start Index at which nodes should be inserted/removed.
+ * @param {Number} count Number of items.
+ *
+ * @returns {Array} New spliced array.
+ */
+export default function spliceArray(target, source, start, count) {
+    // In case of performance problems, see: https://github.com/ckeditor/ckeditor5/pull/12429/files#r965850568
+    if (Math.max(source.length, target.length) > BIG_CHUNK_SIZE) {
+        return target.slice(0, start).concat(source).concat(target.slice(start + count, target.length));
+    }
+    else {
+        const newTarget = Array.from(target);
+        newTarget.splice(start, count, ...source);
+        return newTarget;
+    }
+}

package/src/version.js

@@ -7,7 +7,7 @@
  */
 /* globals window, global */
 import CKEditorError from './ckeditorerror';
-const version = '35.1.0';
+const version = '35.2.0';
 export default version;
 /* istanbul ignore next */
 const windowOrGlobal = typeof window === 'object' ? window : global;