@ckeditor/ckeditor5-theme-lark 43.1.0-alpha.5 → 43.1.0-alpha.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@ckeditor/ckeditor5-theme-lark",
3
- "version": "43.1.0-alpha.5",
3
+ "version": "43.1.0-alpha.6",
4
4
  "description": "A bright theme for CKEditor 5.",
5
5
  "keywords": [
6
6
  "ckeditor",
@@ -9,7 +9,7 @@
9
9
  "ckeditor5-theme"
10
10
  ],
11
11
  "dependencies": {
12
- "@ckeditor/ckeditor5-ui": "43.1.0-alpha.5"
12
+ "@ckeditor/ckeditor5-ui": "43.1.0-alpha.6"
13
13
  },
14
14
  "author": "CKSource (http://cksource.com/)",
15
15
  "license": "GPL-2.0-or-later",
@@ -10,15 +10,16 @@
10
10
  .ck-widget.table {
11
11
  & td,
12
12
  & th {
13
+ /**
14
+ * While setting outline is fine, the border should not be modified here
15
+ * because it overrides the default table cell border color which is not expected.
16
+ * So do not use `@mixin ck-focus-ring;` here, or any other border styles.
17
+ * See more: https://github.com/ckeditor/ckeditor5/issues/16979
18
+ */
13
19
  &.ck-editor__nested-editable.ck-editor__nested-editable_focused,
14
20
  &.ck-editor__nested-editable:focus {
15
21
  /* A very slight background to highlight the focused cell */
16
22
  background: var(--ck-color-selector-focused-cell-background);
17
-
18
- /* Fixes the problem where surrounding cells cover the focused cell's border.
19
- It does not fix the problem in all places but the UX is improved.
20
- See https://github.com/ckeditor/ckeditor5-table/issues/29. */
21
- border-style: none;
22
23
  outline: 1px solid var(--ck-color-focus-border);
23
24
  outline-offset: -1px; /* progressive enhancement - no IE support */
24
25
  }
@@ -46,11 +46,19 @@
46
46
  These styles show a different border for a blink of an eye, so `:focus` need to have same styles applied. */
47
47
  &.ck-editor__nested-editable_focused,
48
48
  &:focus {
49
- @mixin ck-focus-ring;
50
49
  @mixin ck-box-shadow var(--ck-inner-shadow);
51
50
  @mixin ck-media-default-colors {
52
51
  background-color: var(--ck-color-widget-editable-focus-background);
53
52
  }
53
+
54
+ /**
55
+ * Focus border should not be applied to table cells because it overrides the default table cell border color.
56
+ * In other words - in some scenarios, the part of the table cell border has focus color style, which is not expected behavior
57
+ * because it should be the same as the table cell border color.
58
+ */
59
+ &:not(td, th) {
60
+ @mixin ck-focus-ring;
61
+ }
54
62
  }
55
63
  }
56
64