@ckeditor/ckeditor5-restricted-editing 0.0.0-nightly-20240428.0 → 0.0.0-nightly-20240430.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-restricted-editing",
-  "version": "0.0.0-nightly-20240428.0",
+  "version": "0.0.0-nightly-20240430.0",
   "description": "Restricted editing feature for CKEditor 5 editors.",
   "keywords": [
     "ckeditor",
@@ -12,7 +12,7 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "ckeditor5": "0.0.0-nightly-20240428.0"
+    "ckeditor5": "0.0.0-nightly-20240430.0"
   },
   "author": "CKSource (http://cksource.com/)",
   "license": "GPL-2.0-or-later",

package/src/restrictededitingmodeediting.js

@@ -108,8 +108,43 @@ export default class RestrictedEditingModeEditing extends Plugin {
             }
         }));
         // Currently the marker helpers are tied to other use-cases and do not render a collapsed marker as highlight.
-        // That's why there are 2 downcast converters for them:
-        // 1. The default marker-to-highlight will wrap selected text with `<span>`.
+        // Also, markerToHighlight can not convert marker on an inline object. It handles only text and widgets,
+        // but it is not a case in the data pipeline. That's why there are 3 downcast converters for them:
+        //
+        // 1. The custom inline item (text or inline object) converter (but not the selection).
+        editor.conversion.for('downcast').add(dispatcher => {
+            dispatcher.on('addMarker:restrictedEditingException', (evt, data, conversionApi) => {
+                // Only convert per-item conversion.
+                if (!data.item) {
+                    return;
+                }
+                // Do not convert the selection or non-inline items.
+                if (data.item.is('selection') || !conversionApi.schema.isInline(data.item)) {
+                    return;
+                }
+                if (!conversionApi.consumable.consume(data.item, evt.name)) {
+                    return;
+                }
+                const viewWriter = conversionApi.writer;
+                const viewElement = viewWriter.createAttributeElement('span', {
+                    class: 'restricted-editing-exception'
+                }, {
+                    id: data.markerName,
+                    priority: -10
+                });
+                const viewRange = conversionApi.mapper.toViewRange(data.range);
+                const rangeAfterWrap = viewWriter.wrap(viewRange, viewElement);
+                for (const element of rangeAfterWrap.getItems()) {
+                    if (element.is('attributeElement') && element.isSimilar(viewElement)) {
+                        conversionApi.mapper.bindElementToMarker(element, data.markerName);
+                        // One attribute element is enough, because all of them are bound together by the view writer.
+                        // Mapper uses this binding to get all the elements no matter how many of them are registered in the mapper.
+                        break;
+                    }
+                }
+            });
+        });
+        // 2. The marker-to-highlight converter for the document selection.
         editor.conversion.for('downcast').markerToHighlight({
             model: 'restrictedEditingException',
             // Use callback to return new object every time new marker instance is created - otherwise it will be seen as the same marker.
@@ -121,8 +156,8 @@ export default class RestrictedEditingModeEditing extends Plugin {
                 };
             }
         });
-        // 2. But for collapsed marker we need to render it as an element.
-        // Additionally the editing pipeline should always display a collapsed marker.
+        // 3. And for collapsed marker we need to render it as an element.
+        // Additionally, the editing pipeline should always display a collapsed marker.
         editor.conversion.for('editingDowncast').markerToElement({
             model: 'restrictedEditingException',
             view: (markerData, { writer }) => {