@ckeditor/ckeditor5-paragraph 37.0.1 → 38.0.0-rc.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-paragraph",
-  "version": "37.0.1",
+  "version": "38.0.0-rc.0",
   "description": "Paragraph feature for CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -12,20 +12,20 @@
   ],
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-core": "^37.0.1",
-    "@ckeditor/ckeditor5-ui": "^37.0.1",
-    "@ckeditor/ckeditor5-utils": "^37.0.1"
+    "@ckeditor/ckeditor5-core": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-ui": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-utils": "^38.0.0-rc.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^37.0.1",
-    "@ckeditor/ckeditor5-clipboard": "^37.0.1",
-    "@ckeditor/ckeditor5-editor-classic": "^37.0.1",
-    "@ckeditor/ckeditor5-engine": "^37.0.1",
-    "@ckeditor/ckeditor5-enter": "^37.0.1",
-    "@ckeditor/ckeditor5-heading": "^37.0.1",
-    "@ckeditor/ckeditor5-link": "^37.0.1",
-    "@ckeditor/ckeditor5-typing": "^37.0.1",
-    "@ckeditor/ckeditor5-undo": "^37.0.1",
+    "@ckeditor/ckeditor5-basic-styles": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-clipboard": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-editor-classic": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-engine": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-enter": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-heading": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-link": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-typing": "^38.0.0-rc.0",
+    "@ckeditor/ckeditor5-undo": "^38.0.0-rc.0",
     "typescript": "^4.8.4",
     "webpack": "^5.58.1",
     "webpack-cli": "^4.9.0"

package/src/insertparagraphcommand.d.ts

@@ -5,7 +5,7 @@
 /**
  * @module paragraph/insertparagraphcommand
  */
-import { Command } from '@ckeditor/ckeditor5-core';
+import { Command, type Editor } from '@ckeditor/ckeditor5-core';
 import type { Position } from '@ckeditor/ckeditor5-engine';
 /**
  * The insert paragraph command. It inserts a new paragraph at a specific
@@ -25,6 +25,7 @@ import type { Position } from '@ckeditor/ckeditor5-engine';
  * **Note**: This command moves the selection to the inserted paragraph.
  */
 export default class InsertParagraphCommand extends Command {
+    constructor(editor: Editor);
     /**
      * Executes the command.
      *

package/src/insertparagraphcommand.js

@@ -24,6 +24,11 @@ import { Command } from '@ckeditor/ckeditor5-core';
  * **Note**: This command moves the selection to the inserted paragraph.
  */
 export default class InsertParagraphCommand extends Command {
+    constructor(editor) {
+        super(editor);
+        // Since this command passes position in execution block instead of selection, it should be checked directly.
+        this._isEnabledBasedOnSelection = false;
+    }
     /**
      * Executes the command.
      *
@@ -36,6 +41,10 @@ export default class InsertParagraphCommand extends Command {
         const model = this.editor.model;
         const attributes = options.attributes;
         let position = options.position;
+        // Don't execute command if position is in non-editable place.
+        if (!model.canEditAt(position)) {
+            return;
+        }
         model.change(writer => {
             const paragraph = writer.createElement('paragraph');
             if (attributes) {

package/src/paragraphcommand.d.ts

@@ -5,12 +5,13 @@
 /**
  * @module paragraph/paragraphcommand
  */
-import { Command } from '@ckeditor/ckeditor5-core';
+import { Command, type Editor } from '@ckeditor/ckeditor5-core';
 import type { Selection, DocumentSelection } from '@ckeditor/ckeditor5-engine';
 /**
  * The paragraph command.
  */
 export default class ParagraphCommand extends Command {
+    constructor(editor: Editor);
     /**
      * The value of the command. Indicates whether the selection start is placed in a paragraph.
      *

package/src/paragraphcommand.js

@@ -11,6 +11,11 @@ import { first } from '@ckeditor/ckeditor5-utils';
  * The paragraph command.
  */
 export default class ParagraphCommand extends Command {
+    constructor(editor) {
+        super(editor);
+        // Since this command may pass selection in execution block, it should be checked directly.
+        this._isEnabledBasedOnSelection = false;
+    }
     /**
      * @inheritDoc
      */
@@ -33,8 +38,13 @@ export default class ParagraphCommand extends Command {
     execute(options = {}) {
         const model = this.editor.model;
         const document = model.document;
+        const selection = options.selection || document.selection;
+        // Don't execute command if selection is in non-editable place.
+        if (!model.canEditAt(selection)) {
+            return;
+        }
         model.change(writer => {
-            const blocks = (options.selection || document.selection).getSelectedBlocks();
+            const blocks = selection.getSelectedBlocks();
             for (const block of blocks) {
                 if (!block.is('element', 'paragraph') && checkCanBecomeParagraph(block, model.schema)) {
                     writer.rename(block, 'paragraph');