@ckeditor/ckeditor5-list 47.2.0 → 47.3.0-alpha.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-list",
-  "version": "47.2.0",
+  "version": "47.3.0-alpha.0",
   "description": "Ordered and unordered lists feature to CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -13,16 +13,16 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-clipboard": "47.2.0",
-    "@ckeditor/ckeditor5-core": "47.2.0",
-    "@ckeditor/ckeditor5-engine": "47.2.0",
-    "@ckeditor/ckeditor5-enter": "47.2.0",
-    "@ckeditor/ckeditor5-font": "47.2.0",
-    "@ckeditor/ckeditor5-icons": "47.2.0",
-    "@ckeditor/ckeditor5-typing": "47.2.0",
-    "@ckeditor/ckeditor5-ui": "47.2.0",
-    "@ckeditor/ckeditor5-utils": "47.2.0",
-    "ckeditor5": "47.2.0"
+    "@ckeditor/ckeditor5-clipboard": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-core": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-engine": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-enter": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-font": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-icons": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-typing": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-ui": "47.3.0-alpha.0",
+    "@ckeditor/ckeditor5-utils": "47.3.0-alpha.0",
+    "ckeditor5": "47.3.0-alpha.0"
   },
   "author": "CKSource (http://cksource.com/)",
   "license": "SEE LICENSE IN LICENSE.md",

package/src/list/converters.js

@@ -239,7 +239,7 @@ export function reconvertItemsOnDataChange(model, editing, attributeNames, listE
  * @param model The model.
  */
 export function listItemDowncastConverter(attributeNames, strategies, model, { dataPipeline } = {}) {
-    const consumer = createAttributesConsumer(attributeNames);
+    const consumer = createAttributesConsumer(attributeNames, strategies);
     return (evt, data, conversionApi) => {
         const { writer, mapper, consumable } = conversionApi;
         const listItem = data.item;
@@ -478,7 +478,7 @@ function wrapListItemBlock(listItem, viewRange, strategies, writer, options) {
         for (const strategy of strategies) {
             if ((strategy.scope == 'list' || strategy.scope == 'item') &&
                 currentListItem.hasAttribute(strategy.attributeName)) {
-                strategy.setAttributeOnDowncast(writer, currentListItem.getAttribute(strategy.attributeName), strategy.scope == 'list' ? listViewElement : listItemViewElement, options);
+                strategy.setAttributeOnDowncast(writer, currentListItem.getAttribute(strategy.attributeName), strategy.scope == 'list' ? listViewElement : listItemViewElement, options, currentListItem);
             }
         }
         viewRange = writer.wrap(viewRange, listItemViewElement);
@@ -495,12 +495,15 @@ function wrapListItemBlock(listItem, viewRange, strategies, writer, options) {
     }
 }
 // Returns the function that is responsible for consuming attributes that are set on the model node.
-function createAttributesConsumer(attributeNames) {
+function createAttributesConsumer(attributeNames, strategies) {
+    const nonConsumingAttributes = strategies
+        .filter(strategy => strategy.consume === false)
+        .map(strategy => strategy.attributeName);
     return (node, consumable) => {
         const events = [];
         // Collect all set attributes that are triggering conversion.
         for (const attributeName of attributeNames) {
-            if (node.hasAttribute(attributeName)) {
+            if (node.hasAttribute(attributeName) && !nonConsumingAttributes.includes(attributeName)) {
                 events.push(`attribute:${attributeName}`);
             }
         }

package/src/list/listediting.d.ts

@@ -119,10 +119,16 @@ export interface ListAttributeDowncastStrategy {
      * The model attribute name.
      */
     attributeName: string;
+    /**
+     * Whether the attribute should be consumed or this strategy is a side effect.
+     *
+     * @default true
+     */
+    consume?: boolean;
     /**
      * Sets the property on the view element.
      */
-    setAttributeOnDowncast(writer: ViewDowncastWriter, value: unknown, element: ViewElement, options?: Record<string, unknown>): void;
+    setAttributeOnDowncast(writer: ViewDowncastWriter, value: unknown, element: ViewElement, options: Record<string, unknown>, modelElement: ModelElement): void;
 }
 /**
  * The custom marker downcast strategy.
@@ -136,6 +142,12 @@ export interface ListItemMarkerDowncastStrategy {
      * The model attribute name.
      */
     attributeName: string;
+    /**
+     * Whether the attribute should be consumed or this strategy is a side effect.
+     *
+     * @default true
+     */
+    consume?: boolean;
     /**
      * Creates a view element for a custom item marker.
      */