@ckeditor/ckeditor5-link 45.0.0-alpha.5 → 45.0.0-alpha.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-link",
-  "version": "45.0.0-alpha.5",
+  "version": "45.0.0-alpha.7",
   "description": "Link feature for CKEditor 5.",
   "keywords": [
     "ckeditor",
@@ -13,16 +13,16 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-clipboard": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-core": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-engine": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-icons": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-image": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-typing": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-ui": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-utils": "45.0.0-alpha.5",
-    "@ckeditor/ckeditor5-widget": "45.0.0-alpha.5",
-    "ckeditor5": "45.0.0-alpha.5",
+    "@ckeditor/ckeditor5-clipboard": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-core": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-engine": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-icons": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-image": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-typing": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-ui": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-utils": "45.0.0-alpha.7",
+    "@ckeditor/ckeditor5-widget": "45.0.0-alpha.7",
+    "ckeditor5": "45.0.0-alpha.7",
     "es-toolkit": "1.32.0"
   },
   "author": "CKSource (http://cksource.com/)",

package/src/linkimageediting.js

@@ -198,6 +198,20 @@ function downcastImageLinkManualDecorator(decorator) {
             if (!linkInImage) {
                 return;
             }
+            // Handle deactivated manual decorator.
+            if (decorator.value === undefined) {
+                for (const key in decorator.attributes) {
+                    conversionApi.writer.removeAttribute(key, linkInImage);
+                }
+                if (decorator.classes) {
+                    conversionApi.writer.removeClass(decorator.classes, linkInImage);
+                }
+                for (const key in decorator.styles) {
+                    conversionApi.writer.removeStyle(key, linkInImage);
+                }
+                return;
+            }
+            // Handle activated manual decorator.
             for (const [key, val] of toMap(decorator.attributes)) {
                 conversionApi.writer.setAttribute(key, val, linkInImage);
             }

package/src/linkui.js

@@ -498,6 +498,7 @@ export default class LinkUI extends Plugin {
         view.bind('isOn').to(command, 'value', value => !!value);
         // Show the panel on button click.
         this.listenTo(view, 'execute', () => {
+            editor.editing.view.scrollToTheSelection();
             this._showUI(true);
             // Open the form view on-top of the toolbar view if it's already visible.
             // It should be visible every time the link is selected.
@@ -528,6 +529,7 @@ export default class LinkUI extends Plugin {
             // Prevent focusing the search bar in FF, Chrome and Edge. See https://github.com/ckeditor/ckeditor5/issues/4811.
             cancel();
             if (editor.commands.get('link').isEnabled) {
+                editor.editing.view.scrollToTheSelection();
                 this._showUI(true);
             }
         });
@@ -561,7 +563,13 @@ export default class LinkUI extends Plugin {
             emitter: this.formView,
             activator: () => this._isUIInPanel,
             contextElements: () => [this._balloon.view.element],
-            callback: () => this._hideUI()
+            callback: () => {
+                // Focusing on the editable during a click outside the balloon panel might
+                // cause the selection to move to the beginning of the editable, so we avoid
+                // focusing on it during this action.
+                // See: https://github.com/ckeditor/ckeditor5/issues/18253
+                this._hideUI(false);
+            }
         });
     }
     /**
@@ -690,7 +698,7 @@ export default class LinkUI extends Plugin {
     /**
      * Removes the {@link #formView} from the {@link #_balloon}.
      */
-    _removeFormView() {
+    _removeFormView(updateFocus = true) {
         if (this._isFormInPanel) {
             // Blur the input element before removing it from DOM to prevent issues in some browsers.
             // See https://github.com/ckeditor/ckeditor5/issues/1501.
@@ -701,7 +709,9 @@ export default class LinkUI extends Plugin {
             this._balloon.remove(this.formView);
             // Because the form has an input which has focus, the focus must be brought back
             // to the editor. Otherwise, it would be lost.
-            this.editor.editing.view.focus();
+            if (updateFocus) {
+                this.editor.editing.view.focus();
+            }
             this._hideFakeVisualSelection();
         }
     }
@@ -766,7 +776,7 @@ export default class LinkUI extends Plugin {
         // If the properties form view is visible, remove it because it can be on top of the stack.
         this._removePropertiesView();
         // Then remove the form view because it's beneath the properties form.
-        this._removeFormView();
+        this._removeFormView(updateFocus);
         // Finally, remove the link toolbar view because it's last in the stack.
         if (this._isToolbarInPanel) {
             this._balloon.remove(this.toolbarView);