@ckeditor/ckeditor5-link 42.0.2 → 43.0.0-alpha.0

package/dist/index.js

@@ -1366,12 +1366,16 @@ const VISUAL_SELECTION_MARKER_NAME = 'link-ui';
         // Renders a fake visual selection marker on a collapsed selection.
         editor.conversion.for('editingDowncast').markerToElement({
             model: VISUAL_SELECTION_MARKER_NAME,
-            view: {
-                name: 'span',
-                classes: [
+            view: (data, { writer })=>{
+                if (!data.markerRange.isCollapsed) {
+                    return null;
+                }
+                const markerElement = writer.createUIElement('span');
+                writer.addClass([
                     'ck-fake-link-selection',
                     'ck-fake-link-selection_collapsed'
-                ]
+                ], markerElement);
+                return markerElement;
             }
         });
         // Add the information about the keystrokes to the accessibility database.
@@ -1489,18 +1493,19 @@ const VISUAL_SELECTION_MARKER_NAME = 'link-ui';
 	 * a {@link #_balloon} attached to the selection.
 	 */ _createToolbarLinkButton() {
         const editor = this.editor;
-        const linkCommand = editor.commands.get('link');
         editor.ui.componentFactory.add('link', ()=>{
             const button = this._createButton(ButtonView);
             button.set({
-                tooltip: true,
-                isToggleable: true
+                tooltip: true
             });
-            button.bind('isOn').to(linkCommand, 'value', (value)=>!!value);
             return button;
         });
         editor.ui.componentFactory.add('menuBar:link', ()=>{
-            return this._createButton(MenuBarMenuListItemButtonView);
+            const button = this._createButton(MenuBarMenuListItemButtonView);
+            button.set({
+                role: 'menuitemcheckbox'
+            });
+            return button;
         });
     }
     /**
@@ -1514,9 +1519,11 @@ const VISUAL_SELECTION_MARKER_NAME = 'link-ui';
         view.set({
             label: t('Link'),
             icon: linkIcon,
-            keystroke: LINK_KEYSTROKE
+            keystroke: LINK_KEYSTROKE,
+            isToggleable: true
         });
         view.bind('isEnabled').to(command, 'isEnabled');
+        view.bind('isOn').to(command, 'value', (value)=>!!value);
         // Show the panel on button click.
         this.listenTo(view, 'execute', ()=>this._showUI(true));
         return view;