@ckeditor/ckeditor5-engine 47.7.1-alpha.0 → 47.7.2-alpha.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ckeditor/ckeditor5-engine",
-  "version": "47.7.1-alpha.0",
+  "version": "47.7.2-alpha.0",
   "description": "The editing engine of CKEditor 5 – the best browser-based rich text editor.",
   "keywords": [
     "wysiwyg",
@@ -24,7 +24,7 @@
   "type": "module",
   "main": "src/index.js",
   "dependencies": {
-    "@ckeditor/ckeditor5-utils": "47.7.1-alpha.0",
+    "@ckeditor/ckeditor5-utils": "47.7.2-alpha.0",
     "es-toolkit": "1.39.5"
   },
   "author": "CKSource (http://cksource.com/)",

package/src/conversion/downcasthelpers.js

@@ -1332,7 +1332,8 @@ function changeAttribute(attributeCreator) {
         const viewElement = conversionApi.mapper.toViewElement(data.item);
         const viewWriter = conversionApi.writer;
         // If model item cannot be mapped to a view element, it means item is not an `Element` instance but a `ModelTextProxy` node.
-        // Only elements can have attributes in a view so do not proceed for anything else (#1587).
+        // Only elements can have attributes in a view so do not proceed for anything else.
+        // See https://github.com/ckeditor/ckeditor5-engine/issues/1587.
         if (!viewElement) {
             /**
              * This error occurs when a {@link module:engine/model/textproxy~ModelTextProxy text node's} attribute is to be downcasted

package/src/conversion/upcasthelpers.js

@@ -914,7 +914,7 @@ function setAttributeOn(modelRange, modelAttribute, shallow, conversionApi) {
             continue;
         }
         // Mark the node as consumed even if the attribute will not be updated because it's in a valid context (schema)
-        // and would be converted if the attribute wouldn't be present. See #8921.
+        // and would be converted if the attribute wouldn't be present. See https://github.com/ckeditor/ckeditor5/issues/8921.
         result = true;
         // Do not override the attribute if it's already present.
         if (node.hasAttribute(modelAttribute.key)) {

package/src/model/element.js

@@ -284,7 +284,7 @@ export class ModelElement extends ModelNode {
 ModelElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'element' || type === 'model:element' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'node' || type === 'model:node';
     }
     return name === this.name && (type === 'element' || type === 'model:element');

package/src/model/liveposition.js

@@ -63,7 +63,7 @@ export class ModelLivePosition extends /* #__PURE__ */ EmitterMixin(ModelPositio
 // Proper overload would interfere with that.
 ModelLivePosition.prototype.is = function (type) {
     return type === 'livePosition' || type === 'model:livePosition' ||
-        // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+        // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
         type == 'position' || type === 'model:position';
 };
 /**

package/src/model/liverange.js

@@ -51,7 +51,7 @@ export class ModelLiveRange extends /* #__PURE__ */ EmitterMixin(ModelRange) {
 // Proper overload would interfere with that.
 ModelLiveRange.prototype.is = function (type) {
     return type === 'liveRange' || type === 'model:liveRange' ||
-        // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+        // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
         type == 'range' || type === 'model:range';
 };
 /**

package/src/model/position.js

@@ -185,7 +185,8 @@ export class ModelPosition extends ModelTypeCheckable {
      * Node directly after this position. Returns `null` if this position is at the end of its parent, or if it is in a text node.
      */
     get nodeAfter() {
-        // Cache the parent and reuse for performance reasons. See #6579 and #6582.
+        // Cache the parent and reuse for performance reasons.
+        // See https://github.com/ckeditor/ckeditor5/issues/6579 and https://github.com/ckeditor/ckeditor5/issues/6582.
         const parent = this.parent;
         return getNodeAfterPosition(this, parent, getTextNodeAtPosition(this, parent));
     }
@@ -193,7 +194,8 @@ export class ModelPosition extends ModelTypeCheckable {
      * Node directly before this position. Returns `null` if this position is at the start of its parent, or if it is in a text node.
      */
     get nodeBefore() {
-        // Cache the parent and reuse for performance reasons. See #6579 and #6582.
+        // Cache the parent and reuse for performance reasons.
+        // See https://github.com/ckeditor/ckeditor5/issues/6579 and https://github.com/ckeditor/ckeditor5/issues/6582.
         const parent = this.parent;
         return getNodeBeforePosition(this, parent, getTextNodeAtPosition(this, parent));
     }

package/src/model/rootelement.js

@@ -72,11 +72,11 @@ export class ModelRootElement extends ModelElement {
 ModelRootElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'rootElement' || type === 'model:rootElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'model:element' ||
             type === 'node' || type === 'model:node';
     }
     return name === this.name && (type === 'rootElement' || type === 'model:rootElement' ||
-        // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+        // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
         type === 'element' || type === 'model:element');
 };

package/src/model/text.js

@@ -87,6 +87,6 @@ ModelText.prototype.is = function (type) {
     return type === '$text' || type === 'model:$text' ||
         // This are legacy values kept for backward compatibility.
         type === 'text' || type === 'model:text' ||
-        // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+        // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
         type === 'node' || type === 'model:node';
 };

package/src/model/treewalker.js

@@ -193,7 +193,8 @@ export class ModelTreeWalker {
             return { done: true, value: undefined };
         }
         // Get node just after the current position.
-        // Use a highly optimized version instead of checking the text node first and then getting the node after. See #6582.
+        // Use a highly optimized version instead of checking the text node first and then getting the node after.
+        // See https://github.com/ckeditor/ckeditor5/issues/6582.
         const textNodeAtPosition = getTextNodeAtPosition(position, parent);
         const node = textNodeAtPosition || getNodeAfterPosition(position, parent, textNodeAtPosition);
         if (node && node.is('model:element')) {
@@ -256,7 +257,8 @@ export class ModelTreeWalker {
             return { done: true, value: undefined };
         }
         // Get node just before the current position.
-        // Use a highly optimized version instead of checking the text node first and then getting the node before. See #6582.
+        // Use a highly optimized version instead of checking the text node first and then getting the node before.
+        // See https://github.com/ckeditor/ckeditor5/issues/6582.
         const positionParent = position.parent;
         const textNodeAtPosition = getTextNodeAtPosition(position, positionParent);
         const node = textNodeAtPosition || getNodeBeforePosition(position, positionParent, textNodeAtPosition);

package/src/view/attributeelement.js

@@ -178,13 +178,13 @@ export class ViewAttributeElement extends ViewElement {
 ViewAttributeElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'attributeElement' || type === 'view:attributeElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';
     }
     else {
         return name === this.name && (type === 'attributeElement' || type === 'view:attributeElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element');
     }
 };

package/src/view/containerelement.js

@@ -58,13 +58,13 @@ export class ViewContainerElement extends ViewElement {
 ViewContainerElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'containerElement' || type === 'view:containerElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';
     }
     else {
         return name === this.name && (type === 'containerElement' || type === 'view:containerElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element');
     }
 };
@@ -76,7 +76,8 @@ ViewContainerElement.prototype.is = function (type, name) {
 export function getViewFillerOffset() {
     const children = [...this.getChildren()];
     const lastChild = children[this.childCount - 1];
-    // Block filler is required after a `<br>` if it's the last element in its container. See #1422.
+    // Block filler is required after a `<br>` if it's the last element in its container.
+    // See https://github.com/ckeditor/ckeditor5-engine/issues/1422.
     if (lastChild && lastChild.is('element', 'br')) {
         return this.childCount;
     }

package/src/view/domconverter.js

@@ -305,7 +305,7 @@ export class ViewDomConverter {
                     domElement = this._domDocument.createComment(viewElementOrFragment.getCustomProperty('$rawContent'));
                 }
                 else {
-                    // UIElement has its own render() method (see #799).
+                    // UIElement has its own render() method (see https://github.com/ckeditor/ckeditor5/issues/799).
                     domElement = viewElementOrFragment.render(this._domDocument, this);
                 }
                 if (options.bind) {
@@ -1219,7 +1219,8 @@ export class ViewDomConverter {
                 // Change all consecutive whitespace characters (from the [ \n\t\r] set –
                 // see https://github.com/ckeditor/ckeditor5-engine/issues/822#issuecomment-311670249) to a single space character.
                 // That's how multiple whitespaces are treated when rendered, so we normalize those whitespaces.
-                // We're replacing 1+ (and not 2+) to also normalize singular \n\t\r characters (#822).
+                // We're replacing 1+ (and not 2+) to also normalize singular \n\t\r characters.
+                // See https://github.com/ckeditor/ckeditor5/issues/822.
                 data = node.data.replace(/[ \n\t\r]{1,}/g, ' ');
                 nodeEndsWithSpace = /[^\S\u00A0]/.test(data.charAt(data.length - 1));
                 const prevNode = i > 0 ? inlineNodes[i - 1] : null;
@@ -1241,7 +1242,8 @@ export class ViewDomConverter {
                 // At the beginning and end of a block element, Firefox inserts normal space + <br> instead of non-breaking space.
                 // This means that the text node starts/end with normal space instead of non-breaking space.
                 // This causes a problem because the normal space would be removed in `.replace` calls above. To prevent that,
-                // the inline filler is removed only after the data is initially processed (by the `.replace` above). See ckeditor5#692.
+                // the inline filler is removed only after the data is initially processed (by the `.replace` above).
+                // See https://github.com/ckeditor/ckeditor5/issues/692.
                 data = getDataWithoutFiller(data);
                 // Block filler handling.
                 if (this.blockFillerMode != 'br' && node.parent) {

package/src/view/editableelement.js

@@ -60,14 +60,14 @@ export class ViewEditableElement extends /* #__PURE__ */ ObservableMixin(ViewCon
 ViewEditableElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'editableElement' || type === 'view:editableElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'containerElement' || type === 'view:containerElement' ||
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';
     }
     else {
         return name === this.name && (type === 'editableElement' || type === 'view:editableElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'containerElement' || type === 'view:containerElement' ||
             type === 'element' || type === 'view:element');
     }

package/src/view/element.js

@@ -1007,7 +1007,7 @@ export class ViewElement extends ViewNode {
 ViewElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'element' || type === 'view:element' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'node' || type === 'view:node';
     }
     else {

package/src/view/emptyelement.js

@@ -66,7 +66,7 @@ export class ViewEmptyElement extends ViewElement {
 ViewEmptyElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'emptyElement' || type === 'view:emptyElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';
     }

package/src/view/observer/mutationobserver.js

@@ -168,7 +168,8 @@ export class MutationObserver extends Observer {
                 mutations.push({ type: 'children', node: viewElement });
             }
         }
-        // In case only non-relevant mutations were recorded it skips the event and force render (#5600).
+        // In case only non-relevant mutations were recorded it skips the event and force render.
+        // See https://github.com/ckeditor/ckeditor5/issues/5600.
         if (mutations.length) {
             // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
             // @if CK_DEBUG_TYPING // 	_debouncedLine();

package/src/view/observer/selectionobserver.js

@@ -251,7 +251,7 @@ export class SelectionObserver extends Observer {
         if (this.selection.isEqual(newViewSelection) && this.domConverter.isDomSelectionCorrect(domSelection)) {
             return;
         }
-        // Ensure we are not in the infinite loop (#400).
+        // Ensure we are not in the infinite loop (https://github.com/ckeditor/ckeditor5-engine/issues/400).
         // This counter is reset each second. 60 selection changes in 1 second is enough high number
         // to be very difficult (impossible) to achieve using just keyboard keys (during normal editor use).
         if (++this._loopbackCounter > 60) {

package/src/view/rawelement.js

@@ -97,7 +97,7 @@ export class ViewRawElement extends ViewElement {
 ViewRawElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'rawElement' || type === 'view:rawElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === this.name || type === 'view:' + this.name ||
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';

package/src/view/renderer.js

@@ -276,7 +276,8 @@ export class ViewRenderer extends /* #__PURE__ */ ObservableMixin() {
                     const insertIndex = counter.equal + counter.insert;
                     const deleteIndex = counter.equal + counter.delete;
                     const viewChild = viewElement.getChild(insertIndex);
-                    // UIElement and RawElement are special cases. Their children are not stored in a view (#799)
+                    // UIElement and RawElement are special cases. Their children are not stored in a view.
+                    // See https://github.com/ckeditor/ckeditor5/issues/799.
                     // so we cannot use them with replacing flow (since they use view children during rendering
                     // which will always result in rendering empty elements).
                     if (viewChild && !viewChild.is('uiElement') && !viewChild.is('rawElement')) {
@@ -306,12 +307,13 @@ export class ViewRenderer extends /* #__PURE__ */ ObservableMixin() {
         // Because we replace new view element mapping with the existing one, the corresponding DOM element
         // will not be rerendered. The new view element may have different attributes than the previous one.
         // Since its corresponding DOM element will not be rerendered, new attributes will not be added
-        // to the DOM, so we need to mark it here to make sure its attributes gets updated. See #1427 for more
-        // detailed case study.
+        // to the DOM, so we need to mark it here to make sure its attributes gets updated.
+        // See https://github.com/ckeditor/ckeditor5-engine/issues/1427 for more detailed case study.
         // Also there are cases where replaced element is removed from the view structure and then has
         // its attributes changed or removed. In such cases the element will not be present in `markedAttributes`
         // and also may be the same (`element.isSimilar()`) as the reused element not having its attributes updated.
-        // To prevent such situations we always mark reused element to have its attributes rerenderd (#1560).
+        // To prevent such situations we always mark reused element to have its attributes rerenderd.
+        // See https://github.com/ckeditor/ckeditor5-engine/issues/1560.
         this.markedAttributes.add(viewElement);
     }
     /**
@@ -610,7 +612,8 @@ export class ViewRenderer extends /* #__PURE__ */ ObservableMixin() {
                 i++;
             }
             else if (action === 'equal') {
-                // Force updating text nodes inside elements which did not change and do not need to be re-rendered (#1125).
+                // Force updating text nodes inside elements which did not change and do not need to be re-rendered.
+                // See https://github.com/ckeditor/ckeditor5-engine/issues/1125.
                 // Do it here (not in the loop above) because only after insertions the `i` index is correct.
                 this._markDescendantTextToSync(this.domConverter.domToView(expectedDomChildren[i]));
                 i++;

package/src/view/rooteditableelement.js

@@ -62,7 +62,7 @@ export class ViewRootEditableElement extends ViewEditableElement {
 ViewRootEditableElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'rootElement' || type === 'view:rootElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'editableElement' || type === 'view:editableElement' ||
             type === 'containerElement' || type === 'view:containerElement' ||
             type === 'element' || type === 'view:element' ||
@@ -70,7 +70,7 @@ ViewRootEditableElement.prototype.is = function (type, name) {
     }
     else {
         return name === this.name && (type === 'rootElement' || type === 'view:rootElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'editableElement' || type === 'view:editableElement' ||
             type === 'containerElement' || type === 'view:containerElement' ||
             type === 'element' || type === 'view:element');

package/src/view/text.js

@@ -105,6 +105,6 @@ ViewText.prototype.is = function (type) {
     return type === '$text' || type === 'view:$text' ||
         // This are legacy values kept for backward compatibility.
         type === 'text' || type === 'view:text' ||
-        // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+        // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
         type === 'node' || type === 'view:node';
 };

package/src/view/uielement.js

@@ -116,7 +116,7 @@ export class ViewUIElement extends ViewElement {
 ViewUIElement.prototype.is = function (type, name) {
     if (!name) {
         return type === 'uiElement' || type === 'view:uiElement' ||
-            // From super.is(). This is highly utilised method and cannot call super. See ckeditor/ckeditor5#6529.
+            // From super.is(). This is highly utilised method and cannot call super. See https://github.com/ckeditor/ckeditor5/issues/6529.
             type === 'element' || type === 'view:element' ||
             type === 'node' || type === 'view:node';
     }

package/theme/placeholder.css

@@ -3,7 +3,7 @@
  * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-licensing-options
  */
 
-/* See ckeditor/ckeditor5#936. */
+/* See https://github.com/ckeditor/ckeditor5/issues/936. */
 .ck.ck-placeholder,
 .ck .ck-placeholder {
 	position: relative;
@@ -14,12 +14,12 @@
 		right: 0;
 		content: attr(data-placeholder);
 
-		/* See ckeditor/ckeditor5#469. */
+		/* See https://github.com/ckeditor/ckeditor5/issues/469. */
 		pointer-events: none;
 	}
 }
 
-/* See ckeditor/ckeditor5#1987. */
+/* See https://github.com/ckeditor/ckeditor5/issues/1987. */
 .ck.ck-read-only .ck-placeholder {
 	&::before {
 		display: none;