@ckeditor/ckeditor5-engine 45.1.0 → 45.2.0-alpha.0

package/dist/index.js

@@ -9012,15 +9012,25 @@ const validNodesToInsert = [
             this._removeFakeSelection();
             return;
         }
-        const domRoot = this.domConverter.mapViewToDom(this.selection.editableElement);
-        // Do nothing if there is no focus, or there is no DOM element corresponding to selection's editable element.
-        if (!this.isFocused || !domRoot) {
+        const domEditable = this.domConverter.mapViewToDom(this.selection.editableElement);
+        // Do not update DOM selection if there is no focus, or there is no DOM element corresponding to selection's editable element.
+        if (!this.isFocused || !domEditable) {
             // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
             // @if CK_DEBUG_TYPING // 	console.info( ..._buildLogMessage( this, 'Renderer',
             // @if CK_DEBUG_TYPING // 		'Skip updating DOM selection:',
-            // @if CK_DEBUG_TYPING // 		`isFocused: ${ this.isFocused }, hasDomRoot: ${ !!domRoot }`
+            // @if CK_DEBUG_TYPING // 		`isFocused: ${ this.isFocused }, hasDomEditable: ${ !!domEditable }`
             // @if CK_DEBUG_TYPING // 	) );
             // @if CK_DEBUG_TYPING // }
+            // But if there was a fake selection, and it is not fake anymore - remove it as it can map to no longer existing widget.
+            // See https://github.com/ckeditor/ckeditor5/issues/18123.
+            if (!this.selection.isFake && this._fakeSelectionContainer && this._fakeSelectionContainer.isConnected) {
+                // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
+                // @if CK_DEBUG_TYPING // 	console.info( ..._buildLogMessage( this, 'Renderer',
+                // @if CK_DEBUG_TYPING // 		'Remove fake selection (not focused editable)'
+                // @if CK_DEBUG_TYPING // 	) );
+                // @if CK_DEBUG_TYPING // }
+                this._removeFakeSelection();
+            }
             return;
         }
         // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
@@ -9030,31 +9040,31 @@ const validNodesToInsert = [
         // @if CK_DEBUG_TYPING // }
         // Render fake selection - create the fake selection container (if needed) and move DOM selection to it.
         if (this.selection.isFake) {
-            this._updateFakeSelection(domRoot);
+            this._updateFakeSelection(domEditable);
         } else if (this._fakeSelectionContainer && this._fakeSelectionContainer.isConnected) {
             this._removeFakeSelection();
-            this._updateDomSelection(domRoot);
+            this._updateDomSelection(domEditable);
         } else if (!(this.isComposing && env.isAndroid)) {
-            this._updateDomSelection(domRoot);
+            this._updateDomSelection(domEditable);
         }
     }
     /**
 	 * Updates the fake selection.
 	 *
-	 * @param domRoot A valid DOM root where the fake selection container should be added.
-	 */ _updateFakeSelection(domRoot) {
-        const domDocument = domRoot.ownerDocument;
+	 * @param domEditable A valid DOM editable where the fake selection container should be added.
+	 */ _updateFakeSelection(domEditable) {
+        const domDocument = domEditable.ownerDocument;
         if (!this._fakeSelectionContainer) {
             this._fakeSelectionContainer = createFakeSelectionContainer(domDocument);
         }
         const container = this._fakeSelectionContainer;
         // Bind fake selection container with the current selection *position*.
         this.domConverter.bindFakeSelection(container, this.selection);
-        if (!this._fakeSelectionNeedsUpdate(domRoot)) {
+        if (!this._fakeSelectionNeedsUpdate(domEditable)) {
             return;
         }
-        if (!container.parentElement || container.parentElement != domRoot) {
-            domRoot.appendChild(container);
+        if (!container.parentElement || container.parentElement != domEditable) {
+            domEditable.appendChild(container);
         }
         container.textContent = this.selection.fakeSelectionLabel || '\u00A0';
         // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
@@ -9071,9 +9081,9 @@ const validNodesToInsert = [
     /**
 	 * Updates the DOM selection.
 	 *
-	 * @param domRoot A valid DOM root where the DOM selection should be rendered.
-	 */ _updateDomSelection(domRoot) {
-        const domSelection = domRoot.ownerDocument.defaultView.getSelection();
+	 * @param domEditable A valid DOM editable where the DOM selection should be rendered.
+	 */ _updateDomSelection(domEditable) {
+        const domSelection = domEditable.ownerDocument.defaultView.getSelection();
         // Let's check whether DOM selection needs updating at all.
         if (!this._domSelectionNeedsUpdate(domSelection)) {
             // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
@@ -9128,13 +9138,13 @@ const validNodesToInsert = [
     /**
 	 * Checks whether the fake selection needs to be updated.
 	 *
-	 * @param domRoot A valid DOM root where a new fake selection container should be added.
-	 */ _fakeSelectionNeedsUpdate(domRoot) {
+	 * @param domEditable A valid DOM editable where a new fake selection container should be added.
+	 */ _fakeSelectionNeedsUpdate(domEditable) {
         const container = this._fakeSelectionContainer;
-        const domSelection = domRoot.ownerDocument.getSelection();
+        const domSelection = domEditable.ownerDocument.getSelection();
         // Fake selection needs to be updated if there's no fake selection container, or the container currently sits
         // in a different root.
-        if (!container || container.parentElement !== domRoot) {
+        if (!container || container.parentElement !== domEditable) {
             return true;
         }
         // Make sure that the selection actually is within the fake selection.
@@ -10265,7 +10275,7 @@ const UNSAFE_ELEMENT_REPLACEMENT_ATTRIBUTE = 'data-ck-unsafe-element';
         try {
             range.setStart(selection.anchorNode, selection.anchorOffset);
             range.setEnd(selection.focusNode, selection.focusOffset);
-        } catch (e) {
+        } catch  {
             // Safari sometimes gives us a selection that makes Range.set{Start,End} throw.
             // See https://github.com/ckeditor/ckeditor5/issues/12375.
             return false;
@@ -10853,7 +10863,7 @@ const UNSAFE_ELEMENT_REPLACEMENT_ATTRIBUTE = 'data-ck-unsafe-element';
     const container = domSelection.getRangeAt(0).startContainer;
     try {
         Object.prototype.toString.call(container);
-    } catch (error) {
+    } catch  {
         return true;
     }
     return false;
@@ -11784,8 +11794,9 @@ function sameNodes(child1, child2) {
         this.view.hasDomSelection = true;
         // Mark the latest focus change as complete (we got new selection after the focus so the selection is in the focused element).
         this.focusObserver.flush();
-        // Ignore selection change as the editable is not focused.
-        if (!this.view.document.isFocused) {
+        // Ignore selection change as the editable is not focused. Note that in read-only mode, we have to update
+        // the model selection as there won't be any focus change to flush the pending selection changes.
+        if (!this.view.document.isFocused && !this.view.document.isReadOnly) {
             // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
             // @if CK_DEBUG_TYPING // 	console.info( ..._buildLogMessage( this, 'SelectionObserver',
             // @if CK_DEBUG_TYPING // 		'Ignore selection change while editable is not focused'
@@ -12068,7 +12079,8 @@ function getFiles(nativeDataTransfer) {
                 if (viewStart && startsWithFiller(domRange.startContainer) && domRange.startOffset < INLINE_FILLER_LENGTH) {
                     // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
                     // @if CK_DEBUG_TYPING // 	console.info( ..._buildLogMessage( this, 'InputObserver',
-                    // @if CK_DEBUG_TYPING // 		'Target range starts in an inline filler - adjusting it',
+                    // @if CK_DEBUG_TYPING // 		'%cTarget range starts in an inline filler - adjusting it',
+                    // @if CK_DEBUG_TYPING // 		'font-style: italic'
                     // @if CK_DEBUG_TYPING // 	) );
                     // @if CK_DEBUG_TYPING // }
                     domEvent.preventDefault();
@@ -12088,6 +12100,16 @@ function getFiles(nativeDataTransfer) {
                         singleCharacters: true
                     });
                 }
+                // Check if there is no an inline filler just after the target range.
+                if (isFollowedByInlineFiller(domRange.endContainer, domRange.endOffset)) {
+                    // @if CK_DEBUG_TYPING // if ( ( window as any ).logCKETyping ) {
+                    // @if CK_DEBUG_TYPING // 	console.info( ..._buildLogMessage( this, 'InputObserver',
+                    // @if CK_DEBUG_TYPING // 		'%cTarget range ends just before an inline filler - prevent default behavior',
+                    // @if CK_DEBUG_TYPING // 		'font-style: italic'
+                    // @if CK_DEBUG_TYPING // 	) );
+                    // @if CK_DEBUG_TYPING // }
+                    domEvent.preventDefault();
+                }
                 if (viewStart) {
                     return view.createRange(viewStart, viewEnd);
                 } else if (viewEnd) {
@@ -12139,6 +12161,8 @@ function getFiles(nativeDataTransfer) {
             // it to paragraphs as it is our default action for enter handling.
             const parts = data.split(/\n{1,2}/g);
             let partTargetRanges = targetRanges;
+            // Handle all parts on our side as we rely on paragraph inserting and synchronously updated view selection.
+            domEvent.preventDefault();
             for(let i = 0; i < parts.length; i++){
                 const dataPart = parts[i];
                 if (dataPart != '') {
@@ -12183,6 +12207,28 @@ function getFiles(nativeDataTransfer) {
     // @if CK_DEBUG_TYPING // }
     }
 }
+/**
+ * Returns `true` if there is an inline filler just after the position in DOM.
+ * It walks up the DOM tree if the offset is at the end of the node.
+ */ function isFollowedByInlineFiller(node, offset) {
+    while(node.parentNode){
+        if (isText(node)) {
+            if (offset != node.data.length) {
+                return false;
+            }
+        } else {
+            if (offset != node.childNodes.length) {
+                return false;
+            }
+        }
+        offset = indexOf(node) + 1;
+        node = node.parentNode;
+        if (offset < node.childNodes.length && startsWithFiller(node.childNodes[offset])) {
+            return true;
+        }
+    }
+    return false;
+}
 
 /**
  * Arrow keys observer introduces the {@link module:engine/view/document~Document#event:arrowKey `Document#arrowKey`} event.
@@ -39192,7 +39238,7 @@ function convertToModelText() {
 function parseAttributeValue(attribute) {
     try {
         return JSON.parse(attribute);
-    } catch (e) {
+    } catch  {
         return attribute;
     }
 }